Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones?
+1 Actually, we have implemented an 'Intance Recycle Bin' in our customized dashboard via soft-delete. All intances being deleted would be put into the 'Recycle Bin' to give a chance that it could be restored later if needed. Instances which stay in 'Recycle Bin' for more than 24 hours would be safely deleted. Also, instances in 'Recycle Bin' could be force-deleted at any time admin would like to. One problem for this function is how to display instances in the 'Recycle Bin'. They are instances in the 'soft-delete' status, but we cannot filter them out by status via nova-api, as 'deleted' and 'soft-deleted' are mapping to the same status. So it really makes sense to sperate out the two status in nova-api level. 2013/7/17 Day, Phil philip@hp.com -Original Message- From: David Ripton [mailto:drip...@redhat.com] Sent: 16 July 2013 15:39 To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones? On 07/15/2013 10:03 AM, Matt Riedemann wrote: I have a patch up for review on this: _https://review.openstack.org/#/c/35061/_ However, this doesn't fix the vm_states.SOFT_DELETED mapping in nova.api.openstack.common so if you show an instance with vm_states.SOFT_DELETED, the response status will be 'DELETED'. I'd like to see if there are any opinions on if this should come back as 'SOFT_DELETED' or if everyone is OK with mapping soft-delete to 'DELETED' in the v3 API? I would like to see them merged. Having multiple kinds of deleted records is really confusing, and leads to bugs. The more public we make this, the harder it will be to fix it in the future. The only place I can see it would be confusing is if an admin is using deleted in the search options, in which case I think they would need some way to distinguish between soft and hard deleted instances. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones?
I'd like to see if there are any opinions on if this should come back as 'SOFT_DELETED' or if everyone is OK with mapping soft-delete to 'DELETED' in the v3 API? I would like to see them merged. Having multiple kinds of deleted records is really confusing, and leads to bugs. The more public we make this, the harder it will be to fix it in the future. My preference is that we only expose one type of deleted state. I've not yet seen a compelling reason to do otherwise. --Dan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones?
-Original Message- From: David Ripton [mailto:drip...@redhat.com] Sent: 16 July 2013 15:39 To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones? On 07/15/2013 10:03 AM, Matt Riedemann wrote: I have a patch up for review on this: _https://review.openstack.org/#/c/35061/_ However, this doesn't fix the vm_states.SOFT_DELETED mapping in nova.api.openstack.common so if you show an instance with vm_states.SOFT_DELETED, the response status will be 'DELETED'. I'd like to see if there are any opinions on if this should come back as 'SOFT_DELETED' or if everyone is OK with mapping soft-delete to 'DELETED' in the v3 API? I would like to see them merged. Having multiple kinds of deleted records is really confusing, and leads to bugs. The more public we make this, the harder it will be to fix it in the future. The only place I can see it would be confusing is if an admin is using deleted in the search options, in which case I think they would need some way to distinguish between soft and hard deleted instances. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Seperate out 'soft-deleted' instances from 'deleted' ones?
For everyone's awareness, there is a bug related to this: https://bugs.launchpad.net/nova/+bug/1196255 Thanks, MATT RIEDEMANN Advisory Software Engineer Cloud Solutions and OpenStack Development Phone: 1-507-253-7622 | Mobile: 1-507-990-1889 E-mail: mrie...@us.ibm.com 3605 Hwy 52 N Rochester, MN 55901-1407 United States From: Yufang Zhang yufang521...@gmail.com To: openstack-dev@lists.openstack.org, Date: 06/30/2013 10:01 AM Subject:[openstack-dev] Seperate out 'soft-deleted' instances from 'deleted' ones? In nova-api, both vm_states.DELETED and vm_states.SOFT_DELETED states are mapped to the 'DELETED' status. Thus although nova-api supports filtering instances by instance status, we cannot get instances which are in 'soft-deleted' status, like: nova list --status SOFT_DELETED So does it make sense to seperate out 'soft-deleted' instances from 'deleted' ones in the api level? To achive this, we can modify the state-status mappings in nova-api to map vm_states.SOFT_DELETED to a dedicated status(like SOFT_DELETED) and vice versa. Of course, some modification should be token in the instance filter logic. Could anyone give some opinions before I am working on it? Thanks.___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev image/gif___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
