Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
On 12/29/2013 07:45 PM, Jeremy Stanley wrote: On 2013-12-29 15:09:24 -0500 (-0500), David Kranz wrote: [...] Looking at the docs I see the warning that you can't put this in the search field so I tried putting it directly in the url like the other parameters but it was ignored. Is there indeed a way to search for only patches that contain changes to files that match a regexp? As the documentation says, Currently this operator is only available on a watched project... https://review.openstack.org/Documentation/user-search.html#_search_operators The implication being it's only implemented for filtering project watches--the Only if field you see on the Watched Projects setting page. https://review.openstack.org/#/settings/projects I get that but it seems like this is a single field per gerrit user. Is that not true? If true, it is not useful because the point is that we want to be able to filter reviews that contain changes to tests for a particular project. I need to make different kinds of requests, like with a bookmark for each one. Is it possible? -David ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
On 2013-12-30 10:25:07 -0500 (-0500), David Kranz wrote: I get that but it seems like this is a single field per gerrit user. Is that not true? If true, it is not useful because the point is that we want to be able to filter reviews that contain changes to tests for a particular project. I need to make different kinds of requests, like with a bookmark for each one. Is it possible? Right, the file filter parameter is really only effective for determining what changes Gerrit E-mails you about, or which ones should be incorporated into your list of watched changes. It's not available for general search queries (I suspect this was a compromise made for efficiency reasons since the queries could be pretty intense the way file information is stored in the underlying database). Note, we're still running Gerrit 2.4 at the moment, so once we transition to 2.8 or 2.9 the flexibility in the search interface may increase significantly (I've heard it gives you the ability to bookmark various searches as custom dashboard views, but not sure what other search improvements may be added there). -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
On 2013-12-30 22:46:24 -0500 (-0500), David Kranz wrote: Looks like 2.8 came out recently and fixes this. It is mentioned near the top of http://ostrovsky.org/gerrit-code-review-2-8-released/. Awesome! Is there a planned time to upgrade? It's a priority, but the upgrade process is still being tested and kinks worked out for our data. The transition also depends on additional patches/plugins at the moment, and the new version brings changes in features which will are likely to be somewhat disruptive (so we want to find ways to minimize that). I don't believe there's a strict timeline or schedule for it at this point, but it is definitely being worked on. -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
On 2013-12-29 15:09:24 -0500 (-0500), David Kranz wrote: [...] Looking at the docs I see the warning that you can't put this in the search field so I tried putting it directly in the url like the other parameters but it was ignored. Is there indeed a way to search for only patches that contain changes to files that match a regexp? As the documentation says, Currently this operator is only available on a watched project... https://review.openstack.org/Documentation/user-search.html#_search_operators The implication being it's only implemented for filtering project watches--the Only if field you see on the Watched Projects setting page. https://review.openstack.org/#/settings/projects -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
Hi, On Tue, Dec 24, 2013 at 3:47 PM, Yair Fried yfr...@redhat.com wrote: Hi, Suggestion: Please consider tagging your Tempest commit messages the same way you do your mails in the mailing list Explanation: Since tempest is a single project testing multiple Openstack project we have a very diverse collection of patches as well as reviewers. Tagging our commit messages will allow us to classify patches and thus: 1. Allow reviewer to focus on patches related to their area of expertise 2. Track trends in patches - I think we all know that we lack in Neutron testing for example, but can we assess how many network related patches are for awaiting review 3. Future automation of flagging interesting patches You can usually tell all of this from reviewing the patch, but by then - you've spent time on a patch you might not even be qualified to review. I suggest we tag our patches with, to start with, the components we are looking to test, and the type of test (sceanrio, api, ...) and that reviewers should -1 untagged patches. I think the tagging should be the 2nd line in the message: == Example commit message [Neutron][Nova][Network][Scenario] Explanation of how this scenario tests both Neutron and Nova Network performance Chang-id XXX === I would like this to start immediately but what do you guys think? +1 And, how about do we the tagging about the services in the subject(1st line)? For example: Neutron:Example commit subject Because the dashboard of the gerrit shows the subject only now. I think reviewers can find interesting patches easily if the dashboard shows the tags. This is not so strong opinion because some scenario tests may have several services tags. -- Masayuki Igawa ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Tempest][qa] Adding tags to commit messages
On 12/24/2013 06:32 AM, Sean Dague wrote: On 12/24/2013 01:47 AM, Yair Fried wrote: Hi, Suggestion: Please consider tagging your Tempest commit messages the same way you do your mails in the mailing list Explanation: Since tempest is a single project testing multiple Openstack project we have a very diverse collection of patches as well as reviewers. Tagging our commit messages will allow us to classify patches and thus: 1. Allow reviewer to focus on patches related to their area of expertise 2. Track trends in patches - I think we all know that we lack in Neutron testing for example, but can we assess how many network related patches are for awaiting review 3. Future automation of flagging interesting patches You can usually tell all of this from reviewing the patch, but by then - you've spent time on a patch you might not even be qualified to review. I suggest we tag our patches with, to start with, the components we are looking to test, and the type of test (sceanrio, api, ...) and that reviewers should -1 untagged patches. I think the tagging should be the 2nd line in the message: == Example commit message [Neutron][Nova][Network][Scenario] Explanation of how this scenario tests both Neutron and Nova Network performance Chang-id XXX === I would like this to start immediately but what do you guys think? ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -2 I think this is just extra clutter, please don't. Also, it's Holiday season so tons of people are out, policy changes are completely on hold until January. Yes The commit message should be meaningful so I can read it, a bunch of tags I find just ugly and don't want to go near. We already have this information in the directory structure for API tests. And in service tags for the scenario tests. 2 3 you can through gerrit API queries. Replicating that information in another place is just error prone. Perhaps so. Maybe we can figure out some helpful workflows for tempest reviewers and share useful queries. -Sean ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Tempest][qa] Adding tags to commit messages
Hi, Suggestion: Please consider tagging your Tempest commit messages the same way you do your mails in the mailing list Explanation: Since tempest is a single project testing multiple Openstack project we have a very diverse collection of patches as well as reviewers. Tagging our commit messages will allow us to classify patches and thus: 1. Allow reviewer to focus on patches related to their area of expertise 2. Track trends in patches - I think we all know that we lack in Neutron testing for example, but can we assess how many network related patches are for awaiting review 3. Future automation of flagging interesting patches You can usually tell all of this from reviewing the patch, but by then - you've spent time on a patch you might not even be qualified to review. I suggest we tag our patches with, to start with, the components we are looking to test, and the type of test (sceanrio, api, ...) and that reviewers should -1 untagged patches. I think the tagging should be the 2nd line in the message: == Example commit message [Neutron][Nova][Network][Scenario] Explanation of how this scenario tests both Neutron and Nova Network performance Chang-id XXX === I would like this to start immediately but what do you guys think? ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
