[openstack-dev] [ThirdParty][CI] [patch] Status page at http://ci-watch.tintri.com/project
Hi all,
I quite like the page at http://ci-watch.tintri.com/project - it gives
a very quick overview about the failures one should look into, and which to
ignore ;)
Please let me state before anything else that I don't know any of the
restrictions that may have led into the current design - it's very likely
that I'm just missing a few points, and that some or all of my comments
below are invalid anyway. As always, take enough salt!
One thing about that page that is bothering me is the performance... my
(current) Firefox asks me several times whether I'd like to stop the JS,
or whether it should be allowed to continue.
With this patch (and a local exported copy of the page) I don't get asked
about that any more; it seems to give me a speedup of ~200, as no
intermediate lists need to be built and filtered any more:
$ diff -u verified.js.orig verified.js
--- verified.js.orig2015-12-21 15:03:45.614529924 +0100
+++ verified.js 2015-12-21 15:03:36.114432601 +0100
@@ -33,9 +33,9 @@
$(document).ready(function () {
$("colgroup").each(function (i, elem) {
if ($(elem).hasClass("verified-1")) {
- $("#results").find("td").filter(":nth-child(" + (i + 1) +
")").addClass("verified-1");
+ $("#results td:nth-child(" + (i + 1) + ")").addClass("verified-1");
} else if ($(elem).hasClass("verified1")) {
- $("#results").find("td").filter(":nth-child(" + (i + 1) +
")").addClass("verified1");
+ $("#results td:nth-child(" + (i + 1) + ")").addClass("verified1");
}
});
$("#verified1-button").on("click", toggle_verified_plus);
Furthermore, I'm wondering whether
couldn't be simplified to
with the rest being done via CSS? Perhaps a would be needed within
the to get the vertical size right, but everything else should be
possible via CSS, I believe.
This change should reduce the size of the generated HTML big some 50% or
so, too.
Thanks for listening - if you disagree, please ignore and continue working
on something else ;)
Regards,
Phil
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [ThirdParty][CI] [patch] Status page at http://ci-watch.tintri.com/project
Hi Phillip,
Yes, please offer a patch to that repo Anita suggested. There's a small group
of us actively working on improving the code and eventually getting ci-watch
deployed in openstack.org. Your patch and help would be very much appreciated.
We also meet bi-weekly in the 3rd party ci working group:
https://wiki.openstack.org/wiki/Meetings/ThirdParty
We also discuss some issues in #openstack-third-party-ci
Thanks!
Ramy
-Original Message-
From: Anita Kuno [mailto:ante...@anteaya.info]
Sent: Monday, December 21, 2015 6:52 AM
To: openstack-dev@lists.openstack.org
Subject: Re: [openstack-dev] [ThirdParty][CI] [patch] Status page at
http://ci-watch.tintri.com/project
On 12/21/2015 09:20 AM, Philipp Marek wrote:
> Hi all,
>
> I quite like the page at http://ci-watch.tintri.com/project - it gives
> a very quick overview about the failures one should look into, and
> which to ignore ;)
>
>
> Please let me state before anything else that I don't know any of the
> restrictions that may have led into the current design - it's very
> likely that I'm just missing a few points, and that some or all of my
> comments below are invalid anyway. As always, take enough salt!
>
>
> One thing about that page that is bothering me is the performance...
> my
> (current) Firefox asks me several times whether I'd like to stop the
> JS, or whether it should be allowed to continue.
>
> With this patch (and a local exported copy of the page) I don't get
> asked about that any more; it seems to give me a speedup of ~200, as
> no intermediate lists need to be built and filtered any more:
>
> $ diff -u verified.js.orig verified.js
> --- verified.js.orig2015-12-21 15:03:45.614529924 +0100
> +++ verified.js 2015-12-21 15:03:36.114432601 +0100
> @@ -33,9 +33,9 @@
> $(document).ready(function () {
>$("colgroup").each(function (i, elem) {
> if ($(elem).hasClass("verified-1")) {
> - $("#results").find("td").filter(":nth-child(" + (i + 1) +
> ")").addClass("verified-1");
> + $("#results td:nth-child(" + (i + 1) +
> + ")").addClass("verified-1");
> } else if ($(elem).hasClass("verified1")) {
> - $("#results").find("td").filter(":nth-child(" + (i + 1) +
> ")").addClass("verified1");
> + $("#results td:nth-child(" + (i + 1) +
> + ")").addClass("verified1");
> }
>});
>$("#verified1-button").on("click", toggle_verified_plus);
>
>
> Furthermore, I'm wondering whether
>
>
>
>
>
>
>
> couldn't be simplified to
>
>
>
>
>
>
> with the rest being done via CSS? Perhaps a would be needed
> within the to get the vertical size right, but everything else
> should be possible via CSS, I believe.
>
> This change should reduce the size of the generated HTML big some 50%
> or so, too.
>
>
>
> Thanks for listening - if you disagree, please ignore and continue
> working on something else ;)
>
>
> Regards,
>
> Phil
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
The repo is here if you would like to offer your patch via Gerrit.
http://git.openstack.org/cgit/openstack-infra/ciwatch/
Thanks Philipp,
Anita.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [ThirdParty][CI] [patch] Status page at http://ci-watch.tintri.com/project
On 12/21/2015 09:20 AM, Philipp Marek wrote:
> Hi all,
>
> I quite like the page at http://ci-watch.tintri.com/project - it gives
> a very quick overview about the failures one should look into, and which to
> ignore ;)
>
>
> Please let me state before anything else that I don't know any of the
> restrictions that may have led into the current design - it's very likely
> that I'm just missing a few points, and that some or all of my comments
> below are invalid anyway. As always, take enough salt!
>
>
> One thing about that page that is bothering me is the performance... my
> (current) Firefox asks me several times whether I'd like to stop the JS,
> or whether it should be allowed to continue.
>
> With this patch (and a local exported copy of the page) I don't get asked
> about that any more; it seems to give me a speedup of ~200, as no
> intermediate lists need to be built and filtered any more:
>
> $ diff -u verified.js.orig verified.js
> --- verified.js.orig2015-12-21 15:03:45.614529924 +0100
> +++ verified.js 2015-12-21 15:03:36.114432601 +0100
> @@ -33,9 +33,9 @@
> $(document).ready(function () {
>$("colgroup").each(function (i, elem) {
> if ($(elem).hasClass("verified-1")) {
> - $("#results").find("td").filter(":nth-child(" + (i + 1) +
> ")").addClass("verified-1");
> + $("#results td:nth-child(" + (i + 1) + ")").addClass("verified-1");
> } else if ($(elem).hasClass("verified1")) {
> - $("#results").find("td").filter(":nth-child(" + (i + 1) +
> ")").addClass("verified1");
> + $("#results td:nth-child(" + (i + 1) + ")").addClass("verified1");
> }
>});
>$("#verified1-button").on("click", toggle_verified_plus);
>
>
> Furthermore, I'm wondering whether
>
>
>
>
>
>
>
> couldn't be simplified to
>
>
>
>
>
>
> with the rest being done via CSS? Perhaps a would be needed within
> the to get the vertical size right, but everything else should be
> possible via CSS, I believe.
>
> This change should reduce the size of the generated HTML big some 50% or
> so, too.
>
>
>
> Thanks for listening - if you disagree, please ignore and continue working
> on something else ;)
>
>
> Regards,
>
> Phil
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
The repo is here if you would like to offer your patch via Gerrit.
http://git.openstack.org/cgit/openstack-infra/ciwatch/
Thanks Philipp,
Anita.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [ThirdParty][CI] [patch] Status page at http://ci-watch.tintri.com/project
On Dec 21, 2015 10:19 AM, "Asselin, Ramy" <ramy.asse...@hpe.com> wrote:
>
> Hi Phillip,
>
> Yes, please offer a patch to that repo Anita suggested. There's a small
group of us actively working on improving the code and eventually getting
ci-watch deployed in openstack.org. Your patch and help would be very much
appreciated.
+1
>
> We also meet bi-weekly in the 3rd party ci working group:
https://wiki.openstack.org/wiki/Meetings/ThirdParty
> We also discuss some issues in #openstack-third-party-ci
>
> Thanks!
> Ramy
>
> -Original Message-
> From: Anita Kuno [mailto:ante...@anteaya.info]
> Sent: Monday, December 21, 2015 6:52 AM
> To: openstack-dev@lists.openstack.org
> Subject: Re: [openstack-dev] [ThirdParty][CI] [patch] Status page at
http://ci-watch.tintri.com/project
>
> On 12/21/2015 09:20 AM, Philipp Marek wrote:
> > Hi all,
> >
> > I quite like the page at http://ci-watch.tintri.com/project - it gives
> > a very quick overview about the failures one should look into, and
> > which to ignore ;)
> >
> >
> > Please let me state before anything else that I don't know any of the
> > restrictions that may have led into the current design - it's very
> > likely that I'm just missing a few points, and that some or all of my
> > comments below are invalid anyway. As always, take enough salt!
> >
> >
> > One thing about that page that is bothering me is the performance...
> > my
> > (current) Firefox asks me several times whether I'd like to stop the
> > JS, or whether it should be allowed to continue.
> >
> > With this patch (and a local exported copy of the page) I don't get
> > asked about that any more; it seems to give me a speedup of ~200, as
> > no intermediate lists need to be built and filtered any more:
> >
> > $ diff -u verified.js.orig verified.js
> > --- verified.js.orig2015-12-21 15:03:45.614529924 +0100
> > +++ verified.js 2015-12-21 15:03:36.114432601 +0100
> > @@ -33,9 +33,9 @@
> > $(document).ready(function () {
> >$("colgroup").each(function (i, elem) {
> > if ($(elem).hasClass("verified-1")) {
> > - $("#results").find("td").filter(":nth-child(" + (i + 1) +
")").addClass("verified-1");
> > + $("#results td:nth-child(" + (i + 1) +
> > + ")").addClass("verified-1");
> > } else if ($(elem).hasClass("verified1")) {
> > - $("#results").find("td").filter(":nth-child(" + (i + 1) +
")").addClass("verified1");
> > + $("#results td:nth-child(" + (i + 1) +
> > + ")").addClass("verified1");
> > }
> >});
> >$("#verified1-button").on("click", toggle_verified_plus);
> >
> >
> > Furthermore, I'm wondering whether
> >
> >
> >
> >
> >
> >
> >
> > couldn't be simplified to
> >
> >
> >
> >
> >
> >
> > with the rest being done via CSS? Perhaps a would be needed
> > within the to get the vertical size right, but everything else
> > should be possible via CSS, I believe.
> >
> > This change should reduce the size of the generated HTML big some 50%
> > or so, too.
> >
> >
> >
> > Thanks for listening - if you disagree, please ignore and continue
> > working on something else ;)
> >
> >
> > Regards,
> >
> > Phil
> >
> >
> > __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> The repo is here if you would like to offer your patch via Gerrit.
> http://git.openstack.org/cgit/openstack-infra/ciwatch/
>
> Thanks Philipp,
> Anita.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
