Re: [openstack-dev] [TripleO] default region name
Thank you, Derek. So we could also change TripleO register-endpoint/setup-endpoint to use RegionOne. BR Zhou Zhenzan -Original Message- From: Derek Higgins [mailto:der...@redhat.com] Sent: Thursday, January 8, 2015 5:53 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [TripleO] default region name On 08/01/15 05:21, Zhou, Zhenzan wrote: Hi, Does anyone know why TripleO uses regionOne as default region name? A comment in the code says it's the default keystone uses. But I cannot find any regionOne in keystone code. Devstack uses RegionOne by default and I do see lots of RegionOne in keystone code. Looks like this has been changing in various places https://bugs.launchpad.net/keystone/+bug/1252299 I guess the default the code is referring to is in keystoneclient http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/v2_0/shell.py#n509 stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne * scripts/register-endpoint:26:REGION=regionOne # NB: This is the default keystone uses. scripts/register-endpoint:45:echo -r, --region -- Override the default region 'regionOne'. scripts/setup-endpoints:33:echo -r, --region-- Override the default region 'regionOne'. scripts/setup-endpoints:68:REGION=regionOne #NB: This is the keystone default. stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-heat-templates/ stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-image-elements/ ../tripleo-image-elements/elements/tempest/os-apply-config/opt/stack/t empest/etc/tempest.conf:10:region = regionOne ../tripleo-image-elements/elements/neutron/os-apply-config/etc/neutron /metadata_agent.ini:3:auth_region = regionOne stack@u140401:~/openstack/keystone$ grep -rn RegionOne * | wc -l 130 stack@u140401:~/openstack/keystone$ grep -rn regionOne * | wc -l 0 Another question is that TripleO doesn't export OS_REGION_NAME in stackrc. So when someone source devstack rc file to do something and then source TripleO rc file again, the OS_REGION_NAME will be the one set by devstack rc file. I know this may be strange but isn't it better to use the same default value? We should probably add that to our various rc files, not having it there is probably the reason we used keystoneclients default in the first place. Thanks a lot. BR Zhou Zhenzan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [TripleO] default region name
On 08/01/15 05:21, Zhou, Zhenzan wrote: Hi, Does anyone know why TripleO uses regionOne as default region name? A comment in the code says it's the default keystone uses. But I cannot find any regionOne in keystone code. Devstack uses RegionOne by default and I do see lots of RegionOne in keystone code. Looks like this has been changing in various places https://bugs.launchpad.net/keystone/+bug/1252299 I guess the default the code is referring to is in keystoneclient http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/v2_0/shell.py#n509 stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne * scripts/register-endpoint:26:REGION=regionOne # NB: This is the default keystone uses. scripts/register-endpoint:45:echo -r, --region -- Override the default region 'regionOne'. scripts/setup-endpoints:33:echo -r, --region-- Override the default region 'regionOne'. scripts/setup-endpoints:68:REGION=regionOne #NB: This is the keystone default. stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-heat-templates/ stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-image-elements/ ../tripleo-image-elements/elements/tempest/os-apply-config/opt/stack/tempest/etc/tempest.conf:10:region = regionOne ../tripleo-image-elements/elements/neutron/os-apply-config/etc/neutron/metadata_agent.ini:3:auth_region = regionOne stack@u140401:~/openstack/keystone$ grep -rn RegionOne * | wc -l 130 stack@u140401:~/openstack/keystone$ grep -rn regionOne * | wc -l 0 Another question is that TripleO doesn't export OS_REGION_NAME in stackrc. So when someone source devstack rc file to do something and then source TripleO rc file again, the OS_REGION_NAME will be the one set by devstack rc file. I know this may be strange but isn't it better to use the same default value? We should probably add that to our various rc files, not having it there is probably the reason we used keystoneclients default in the first place. Thanks a lot. BR Zhou Zhenzan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [TripleO] default region name
On 01/08/2015 06:38 AM, Zhou, Zhenzan wrote: Thank you, Derek. So we could also change TripleO register-endpoint/setup-endpoint to use RegionOne. Our policy in TripleO is to use project defaults whenever possible, in the interest of making sure our project defaults are sane for all users. If we find one that's bad we want to push for a fix in the project rather than fixing it downstream in TripleO. That said, this is a tricky situation. As noted in the Keystone review, changing the default for the region has the potential to break existing users of the client. If we're going to change the default we need a deprecation cycle to give people notice that their stuff is going to break. I do think it's something we should do though, because the mismatch in defaults between the Keystone client and other clients is also a problem, and arguably a bigger one since it will cause issues for all new users, who are least likely to be able to figure out why they can't talk to their cloud. So I would prefer not to change this in TripleO and instead proceed on rationalizing the defaults in the clients. Step one seems to be picking a common default and adding deprecation warnings to any client not currently using that default. -Ben BR Zhou Zhenzan -Original Message- From: Derek Higgins [mailto:der...@redhat.com] Sent: Thursday, January 8, 2015 5:53 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [TripleO] default region name On 08/01/15 05:21, Zhou, Zhenzan wrote: Hi, Does anyone know why TripleO uses regionOne as default region name? A comment in the code says it's the default keystone uses. But I cannot find any regionOne in keystone code. Devstack uses RegionOne by default and I do see lots of RegionOne in keystone code. Looks like this has been changing in various places https://bugs.launchpad.net/keystone/+bug/1252299 I guess the default the code is referring to is in keystoneclient http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/v2_0/shell.py#n509 stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne * scripts/register-endpoint:26:REGION=regionOne # NB: This is the default keystone uses. scripts/register-endpoint:45:echo -r, --region -- Override the default region 'regionOne'. scripts/setup-endpoints:33:echo -r, --region-- Override the default region 'regionOne'. scripts/setup-endpoints:68:REGION=regionOne #NB: This is the keystone default. stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-heat-templates/ stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-image-elements/ ../tripleo-image-elements/elements/tempest/os-apply-config/opt/stack/t empest/etc/tempest.conf:10:region = regionOne ../tripleo-image-elements/elements/neutron/os-apply-config/etc/neutron /metadata_agent.ini:3:auth_region = regionOne stack@u140401:~/openstack/keystone$ grep -rn RegionOne * | wc -l 130 stack@u140401:~/openstack/keystone$ grep -rn regionOne * | wc -l 0 Another question is that TripleO doesn't export OS_REGION_NAME in stackrc. So when someone source devstack rc file to do something and then source TripleO rc file again, the OS_REGION_NAME will be the one set by devstack rc file. I know this may be strange but isn't it better to use the same default value? We should probably add that to our various rc files, not having it there is probably the reason we used keystoneclients default in the first place. Thanks a lot. BR Zhou Zhenzan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [TripleO] default region name
Hi, Does anyone know why TripleO uses regionOne as default region name? A comment in the code says it's the default keystone uses. But I cannot find any regionOne in keystone code. Devstack uses RegionOne by default and I do see lots of RegionOne in keystone code. stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne * scripts/register-endpoint:26:REGION=regionOne # NB: This is the default keystone uses. scripts/register-endpoint:45:echo -r, --region -- Override the default region 'regionOne'. scripts/setup-endpoints:33:echo -r, --region-- Override the default region 'regionOne'. scripts/setup-endpoints:68:REGION=regionOne #NB: This is the keystone default. stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-heat-templates/ stack@u140401:~/openstack/tripleo-incubator$ grep -rn regionOne ../tripleo-image-elements/ ../tripleo-image-elements/elements/tempest/os-apply-config/opt/stack/tempest/etc/tempest.conf:10:region = regionOne ../tripleo-image-elements/elements/neutron/os-apply-config/etc/neutron/metadata_agent.ini:3:auth_region = regionOne stack@u140401:~/openstack/keystone$ grep -rn RegionOne * | wc -l 130 stack@u140401:~/openstack/keystone$ grep -rn regionOne * | wc -l 0 Another question is that TripleO doesn't export OS_REGION_NAME in stackrc. So when someone source devstack rc file to do something and then source TripleO rc file again, the OS_REGION_NAME will be the one set by devstack rc file. I know this may be strange but isn't it better to use the same default value? Thanks a lot. BR Zhou Zhenzan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
