Re: [openstack-dev] [all] Hide CI comments in Gerrit
Great script! I have a fork that I made and improved it a bit: https://gist.github.com/mkolesni/92076378d45c7b5e692b This fork supports: 1. Button/link is integrated nicely to the gerrit UI (appears in the comments title, just like the other ones). 2. Auto hide will hide comments by default (can be turned off). 3. Regex like bot detection which requires a shorter list of unique bot names, and less maintenance of the script. 4. oVirt support (for those interested). Regards, Mike - Original Message - Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks, Rado ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On Tue, May 27, 2014 at 6:07 PM, James E. Blair jebl...@openstack.orgwrote: I wonder if it would be possible to detect them based on the presence of a Verified vote? Not all CIs always add a vote. Only 3 or so of over 9000 Neutron's CIs put their +/-1s on the change. -- Kind regards, Yuriy. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
Hi Rado, Thanks for this cool userscript! It works great, and the only problem I found is TamperMonkey has some issue with hash in @include pattern matching[1]. So I end up using https://review.openstack.org/* instead of https://review.openstack.org/#/c/* [1] http://tampermonkey.net/documentation.php#@include Thanks, -- QY On Sun, May 25, 2014 at 8:23 PM, Radoslav Gerganov rgerga...@vmware.com wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks, Rado ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Thanks, -- Qiu Yu On Sun, May 25, 2014 at 8:23 PM, Radoslav Gerganov rgerga...@vmware.com wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks, Rado ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted https://review.openstack.org/#/c/95743 It is still a work in progress as I need to figure out how to augment only review pages, not the entire Gerrit interface. What would be a good way to test this kind of changes? I have been told there is Gerrit dev box out there. I guess I can also test it with an http proxy that rewrites the pages from the upstream Gerrit but I am looking for something easier :) Having template for CI names would be very helpful indeed. Thanks, Rado ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted https://review.openstack.org/#/c/95743 It is still a work in progress as I need to figure out how to augment only review pages, not the entire Gerrit interface. What would be a good way to test this kind of changes? I have been told there is Gerrit dev box out there. I guess I can also test it with an http proxy that rewrites the pages from the upstream Gerrit but I am looking for something easier :) Having template for CI names would be very helpful indeed. Very cool! When that's ready, we can manually apply it to review-dev only to make sure it works before we put it into production. We're definitely interested in templating the CI names, but we haven't actually asked anyone to start doing that yet (we're getting some other changes ready at the same time so that the third-party CI folks can make all the requested changes at once). Realistically, it's going to take a little while for all of that to get into place. We could just list the names for now and then change to a regex later, or I wonder if it would be possible to detect them based on the presence of a Verified vote? -Jim ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On Mon, May 26, 2014 at 7:52 PM, Henry Gessau ges...@cisco.com wrote: On 5/26/2014 8:31 PM, Monty Taylor wrote: On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks! This is a great first step towards filtering all of this stuff out. We have the ability to add javascript and whatnot to the gerrit site html header: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/GerritSiteHeader.html As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Here is the expanded list of CI names covering Nova and Neutron: // these are CIs for Nova and Neutron var ciNames = [Jenkins, Arista Testing, Big Switch CI, Brocade CI, Cisco Neutron CI, Elastic Recheck, Embrane CI, Freescale CI, Huawei CI, Hyper-V CI, IBM Neutron Testing, IBM PowerKVM Testing, Mellanox External Testing, Metaplugin CI Test, Midokura CI Bot, NEC OpenStack CI, Neutron Ryu, Nuage CI, One Convergence CI, OpenDaylight Jenkins, PLUMgrid CI, Radware 3rd Party Testing, Red Hat CI, SmokeStack, VMware Mine Sweeper, XenServer CI, turbo-hipster, ]; There is no consistency. It might help to ask/require the third party names to contain a substring, like CI Bot for example. +100 for that. It was discussed in the Neutron sessions in Atlanta about having a requirement around naming for CI Bots. Enforcing this project-wide would be a good thing. Thanks, Kyle I would also like to have a keyboard shortcut to toggle hide/display of these CI Bot comments. It would also be nice to be able to hide the CI Bots from the review table. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted https://review.openstack.org/#/c/95743 It is still a work in progress as I need to figure out how to augment only review pages, not the entire Gerrit interface. What would be a good way to test this kind of changes? I have been told there is Gerrit dev box out there. I guess I can also test it with an http proxy that rewrites the pages from the upstream Gerrit but I am looking for something easier :) Having template for CI names would be very helpful indeed. Very cool! When that's ready, we can manually apply it to review-dev only to make sure it works before we put it into production. We're definitely interested in templating the CI names, but we haven't actually asked anyone to start doing that yet (we're getting some other changes ready at the same time so that the third-party CI folks can make all the requested changes at once). Realistically, it's going to take a little while for all of that to get into place. We could just list the names for now and then change to a regex later, or I wonder if it would be possible to detect them based on the presence of a Verified vote? FYI I figured what I believe to be a reasonably complete set of CI account usernames to use with Gerrymander[1] jenkins, elasticrecheck, arista-test, bsn, pattabi-ayyasami-ci, brocade-oss-service, brocade_jenkins, cisco-openstack-ci, citrixjenkins, compass_ci, designate-jenkins, docker-ci, eci, freescale-ci, fuel-ci, fuel-watcher, huawei-ci, hyper-v-ci, ibmdb2, ibmsdnve, powerkvm, ibmpwrvc, ibm-zvm-ci, rocktown, lvstest, mellanox, metaplugintest, midokura, nec-openstack-ci, netapp-ci, NetScalerAts, neutronryu, nuage-ci, contrail, odl-jenkins, plumgrid-ci, puppetceph, puppet-openstack-ci-user, raxheatci, radware3rdpartytesting, redhatci, smokestack, sfci, thstack-ci, tailfncs, vmwareminesweeper, wherenowjenkins, citrix_xenserver_ci, jaypipes-testing, jenkins-magnetodb, murano-ci, nicirabot, novaimagebuilder-jenkins, reddwarf, savanna-ci, turbo-hipster, varmourci, vanillabot, trivial-rebase, launchpadsync It sure would be nice if every single bot username had 'ci-' as a prefix or suffix, so you could just wildcard match '*-ci' on the usernames Regards, Daniel [1] https://wiki.openstack.org/wiki/GerrymanderConfig -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On 05/27/2014 10:16 AM, Daniel P. Berrange wrote: On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted https://review.openstack.org/#/c/95743 It is still a work in progress as I need to figure out how to augment only review pages, not the entire Gerrit interface. What would be a good way to test this kind of changes? I have been told there is Gerrit dev box out there. I guess I can also test it with an http proxy that rewrites the pages from the upstream Gerrit but I am looking for something easier :) Having template for CI names would be very helpful indeed. Very cool! When that's ready, we can manually apply it to review-dev only to make sure it works before we put it into production. We're definitely interested in templating the CI names, but we haven't actually asked anyone to start doing that yet (we're getting some other changes ready at the same time so that the third-party CI folks can make all the requested changes at once). Realistically, it's going to take a little while for all of that to get into place. We could just list the names for now and then change to a regex later, or I wonder if it would be possible to detect them based on the presence of a Verified vote? FYI I figured what I believe to be a reasonably complete set of CI account usernames to use with Gerrymander[1] jenkins, elasticrecheck, arista-test, bsn, pattabi-ayyasami-ci, brocade-oss-service, brocade_jenkins, cisco-openstack-ci, citrixjenkins, compass_ci, designate-jenkins, docker-ci, eci, freescale-ci, fuel-ci, fuel-watcher, huawei-ci, hyper-v-ci, ibmdb2, ibmsdnve, powerkvm, ibmpwrvc, ibm-zvm-ci, rocktown, lvstest, mellanox, metaplugintest, midokura, nec-openstack-ci, netapp-ci, NetScalerAts, neutronryu, nuage-ci, contrail, odl-jenkins, plumgrid-ci, puppetceph, puppet-openstack-ci-user, raxheatci, radware3rdpartytesting, redhatci, smokestack, sfci, thstack-ci, tailfncs, vmwareminesweeper, wherenowjenkins, citrix_xenserver_ci, jaypipes-testing, jenkins-magnetodb, murano-ci, nicirabot, novaimagebuilder-jenkins, reddwarf, savanna-ci, turbo-hipster, varmourci, vanillabot, trivial-rebase, launchpadsync It sure would be nice if every single bot username had 'ci-' as a prefix or suffix, so you could just wildcard match '*-ci' on the usernames Regards, Daniel [1] https://wiki.openstack.org/wiki/GerrymanderConfig Discussing the format for the Third Party Account names is on today's infra-meeting agenda: https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting I added it so we could have a space to discuss it, not because I have a whole lot of ideas what it should look like. Do attend and share your thoughts on how these names should be formatted. Thanks, Anita. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On Tue, May 27, 2014 at 10:32:58AM -0400, Anita Kuno wrote: On 05/27/2014 10:16 AM, Daniel P. Berrange wrote: On Tue, May 27, 2014 at 07:07:54AM -0700, James E. Blair wrote: Radoslav Gerganov rgerga...@vmware.com writes: Hi Monty, As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Thanks for the pointer, I have submitted https://review.openstack.org/#/c/95743 It is still a work in progress as I need to figure out how to augment only review pages, not the entire Gerrit interface. What would be a good way to test this kind of changes? I have been told there is Gerrit dev box out there. I guess I can also test it with an http proxy that rewrites the pages from the upstream Gerrit but I am looking for something easier :) Having template for CI names would be very helpful indeed. Very cool! When that's ready, we can manually apply it to review-dev only to make sure it works before we put it into production. We're definitely interested in templating the CI names, but we haven't actually asked anyone to start doing that yet (we're getting some other changes ready at the same time so that the third-party CI folks can make all the requested changes at once). Realistically, it's going to take a little while for all of that to get into place. We could just list the names for now and then change to a regex later, or I wonder if it would be possible to detect them based on the presence of a Verified vote? FYI I figured what I believe to be a reasonably complete set of CI account usernames to use with Gerrymander[1] jenkins, elasticrecheck, arista-test, bsn, pattabi-ayyasami-ci, brocade-oss-service, brocade_jenkins, cisco-openstack-ci, citrixjenkins, compass_ci, designate-jenkins, docker-ci, eci, freescale-ci, fuel-ci, fuel-watcher, huawei-ci, hyper-v-ci, ibmdb2, ibmsdnve, powerkvm, ibmpwrvc, ibm-zvm-ci, rocktown, lvstest, mellanox, metaplugintest, midokura, nec-openstack-ci, netapp-ci, NetScalerAts, neutronryu, nuage-ci, contrail, odl-jenkins, plumgrid-ci, puppetceph, puppet-openstack-ci-user, raxheatci, radware3rdpartytesting, redhatci, smokestack, sfci, thstack-ci, tailfncs, vmwareminesweeper, wherenowjenkins, citrix_xenserver_ci, jaypipes-testing, jenkins-magnetodb, murano-ci, nicirabot, novaimagebuilder-jenkins, reddwarf, savanna-ci, turbo-hipster, varmourci, vanillabot, trivial-rebase, launchpadsync It sure would be nice if every single bot username had 'ci-' as a prefix or suffix, so you could just wildcard match '*-ci' on the usernames Regards, Daniel [1] https://wiki.openstack.org/wiki/GerrymanderConfig Discussing the format for the Third Party Account names is on today's infra-meeting agenda: https://wiki.openstack.org/wiki/Meetings/InfraTeamMeeting I added it so we could have a space to discuss it, not because I have a whole lot of ideas what it should look like. Do attend and share your thoughts on how these names should be formatted. Afraid I can't make the time of the meeting, but one thing to note is that this isn't just about 3rd party CI. Any naming convention should be for *all* robot accounts, not just 3rd party robot accounts. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks! This is a great first step towards filtering all of this stuff out. We have the ability to add javascript and whatnot to the gerrit site html header: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/GerritSiteHeader.html As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Monty ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] Hide CI comments in Gerrit
On 5/26/2014 8:31 PM, Monty Taylor wrote: On 05/25/2014 05:23 AM, Radoslav Gerganov wrote: Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks! This is a great first step towards filtering all of this stuff out. We have the ability to add javascript and whatnot to the gerrit site html header: http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/GerritSiteHeader.html As a next step - why not take the Javascript you've got there and submit it as a patch to the file above? We can probably figure out a way to template the third party CI names ... but starting one step at a time is a great idea. Here is the expanded list of CI names covering Nova and Neutron: // these are CIs for Nova and Neutron var ciNames = [Jenkins, Arista Testing, Big Switch CI, Brocade CI, Cisco Neutron CI, Elastic Recheck, Embrane CI, Freescale CI, Huawei CI, Hyper-V CI, IBM Neutron Testing, IBM PowerKVM Testing, Mellanox External Testing, Metaplugin CI Test, Midokura CI Bot, NEC OpenStack CI, Neutron Ryu, Nuage CI, One Convergence CI, OpenDaylight Jenkins, PLUMgrid CI, Radware 3rd Party Testing, Red Hat CI, SmokeStack, VMware Mine Sweeper, XenServer CI, turbo-hipster, ]; There is no consistency. It might help to ask/require the third party names to contain a substring, like CI Bot for example. I would also like to have a keyboard shortcut to toggle hide/display of these CI Bot comments. It would also be nice to be able to hide the CI Bots from the review table. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [all] Hide CI comments in Gerrit
Hi, I created a small userscript that allows you to hide CI comments in Gerrit. That way you can read only comments written by humans and hide everything else. I’ve been struggling for a long time to follow discussions on changes with many patch sets because of the CI noise. So I came up with this userscript: https://gist.github.com/rgerganov/35382752557cb975354a It adds “Toggle CI” button at the bottom of the page that hides/shows CI comments. Right now it is configured for Nova CIs, as I contribute mostly there, but you can easily make it work for other projects as well. It supports both the “old” and “new” screens that we have. How to install on Chrome: open chrome://extensions and dragdrop the script there How to install on Firefox: install Greasemonkey first and then open the script Known issues: - you may need to reload the page to get the new button - I tried to add the button somewhere close to the collapse/expand links but it didn’t work for some reason Hope you will find it useful. Any feedback is welcome :) Thanks, Rado ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
