Re: [openstack-dev] [cinder] Should we fix XML request issues?

[Doug Hellmann]

Excerpts from Michał Dulko's message of 2016-01-15 09:08:54 +0100:
> On 01/15/2016 07:14 AM, Jethani, Ravishekar wrote:
> > Hi Devs,
> >
> > I have come across a few 500 response issues while sending request
> > body as XML to cinder service. For example:
> >
> > 
> >
> > I can see that XML support has been marked as depricated and will be
> > removed in 'N' release. So is it still worth trying fixing these
> > issues during Mitaka time frame?
> >
> > Thanks.
> > Ravi Jethani
> 
> One of the reasons XML API was deprecated is the fact that it weren't
> getting much CI testing and as Doug Hellmann once mentioned - "if
> something isn't tested then it isn't working".

I may have said it, but I was hardly the first to do so! :-)

Doug

> 
> I'm okay with fixing it (if someone really needs that feature), but we
> don't have any means to prevent further regressions, so it may not be
> worth it.
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [cinder] Should we fix XML request issues?

[Sean McGinnis]

On Fri, Jan 15, 2016 at 09:08:54AM +0100, Michał Dulko wrote:
> On 01/15/2016 07:14 AM, Jethani, Ravishekar wrote:
> > Hi Devs,
> >
> > I have come across a few 500 response issues while sending request
> > body as XML to cinder service. For example:
> >
> > 
> >
> > I can see that XML support has been marked as depricated and will be
> > removed in 'N' release. So is it still worth trying fixing these
> > issues during Mitaka time frame?
> >
> > Thanks.
> > Ravi Jethani
> 
> One of the reasons XML API was deprecated is the fact that it weren't
> getting much CI testing and as Doug Hellmann once mentioned - "if
> something isn't tested then it isn't working".
> 
> I'm okay with fixing it (if someone really needs that feature), but we
> don't have any means to prevent further regressions, so it may not be
> worth it.

I'm in the same boat. I think we have other more important things to
focus on right now, but if there is someone that wants to submit a patch
to fix these - and do their own testing to validate the fix - I'm fine
with letting that through.

But given that this code will all be removed shortly, I would really
rather see that effort going the other way to update the API consumer's
code to switch to JSON.



> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [cinder] Should we fix XML request issues?

[Ivan Kolodyazhny]

500 error is bad for any API. IMO, I'm OK to fix it Mitaka. Deprecated
means that it could be dropped soon. It doesn't mean that it's not working
at all.

BTW, XML API almost has no tests so I'm not surprised that it's broken

Regards,
Ivan Kolodyazhny,
http://blog.e0ne.info/

On Fri, Jan 15, 2016 at 10:08 AM, Michał Dulko 
wrote:

> On 01/15/2016 07:14 AM, Jethani, Ravishekar wrote:
> > Hi Devs,
> >
> > I have come across a few 500 response issues while sending request
> > body as XML to cinder service. For example:
> >
> > 
> >
> > I can see that XML support has been marked as depricated and will be
> > removed in 'N' release. So is it still worth trying fixing these
> > issues during Mitaka time frame?
> >
> > Thanks.
> > Ravi Jethani
>
> One of the reasons XML API was deprecated is the fact that it weren't
> getting much CI testing and as Doug Hellmann once mentioned - "if
> something isn't tested then it isn't working".
>
> I'm okay with fixing it (if someone really needs that feature), but we
> don't have any means to prevent further regressions, so it may not be
> worth it.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [cinder] Should we fix XML request issues?

[Michał Dulko]

On 01/15/2016 07:14 AM, Jethani, Ravishekar wrote:
> Hi Devs,
>
> I have come across a few 500 response issues while sending request
> body as XML to cinder service. For example:
>
> 
>
> I can see that XML support has been marked as depricated and will be
> removed in 'N' release. So is it still worth trying fixing these
> issues during Mitaka time frame?
>
> Thanks.
> Ravi Jethani

One of the reasons XML API was deprecated is the fact that it weren't
getting much CI testing and as Doug Hellmann once mentioned - "if
something isn't tested then it isn't working".

I'm okay with fixing it (if someone really needs that feature), but we
don't have any means to prevent further regressions, so it may not be
worth it.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [cinder] Should we fix XML request issues?

[Jethani, Ravishekar]

Hi Devs,

I have come across a few 500 response issues while sending request
body as XML to cinder service. For example:

--
openstack@openstack-136:/opt/stack/cinder$ curl -i -X PUT -H "X-Auth-Token: 
79e6f8f529d2494b81dbd1a6ea5e077d"  -H "Accept: application/xml" 
"http://10.69.4.136:8776/v2/0fea9a45c8504875bcda9690a5625eab/volumes/921d806e-313f-47f5-9a1a-3ecffa0aa8ba/metadata;
 -H "Content-Type: application/xml" -d ' 
  v2 '
HTTP/1.1 500 Internal Server Error
Content-Length: 215
Content-Type: application/xml; charset=UTF-8
X-Compute-Request-Id: req-177f7212-af65-4bad-84d0-aac0263d46eb
X-Openstack-Request-Id: req-177f7212-af65-4bad-84d0-aac0263d46eb
Date: Thu, 14 Jan 2016 07:28:06 GMT

http://docs.openstack.org/api/openstack-block-storage/2.0/content;>The
 server has either erred or is incapable of performing the requested 
operation.openstack@openstack-136:/opt/stack/cinder$


LOG:
2016-01-13 23:28:06.420 DEBUG eventlet.wsgi.server [-] (7587) accepted 
('10.69.4.136', 59959) from (pid=7587) server 
/usr/local/lib/python2.7/dist-packages/eventlet/wsgi.py:826
2016-01-13 23:28:06.678 DEBUG oslo_policy._cache_handler 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] Reloading cached file /etc/cinder/policy.json 
from (pid=7587) read_cached_file 
/usr/local/lib/python2.7/dist-packages/oslo_policy/_cache_handler.py:38
2016-01-13 23:28:06.680 DEBUG oslo_policy.policy 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] Reloaded policy file: /etc/cinder/policy.json 
from (pid=7587) _load_policy_file 
/usr/local/lib/python2.7/dist-packages/oslo_policy/policy.py:493
2016-01-13 23:28:06.890 INFO cinder.api.openstack.wsgi 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] PUT 
http://10.69.4.136:8776/v2/0fea9a45c8504875bcda9690a5625eab/volumes/921d806e-313f-47f5-9a1a-3ecffa0aa8ba/metadata
2016-01-13 23:28:06.891 ERROR cinder.api.middleware.fault 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] Caught error:
2016-01-13 23:28:06.892 INFO cinder.api.middleware.fault 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] 
http://10.69.4.136:8776/v2/0fea9a45c8504875bcda9690a5625eab/volumes/921d806e-313f-47f5-9a1a-3ecffa0aa8ba/metadata
 returned with HTTP 500
2016-01-13 23:28:06.893 WARNING cinder.api.openstack.wsgi 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] Deprecated: XML support has been deprecated 
and will be removed in the N release.
2016-01-13 23:28:06.894 INFO eventlet.wsgi.server 
[req-177f7212-af65-4bad-84d0-aac0263d46eb e1079bbb3aa54660b2cacd9c8ca1e1d7 
0fea9a45c8504875bcda9690a5625eab] 10.69.4.136 "PUT 
/v2/0fea9a45c8504875bcda9690a5625eab/volumes/921d806e-313f-47f5-9a1a-3ecffa0aa8ba/metadata
 HTTP/1.1" status: 500  len: 487 time: 0.4734759


I can see that XML support has been marked as depricated and will be
removed in 'N' release. So is it still worth trying fixing these
issues during Mitaka time frame?

Thanks.
Ravi Jethani

__
Disclaimer: This email and any attachments are sent in strictest confidence
for the sole use of the addressee and may contain legally privileged,
confidential, and proprietary data. If you are not the intended recipient,
please advise the sender by replying promptly to this email and then delete
and destroy this email and any attachments without any further use, copying
or forwarding.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev