Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Kaz Shinohara]

Hi,

Thank you very much for your quick response & kind comment :)

Yes, we are planning to backport some patches to stable/queens.
Also in the last PTG, had discussion with horizon team about how to
leverage xstatic repos to solve this issue.
Current our plan is to create a new xstatic-*** repo to support js
which are needed by only heat-dashboard.
For any other js, heat-dashboard will take the existing xstatic-***.
In the end, we will not have any embedded js in heat-dashboard repo, for sure.

Now Dublin's snow is pretty cleared, it's time to fly back to my home.
I don't like to see snow any more :P

Regards,
Kaz


2018-03-04 22:22 GMT+09:00 Thomas Goirand :
> On 03/02/2018 07:28 PM, Kaz Shinohara wrote:
>> Hi Thomas(zigo),
>>
>> I found an issue which is included in
>> https://review.openstack.org/#/c/548924/ (you did cherry pick last
>> night)
>> In short, this issue makes it impossible to install heat-dashboard..
>>
>> I landed fix for this.  https://review.openstack.org/#/c/549214/
>>
>> Could you kindly pick up this for your package ?
>> Sorry again for your inconvenience.
>>
>> Regards,
>> Kaz(kazsh)
>
> Hi,
>
> I've added the patch, thanks for it.
>
> So now, I'm embedding that patch for fixing unit tests, plus:
> https://review.openstack.org/#/c/547468/
> https://review.openstack.org/#/c/549214/
>
> Indeed, it'd be nice to have all of them officially backported to
> Queens, as you suggested on IRC. It'd be even better to completely
> remove embedded stuff, and use xstatic packages. There's already an
> XStatic package for the font-awesome which can be used. I do believe it
> would be very much OK to add such a requirement to heat-dashboard, since
> it is already one of the requirements for Horizon.
>
> Altogether, thanks a lot for your care, as always, the OpenStack
> community turns out to be comprehensive, reactive and simply awesome! :)
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Thomas Goirand]

On 03/02/2018 07:28 PM, Kaz Shinohara wrote:
> Hi Thomas(zigo),
> 
> I found an issue which is included in
> https://review.openstack.org/#/c/548924/ (you did cherry pick last
> night)
> In short, this issue makes it impossible to install heat-dashboard..
> 
> I landed fix for this.  https://review.openstack.org/#/c/549214/
> 
> Could you kindly pick up this for your package ?
> Sorry again for your inconvenience.
> 
> Regards,
> Kaz(kazsh)

Hi,

I've added the patch, thanks for it.

So now, I'm embedding that patch for fixing unit tests, plus:
https://review.openstack.org/#/c/547468/
https://review.openstack.org/#/c/549214/

Indeed, it'd be nice to have all of them officially backported to
Queens, as you suggested on IRC. It'd be even better to completely
remove embedded stuff, and use xstatic packages. There's already an
XStatic package for the font-awesome which can be used. I do believe it
would be very much OK to add such a requirement to heat-dashboard, since
it is already one of the requirements for Horizon.

Altogether, thanks a lot for your care, as always, the OpenStack
community turns out to be comprehensive, reactive and simply awesome! :)

Cheers,

Thomas Goirand (zigo)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Kaz Shinohara]

Hi Thomas(zigo),

I found an issue which is included in
https://review.openstack.org/#/c/548924/ (you did cherry pick last
night)
In short, this issue makes it impossible to install heat-dashboard..

I landed fix for this.  https://review.openstack.org/#/c/549214/

Could you kindly pick up this for your package ?
Sorry again for your inconvenience.

Regards,
Kaz(kazsh)


2018-03-02 23:37 GMT+09:00 Akihiro Motoki :
> Thanks for clarification.
> I was a bit confused with the two things because the patch dropped
> some embedded stuffs like font-awesome.
> Let's address the "embedded" problem soon :)
>
> Akihiro
>
> 2018-03-02 14:27 GMT+00:00 Xinni Ge :
>> Hi, Akihiro,
>>
>> The patch I submitted previously didn't solve the embedded problem.
>> I would like to fix out the whole thing in several steps, because the
>> current status of static files arrangment is quite messy.
>>
>> I will upload the javascript and css style files as xstatic-* projects and
>> remove them from the code later on.
>>
>> I wanted to solve the unittest problem ASAP and assumed it will take some
>> time to create xstatic repos and get the approval from infra team,
>> so I just submitted this patch to let unittest go well at first.
>>
>> Thanks for asking, I am happy to hear from your all about the js and static
>> files issue.
>>
>> Best regards,
>>
>> Xinni
>>
>> On Fri, Mar 2, 2018 at 1:29 PM, Akihiro Motoki  wrote:
>>>
>>> Hi Xinni,
>>>
>>> I looked at your patch which drops the vendors stuffs, but I still
>>> have a question.
>>>
>>> The patch introduces some SCSS like:
>>> - bootstrap.scss
>>> - angular-notify.scss
>>> - angular-material.scss
>>>
>>> Aren't they another type of "vendors" stuffs?
>>> I don't understand why switching to SCSS solves the embedded "vendors"
>>> problem?
>>>
>>> I would like to know opinions from zigo and Corey.
>>>
>>> Thanks,
>>> Akihiro
>>>
>>>
>>> 2018-03-01 21:30 GMT+00:00 Xinni Ge :
>>> > Hi, there.
>>> >
>>> > This is a page of a similar unittest issue.
>>> > https://bugs.launchpad.net/heat-dashboard/+bug/1752527
>>> >
>>> > We merged the following patch to fix the issue, and hope it also fix the
>>> > trouble described here.
>>> >  https://review.openstack.org/#/c/548924/
>>> >
>>> > As for the minified javascript files, we are working on removing from
>>> > the
>>> > source code,
>>> >  and uploading as xstatic packages.
>>> > Just need a little more time to finish it.
>>> >
>>> >
>>> > Best regards,
>>> >
>>> > Xinni
>>> >
>>> > On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand 
>>> > wrote:
>>> >>
>>> >> On 02/23/2018 09:29 AM, Xinni Ge wrote:
>>> >> > Hi there,
>>> >> >
>>> >> > We are aware of the javascript embedded issue, and working on it now,
>>> >> > the patch will be summited later.
>>> >> >
>>> >> > As for the unittest failure, we are still investigating it. We will
>>> >> > contant you as soon as we find out the cause.
>>> >> >
>>> >> > Sorry to bring troubles to you. We will be grateful if you could wait
>>> >> > for a little longer.
>>> >> >
>>> >> > Best Regards,
>>> >> >
>>> >> > Xinni
>>> >>
>>> >> Hi,
>>> >>
>>> >> Thanks for this message. This lowers the frustration! :)
>>> >> Let me know if there's any patch I could review.
>>> >>
>>> >> Cheers,
>>> >>
>>> >> Thomas Goirand (zigo)
>>> >>
>>> >>
>>> >> __
>>> >> OpenStack Development Mailing List (not for usage questions)
>>> >> Unsubscribe:
>>> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > 葛馨霓 Xinni Ge
>>> >
>>> >
>>> > __
>>> > OpenStack Development Mailing List (not for usage questions)
>>> > Unsubscribe:
>>> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>> >
>>>
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>>
>>
>> --
>> 葛馨霓 Xinni Ge
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Akihiro Motoki]

Thanks for clarification.
I was a bit confused with the two things because the patch dropped
some embedded stuffs like font-awesome.
Let's address the "embedded" problem soon :)

Akihiro

2018-03-02 14:27 GMT+00:00 Xinni Ge :
> Hi, Akihiro,
>
> The patch I submitted previously didn't solve the embedded problem.
> I would like to fix out the whole thing in several steps, because the
> current status of static files arrangment is quite messy.
>
> I will upload the javascript and css style files as xstatic-* projects and
> remove them from the code later on.
>
> I wanted to solve the unittest problem ASAP and assumed it will take some
> time to create xstatic repos and get the approval from infra team,
> so I just submitted this patch to let unittest go well at first.
>
> Thanks for asking, I am happy to hear from your all about the js and static
> files issue.
>
> Best regards,
>
> Xinni
>
> On Fri, Mar 2, 2018 at 1:29 PM, Akihiro Motoki  wrote:
>>
>> Hi Xinni,
>>
>> I looked at your patch which drops the vendors stuffs, but I still
>> have a question.
>>
>> The patch introduces some SCSS like:
>> - bootstrap.scss
>> - angular-notify.scss
>> - angular-material.scss
>>
>> Aren't they another type of "vendors" stuffs?
>> I don't understand why switching to SCSS solves the embedded "vendors"
>> problem?
>>
>> I would like to know opinions from zigo and Corey.
>>
>> Thanks,
>> Akihiro
>>
>>
>> 2018-03-01 21:30 GMT+00:00 Xinni Ge :
>> > Hi, there.
>> >
>> > This is a page of a similar unittest issue.
>> > https://bugs.launchpad.net/heat-dashboard/+bug/1752527
>> >
>> > We merged the following patch to fix the issue, and hope it also fix the
>> > trouble described here.
>> >  https://review.openstack.org/#/c/548924/
>> >
>> > As for the minified javascript files, we are working on removing from
>> > the
>> > source code,
>> >  and uploading as xstatic packages.
>> > Just need a little more time to finish it.
>> >
>> >
>> > Best regards,
>> >
>> > Xinni
>> >
>> > On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand 
>> > wrote:
>> >>
>> >> On 02/23/2018 09:29 AM, Xinni Ge wrote:
>> >> > Hi there,
>> >> >
>> >> > We are aware of the javascript embedded issue, and working on it now,
>> >> > the patch will be summited later.
>> >> >
>> >> > As for the unittest failure, we are still investigating it. We will
>> >> > contant you as soon as we find out the cause.
>> >> >
>> >> > Sorry to bring troubles to you. We will be grateful if you could wait
>> >> > for a little longer.
>> >> >
>> >> > Best Regards,
>> >> >
>> >> > Xinni
>> >>
>> >> Hi,
>> >>
>> >> Thanks for this message. This lowers the frustration! :)
>> >> Let me know if there's any patch I could review.
>> >>
>> >> Cheers,
>> >>
>> >> Thomas Goirand (zigo)
>> >>
>> >>
>> >> __
>> >> OpenStack Development Mailing List (not for usage questions)
>> >> Unsubscribe:
>> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>> >
>> >
>> >
>> > --
>> > 葛馨霓 Xinni Ge
>> >
>> >
>> > __
>> > OpenStack Development Mailing List (not for usage questions)
>> > Unsubscribe:
>> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> 葛馨霓 Xinni Ge
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Xinni Ge]

Hi, Akihiro,

The patch I submitted previously didn't solve the embedded problem.
I would like to fix out the whole thing in several steps, because the
current status of static files arrangment is quite messy.

I will upload the javascript and css style files as xstatic-* projects and
remove them from the code later on.

I wanted to solve the unittest problem ASAP and assumed it will take some
time to create xstatic repos and get the approval from infra team,
so I just submitted this patch to let unittest go well at first.

Thanks for asking, I am happy to hear from your all about the js and static
files issue.

Best regards,

Xinni

On Fri, Mar 2, 2018 at 1:29 PM, Akihiro Motoki  wrote:

> Hi Xinni,
>
> I looked at your patch which drops the vendors stuffs, but I still
> have a question.
>
> The patch introduces some SCSS like:
> - bootstrap.scss
> - angular-notify.scss
> - angular-material.scss
>
> Aren't they another type of "vendors" stuffs?
> I don't understand why switching to SCSS solves the embedded "vendors"
> problem?
>
> I would like to know opinions from zigo and Corey.
>
> Thanks,
> Akihiro
>
>
> 2018-03-01 21:30 GMT+00:00 Xinni Ge :
> > Hi, there.
> >
> > This is a page of a similar unittest issue.
> > https://bugs.launchpad.net/heat-dashboard/+bug/1752527
> >
> > We merged the following patch to fix the issue, and hope it also fix the
> > trouble described here.
> >  https://review.openstack.org/#/c/548924/
> >
> > As for the minified javascript files, we are working on removing from the
> > source code,
> >  and uploading as xstatic packages.
> > Just need a little more time to finish it.
> >
> >
> > Best regards,
> >
> > Xinni
> >
> > On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand 
> wrote:
> >>
> >> On 02/23/2018 09:29 AM, Xinni Ge wrote:
> >> > Hi there,
> >> >
> >> > We are aware of the javascript embedded issue, and working on it now,
> >> > the patch will be summited later.
> >> >
> >> > As for the unittest failure, we are still investigating it. We will
> >> > contant you as soon as we find out the cause.
> >> >
> >> > Sorry to bring troubles to you. We will be grateful if you could wait
> >> > for a little longer.
> >> >
> >> > Best Regards,
> >> >
> >> > Xinni
> >>
> >> Hi,
> >>
> >> Thanks for this message. This lowers the frustration! :)
> >> Let me know if there's any patch I could review.
> >>
> >> Cheers,
> >>
> >> Thomas Goirand (zigo)
> >>
> >> 
> __
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> >
> >
> > --
> > 葛馨霓 Xinni Ge
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
葛馨霓 Xinni Ge
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Akihiro Motoki]

Hi Xinni,

I looked at your patch which drops the vendors stuffs, but I still
have a question.

The patch introduces some SCSS like:
- bootstrap.scss
- angular-notify.scss
- angular-material.scss

Aren't they another type of "vendors" stuffs?
I don't understand why switching to SCSS solves the embedded "vendors" problem?

I would like to know opinions from zigo and Corey.

Thanks,
Akihiro


2018-03-01 21:30 GMT+00:00 Xinni Ge :
> Hi, there.
>
> This is a page of a similar unittest issue.
> https://bugs.launchpad.net/heat-dashboard/+bug/1752527
>
> We merged the following patch to fix the issue, and hope it also fix the
> trouble described here.
>  https://review.openstack.org/#/c/548924/
>
> As for the minified javascript files, we are working on removing from the
> source code,
>  and uploading as xstatic packages.
> Just need a little more time to finish it.
>
>
> Best regards,
>
> Xinni
>
> On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand  wrote:
>>
>> On 02/23/2018 09:29 AM, Xinni Ge wrote:
>> > Hi there,
>> >
>> > We are aware of the javascript embedded issue, and working on it now,
>> > the patch will be summited later.
>> >
>> > As for the unittest failure, we are still investigating it. We will
>> > contant you as soon as we find out the cause.
>> >
>> > Sorry to bring troubles to you. We will be grateful if you could wait
>> > for a little longer.
>> >
>> > Best Regards,
>> >
>> > Xinni
>>
>> Hi,
>>
>> Thanks for this message. This lowers the frustration! :)
>> Let me know if there's any patch I could review.
>>
>> Cheers,
>>
>> Thomas Goirand (zigo)
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> 葛馨霓 Xinni Ge
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Xinni Ge]

Hi, there.

This is a page of a similar unittest issue.
https://bugs.launchpad.net/heat-dashboard/+bug/1752527

We merged the following patch to fix the issue, and hope it also fix the
trouble described here.
 https://review.openstack.org/#/c/548924/

As for the minified javascript files, we are working on removing from the
source code,
 and uploading as xstatic packages.
Just need a little more time to finish it.


Best regards,

Xinni

On Tue, Feb 27, 2018 at 10:48 AM, Thomas Goirand  wrote:

> On 02/23/2018 09:29 AM, Xinni Ge wrote:
> > Hi there,
> >
> > We are aware of the javascript embedded issue, and working on it now,
> > the patch will be summited later.
> >
> > As for the unittest failure, we are still investigating it. We will
> > contant you as soon as we find out the cause.
> >
> > Sorry to bring troubles to you. We will be grateful if you could wait
> > for a little longer.
> >
> > Best Regards,
> >
> > Xinni
>
> Hi,
>
> Thanks for this message. This lowers the frustration! :)
> Let me know if there's any patch I could review.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
葛馨霓 Xinni Ge
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Thomas Goirand]

On 02/23/2018 09:29 AM, Xinni Ge wrote:
> Hi there,
> 
> We are aware of the javascript embedded issue, and working on it now,
> the patch will be summited later.
> 
> As for the unittest failure, we are still investigating it. We will
> contant you as soon as we find out the cause.
> 
> Sorry to bring troubles to you. We will be grateful if you could wait
> for a little longer.
> 
> Best Regards,
> 
> Xinni

Hi,

Thanks for this message. This lowers the frustration! :)
Let me know if there's any patch I could review.

Cheers,

Thomas Goirand (zigo)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Xinni Ge]

Hi there,

We are aware of the javascript embedded issue, and working on it now, the
patch will be summited later.

As for the unittest failure, we are still investigating it. We will contant
you as soon as we find out the cause.

Sorry to bring troubles to you. We will be grateful if you could wait for a
little longer.

Best Regards,

Xinni

On Thu, Feb 22, 2018 at 5:41 AM, Thomas Goirand  wrote:

> On 02/21/2018 05:54 PM, Corey Bryant wrote:
> >
> >
> > On Wed, Feb 21, 2018 at 9:35 AM, Thomas Goirand  > > wrote:
> >
> > Hi there!
> >
> > I'm having big trouble package heat-dashboard for Debian. I hope I
> can
> > get help through this list.
> >
> > In here:
> >
> > heat_dashboard/static/dashboard/project/heat_
> dashboard/template_generator/js/
> >
> > we have minified *only* versions of Javascript.
> >
> >
> > There's also a bug open for this:
> > https://bugs.launchpad.net/heat-dashboard/+bug/1747687
> >
> > Regards,
> > Corey
>
> Thanks for the link and filing this bug.
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
葛馨霓 Xinni Ge
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Thomas Goirand]

On 02/21/2018 05:54 PM, Corey Bryant wrote:
> 
> 
> On Wed, Feb 21, 2018 at 9:35 AM, Thomas Goirand  > wrote:
> 
> Hi there!
> 
> I'm having big trouble package heat-dashboard for Debian. I hope I can
> get help through this list.
> 
> In here:
> 
> 
> heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/js/
> 
> we have minified *only* versions of Javascript.
> 
> 
> There's also a bug open for this:
> https://bugs.launchpad.net/heat-dashboard/+bug/1747687
> 
> Regards,
> Corey

Thanks for the link and filing this bug.

Cheers,

Thomas Goirand (zigo)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Akihiro Motoki]

2018-02-21 23:35 GMT+09:00 Thomas Goirand :
> Hi there!
>
> I'm having big trouble package heat-dashboard for Debian. I hope I can
> get help through this list.
>
> In here:
>
> heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/js/
>
> we have minified *only* versions of Javascript.
>
> 1/ Why is there only minified versions? That's non-free to me, Debian,
> and probably any other distro caring about OpenStack.
> 2/ Why do we even have a folder called "vendors"? Doesn't this sound
> really a bad practice?
> 3/ Why is there so many angular-*.min.js files? Do we need them all?
> 4/ Why isn't the package using xstatic-angular and friends?

IIUC, these javascript files are only used by the template generator
which was newly added after split out from horizon.
If you can provide only the Pike-compatible feature from, horizon,
code related to the template generator can be excluded.
I know it is not ideal and am not sure this is acceptable workaround.

Horizon docs contains a guideline on javascript and it discourages
embedded JS files.
https://docs.openstack.org/horizon/latest/contributor/topics/packaging.html
heat-dashboard choice does not look the right way.

Akihiro

>
> As it stands, I can't upload heat-dashboard to Debian for Queens, and
> it's been removed from Horizon... :(
>
> Oh, and I almost forgot! When running unit tests, I get:
>
> PYTHON=python$i NOSE_WITH_OPENSTACK=1 \
> NOSE_OPENSTACK_COLOR=1 \
> NOSE_OPENSTACK_RED=0.05 \
> NOSE_OPENSTACK_YELLOW=0.025 \
> NOSE_OPENSTACK_SHOW_ELAPSED=1 \
> DJANGO_SETTINGS_MODULE=heat_dashboard.test.settings \
> python$i
> /home/zigo/sources/openstack/queens/services/heat-dashboard/build-area/heat-dashboard-1.0.2/manage.py
> test heat_dashboard.test --settings=heat_dashboard.test.settings
>
> No local_settings file found.
> Traceback (most recent call last):
>   File
> "/home/zigo/sources/openstack/queens/services/heat-dashboard/build-area/heat-dashboard-1.0.2/manage.py",
> line 23, in 
> execute_from_command_line(sys.argv)
>
> [ ... some stack dump ...]
>
>   File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
> 147, in acquire
> self._do_open()
>   File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
> 119, in _do_open
> self.lockfile = open(self.path, 'a')
> PermissionError: [Errno 13] Permission denied:
> '/usr/lib/python3/dist-packages/openstack_dashboard/local/_usr_lib_python3_dist-packages_openstack_dashboard_local_.secret_key_store.lock'
>
> What thing is attempting to write in my read only /usr, while Horizon is
> correctly installed, and writing its secret key material as it should,
> in /var/lib/openstack-dashboard? It's probably due to me, but here, how
> can I make heat-dashboard unit test behave during package build? What's
> this "No local_settings file found" thing? Other dashboards didn't
> complain in this way...
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Corey Bryant]

On Wed, Feb 21, 2018 at 9:35 AM, Thomas Goirand  wrote:

> Hi there!
>
> I'm having big trouble package heat-dashboard for Debian. I hope I can
> get help through this list.
>
> In here:
>
> heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/
> js/
>
> we have minified *only* versions of Javascript.
>
>
There's also a bug open for this:
https://bugs.launchpad.net/heat-dashboard/+bug/1747687

Regards,
Corey


> 1/ Why is there only minified versions? That's non-free to me, Debian,
> and probably any other distro caring about OpenStack.
> 2/ Why do we even have a folder called "vendors"? Doesn't this sound
> really a bad practice?
> 3/ Why is there so many angular-*.min.js files? Do we need them all?
> 4/ Why isn't the package using xstatic-angular and friends?
>
> As it stands, I can't upload heat-dashboard to Debian for Queens, and
> it's been removed from Horizon... :(
>
> Oh, and I almost forgot! When running unit tests, I get:
>
> PYTHON=python$i NOSE_WITH_OPENSTACK=1 \
> NOSE_OPENSTACK_COLOR=1 \
> NOSE_OPENSTACK_RED=0.05 \
> NOSE_OPENSTACK_YELLOW=0.025 \
> NOSE_OPENSTACK_SHOW_ELAPSED=1 \
> DJANGO_SETTINGS_MODULE=heat_dashboard.test.settings \
> python$i
> /home/zigo/sources/openstack/queens/services/heat-
> dashboard/build-area/heat-dashboard-1.0.2/manage.py
> test heat_dashboard.test --settings=heat_dashboard.test.settings
>
> No local_settings file found.
> Traceback (most recent call last):
>   File
> "/home/zigo/sources/openstack/queens/services/heat-
> dashboard/build-area/heat-dashboard-1.0.2/manage.py",
> line 23, in 
> execute_from_command_line(sys.argv)
>
> [ ... some stack dump ...]
>
>   File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
> 147, in acquire
> self._do_open()
>   File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
> 119, in _do_open
> self.lockfile = open(self.path, 'a')
> PermissionError: [Errno 13] Permission denied:
> '/usr/lib/python3/dist-packages/openstack_dashboard/
> local/_usr_lib_python3_dist-packages_openstack_dashboard_
> local_.secret_key_store.lock'
>
> What thing is attempting to write in my read only /usr, while Horizon is
> correctly installed, and writing its secret key material as it should,
> in /var/lib/openstack-dashboard? It's probably due to me, but here, how
> can I make heat-dashboard unit test behave during package build? What's
> this "No local_settings file found" thing? Other dashboards didn't
> complain in this way...
>
> Cheers,
>
> Thomas Goirand (zigo)
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [heat] heat-dashboard is non-free, with broken unit test env

[Thomas Goirand]

Hi there!

I'm having big trouble package heat-dashboard for Debian. I hope I can
get help through this list.

In here:

heat_dashboard/static/dashboard/project/heat_dashboard/template_generator/js/

we have minified *only* versions of Javascript.

1/ Why is there only minified versions? That's non-free to me, Debian,
and probably any other distro caring about OpenStack.
2/ Why do we even have a folder called "vendors"? Doesn't this sound
really a bad practice?
3/ Why is there so many angular-*.min.js files? Do we need them all?
4/ Why isn't the package using xstatic-angular and friends?

As it stands, I can't upload heat-dashboard to Debian for Queens, and
it's been removed from Horizon... :(

Oh, and I almost forgot! When running unit tests, I get:

PYTHON=python$i NOSE_WITH_OPENSTACK=1 \
NOSE_OPENSTACK_COLOR=1 \
NOSE_OPENSTACK_RED=0.05 \
NOSE_OPENSTACK_YELLOW=0.025 \
NOSE_OPENSTACK_SHOW_ELAPSED=1 \
DJANGO_SETTINGS_MODULE=heat_dashboard.test.settings \
python$i
/home/zigo/sources/openstack/queens/services/heat-dashboard/build-area/heat-dashboard-1.0.2/manage.py
test heat_dashboard.test --settings=heat_dashboard.test.settings

No local_settings file found.
Traceback (most recent call last):
  File
"/home/zigo/sources/openstack/queens/services/heat-dashboard/build-area/heat-dashboard-1.0.2/manage.py",
line 23, in 
execute_from_command_line(sys.argv)

[ ... some stack dump ...]

  File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
147, in acquire
self._do_open()
  File "/usr/lib/python3/dist-packages/fasteners/process_lock.py", line
119, in _do_open
self.lockfile = open(self.path, 'a')
PermissionError: [Errno 13] Permission denied:
'/usr/lib/python3/dist-packages/openstack_dashboard/local/_usr_lib_python3_dist-packages_openstack_dashboard_local_.secret_key_store.lock'

What thing is attempting to write in my read only /usr, while Horizon is
correctly installed, and writing its secret key material as it should,
in /var/lib/openstack-dashboard? It's probably due to me, but here, how
can I make heat-dashboard unit test behave during package build? What's
this "No local_settings file found" thing? Other dashboards didn't
complain in this way...

Cheers,

Thomas Goirand (zigo)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev