Re: [openstack-dev] [horizon] npm lint and test problems in gate
JFYI, CR [1] which fixes the corresponding bug [2] was merged on Jun 28, so
it may make sense to recheck you perfectly looking commit if it has been
staying in Gerrit for a while.
[1] https://review.openstack.org/#/c/334582/
[2] https://bugs.launchpad.net/horizon/+bug/1595938
On Mon, Jun 27, 2016 at 10:42 PM Jeremy Stanley wrote:
> On 2016-06-24 22:08:40 + (+), Jeremy Stanley wrote:
> [...]
> > the gate-horizon-npm-run-test job uses that same configuration
> > (just passing a different {command}) and we're still seeing
> > failures registered for it even now.
> [...]
>
> Just following up since I got a few more minutes to poke at this
> after discussing in IRC: I have confirmed the stats we have in
> graphite seem to match what's recorded by logstash, and dug up
> three example failure logs from today.
>
>
> http://logs.openstack.org/00/334300/1/check/gate-horizon-npm-run-test/469ff89/console.html
>
>
> http://logs.openstack.org/03/320203/9/check/gate-horizon-npm-run-test/e71f803/console.html
>
>
> http://logs.openstack.org/28/333628/5/check/gate-horizon-npm-run-test/5ae2085/console.html
>
> However, there's (thankfully) a consistent explanation. Take a look
> at the timestamp gaps between the penultimate and ultimate lines of
> each log... timeouts! So I agree the issue seems to be lack of
> errexit in the npm-run builder. The old failures observed for
> gate-horizon-npm-run-lint are probably similarly explained as
> timeout issues we've just been lucky enough not to hit in the past
> week or so. Unfortunately those failures fall just outside our
> elasticsearch retention window so confirming that would be a very
> time-intensive exercise at this point.
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] npm lint and test problems in gate
On 2016-06-24 22:08:40 + (+), Jeremy Stanley wrote:
[...]
> the gate-horizon-npm-run-test job uses that same configuration
> (just passing a different {command}) and we're still seeing
> failures registered for it even now.
[...]
Just following up since I got a few more minutes to poke at this
after discussing in IRC: I have confirmed the stats we have in
graphite seem to match what's recorded by logstash, and dug up
three example failure logs from today.
http://logs.openstack.org/00/334300/1/check/gate-horizon-npm-run-test/469ff89/console.html
http://logs.openstack.org/03/320203/9/check/gate-horizon-npm-run-test/e71f803/console.html
http://logs.openstack.org/28/333628/5/check/gate-horizon-npm-run-test/5ae2085/console.html
However, there's (thankfully) a consistent explanation. Take a look
at the timestamp gaps between the penultimate and ultimate lines of
each log... timeouts! So I agree the issue seems to be lack of
errexit in the npm-run builder. The old failures observed for
gate-horizon-npm-run-lint are probably similarly explained as
timeout issues we've just been lucky enough not to hit in the past
week or so. Unfortunately those failures fall just outside our
elasticsearch retention window so confirming that would be a very
time-intensive exercise at this point.
--
Jeremy Stanley
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] npm lint and test problems in gate
On 2016-06-24 19:12:01 + (+), Borland, Matt wrote:
> It seems that the npm-run jobs are both passing Jenkins even when the tests
> themselves fail. I'm not sure why that is, but Cores in particular:
>
> Please run "npm run lint && npm run test" before you +2 (or +1) anything.
> This ensures that we don't pollute master with broken linting/tests.
I started digging into this briefly, mostly so that we could rule
out a behavior change from the switch from Jenkins to
zuul-launcher/ansible. Jobs were fully on zuul-launcher and off
Jenkins by the UTC end of the 16th[1] but according to graphite[2]
failures were seen in the check pipeline for
gate-horizon-npm-run-lint up to almost noon UTC on the 18th. Worth
noting, however, the gate-horizon-npm-run-test job uses that same
configuration (just passing a different {command}) and we're still
seeing failures[3] registered for it even now.
I also don't see any obvious changes to the configuration
gate-{name}-npm-run-{command} template or npm-run builder definition
this week to account for the behavior change.
[1] http://lists.openstack.org/pipermail/openstack-infra/2016-June/004435.html
[2] http://graphite.openstack.org/render/?width=800&height=400&target=None&target=stats_counts.zuul.pipeline.check.job.gate-horizon-npm-run-lint.FAILURE&from=-24days
>
[3] http://graphite.openstack.org/render/?width=800&height=400&target=None&target=stats_counts.zuul.pipeline.check.job.gate-horizon-npm-run-test.FAILURE&from=-24days
>
--
Jeremy Stanley
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [horizon] npm lint and test problems in gate
Horizoneers, It seems that the npm-run jobs are both passing Jenkins even when the tests themselves fail. I'm not sure why that is, but Cores in particular: Please run "npm run lint && npm run test" before you +2 (or +1) anything. This ensures that we don't pollute master with broken linting/tests. Thanks! Matt Borland __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
