Re: [openstack-dev] [ironic-staging-drivers] Tests at the gates

2016-04-21 Thread Vladyslav Drok
It seems that all the drivers' dependencies currently present in ironic
tree can be installed
from binary packages, so maybe we could make use of bindep. But what if
some driver
will require addition of some custom repository, it will have to go
directly to plugin.sh?
Also, after e.g. gate switch to ubuntu 16.04, some of packages may break
(e.g. pywsman
states that it has been tested only on ubuntu 14.04), we should disable
those broken
drivers and require maintainers to fix things, is there any time frame set
for this?

On Thu, Apr 21, 2016 at 11:26 AM, Andreas Jaeger  wrote:

> On 2016-04-21 10:20, Vasyl Saienko wrote:
> > Hello Andreas,
> >
> > Thanks for comment, I didn't know about other-requirements.
> >
> > There is a tool 'bindep' [0] that allows to parse other-requirements.txt
> > It is possible to mix python/system dependencies in single
> > other-requirements.txt. But mixing packages from different distros are
> > not supported.
>
> other-requirements.txt only handles binary distro packages, you can mix
> different distros.
>
> > Also it doesn't allow to install dependencies from sources. I'm not sure
> > that it is what we need.
>
> Then, please name what you do differently to avoid confusion.
>
> > I would prefer to have shell script that is maintained by driver's owner
> > and provides complete freedom in configuration.
>
> Do you really need that?
>
> Andreas
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>HRB 21284 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [ironic-staging-drivers] Tests at the gates

2016-04-21 Thread Andreas Jaeger
On 2016-04-21 10:20, Vasyl Saienko wrote:
> Hello Andreas,
> 
> Thanks for comment, I didn't know about other-requirements.
> 
> There is a tool 'bindep' [0] that allows to parse other-requirements.txt
> It is possible to mix python/system dependencies in single
> other-requirements.txt. But mixing packages from different distros are
> not supported.

other-requirements.txt only handles binary distro packages, you can mix
different distros.

> Also it doesn't allow to install dependencies from sources. I'm not sure
> that it is what we need.

Then, please name what you do differently to avoid confusion.

> I would prefer to have shell script that is maintained by driver's owner
> and provides complete freedom in configuration.

Do you really need that?

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [ironic-staging-drivers] Tests at the gates

2016-04-21 Thread Vasyl Saienko
Hello Andreas,

Thanks for comment, I didn't know about other-requirements.

There is a tool 'bindep' [0] that allows to parse other-requirements.txt
It is possible to mix python/system dependencies in single
other-requirements.txt. But mixing packages from different distros are not
supported.
Also it doesn't allow to install dependencies from sources. I'm not sure
that it is what we need.

I would prefer to have shell script that is maintained by driver's owner
and provides complete freedom in configuration.


[0] https://github.com/openstack-infra/bindep

On Wed, Apr 20, 2016 at 9:38 PM, Andreas Jaeger  wrote:

> On 04/20/2016 04:57 PM, Vasyl Saienko wrote:
> > Hello Ironic-staging-drivers team,
> >
> > At the moment there is no tests for ironic-staging-drivers at the gates.
> > I think we need to have a simple test that install drivers with theirs
> > dependencies and ensures that ironic-conductor is able to start.
> > It may be performed in the following way. Each staging driver contain
> > two files:
> >
> >   * python-requirements.txt - file for python libraries
> >   * other-requirements.sh - script that will install all non-python
>
> The file other-requirements.txt is already one way to install additional
> packages, just use that one. Best ask on #openstack-infra for details,
>
> Andreas
>
> > driver requirements.
> >
> > During devstack installation phase for each driver we launch:
> >
> >   * pip install -r
> >
>  ironic-staging-drivers/ironic-staging-drivers/$driver/python-requirements.txt
> >   * bash
> >
>  ironic-staging-drivers/ironic-staging-drivers/$driver/other-requirements.sh
> >   * add drivers to enabled_driver list
> >
> > At the end ironic will try to register a node with some *_ssh driver. So
> > if it succeed it means that conductor with staging drivers has started
> > successfully.
> >
> > The devstack plugin is on review already:
> > https://review.openstack.org/#/c/299229/
> >
> > Sincerely,
> > Vasyl Saienko
> >
> >
> >
> >
> >
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>HRB 21284 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [ironic-staging-drivers] Tests at the gates

2016-04-20 Thread Andreas Jaeger
On 04/20/2016 04:57 PM, Vasyl Saienko wrote:
> Hello Ironic-staging-drivers team,
> 
> At the moment there is no tests for ironic-staging-drivers at the gates.
> I think we need to have a simple test that install drivers with theirs
> dependencies and ensures that ironic-conductor is able to start.
> It may be performed in the following way. Each staging driver contain
> two files:
> 
>   * python-requirements.txt - file for python libraries
>   * other-requirements.sh - script that will install all non-python

The file other-requirements.txt is already one way to install additional
packages, just use that one. Best ask on #openstack-infra for details,

Andreas

> driver requirements.
> 
> During devstack installation phase for each driver we launch:
> 
>   * pip install -r
> 
> ironic-staging-drivers/ironic-staging-drivers/$driver/python-requirements.txt
>   * bash
> 
> ironic-staging-drivers/ironic-staging-drivers/$driver/other-requirements.sh
>   * add drivers to enabled_driver list
> 
> At the end ironic will try to register a node with some *_ssh driver. So
> if it succeed it means that conductor with staging drivers has started
> successfully.
> 
> The devstack plugin is on review already:
> https://review.openstack.org/#/c/299229/
> 
> Sincerely,
> Vasyl Saienko
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [ironic-staging-drivers] Tests at the gates

2016-04-20 Thread Vasyl Saienko
Hello Ironic-staging-drivers team,

At the moment there is no tests for ironic-staging-drivers at the gates.
I think we need to have a simple test that install drivers with theirs
dependencies and ensures that ironic-conductor is able to start.
It may be performed in the following way. Each staging driver contain two
files:

   - python-requirements.txt - file for python libraries
   - other-requirements.sh - script that will install all non-python driver
   requirements.

During devstack installation phase for each driver we launch:

   - pip install -r
   ironic-staging-drivers/ironic-staging-drivers/$driver/python-requirements.txt
   - bash
   ironic-staging-drivers/ironic-staging-drivers/$driver/other-requirements.sh
   - add drivers to enabled_driver list

At the end ironic will try to register a node with some *_ssh driver. So if
it succeed it means that conductor with staging drivers has started
successfully.

The devstack plugin is on review already:
https://review.openstack.org/#/c/299229/

Sincerely,
Vasyl Saienko
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev