Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Paul Bourke]

Thanks for the reminder Andreas, patchset here: 
https://review.openstack.org/397672


On 15/11/16 10:29, Andreas Jaeger wrote:

On 2016-11-15 11:10, Paul Bourke wrote:

Given the window for this vote is now closed and I saw no minus ones
I'll assume this has passed. TrivialFix is now optional.


Is TrivialFix mentioned in the docs and do those need updating for the
changed policy?

Andreas



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Andreas Jaeger]

On 2016-11-15 11:10, Paul Bourke wrote:
> Given the window for this vote is now closed and I saw no minus ones
> I'll assume this has passed. TrivialFix is now optional.

Is TrivialFix mentioned in the docs and do those need updating for the
changed policy?

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Paul Bourke]

Given the window for this vote is now closed and I saw no minus ones 
I'll assume this has passed. TrivialFix is now optional.


Thanks,
-Paul

On 04/11/16 22:51, Steven Dake (stdake) wrote:

Paul,



I’ll take your request as a request for a vote of the core reviewers.



My vote is +1 in favor of removing the requirement for TrivialFix.



As per our standard policy, the voting window is open for 7 days
beginning November 3^rd , and finishing (in 7 days) on November 11^th .



Regards

-steve





*From: *Paul Bourke <paul.bou...@oracle.com>
*Reply-To: *"OpenStack Development Mailing List (not for usage
questions)" <openstack-dev@lists.openstack.org>
*Date: *Thursday, November 3, 2016 at 6:21 AM
*To: *"OpenStack Development Mailing List (not for usage questions)"
<openstack-dev@lists.openstack.org>
    *Subject: *[openstack-dev] [kolla] Propose removal of TrivialFix
requirement



Kolleagues,



How do people feel above removing the requirement of having TrivialFix

in commit messages where a bug/bp is not required?



I'm seeing a lot of valid and important commits being held up
because of

this, in my opinion, unnecessary requirement. It also causes friction

for new contributers to the project.



Are there any major benefits we're getting from the use of this tag
that

I'm missing?



Cheers,

-Paul



__

OpenStack Development Mailing List (not for usage questions)

Unsubscribe: openstack-dev-requ...@lists.openstack.org
<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev





__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Vikram Hosakote (vhosakot)]

Yes, I'm +1 for this.

I've seen TrivialFix used for a lot of non-trivial fixes.

May be, we need a spec to define what is trivial?  ;)

Regards,
Vikram Hosakote
IRC:  vhosakot

From: Paul Bourke <paul.bou...@oracle.com<mailto:paul.bou...@oracle.com>>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>>
Date: Thursday, November 3, 2016 at 6:51 PM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>>
Subject: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

Kolleagues,

How do people feel above removing the requirement of having TrivialFix
in commit messages where a bug/bp is not required?

I'm seeing a lot of valid and important commits being held up because of
this, in my opinion, unnecessary requirement. It also causes friction
for new contributers to the project.

Are there any major benefits we're getting from the use of this tag that
I'm missing?

Cheers,
-Paul

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Steven Dake (stdake)]

Swapnil,

If you feel someone is lazy with not filing bugs for backports or feature 
request, with a monster feature request or something that requires a backport, 
simply -1 the review and add a polite comment “Please add a bug ID or 
blueprint”.

Regards,
-steve


From: Swapnil Kulkarni <cools...@gmail.com>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Friday, November 4, 2016 at 5:48 AM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke 
<paul.bou...@oracle.com<mailto:paul.bou...@oracle.com>> wrote:
Kolleagues,

How do people feel above removing the requirement of having TrivialFix in
commit messages where a bug/bp is not required?

I'm seeing a lot of valid and important commits being held up because of
this, in my opinion, unnecessary requirement. It also causes friction for
new contributers to the project.

Are there any major benefits we're getting from the use of this tag that I'm
missing?

Cheers,
-Paul

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.

If the commits are important then there is no harm in creating a
tracking bug for it.
It would take 1/30(I am just making highest time for a build/deploy
gate) amount of time you need to verify the (important)fix on gate.

[1] docs.openstack.org/developer/kolla/CONTRIBUTING.html

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Steven Dake (stdake)]

Paul,

I’ll take your request as a request for a vote of the core reviewers.

My vote is +1 in favor of removing the requirement for TrivialFix.

As per our standard policy, the voting window is open for 7 days beginning 
November 3rd, and finishing (in 7 days) on November 11th.

Regards
-steve


From: Paul Bourke <paul.bou...@oracle.com>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Thursday, November 3, 2016 at 6:21 AM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

Kolleagues,

How do people feel above removing the requirement of having TrivialFix
in commit messages where a bug/bp is not required?

I'm seeing a lot of valid and important commits being held up because of
this, in my opinion, unnecessary requirement. It also causes friction
for new contributers to the project.

Are there any major benefits we're getting from the use of this tag that
I'm missing?

Cheers,
-Paul

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Steven Dake (stdake)]

Andreas,

Agree.  Asked and answered.  If Michal has some differing viewpoint, that’s his 
prerogative as the PTL of Kolla, however, I would have serious concerns with 
that model, and would request a vote of the core reviewers to solidify our 
processes to match the OpenStack way.

Regards
-steve


From: Andreas Jaeger <a...@suse.com>
Organization: SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham 
Norton, HRB 21284 (AG Nürnberg)
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Friday, November 4, 2016 at 8:30 AM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

On 11/04/2016 04:25 PM, Jeremy Stanley wrote:
On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:
I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.

If the commits are important then there is no harm in creating a
tracking bug for it.
[...]
All I ask is that if the Kolla team wants to differentiate itself
from the review requirements of most OpenStack projects, please make
sure you have active and attentive liaisons who can update
mass-proposed changes for base infrastructure or other similar
horizonal and cross-project efforts to meet your special reviewing
standards. I cannot personally keep on top of the nuances of every
review team and individually adjust such mass changes myself, so
rely on you to "fix" my patches for me in such situations.

Jeremy, I do agree with your request.

I expect this to be settled by Steven Dake's email:
http://lists.openstack.org/pipermail/openstack-dev/2016-October/105287.html

Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Steven Dake (stdake)]

Jeremy,

Kolla doesn’t want to be a special snowflake WRT patches.  TrivialFix was 
introduced to help core reviewers identify what bugs need backports vs which 
changes do not or are feature changes (which we also don’t backport).  We don’t 
always get backport tracking correctly, but I think we are running about 90% or 
better, which is GEFN.  Gaming reviews by using TrivialFix that require actual 
backports are responded to in my reviews with a polite “Please add a Bug ID” 
with a -1 associated in the review.  I believe most of the core team is on 
board with this model – if not we should have a vote on it amongst the core 
reviewer team.

Regards
-steve


From: Jeremy Stanley <fu...@yuggoth.org>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Friday, November 4, 2016 at 9:31 AM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

On 2016-11-04 15:42:17 + (+), Paul Bourke wrote:
We have no desire to do this, that's not what is being discussed
here. On the contrary we're looking to reduce the barrier to entry
for committers. Also the team is aware that cross project efforts
should not be nit picked.

That's what it seemed like to me up to this point in the thread as
well; I was specifically replying to Swapnil's suggestion that any
important change to Kolla deliverables should have a bug filed or
should continue to add a TrivialFix header in the commit message
otherwise. (And yes, as Andreas pointed out the other thread on the
related topic of mass changes for cross-project efforts does address
the case specifically, but becomes less necessary if you end up
agreeing to drop the TrivialFix requirement.)
--
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Steven Dake (stdake)]

The general rule I follow (and would propose we stick to) is is as follows:

If it requires a backport – it requires a bug id.  (This is to facilitate the 
tracking of backports to make sure we do the job correctly)
If it doesn’t require a backport but is a feature submission, it should include 
a blueprint header (for tracking purposes, yet again)
If it doesn’t fit into the above two categories, I really don’t see a need for 
any type of extra tagging including TrivialFix.  TrivialFix was a nice idea to 
help core reviewers understand if the work needed a backport, or was a feature 
request.  Our core reviewer team is smart enough to make that determination 
during the very thorough review process we undertake on all patches.

TrivialFix can go assuming the core reviewers can determine what is needed for 
a backport (high/critical bugs only) – and request a bug ID during the review 
with an appropriate -1.

Regards
-steve


From: Swapnil Kulkarni <cools...@gmail.com>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Friday, November 4, 2016 at 10:50 AM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

On Fri, Nov 4, 2016 at 10:01 PM, Jeremy Stanley 
<fu...@yuggoth.org<mailto:fu...@yuggoth.org>> wrote:
On 2016-11-04 15:42:17 + (+), Paul Bourke wrote:
We have no desire to do this, that's not what is being discussed
here. On the contrary we're looking to reduce the barrier to entry
for committers. Also the team is aware that cross project efforts
should not be nit picked.

That's what it seemed like to me up to this point in the thread as
well; I was specifically replying to Swapnil's suggestion that any
important change to Kolla deliverables should have a bug filed or
should continue to add a TrivialFix header in the commit message
otherwise. (And yes, as Andreas pointed out the other thread on the
related topic of mass changes for cross-project efforts does address
the case specifically, but becomes less necessary if you end up
agreeing to drop the TrivialFix requirement.)
--
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Jeremy,

I am sorry if I have miscommunicated earlier. I am referring to the
situation where people are using TrivialFix just to get the changes in
which is not good practice.

I agree with removing TrivialFix just that we need to be very careful
with changes that need tracking (e.g. bug/bp).

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org<mailto:openstack-dev-requ...@lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Swapnil Kulkarni]

On Fri, Nov 4, 2016 at 10:01 PM, Jeremy Stanley  wrote:
> On 2016-11-04 15:42:17 + (+), Paul Bourke wrote:
>> We have no desire to do this, that's not what is being discussed
>> here. On the contrary we're looking to reduce the barrier to entry
>> for committers. Also the team is aware that cross project efforts
>> should not be nit picked.
>
> That's what it seemed like to me up to this point in the thread as
> well; I was specifically replying to Swapnil's suggestion that any
> important change to Kolla deliverables should have a bug filed or
> should continue to add a TrivialFix header in the commit message
> otherwise. (And yes, as Andreas pointed out the other thread on the
> related topic of mass changes for cross-project efforts does address
> the case specifically, but becomes less necessary if you end up
> agreeing to drop the TrivialFix requirement.)
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Jeremy,

I am sorry if I have miscommunicated earlier. I am referring to the
situation where people are using TrivialFix just to get the changes in
which is not good practice.

I agree with removing TrivialFix just that we need to be very careful
with changes that need tracking (e.g. bug/bp).

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Swapnil Kulkarni]

On Fri, Nov 4, 2016 at 9:12 PM, Paul Bourke  wrote:
> Hi Jeremy,
>
>> All I ask is that if the Kolla team wants to differentiate itself
>> from the review requirements of most OpenStack projects, please make
>
> We have no desire to do this, that's not what is being discussed here. On
> the contrary we're looking to reduce the barrier to entry for committers.
> Also the team is aware that cross project efforts should not be nit picked.
>
> -Paul
>
> On 04/11/16 15:25, Jeremy Stanley wrote:
>>
>> On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:
>>>
>>> I feel TrivialFix is consistently used by people just to avoid going
>>> to lanuchpad and filing a bug. It should only be used only if the "Fix
>>> is Trivial"
>>> This has been well documented in the contributing doc [1] and this
>>> should be referred to people when they do not have the bug/bp in the
>>> commit message.
>>>
>>> If the commits are important then there is no harm in creating a
>>> tracking bug for it.
>>
>> [...]
>>
>> All I ask is that if the Kolla team wants to differentiate itself
>> from the review requirements of most OpenStack projects, please make
>> sure you have active and attentive liaisons who can update
>> mass-proposed changes for base infrastructure or other similar
>> horizonal and cross-project efforts to meet your special reviewing
>> standards. I cannot personally keep on top of the nuances of every
>> review team and individually adjust such mass changes myself, so
>> rely on you to "fix" my patches for me in such situations.
>>
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Nit picking was needed since the policy was followed more to avoid
creating or using a tracker more often.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Jeremy Stanley]

On 2016-11-04 15:42:17 + (+), Paul Bourke wrote:
> We have no desire to do this, that's not what is being discussed
> here. On the contrary we're looking to reduce the barrier to entry
> for committers. Also the team is aware that cross project efforts
> should not be nit picked.

That's what it seemed like to me up to this point in the thread as
well; I was specifically replying to Swapnil's suggestion that any
important change to Kolla deliverables should have a bug filed or
should continue to add a TrivialFix header in the commit message
otherwise. (And yes, as Andreas pointed out the other thread on the
related topic of mass changes for cross-project efforts does address
the case specifically, but becomes less necessary if you end up
agreeing to drop the TrivialFix requirement.)
-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Paul Bourke]

Hi Jeremy,

> All I ask is that if the Kolla team wants to differentiate itself
> from the review requirements of most OpenStack projects, please make

We have no desire to do this, that's not what is being discussed here. 
On the contrary we're looking to reduce the barrier to entry for 
committers. Also the team is aware that cross project efforts should not 
be nit picked.


-Paul

On 04/11/16 15:25, Jeremy Stanley wrote:

On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:

I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.

If the commits are important then there is no harm in creating a
tracking bug for it.

[...]

All I ask is that if the Kolla team wants to differentiate itself
from the review requirements of most OpenStack projects, please make
sure you have active and attentive liaisons who can update
mass-proposed changes for base infrastructure or other similar
horizonal and cross-project efforts to meet your special reviewing
standards. I cannot personally keep on top of the nuances of every
review team and individually adjust such mass changes myself, so
rely on you to "fix" my patches for me in such situations.



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Andreas Jaeger]

On 11/04/2016 04:25 PM, Jeremy Stanley wrote:
> On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:
>> I feel TrivialFix is consistently used by people just to avoid going
>> to lanuchpad and filing a bug. It should only be used only if the "Fix
>> is Trivial"
>> This has been well documented in the contributing doc [1] and this
>> should be referred to people when they do not have the bug/bp in the
>> commit message.
>>
>> If the commits are important then there is no harm in creating a
>> tracking bug for it.
> [...]
> 
> All I ask is that if the Kolla team wants to differentiate itself
> from the review requirements of most OpenStack projects, please make
> sure you have active and attentive liaisons who can update
> mass-proposed changes for base infrastructure or other similar
> horizonal and cross-project efforts to meet your special reviewing
> standards. I cannot personally keep on top of the nuances of every
> review team and individually adjust such mass changes myself, so
> rely on you to "fix" my patches for me in such situations.

Jeremy, I do agree with your request.

I expect this to be settled by Steven Dake's email:
http://lists.openstack.org/pipermail/openstack-dev/2016-October/105287.html

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Jeremy Stanley]

On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:
> I feel TrivialFix is consistently used by people just to avoid going
> to lanuchpad and filing a bug. It should only be used only if the "Fix
> is Trivial"
> This has been well documented in the contributing doc [1] and this
> should be referred to people when they do not have the bug/bp in the
> commit message.
> 
> If the commits are important then there is no harm in creating a
> tracking bug for it.
[...]

All I ask is that if the Kolla team wants to differentiate itself
from the review requirements of most OpenStack projects, please make
sure you have active and attentive liaisons who can update
mass-proposed changes for base infrastructure or other similar
horizonal and cross-project efforts to meet your special reviewing
standards. I cannot personally keep on top of the nuances of every
review team and individually adjust such mass changes myself, so
rely on you to "fix" my patches for me in such situations.
-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Eduardo Gonzalez]

+1


2016-11-04 13:32 GMT+00:00 Jeffrey Zhang <zhang.lei@gmail.com>:

> +1
>
> On Fri, Nov 4, 2016 at 8:51 PM, Ryan Hallisey <rhall...@redhat.com> wrote:
>
>> +1
>>
>> -Ryan
>>
>> - Original Message -
>> From: "Swapnil Kulkarni" <cools...@gmail.com>
>> To: "OpenStack Development Mailing List (not for usage questions)" <
>> openstack-dev@lists.openstack.org>
>> Sent: Friday, November 4, 2016 8:48:49 AM
>> Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix
>> requirement
>>
>> On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke <paul.bou...@oracle.com>
>> wrote:
>> > Kolleagues,
>> >
>> > How do people feel above removing the requirement of having TrivialFix
>> in
>> > commit messages where a bug/bp is not required?
>> >
>> > I'm seeing a lot of valid and important commits being held up because of
>> > this, in my opinion, unnecessary requirement. It also causes friction
>> for
>> > new contributers to the project.
>> >
>> > Are there any major benefits we're getting from the use of this tag
>> that I'm
>> > missing?
>> >
>> > Cheers,
>> > -Paul
>> >
>> > 
>> __
>> > OpenStack Development Mailing List (not for usage questions)
>> > Unsubscribe: openstack-dev-requ...@lists.op
>> enstack.org?subject:unsubscribe
>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> I feel TrivialFix is consistently used by people just to avoid going
>> to lanuchpad and filing a bug. It should only be used only if the "Fix
>> is Trivial"
>> This has been well documented in the contributing doc [1] and this
>> should be referred to people when they do not have the bug/bp in the
>> commit message.
>>
>> If the commits are important then there is no harm in creating a
>> tracking bug for it.
>> It would take 1/30(I am just making highest time for a build/deploy
>> gate) amount of time you need to verify the (important)fix on gate.
>>
>> [1] docs.openstack.org/developer/kolla/CONTRIBUTING.html
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Regards,
> Jeffrey Zhang
> Blog: http://xcodest.me
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Jeffrey Zhang]

+1

On Fri, Nov 4, 2016 at 8:51 PM, Ryan Hallisey <rhall...@redhat.com> wrote:

> +1
>
> -Ryan
>
> - Original Message -
> From: "Swapnil Kulkarni" <cools...@gmail.com>
> To: "OpenStack Development Mailing List (not for usage questions)" <
> openstack-dev@lists.openstack.org>
> Sent: Friday, November 4, 2016 8:48:49 AM
> Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix
> requirement
>
> On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke <paul.bou...@oracle.com>
> wrote:
> > Kolleagues,
> >
> > How do people feel above removing the requirement of having TrivialFix in
> > commit messages where a bug/bp is not required?
> >
> > I'm seeing a lot of valid and important commits being held up because of
> > this, in my opinion, unnecessary requirement. It also causes friction for
> > new contributers to the project.
> >
> > Are there any major benefits we're getting from the use of this tag that
> I'm
> > missing?
> >
> > Cheers,
> > -Paul
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> I feel TrivialFix is consistently used by people just to avoid going
> to lanuchpad and filing a bug. It should only be used only if the "Fix
> is Trivial"
> This has been well documented in the contributing doc [1] and this
> should be referred to people when they do not have the bug/bp in the
> commit message.
>
> If the commits are important then there is no harm in creating a
> tracking bug for it.
> It would take 1/30(I am just making highest time for a build/deploy
> gate) amount of time you need to verify the (important)fix on gate.
>
> [1] docs.openstack.org/developer/kolla/CONTRIBUTING.html
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Regards,
Jeffrey Zhang
Blog: http://xcodest.me
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Ryan Hallisey]

+1

-Ryan

- Original Message -
From: "Swapnil Kulkarni" <cools...@gmail.com>
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Sent: Friday, November 4, 2016 8:48:49 AM
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix  
requirement

On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke <paul.bou...@oracle.com> wrote:
> Kolleagues,
>
> How do people feel above removing the requirement of having TrivialFix in
> commit messages where a bug/bp is not required?
>
> I'm seeing a lot of valid and important commits being held up because of
> this, in my opinion, unnecessary requirement. It also causes friction for
> new contributers to the project.
>
> Are there any major benefits we're getting from the use of this tag that I'm
> missing?
>
> Cheers,
> -Paul
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.

If the commits are important then there is no harm in creating a
tracking bug for it.
It would take 1/30(I am just making highest time for a build/deploy
gate) amount of time you need to verify the (important)fix on gate.

[1] docs.openstack.org/developer/kolla/CONTRIBUTING.html

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Swapnil Kulkarni]

On Thu, Nov 3, 2016 at 6:51 PM, Paul Bourke  wrote:
> Kolleagues,
>
> How do people feel above removing the requirement of having TrivialFix in
> commit messages where a bug/bp is not required?
>
> I'm seeing a lot of valid and important commits being held up because of
> this, in my opinion, unnecessary requirement. It also causes friction for
> new contributers to the project.
>
> Are there any major benefits we're getting from the use of this tag that I'm
> missing?
>
> Cheers,
> -Paul
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.

If the commits are important then there is no harm in creating a
tracking bug for it.
It would take 1/30(I am just making highest time for a build/deploy
gate) amount of time you need to verify the (important)fix on gate.

[1] docs.openstack.org/developer/kolla/CONTRIBUTING.html

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Michał Jastrzębski]

Yeah I was thinking of it myself.

+1 from me

On 3 November 2016 at 09:08, Christian Berendt
 wrote:
>
>> On 3 Nov 2016, at 14:33, Mauricio Lima  wrote:
>>
>> I Agree. +1
>
> +1
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Christian Berendt]

> On 3 Nov 2016, at 14:33, Mauricio Lima  wrote:
> 
> I Agree. +1

+1

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Mauricio Lima]

I Agree. +1

2016-11-03 10:21 GMT-03:00 Paul Bourke :

> Kolleagues,
>
> How do people feel above removing the requirement of having TrivialFix in
> commit messages where a bug/bp is not required?
>
> I'm seeing a lot of valid and important commits being held up because of
> this, in my opinion, unnecessary requirement. It also causes friction for
> new contributers to the project.
>
> Are there any major benefits we're getting from the use of this tag that
> I'm missing?
>
> Cheers,
> -Paul
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [kolla] Propose removal of TrivialFix requirement

[Paul Bourke]

Kolleagues,

How do people feel above removing the requirement of having TrivialFix 
in commit messages where a bug/bp is not required?


I'm seeing a lot of valid and important commits being held up because of 
this, in my opinion, unnecessary requirement. It also causes friction 
for new contributers to the project.


Are there any major benefits we're getting from the use of this tag that 
I'm missing?


Cheers,
-Paul

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev