Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
Renat, Yes, I have created blueprint, here is a link [1] . In this bp you can find link to the etherpad where I described a couple of rules that came to my mind. [1] https://blueprints.launchpad.net/mistral/+spec/add-custom-code-style-checks On Thu, Dec 24, 2015 at 10:59 AM, Renat Akhmerov wrote: > I’m the one who has been enforcing those style things from the beginning > so let me take this and describe these rules in details. > > Anastasia, have you already created a BP? > > Renat Akhmerov > @ Mirantis Inc. > > > > On 10 Dec 2015, at 20:05, Anastasia Kuznetsova > wrote: > > Moshe, > > I will create blueprint for that and will attach link to etherpad, so we > can form list of the rules all together. > After that it will be possible to publish all our 'rules' to docs and > start their implementation. > > On Thu, Dec 10, 2015 at 11:23 AM, ELISHA, Moshe (Moshe) < > moshe.eli...@alcatel-lucent.com> wrote: > >> Thanks, Anastasia! >> >> >> >> Who can take start documenting the rules? I remember only a few rules and >> I don’t know all the nuances. >> >> For example, if the return statement is the only statement of a function >> – do you still need a blank line before it? >> >> >> >> Once the rules doc will be available I can work on adding these rules to >> our pep8. >> >> >> >> >> >> *From:* Anastasia Kuznetsova [mailto:akuznets...@mirantis.com] >> *Sent:* Wednesday, December 09, 2015 1:13 PM >> *To:* OpenStack Development Mailing List (not for usage questions) >> *Subject:* Re: [openstack-dev] [mistral] Improving Mistral pep8 rules >> files to match Mistral guidelines >> >> >> >> Hi Moshe, >> >> >> >> Great idea! >> >> >> >> It is possible to prepare some additional code checks, for example you >> can take a look how it was done in Rally project [1]. >> Before starting such work in Mistral, I guess that we can describe our >> addition code style rules in our official docs (somewhere in "Developer >> Guide" section [2]). >> >> >> >> [1] https://github.com/openstack/rally/tree/master/tests/hacking >> >> [2] http://docs.openstack.org/developer/mistral/#developer-guide >> >> >> >> On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) < >> moshe.eli...@alcatel-lucent.com> wrote: >> >> Hi all, >> >> >> >> Is it possible to add all / some of the special guidelines of Mistral >> (like blank line before return, period at end of comment, …) to our pep8 >> rules file? >> >> >> >> This can save a lot of time for both committers and reviewers. >> >> >> >> Thanks! >> >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> <http://openstack-dev-requ...@lists.openstack.org/?subject:unsubscribe> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> >> >> -- >> >> Best regards, >> >> Anastasia Kuznetsova >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> <http://openstack-dev-requ...@lists.openstack.org/?subject:unsubscribe> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > > -- > Best regards, > Anastasia Kuznetsova > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Best regards, Anastasia Kuznetsova __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
I’m the one who has been enforcing those style things from the beginning so let me take this and describe these rules in details. Anastasia, have you already created a BP? Renat Akhmerov @ Mirantis Inc. > On 10 Dec 2015, at 20:05, Anastasia Kuznetsova > wrote: > > Moshe, > > I will create blueprint for that and will attach link to etherpad, so we can > form list of the rules all together. > After that it will be possible to publish all our 'rules' to docs and start > their implementation. > > On Thu, Dec 10, 2015 at 11:23 AM, ELISHA, Moshe (Moshe) > mailto:moshe.eli...@alcatel-lucent.com>> > wrote: > Thanks, Anastasia! > > > > Who can take start documenting the rules? I remember only a few rules and I > don’t know all the nuances. > > For example, if the return statement is the only statement of a function – do > you still need a blank line before it? > > > > Once the rules doc will be available I can work on adding these rules to our > pep8. > > > > > > From: Anastasia Kuznetsova [mailto:akuznets...@mirantis.com > <mailto:akuznets...@mirantis.com>] > Sent: Wednesday, December 09, 2015 1:13 PM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to > match Mistral guidelines > > > > Hi Moshe, > > > > Great idea! > > > > It is possible to prepare some additional code checks, for example you can > take a look how it was done in Rally project [1]. > Before starting such work in Mistral, I guess that we can describe our > addition code style rules in our official docs (somewhere in "Developer > Guide" section [2]). > > > > [1] https://github.com/openstack/rally/tree/master/tests/hacking > <https://github.com/openstack/rally/tree/master/tests/hacking> > [2] http://docs.openstack.org/developer/mistral/#developer-guide > <http://docs.openstack.org/developer/mistral/#developer-guide> > > > On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) > mailto:moshe.eli...@alcatel-lucent.com>> > wrote: > > Hi all, > > > > Is it possible to add all / some of the special guidelines of Mistral (like > blank line before return, period at end of comment, …) to our pep8 rules file? > > > > This can save a lot of time for both committers and reviewers. > > > > Thanks! > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > <http://openstack-dev-requ...@lists.openstack.org/?subject:unsubscribe> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> > > > > > -- > > Best regards, > > Anastasia Kuznetsova > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > <http://openstack-dev-requ...@lists.openstack.org/?subject:unsubscribe> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> > > > > > -- > Best regards, > Anastasia Kuznetsova > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
Moshe, I will create blueprint for that and will attach link to etherpad, so we can form list of the rules all together. After that it will be possible to publish all our 'rules' to docs and start their implementation. On Thu, Dec 10, 2015 at 11:23 AM, ELISHA, Moshe (Moshe) < moshe.eli...@alcatel-lucent.com> wrote: > Thanks, Anastasia! > > > > Who can take start documenting the rules? I remember only a few rules and > I don’t know all the nuances. > > For example, if the return statement is the only statement of a function – > do you still need a blank line before it? > > > > Once the rules doc will be available I can work on adding these rules to > our pep8. > > > > > > *From:* Anastasia Kuznetsova [mailto:akuznets...@mirantis.com] > *Sent:* Wednesday, December 09, 2015 1:13 PM > *To:* OpenStack Development Mailing List (not for usage questions) > *Subject:* Re: [openstack-dev] [mistral] Improving Mistral pep8 rules > files to match Mistral guidelines > > > > Hi Moshe, > > > > Great idea! > > > > It is possible to prepare some additional code checks, for example you can > take a look how it was done in Rally project [1]. > Before starting such work in Mistral, I guess that we can describe our > addition code style rules in our official docs (somewhere in "Developer > Guide" section [2]). > > > > [1] https://github.com/openstack/rally/tree/master/tests/hacking > > [2] http://docs.openstack.org/developer/mistral/#developer-guide > > > > On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) < > moshe.eli...@alcatel-lucent.com> wrote: > > Hi all, > > > > Is it possible to add all / some of the special guidelines of Mistral > (like blank line before return, period at end of comment, …) to our pep8 > rules file? > > > > This can save a lot of time for both committers and reviewers. > > > > Thanks! > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > > -- > > Best regards, > > Anastasia Kuznetsova > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Best regards, Anastasia Kuznetsova __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
Thanks, Anastasia! Who can take start documenting the rules? I remember only a few rules and I don’t know all the nuances. For example, if the return statement is the only statement of a function – do you still need a blank line before it? Once the rules doc will be available I can work on adding these rules to our pep8. From: Anastasia Kuznetsova [mailto:akuznets...@mirantis.com] Sent: Wednesday, December 09, 2015 1:13 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines Hi Moshe, Great idea! It is possible to prepare some additional code checks, for example you can take a look how it was done in Rally project [1]. Before starting such work in Mistral, I guess that we can describe our addition code style rules in our official docs (somewhere in "Developer Guide" section [2]). [1] https://github.com/openstack/rally/tree/master/tests/hacking [2] http://docs.openstack.org/developer/mistral/#developer-guide On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) mailto:moshe.eli...@alcatel-lucent.com>> wrote: Hi all, Is it possible to add all / some of the special guidelines of Mistral (like blank line before return, period at end of comment, …) to our pep8 rules file? This can save a lot of time for both committers and reviewers. Thanks! __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Best regards, Anastasia Kuznetsova __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
Hi Moshe, Great idea! It is possible to prepare some additional code checks, for example you can take a look how it was done in Rally project [1]. Before starting such work in Mistral, I guess that we can describe our addition code style rules in our official docs (somewhere in "Developer Guide" section [2]). [1] https://github.com/openstack/rally/tree/master/tests/hacking [2] http://docs.openstack.org/developer/mistral/#developer-guide On Wed, Dec 9, 2015 at 11:21 AM, ELISHA, Moshe (Moshe) < moshe.eli...@alcatel-lucent.com> wrote: > Hi all, > > > > Is it possible to add all / some of the special guidelines of Mistral > (like blank line before return, period at end of comment, …) to our pep8 > rules file? > > > > This can save a lot of time for both committers and reviewers. > > > > Thanks! > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Best regards, Anastasia Kuznetsova __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [mistral] Improving Mistral pep8 rules files to match Mistral guidelines
Hi all, Is it possible to add all / some of the special guidelines of Mistral (like blank line before return, period at end of comment, ...) to our pep8 rules file? This can save a lot of time for both committers and reviewers. Thanks! __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
