Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On Tue, Sep 11, 2018 at 7:29 AM, Tony Breeds wrote: > > So I think we have the required reviews lined up to fix master, but they > need votes from zuul and core teams. > > Thanks a lot for the work, Tony. On the n-odl side, when the Depends-On gets merged I'll give it a +W. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On Wed, Sep 05, 2018 at 10:03:09AM -0500, Matthew Thode wrote: > The requirements team has gone ahead and made a aweful hack to get gate > unwedged. The commit message is a very good summary of our reasoning > why it has to be this way for now. My comment explains our plan going > forward (there will be a revert prepared as soon as this merges for > instance). > > step 1. merge this This == https://review.openstack.org/#/c/599277/ ; done and similar versions on stable branches. > step 2. look into and possibly fix our tooling (why was the gitref > addition not rejected by gate) Not done yet > step 3. fix networking-odl (release ceilometer) Done. See: * https://review.openstack.org/#/c/601487/ ; and * https://review.openstack.org/#/c/601488/ > step 4. unmerge this Done and marked as Depending on the reviews above. https://review.openstack.org/#/c/600123/ So I think we have the required reviews lined up to fix master, but they need votes from zuul and core teams. We can handle stable later ;P Yours Tony. signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On 18-09-06 13:33:12, Michel Peterson wrote: > On Wed, Sep 5, 2018 at 6:03 PM, Matthew Thode > wrote: > > > On 18-08-31 19:52:09, Matthew Thode wrote: > > > The requirements project has a co-installability test for the various > > > projects, networking-odl being included. > > > > > > Because of the way the dependancy on ceilometer is done it is blocking > > > all reviews and updates to the requirements project. > > > > > > http://logs.openstack.org/96/594496/2/check/requirements- > > integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > > > The requirements team has gone ahead and made a aweful hack to get gate > > unwedged. The commit message is a very good summary of our reasoning > > why it has to be this way for now. My comment explains our plan going > > forward (there will be a revert prepared as soon as this merges for > > instance). > > > > step 1. merge this > > step 2. look into and possibly fix our tooling (why was the gitref > > addition not rejected by gate) > > step 3. fix networking-odl (release ceilometer) > > step 4. unmerge this > > > > I remember that before landing the problematic patch [1] there was some > discussion around it. Basically the problem was not n-odl but ceilometer > not being in pypi, but we never foresaw this problem. > > Now that the problem is so critical, the question is how can we, from the > n-odl team, help in fixing this? I am open to help in any effort that > involves n-odl or any other project. > > Sorry this message fell through the cracks and I didn't answer before. > > PS: I'm CCing Mike Kolesnik to this email, as he will be going to the PTG > and can represent n-odl. > > [1] https://review.openstack.org/557370/ I think the best choice at this point in time would be to get a ceilometer release onto pypi. At that time you can move to using that version as your project minimum. Just make sure that if you need a new feature you ask them for a release instead of using a git SHA. I'll be at the PTG as well, infra/upgrade/OSA rooms mostly I think. -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On Wed, Sep 5, 2018 at 6:03 PM, Matthew Thode wrote: > On 18-08-31 19:52:09, Matthew Thode wrote: > > The requirements project has a co-installability test for the various > > projects, networking-odl being included. > > > > Because of the way the dependancy on ceilometer is done it is blocking > > all reviews and updates to the requirements project. > > > > http://logs.openstack.org/96/594496/2/check/requirements- > integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > The requirements team has gone ahead and made a aweful hack to get gate > unwedged. The commit message is a very good summary of our reasoning > why it has to be this way for now. My comment explains our plan going > forward (there will be a revert prepared as soon as this merges for > instance). > > step 1. merge this > step 2. look into and possibly fix our tooling (why was the gitref > addition not rejected by gate) > step 3. fix networking-odl (release ceilometer) > step 4. unmerge this > I remember that before landing the problematic patch [1] there was some discussion around it. Basically the problem was not n-odl but ceilometer not being in pypi, but we never foresaw this problem. Now that the problem is so critical, the question is how can we, from the n-odl team, help in fixing this? I am open to help in any effort that involves n-odl or any other project. Sorry this message fell through the cracks and I didn't answer before. PS: I'm CCing Mike Kolesnik to this email, as he will be going to the PTG and can represent n-odl. [1] https://review.openstack.org/557370/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On 18-09-05 17:50:59, thomas.mo...@orange.com wrote: > Mathew, > > networking-odl has now been removed from the requirements of > networking-bgpvpn [1], on master, so networking-odl could be removed from > requirements. > > This is not the case on stable branches, though. > > -Thomas > > [1] https://review.openstack.org/#/c/599422/ > > On 05/09/2018 17:03, Matthew Thode wrote: > > On 18-08-31 19:52:09, Matthew Thode wrote: > > > The requirements project has a co-installability test for the various > > > projects, networking-odl being included. > > > > > > Because of the way the dependancy on ceilometer is done it is blocking > > > all reviews and updates to the requirements project. > > > > > > http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > > > > > If networking-odl is not meant to be used as a library I'd recommend > > > it's removal from networking-bgpvpn (it's test-requirements.txt file). > > > Once that is done networking-odl can be removed from global-requirements > > > and we won't be blocked anymore. > > > > > > As a side note, fungi noticed that when you branched you are still > > > installing ceilometer from master. Also, the ceilometer team > > > doesnt wish it to be used as a library either (like networking-odl > > > doesn't wish to be used as a library). > > > > > The requirements team has gone ahead and made a aweful hack to get gate > > unwedged. The commit message is a very good summary of our reasoning > > why it has to be this way for now. My comment explains our plan going > > forward (there will be a revert prepared as soon as this merges for > > instance). > > > > step 1. merge this > > step 2. look into and possibly fix our tooling (why was the gitref addition > > not rejected by gate) > > step 3. fix networking-odl (release ceilometer) > > step 4. unmerge this > > > > > > __ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > _ > > Ce message et ses pieces jointes peuvent contenir des informations > confidentielles ou privilegiees et ne doivent donc > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu > ce message par erreur, veuillez le signaler > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages > electroniques etant susceptibles d'alteration, > Orange decline toute responsabilite si ce message a ete altere, deforme ou > falsifie. Merci. > > This message and its attachments may contain confidential or privileged > information that may be protected by law; > they should not be distributed, used or copied without authorisation. > If you have received this email in error, please notify the sender and delete > this message and its attachments. > As emails may be altered, Orange is not liable for messages that have been > modified, changed or falsified. > Thank you. > Yep, we discussed doing that (and it's still an option). We decided to do something a bit more verbose though and have a plan. Just need to get ceilometer to release to pypi... -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
Mathew, networking-odl has now been removed from the requirements of networking-bgpvpn [1], on master, so networking-odl could be removed from requirements. This is not the case on stable branches, though. -Thomas [1] https://review.openstack.org/#/c/599422/ On 05/09/2018 17:03, Matthew Thode wrote: On 18-08-31 19:52:09, Matthew Thode wrote: The requirements project has a co-installability test for the various projects, networking-odl being included. Because of the way the dependancy on ceilometer is done it is blocking all reviews and updates to the requirements project. http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 If networking-odl is not meant to be used as a library I'd recommend it's removal from networking-bgpvpn (it's test-requirements.txt file). Once that is done networking-odl can be removed from global-requirements and we won't be blocked anymore. As a side note, fungi noticed that when you branched you are still installing ceilometer from master. Also, the ceilometer team doesnt wish it to be used as a library either (like networking-odl doesn't wish to be used as a library). The requirements team has gone ahead and made a aweful hack to get gate unwedged. The commit message is a very good summary of our reasoning why it has to be this way for now. My comment explains our plan going forward (there will be a revert prepared as soon as this merges for instance). step 1. merge this step 2. look into and possibly fix our tooling (why was the gitref addition not rejected by gate) step 3. fix networking-odl (release ceilometer) step 4. unmerge this __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev _ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On 18-08-31 19:52:09, Matthew Thode wrote: > The requirements project has a co-installability test for the various > projects, networking-odl being included. > > Because of the way the dependancy on ceilometer is done it is blocking > all reviews and updates to the requirements project. > > http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > If networking-odl is not meant to be used as a library I'd recommend > it's removal from networking-bgpvpn (it's test-requirements.txt file). > Once that is done networking-odl can be removed from global-requirements > and we won't be blocked anymore. > > As a side note, fungi noticed that when you branched you are still > installing ceilometer from master. Also, the ceilometer team > doesnt wish it to be used as a library either (like networking-odl > doesn't wish to be used as a library). > The requirements team has gone ahead and made a aweful hack to get gate unwedged. The commit message is a very good summary of our reasoning why it has to be this way for now. My comment explains our plan going forward (there will be a revert prepared as soon as this merges for instance). step 1. merge this step 2. look into and possibly fix our tooling (why was the gitref addition not rejected by gate) step 3. fix networking-odl (release ceilometer) step 4. unmerge this -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
Thomas Morin, 2018-09-03 13:31: > Matthew Thode, 2018-08-31 19:52: > > > > If networking-odl is not meant to be used as a library I'd > > recommend > > it's removal from networking-bgpvpn (it's test-requirements.txt > > file). > > We can work at removing this historical driver from networking- > bgpvpn. Since a v2 driver (hosted in networking-odl) has been > existing for a long time, we possibly can do that without waiting. > Just need to think about the best way to do it. Realizing that we've had a warning announcing deprecation and future removal for the last release [1], I've pushed [2] to remove the ODL driver from master without waiting. Please comment there as needed. -Thomas [1] https://github.com/openstack/networking-bgpvpn/commit/ffee38097709dd4091fb8709a70cf6c361ed60ee#diff-88cc53515016b9f865a830b216c8e564 [2] https://review.openstack.org/599422 > > Once that is done networking-odl can be removed from global- > > requirements > > and we won't be blocked anymore. > > > > As a side note, fungi noticed that when you branched you are still > > installing ceilometer from master. Also, the ceilometer team > > doesnt wish it to be used as a library either (like networking-odl > > doesn't wish to be used as a library). > > > > ___ > > __ > > _ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsu > > bs > > cribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > _ > _ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubs > cribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
Hi Mathew, Matthew Thode, 2018-08-31 19:52: > The requirements project has a co-installability test for the various > projects, networking-odl being included. > > Because of the way the dependancy on ceilometer is done it is > blocking all reviews and updates to the requirements project. (also blocking reviews for networking-bgpvpn) > http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > If networking-odl is not meant to be used as a library I'd recommend > it's removal from networking-bgpvpn (it's test-requirements.txt > file). Historically, the driver allowing the use of networking-bgpvpn with the ODL SDN controller was in the networking-bgpvpn project ; this is why we have this dependency (the driver using some ODL utility code found in the networking-odl project). We can work at removing this historical driver from networking-bgpvpn. Since a v2 driver (hosted in networking-odl) has been existing for a long time, we possibly can do that without waiting. Just need to think about the best way to do it. ODL team, what do you think ? In the meantime, to unbreak the CI for networking-bgpvpn, I'm pushing [1], which puts an upper bound (< 13) on the dependency on networking- odl to avoid drawing version 13 of networking-odl which introduces the requirement on ceilometer. -Thomas [1] https://review.openstack.org/#/c/599310/2/test-requirements.txt > Once that is done networking-odl can be removed from global- > requirements > and we won't be blocked anymore. > > As a side note, fungi noticed that when you branched you are still > installing ceilometer from master. Also, the ceilometer team > doesnt wish it to be used as a library either (like networking-odl > doesn't wish to be used as a library). > > _ > _ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubs > cribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
On Fri, Aug 31, 2018 at 07:52:09PM -0500, Matthew Thode wrote: > The requirements project has a co-installability test for the various > projects, networking-odl being included. > > Because of the way the dependancy on ceilometer is done it is blocking > all reviews and updates to the requirements project. > > http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 > > If networking-odl is not meant to be used as a library I'd recommend > it's removal from networking-bgpvpn (it's test-requirements.txt file). > Once that is done networking-odl can be removed from global-requirements > and we won't be blocked anymore. > > As a side note, fungi noticed that when you branched you are still > installing ceilometer from master. Also, the ceilometer team > doesnt wish it to be used as a library either (like networking-odl > doesn't wish to be used as a library). Yup this seems totally wrong for anything to be importing ceilometer directly like that. The networking-* projects are pretty tightly coupled so the links there are ok and workable but the ceilometer thing needs to be reconsidered. Having said that it's been part of the design for a while now. The "quick" fix would be to have ceilometer published to pypi, get requirements.txt fixed in networking-odl and re-release that. In order to unblock the requirements gate we *could* block 13.0.0 in global-requirements but that's strange as that means we're installing the queens version instead of rocky, and will more than likely have a cascade effect :( https://review.openstack.org/599277 is my pragmatic compromise while we work through this. Yours Tony. signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [networking-odl][networking-bgpvpn][ceilometer] all requirement updates are currently blocked
The requirements project has a co-installability test for the various projects, networking-odl being included. Because of the way the dependancy on ceilometer is done it is blocking all reviews and updates to the requirements project. http://logs.openstack.org/96/594496/2/check/requirements-integration/8378cd8/job-output.txt.gz#_2018-08-31_22_54_49_357505 If networking-odl is not meant to be used as a library I'd recommend it's removal from networking-bgpvpn (it's test-requirements.txt file). Once that is done networking-odl can be removed from global-requirements and we won't be blocked anymore. As a side note, fungi noticed that when you branched you are still installing ceilometer from master. Also, the ceilometer team doesnt wish it to be used as a library either (like networking-odl doesn't wish to be used as a library). -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
