[openstack-dev] [neutron] Location of 'enable_security_group' key in ml2_conf.ini

2014-04-07 Thread Matt Kassawara
I'm writing the ML2 configuration sections for the installation guide and
found a potential location conflict for the 'enable_security_group' key in
ml2_conf.ini. In the patch associated with this feature, the example
configuration file has this key under [security_group].

https://review.openstack.org/#/c/67281/33/etc/neutron/plugins/ml2/ml2_conf.ini

The most recent gate from the milestone-proposed branch also has this key
under [security_group].

http://logs.openstack.org/76/85676/1/gate/gate-tempest-dsvm-neutron/80af0f6/logs/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz

However, the code has this key under [securitygroup] with the
'firewall_driver' key.

https://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py

What's the proper location for the 'enable_security_group' key?

Thanks,
Matt
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [neutron] Location of 'enable_security_group' key in ml2_conf.ini

2014-04-07 Thread Akihiro Motoki
Hi Matt,

Thanks for raising this. Both should be the same section.
[securitygroup] section exists in Havana and previous releases and
it is the right section name.

When we introduced enable_security_group option, we seem to have added
a new section
accidentally. We don't intended to introduce a new section name.

IMO, both firewall_driver and enable_security_group are placed in
[securitygroup].
It should be fixed ASAP. I will take care of it.

Thanks,
Akihiro


On Tue, Apr 8, 2014 at 5:51 AM, Matt Kassawara mkassaw...@gmail.com wrote:
 I'm writing the ML2 configuration sections for the installation guide and
 found a potential location conflict for the 'enable_security_group' key in
 ml2_conf.ini. In the patch associated with this feature, the example
 configuration file has this key under [security_group].

 https://review.openstack.org/#/c/67281/33/etc/neutron/plugins/ml2/ml2_conf.ini

 The most recent gate from the milestone-proposed branch also has this key
 under [security_group].

 http://logs.openstack.org/76/85676/1/gate/gate-tempest-dsvm-neutron/80af0f6/logs/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz

 However, the code has this key under [securitygroup] with the
 'firewall_driver' key.

 https://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py

 What's the proper location for the 'enable_security_group' key?

 Thanks,
 Matt

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [neutron] Location of 'enable_security_group' key in ml2_conf.ini

2014-04-07 Thread Martinx - ジェームズ
Hi!

I faced this problem this weekend, look:
https://bugs.launchpad.net/bugs/1303517

Currently, my ml2_conf.ini contains:

---
[security_group]
enable_security_group = True

[securitygroup]
firewall_driver =
neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver
---

Best!
Thiago


On 7 April 2014 19:50, Akihiro Motoki amot...@gmail.com wrote:

 Hi Matt,

 Thanks for raising this. Both should be the same section.
 [securitygroup] section exists in Havana and previous releases and
 it is the right section name.

 When we introduced enable_security_group option, we seem to have added
 a new section
 accidentally. We don't intended to introduce a new section name.

 IMO, both firewall_driver and enable_security_group are placed in
 [securitygroup].
 It should be fixed ASAP. I will take care of it.

 Thanks,
 Akihiro


 On Tue, Apr 8, 2014 at 5:51 AM, Matt Kassawara mkassaw...@gmail.com
 wrote:
  I'm writing the ML2 configuration sections for the installation guide and
  found a potential location conflict for the 'enable_security_group' key
 in
  ml2_conf.ini. In the patch associated with this feature, the example
  configuration file has this key under [security_group].
 
 
 https://review.openstack.org/#/c/67281/33/etc/neutron/plugins/ml2/ml2_conf.ini
 
  The most recent gate from the milestone-proposed branch also has this key
  under [security_group].
 
 
 http://logs.openstack.org/76/85676/1/gate/gate-tempest-dsvm-neutron/80af0f6/logs/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz
 
  However, the code has this key under [securitygroup] with the
  'firewall_driver' key.
 
 
 https://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py
 
  What's the proper location for the 'enable_security_group' key?
 
  Thanks,
  Matt
 
  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [neutron] Location of 'enable_security_group' key in ml2_conf.ini

2014-04-07 Thread Matt Kassawara
Thiago,

My current ml2_conf.ini looks like your example. My environment also
continues to work if I omit the entire [security_group] section. However,
it stops working if I omit the [securitygroup] section.

Matt


On Mon, Apr 7, 2014 at 5:36 PM, Martinx - ジェームズ
thiagocmarti...@gmail.comwrote:

 Hi!

 I faced this problem this weekend, look:
 https://bugs.launchpad.net/bugs/1303517

 Currently, my ml2_conf.ini contains:

 ---
 [security_group]
 enable_security_group = True

 [securitygroup]
 firewall_driver =
 neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver
 ---

 Best!
 Thiago


 On 7 April 2014 19:50, Akihiro Motoki amot...@gmail.com wrote:

 Hi Matt,

 Thanks for raising this. Both should be the same section.
 [securitygroup] section exists in Havana and previous releases and
 it is the right section name.

 When we introduced enable_security_group option, we seem to have added
 a new section
 accidentally. We don't intended to introduce a new section name.

 IMO, both firewall_driver and enable_security_group are placed in
 [securitygroup].
 It should be fixed ASAP. I will take care of it.

 Thanks,
 Akihiro


 On Tue, Apr 8, 2014 at 5:51 AM, Matt Kassawara mkassaw...@gmail.com
 wrote:
  I'm writing the ML2 configuration sections for the installation guide
 and
  found a potential location conflict for the 'enable_security_group' key
 in
  ml2_conf.ini. In the patch associated with this feature, the example
  configuration file has this key under [security_group].
 
 
 https://review.openstack.org/#/c/67281/33/etc/neutron/plugins/ml2/ml2_conf.ini
 
  The most recent gate from the milestone-proposed branch also has this
 key
  under [security_group].
 
 
 http://logs.openstack.org/76/85676/1/gate/gate-tempest-dsvm-neutron/80af0f6/logs/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz
 
  However, the code has this key under [securitygroup] with the
  'firewall_driver' key.
 
 
 https://github.com/openstack/neutron/blob/master/neutron/agent/securitygroups_rpc.py
 
  What's the proper location for the 'enable_security_group' key?
 
  Thanks,
  Matt
 
  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev