Re: [openstack-dev] [nova] Removes the extra URL routes in Nova API

2017-04-12 Thread Matt Riedemann

On 3/30/2017 12:22 AM, Alex Xu wrote:

Currently I'm working on removing the stevedore [0], and move the URL
routes mapping into a plain list [1].

But actually, the original URL mappings which Nova created [2] are more
than that list.
Due to the interface 'routes.Mapper.resources' create a set routes
conforming to the Atom publish protocol.[3]

So there are some URL mapping we never documented at somewhere (at least
I don't know):

POST /servers.:(format)
GET /servers/detail.:(format)

GET /servers/new.:(format)  (the API doesn't work, return 404)
GET /servers/new (the API doesn't work, return 404)
GET /servers/:(id)/edit.:(format) (the API doesn't work, return 404)


I plan to remove the support for those URL mappings in the patch [1],
and it will fix the bug https://bugs.launchpad.net/nova/+bug/1615475.

But I want to send this email to ensure we are ok to remove those URL
mappings.

Thanks
Alex

[0] https://review.openstack.org/#/c/445864/
[1] 
https://review.openstack.org/#/c/445864/7/nova/api/openstack/compute/routes.py@119
[2] 
https://github.com/openstack/nova/blob/master/nova/api/openstack/__init__.py#L174
[3] https://routes.readthedocs.io/en/latest/restful.html


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



I'm fine with removing those undocumented, frankly unknown to most of 
us, URL mappings. We don't support them, document them, or test them. 
They are basically an accident as far as I know, so +1 for removal.


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [nova] Removes the extra URL routes in Nova API

2017-03-29 Thread Alex Xu
Currently I'm working on removing the stevedore [0], and move the URL
routes mapping into a plain list [1].

But actually, the original URL mappings which Nova created [2] are more
than that list.
Due to the interface 'routes.Mapper.resources' create a set routes
conforming to the Atom publish protocol.[3]

So there are some URL mapping we never documented at somewhere (at least I
don't know):

POST /servers.:(format)
GET /servers/detail.:(format)

GET /servers/new.:(format)  (the API doesn't work, return 404)
GET /servers/new (the API doesn't work, return 404)
GET /servers/:(id)/edit.:(format) (the API doesn't work, return 404)


I plan to remove the support for those URL mappings in the patch [1], and
it will fix the bug https://bugs.launchpad.net/nova/+bug/1615475.

But I want to send this email to ensure we are ok to remove those URL
mappings.

Thanks
Alex

[0] https://review.openstack.org/#/c/445864/
[1]
https://review.openstack.org/#/c/445864/7/nova/api/openstack/compute/routes.py@119
[2]
https://github.com/openstack/nova/blob/master/nova/api/openstack/__init__.py#L174
[3] https://routes.readthedocs.io/en/latest/restful.html
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev