Re: [openstack-dev] [oslo] XxxOpt classes "kept for backward-compatibility" in oslo.config
Le 10/11/2015 15:33, Davanum Srinivas a écrit : +1 Victor. Ok thanks for the confirmation. The comment disturbed me a lot :-D Here is a simple change to remove the comment: https://review.openstack.org/243630 Victor __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] XxxOpt classes "kept for backward-compatibility" in oslo.config
Excerpts from Victor Stinner's message of 2015-11-10 15:30:18 +0100: > Hi, > > In oslo_config/cfg.py, there is a main Opt class which takes an optional > type parameter (default is oslo_config.types.String). But there is also > a long list of XxxOpt classes: StrOpt, BoolOpt, FloatOpt, ListOpt, > IPOpt, etc. Recently I saw *new* classes added with the "kept for > backward-compatibility" comment, comment copied from existing classes. > > What is the plan for these XxxOpt classes? Is there a clear plan to > deprecate them and remove them? Or can we agree on keeping them and so > removing the comment? > > It looks like oslo_config.cfg.Opt is *never* used directly in OpenStack. > Only specialized options StrOpt, IntOpt etc. are used. > > So the obvious choice is to remove the comment, right? > > Victor > +1 for removing the comment. I think the intent was to have folks use Opt with type set to something specific, but that's a lot of rework for little gain. Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] XxxOpt classes "kept for backward-compatibility" in oslo.config
+1 Victor. On Tue, Nov 10, 2015 at 9:30 AM, Victor Stinner wrote: > Hi, > > In oslo_config/cfg.py, there is a main Opt class which takes an optional > type parameter (default is oslo_config.types.String). But there is also a > long list of XxxOpt classes: StrOpt, BoolOpt, FloatOpt, ListOpt, IPOpt, etc. > Recently I saw *new* classes added with the "kept for > backward-compatibility" comment, comment copied from existing classes. > > What is the plan for these XxxOpt classes? Is there a clear plan to > deprecate them and remove them? Or can we agree on keeping them and so > removing the comment? > > It looks like oslo_config.cfg.Opt is *never* used directly in OpenStack. > Only specialized options StrOpt, IntOpt etc. are used. > > So the obvious choice is to remove the comment, right? > > Victor > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [oslo] XxxOpt classes "kept for backward-compatibility" in oslo.config
Hi, In oslo_config/cfg.py, there is a main Opt class which takes an optional type parameter (default is oslo_config.types.String). But there is also a long list of XxxOpt classes: StrOpt, BoolOpt, FloatOpt, ListOpt, IPOpt, etc. Recently I saw *new* classes added with the "kept for backward-compatibility" comment, comment copied from existing classes. What is the plan for these XxxOpt classes? Is there a clear plan to deprecate them and remove them? Or can we agree on keeping them and so removing the comment? It looks like oslo_config.cfg.Opt is *never* used directly in OpenStack. Only specialized options StrOpt, IntOpt etc. are used. So the obvious choice is to remove the comment, right? Victor __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
