Re: [openstack-dev] [puppet][ec2api] - Official EC2 puppet module repo

2016-04-04 Thread Alex Schultz 
On Mon, Apr 4, 2016 at 9:12 AM, Denis Egorenko 
wrote:

> Hi Marcos,
>
> Are you still working on your initial commit to puppet-ec2api [1] ?
>
> [1] https://review.openstack.org/#/c/276103/
>


It might be a good idea to redo this review with a newer version of the
cookiecutter and split the ec2api specific additions into their own
reviews.  it would make it easier to review and land. Also we'd be able to
assist in getting things added.  I know the baribican module is currently
going a similar initial bootstrap process and it seems be going better as
far as getting incremental items added in.

-Alex



>
>
2016-01-29 22:02 GMT+03:00 Emilien Macchi :
>
>>
>>
>> On 01/29/2016 10:35 AM, Marcos Fermin Lobo wrote:
>> > Hi,
>> >
>> > Since I finished to "apply" for puppet-ec2api module as official puppet
>> > module in OpenStack (see https://review.openstack.org/#/c/252959/ and
>> > https://review.openstack.org/#/c/251857/), I saw that the puppet module
>> > repository is created https://github.com/openstack/puppet-ec2api
>> >
>> > But the repository is still empty.
>>
>> Yeah, you have two options:
>>
>> #1 Import your code
>>
>> If you do that, please iterate your patches so you'll have reviews more
>> quickly. You can look how puppet-mistral was created [1], I like the
>> iterative approach (step by step).
>>
>> #2 Generate a new module with this procedure [2]
>>
>> Run the procedure, and follow-up with new patches to add the classes
>> that you had in our module.
>>
>> [1] https://review.openstack.org/#/q/project:openstack/puppet-mistral
>> [2]
>> https://wiki.openstack.org/wiki/Puppet/New_module#On_the_technical_side
>>
>> > (...)
>>
>> Both approaches work for us, but please iterate with small chunks, which
>> is easier to test and review.
>>
>>
>> Thanks a lot for your efforts, very appreciated.
>> --
>> Emilien Macchi
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
>
> --
> Best Regards,
> Egorenko Denis,
> Senior Deployment Engineer
> Mirantis
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet][ec2api] - Official EC2 puppet module repo

2016-04-04 Thread Denis Egorenko 
Hi Marcos,

Are you still working on your initial commit to puppet-ec2api [1] ?

[1] https://review.openstack.org/#/c/276103/

2016-01-29 22:02 GMT+03:00 Emilien Macchi :

>
>
> On 01/29/2016 10:35 AM, Marcos Fermin Lobo wrote:
> > Hi,
> >
> > Since I finished to "apply" for puppet-ec2api module as official puppet
> > module in OpenStack (see https://review.openstack.org/#/c/252959/ and
> > https://review.openstack.org/#/c/251857/), I saw that the puppet module
> > repository is created https://github.com/openstack/puppet-ec2api
> >
> > But the repository is still empty.
>
> Yeah, you have two options:
>
> #1 Import your code
>
> If you do that, please iterate your patches so you'll have reviews more
> quickly. You can look how puppet-mistral was created [1], I like the
> iterative approach (step by step).
>
> #2 Generate a new module with this procedure [2]
>
> Run the procedure, and follow-up with new patches to add the classes
> that you had in our module.
>
> [1] https://review.openstack.org/#/q/project:openstack/puppet-mistral
> [2]
> https://wiki.openstack.org/wiki/Puppet/New_module#On_the_technical_side
>
> > (...)
>
> Both approaches work for us, but please iterate with small chunks, which
> is easier to test and review.
>
>
> Thanks a lot for your efforts, very appreciated.
> --
> Emilien Macchi
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Best Regards,
Egorenko Denis,
Senior Deployment Engineer
Mirantis
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [puppet][ec2api] - Official EC2 puppet module repo

2016-01-29 Thread Marcos Fermin Lobo 
Hi,

Since I finished to "apply" for puppet-ec2api module as official puppet module 
in OpenStack (see https://review.openstack.org/#/c/252959/ and 
https://review.openstack.org/#/c/251857/), I saw that the puppet module 
repository is created https://github.com/openstack/puppet-ec2api

But the repository is still empty.

I already have the code for this module here 
https://github.com/cernops/puppet-ec2api, so I was wondering if some step more 
is needed from me in order to fill the official repository.

Thank you for your attention.

Regards,
Marcos.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet][ec2api] - Official EC2 puppet module repo

2016-01-29 Thread Emilien Macchi 


On 01/29/2016 10:35 AM, Marcos Fermin Lobo wrote:
> Hi,
> 
> Since I finished to "apply" for puppet-ec2api module as official puppet
> module in OpenStack (see https://review.openstack.org/#/c/252959/ and
> https://review.openstack.org/#/c/251857/), I saw that the puppet module
> repository is created https://github.com/openstack/puppet-ec2api
> 
> But the repository is still empty.

Yeah, you have two options:

#1 Import your code

If you do that, please iterate your patches so you'll have reviews more
quickly. You can look how puppet-mistral was created [1], I like the
iterative approach (step by step).

#2 Generate a new module with this procedure [2]

Run the procedure, and follow-up with new patches to add the classes
that you had in our module.

[1] https://review.openstack.org/#/q/project:openstack/puppet-mistral
[2] https://wiki.openstack.org/wiki/Puppet/New_module#On_the_technical_side

> (...)

Both approaches work for us, but please iterate with small chunks, which
is easier to test and review.


Thanks a lot for your efforts, very appreciated.
-- 
Emilien Macchi



signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev