Re: [openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-12-09 Thread Martin Mágr



On 12/04/2015 11:21 PM, Emilien Macchi wrote:


On 12/02/2015 10:32 PM, Cody Herriges wrote:

Martin,

I see no reason this shouldn't just be pushed into puppetlabs-inifile.
I can't actually find a real "spec" for INI file and even the Wiki
link[3] calls out that there is no actual spec.

I suggest:

1/ we land https://review.openstack.org/#/c/234727/
2/ in the meantime, we work on a puppetlabs-inifile patch
3/ once it's done, we switch puppet-openstacklib to use it.

What do you think?
Martin, are you willing to work on it?


Sure, no problem.




On Fri, Nov 27, 2015 at 5:04 AM, Martin Mágr > wrote:

 Greetings,

   I've submitted patch to puppet-openstacklib [1] which adds
 provider for parsing INI files containing duplicated variables
 (a.k.a MultiStrOpt [2]). Such parameters are used for example to set
 service_providers/service_provider for Neutron LBaaSv2. There has
 been a thought raised, that the patch should rather be submitted to
 puppetlabs-inifile module instead. The reason I did not submitted
 the patch to inifile module is that IMHO duplicate variables are not
 in the INI file spec [3]. Thoughts?

 Regards,
 Martin


 [1] https://review.openstack.org/#/c/234727/
 [2]
 
https://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt
 [3] https://en.wikipedia.org/wiki/INI_file#Duplicate_names

 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe:
 openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-12-04 Thread Emilien Macchi


On 12/02/2015 10:32 PM, Cody Herriges wrote:
> Martin,
> 
> I see no reason this shouldn't just be pushed into puppetlabs-inifile. 
> I can't actually find a real "spec" for INI file and even the Wiki
> link[3] calls out that there is no actual spec.

I suggest:

1/ we land https://review.openstack.org/#/c/234727/
2/ in the meantime, we work on a puppetlabs-inifile patch
3/ once it's done, we switch puppet-openstacklib to use it.

What do you think?
Martin, are you willing to work on it?

> On Fri, Nov 27, 2015 at 5:04 AM, Martin Mágr  > wrote:
> 
> Greetings,
> 
>   I've submitted patch to puppet-openstacklib [1] which adds
> provider for parsing INI files containing duplicated variables
> (a.k.a MultiStrOpt [2]). Such parameters are used for example to set
> service_providers/service_provider for Neutron LBaaSv2. There has
> been a thought raised, that the patch should rather be submitted to
> puppetlabs-inifile module instead. The reason I did not submitted
> the patch to inifile module is that IMHO duplicate variables are not
> in the INI file spec [3]. Thoughts?
> 
> Regards,
> Martin
> 
> 
> [1] https://review.openstack.org/#/c/234727/
> [2]
> 
> https://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt
> [3] https://en.wikipedia.org/wiki/INI_file#Duplicate_names
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-- 
Emilien Macchi



signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-12-03 Thread Clayton O'Neill
For puppetlabs-inifile that’s a bigger question.  For our purposes the
answer is “whatever ConfigParser does”.

On Wed, Dec 2, 2015 at 10:32 PM, Cody Herriges  wrote:

> Martin,
>
> I see no reason this shouldn't just be pushed into puppetlabs-inifile.  I
> can't actually find a real "spec" for INI file and even the Wiki link[3]
> calls out that there is no actual spec.
>
> On Fri, Nov 27, 2015 at 5:04 AM, Martin Mágr  wrote:
>
>> Greetings,
>>
>>   I've submitted patch to puppet-openstacklib [1] which adds provider for
>> parsing INI files containing duplicated variables (a.k.a MultiStrOpt [2]).
>> Such parameters are used for example to set
>> service_providers/service_provider for Neutron LBaaSv2. There has been a
>> thought raised, that the patch should rather be submitted to
>> puppetlabs-inifile module instead. The reason I did not submitted the patch
>> to inifile module is that IMHO duplicate variables are not in the INI file
>> spec [3]. Thoughts?
>>
>> Regards,
>> Martin
>>
>>
>> [1] https://review.openstack.org/#/c/234727/
>> [2]
>> https://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt
>> [3] https://en.wikipedia.org/wiki/INI_file#Duplicate_names
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-12-02 Thread Cody Herriges
Martin,

I see no reason this shouldn't just be pushed into puppetlabs-inifile.  I
can't actually find a real "spec" for INI file and even the Wiki link[3]
calls out that there is no actual spec.

On Fri, Nov 27, 2015 at 5:04 AM, Martin Mágr  wrote:

> Greetings,
>
>   I've submitted patch to puppet-openstacklib [1] which adds provider for
> parsing INI files containing duplicated variables (a.k.a MultiStrOpt [2]).
> Such parameters are used for example to set
> service_providers/service_provider for Neutron LBaaSv2. There has been a
> thought raised, that the patch should rather be submitted to
> puppetlabs-inifile module instead. The reason I did not submitted the patch
> to inifile module is that IMHO duplicate variables are not in the INI file
> spec [3]. Thoughts?
>
> Regards,
> Martin
>
>
> [1] https://review.openstack.org/#/c/234727/
> [2]
> https://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt
> [3] https://en.wikipedia.org/wiki/INI_file#Duplicate_names
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [puppet] Config support for oslo.config.cfg.MultiStrOpt

2015-11-27 Thread Martin Mágr

Greetings,

  I've submitted patch to puppet-openstacklib [1] which adds provider 
for parsing INI files containing duplicated variables (a.k.a MultiStrOpt 
[2]). Such parameters are used for example to set 
service_providers/service_provider for Neutron LBaaSv2. There has been a 
thought raised, that the patch should rather be submitted to 
puppetlabs-inifile module instead. The reason I did not submitted the 
patch to inifile module is that IMHO duplicate variables are not in the 
INI file spec [3]. Thoughts?


Regards,
Martin


[1] https://review.openstack.org/#/c/234727/
[2] 
https://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt

[3] https://en.wikipedia.org/wiki/INI_file#Duplicate_names

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev