Re: [openstack-dev] [qa] Tempest removal of tempest.api.compute.test_authorization
On 02/16/2016 03:38 PM, Matthew Treinish wrote: > On Tue, Feb 09, 2016 at 07:41:18PM -0500, Sean Dague wrote: >> As proposed in this patch - https://review.openstack.org/#/c/271467/ >> >> These tests do some manipulation of the request URI to attempt to >> request Nova resources owned by a different project_id. However they all >> basically test the same 7 lines of Nova, and now that Nova doesn't >> require project_id in the url it's actively harmful to moving forward. >> > > Looking at the review it looks like people working on defcore chimed and said > that they are ok with these tests being removed. So my primary concern with > removing the tests seems to be addressed. It looks like all 3 criteria from: > > https://wiki.openstack.org/wiki/QA/Tempest-test-removal > > have been addressed. (since there is equivalent coverage elsewhere and the > tests haven't ever really failed according to [1]) But, before I'm +2 on the > change I had a couple of questions. Do you think there is a potential exposure > being opened up here across release boundaries? Is there still value in > running > the tests on either stable releases or existing deployments? Tempest is used > for > more than just gate testing master and I just want to make sure we're not > opening a hole in our coverage to make some nova changes on master easier. I realized there remained an open question here. I don't think this test is really useful for stable. At the end of the day everything in the test class is testing the same single if condition in Nova. That's covered well enough by Nova in tree tests. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] Tempest removal of tempest.api.compute.test_authorization
On Tue, Feb 09, 2016 at 07:41:18PM -0500, Sean Dague wrote: > As proposed in this patch - https://review.openstack.org/#/c/271467/ > > These tests do some manipulation of the request URI to attempt to > request Nova resources owned by a different project_id. However they all > basically test the same 7 lines of Nova, and now that Nova doesn't > require project_id in the url it's actively harmful to moving forward. > Looking at the review it looks like people working on defcore chimed and said that they are ok with these tests being removed. So my primary concern with removing the tests seems to be addressed. It looks like all 3 criteria from: https://wiki.openstack.org/wiki/QA/Tempest-test-removal have been addressed. (since there is equivalent coverage elsewhere and the tests haven't ever really failed according to [1]) But, before I'm +2 on the change I had a couple of questions. Do you think there is a potential exposure being opened up here across release boundaries? Is there still value in running the tests on either stable releases or existing deployments? Tempest is used for more than just gate testing master and I just want to make sure we're not opening a hole in our coverage to make some nova changes on master easier. -Matt Treinish [1] http://status.openstack.org/openstack-health/#/tests?groupKey=project&resolutionKey=hour&searchTest=AuthorizationTestJSON signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [qa] Tempest removal of tempest.api.compute.test_authorization
As proposed in this patch - https://review.openstack.org/#/c/271467/ These tests do some manipulation of the request URI to attempt to request Nova resources owned by a different project_id. However they all basically test the same 7 lines of Nova, and now that Nova doesn't require project_id in the url it's actively harmful to moving forward. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
