[openstack-dev] [requirements][horizon] Dependency freeze exceptions: django-openstack-auth

2014-09-23 Thread Akihiro Motoki
Hi,

I would like to request dependency freeze exceptions for django-openstack-auth.
https://review.openstack.org/#/c/123101/

django-openstack-auth is developped along with Horizon and the recent
release 1.1.7 of django-openstack-auth has good fixes which affect
Juno Horizon, especially from the following fixes.

- https://bugs.launchpad.net/horizon/+bug/1308918
  django-openstack-auth fix is required to fix the logout bug in
Horizon (targeted to Juno-RC1). The bug is painful for users as they
are forced to log-in twice.
- https://bugs.launchpad.net/django-openstack-auth/+bug/1324948
  It fixes a bug where keystone urls where rewritten if v3 or v2.0
was found in the hostname.

Thanks,
Akihiro

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [requirements][horizon] Dependency freeze exceptions: django-openstack-auth

2014-09-23 Thread Thierry Carrez
Akihiro Motoki wrote:
 I would like to request dependency freeze exceptions for 
 django-openstack-auth.
 https://review.openstack.org/#/c/123101/

This arguably counts as an internal library. We are freezing those now
(well, last Friday was the deadline), so +1 on this one.

-- 
Thierry Carrez (ttx)

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [requirements][horizon] Dependency freeze exceptions: django-openstack-auth

2014-09-23 Thread Akihiro Motoki
Sorry for the delay. django-openstack-auth 1.1.7 was released last Friday and
it seems David forgot to update global requirements.

Now let me clarify how to handle this kind of bugs which requires a
fix in a library after the release.
What is the appropriate way to fix a bug depending on libraries
(including internal and external libraries) after the release.
Can we mark the bug as Fixed even if operators use a newer released
version of libraries is used?
In this case the bug itself is not fixed without upgrading the libraries,
but we cannot update the requirement after the release in general.
Another way is to copy the logic from a library a workaround but it is
a bit ugly.
Of course we need to keep compatibility for the declared version in
requirement.txt.

Thanks,
Akihiro


On Tue, Sep 23, 2014 at 6:47 PM, Thierry Carrez thie...@openstack.org wrote:
 Akihiro Motoki wrote:
 I would like to request dependency freeze exceptions for 
 django-openstack-auth.
 https://review.openstack.org/#/c/123101/

 This arguably counts as an internal library. We are freezing those now
 (well, last Friday was the deadline), so +1 on this one.

 --
 Thierry Carrez (ttx)

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Akihiro Motoki amot...@gmail.com

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [requirements][horizon] Dependency freeze exceptions

2014-09-19 Thread Thierry Carrez
Radomir Dopieralski wrote:
 I would like to request dependency freeze exceptions for the following
 patches for Horizon:
 
 https://review.openstack.org/#/c/121509/
 https://review.openstack.org/#/c/122410/
 
 and
 
 https://review.openstack.org/#/c/113184/
 
 They are all fixing high priority bugs. The first two are related to
 bugs with parsing Bootstrap 3.2.0 scss files that have been fixed
 upstream. The third one makes the life of packagers a little eaiser,
 by using versions that both Debian and Fedora, and possibly many
 other distros, can ship.
 
 I am not sure what the formal process for such an exception should be,
 so I'm writing here. Please let me know if I should have done it
 differently.

No, that's the right way of doing it.

These look like valid requests, but this is mostly affecting the
distributions, so let's wait for the packagers to chime in on how much
of a disruption that would cause to them at this point.

-- 
Thierry Carrez (ttx)

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [requirements][horizon] Dependency freeze exceptions

2014-09-19 Thread Thierry Carrez
Thierry Carrez wrote:
 Radomir Dopieralski wrote:
 I would like to request dependency freeze exceptions for the following
 patches for Horizon:

 https://review.openstack.org/#/c/121509/
 https://review.openstack.org/#/c/122410/

 and

 https://review.openstack.org/#/c/113184/

 They are all fixing high priority bugs. The first two are related to
 bugs with parsing Bootstrap 3.2.0 scss files that have been fixed
 upstream. The third one makes the life of packagers a little eaiser,
 by using versions that both Debian and Fedora, and possibly many
 other distros, can ship.

 I am not sure what the formal process for such an exception should be,
 so I'm writing here. Please let me know if I should have done it
 differently.
 
 No, that's the right way of doing it.
 
 These look like valid requests, but this is mostly affecting the
 distributions, so let's wait for the packagers to chime in on how much
 of a disruption that would cause to them at this point.

https://review.openstack.org/#/c/122410/ is fixing significant gate
issues, so I approved it without waiting for more feedback.

Race is still on for the other two.

-- 
Thierry Carrez (ttx)

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev