Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
Thanks all for helping , Saw this patch [1] merged and assume that's the fix for the issue , we will rebase based on it then try again, [1] https://review.openstack.org/#/c/575872/4 Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82451493 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC From: Doug Hellmann To: openstack-dev Date: 06/16/2018 08:14 AM Subject:Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt' Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -0500: > Doug- > > > The lower constraints tests only look at files in the same repo. > > The minimum versions of dependencies set in requirements.txt, > > test-requirements.txt, etc. need to match the values in > > lower-constraints.txt. > > > > In this case, the more detailed error message is a few lines above the > > error quoted by Chen CH Ji. The detail say "Requirement for package > > retrying has no lower bound" which means that there is a line in > > requirements.txt indicating a dependency on "retrying" but without > > specifying a minimum version. That is the problem. > > The patch didn't change the retrying constraint in requirements.txt [1]; > why isn't this same failure affecting every other patch in nova? > > [1] https://review.openstack.org/#/c/523387/51/requirements.txt@65 > > -efried > Earlier this cycle I updated the requirements check job to verify that all of the settings are correct any time any changes to the dependency lists are made. We used to only look at the line being changed, but that allowed incorrect settings to stay in place for a long time so we weren't actually testing with good settings. We still only run that job when the dependency list is modified in some way. Earlier this week, Matt Thode updated the job to be more strict and to require that all dependencies have a minimum version specified [2]. We did this because some project teams thought that after we dropped the minimums from the global-requirements.txt list they were supposed to (or allowed to) drop them from their project dependency lists, too. My guess is that this dependency in nova never had a lower bound and that this is the first patch to touch the dependency list, so now it's being blocked on the fact that the list has a validation error. I recommend using a separate patch to fix the minimum version of retrying and then rebasing 523387 on top of the new patch. Doug [2] https://review.openstack.org/#/c/574367/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
On 6/15/2018 6:09 PM, Eric Fried wrote: why isn't this same failure affecting every other patch in nova? It is: https://review.openstack.org/#/c/571225/ -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -0500: > Doug- > > > The lower constraints tests only look at files in the same repo. > > The minimum versions of dependencies set in requirements.txt, > > test-requirements.txt, etc. need to match the values in > > lower-constraints.txt. > > > > In this case, the more detailed error message is a few lines above the > > error quoted by Chen CH Ji. The detail say "Requirement for package > > retrying has no lower bound" which means that there is a line in > > requirements.txt indicating a dependency on "retrying" but without > > specifying a minimum version. That is the problem. > > The patch didn't change the retrying constraint in requirements.txt [1]; > why isn't this same failure affecting every other patch in nova? > > [1] https://review.openstack.org/#/c/523387/51/requirements.txt@65 > > -efried > Earlier this cycle I updated the requirements check job to verify that all of the settings are correct any time any changes to the dependency lists are made. We used to only look at the line being changed, but that allowed incorrect settings to stay in place for a long time so we weren't actually testing with good settings. We still only run that job when the dependency list is modified in some way. Earlier this week, Matt Thode updated the job to be more strict and to require that all dependencies have a minimum version specified [2]. We did this because some project teams thought that after we dropped the minimums from the global-requirements.txt list they were supposed to (or allowed to) drop them from their project dependency lists, too. My guess is that this dependency in nova never had a lower bound and that this is the first patch to touch the dependency list, so now it's being blocked on the fact that the list has a validation error. I recommend using a separate patch to fix the minimum version of retrying and then rebasing 523387 on top of the new patch. Doug [2] https://review.openstack.org/#/c/574367/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
Doug- > The lower constraints tests only look at files in the same repo. > The minimum versions of dependencies set in requirements.txt, > test-requirements.txt, etc. need to match the values in > lower-constraints.txt. > > In this case, the more detailed error message is a few lines above the > error quoted by Chen CH Ji. The detail say "Requirement for package > retrying has no lower bound" which means that there is a line in > requirements.txt indicating a dependency on "retrying" but without > specifying a minimum version. That is the problem. The patch didn't change the retrying constraint in requirements.txt [1]; why isn't this same failure affecting every other patch in nova? [1] https://review.openstack.org/#/c/523387/51/requirements.txt@65 -efried __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
Excerpts from Balázs Gibizer's message of 2018-06-15 13:34:09 +0200: > > On Fri, Jun 15, 2018 at 11:36 AM, Chen CH Ji > wrote: > > on patch [1] , PS 50 and PS51 just a minor rebase but PS51 start to > > fail on requirements-check with following error in [2] > > > > Validating lower constraints of test-requirements.txt > > *** Incompatible requirement found! > > *** See http://docs.openstack.org/developer/requirements > > > > but it doesn't provide enough info to know what's wrong , and because > > I didn't make too much change , curious on why > > the job failed... can anyone provide any hint on what happened there? > > thanks > > > > [1]https://review.openstack.org/#/c/523387 > > [2]http://logs.openstack.org/87/523387/51/check/requirements-check/3598ba0/job-output.txt.gz > > > > Looking at your change and the state of the global requirements repo I > see the following contradiction > https://github.com/openstack/requirements/blob/a07ef1c282a37a4bcc93166ddf4cdc97f7626d5d/lower-constraints.txt#L151 > > says zVMCloudConnector===0.3.2 > while > https://review.openstack.org/#/c/523387/51/lower-constraints.txt@173 > says zVMCloudConnector==1.1.1 > > Based on the history of the lower-constraints.txt in the global repo > you have to manually bump the lower constraint there as well > https://github.com/openstack/requirements/commits/master/lower-constraints.txt No, that file is not used and does not need to be changed. The lower constraints tests only look at files in the same repo. The minimum versions of dependencies set in requirements.txt, test-requirements.txt, etc. need to match the values in lower-constraints.txt. In this case, the more detailed error message is a few lines above the error quoted by Chen CH Ji. The detail say "Requirement for package retrying has no lower bound" which means that there is a line in requirements.txt indicating a dependency on "retrying" but without specifying a minimum version. That is the problem. Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
On Fri, Jun 15, 2018 at 11:36 AM, Chen CH Ji wrote: on patch [1] , PS 50 and PS51 just a minor rebase but PS51 start to fail on requirements-check with following error in [2] Validating lower constraints of test-requirements.txt *** Incompatible requirement found! *** See http://docs.openstack.org/developer/requirements but it doesn't provide enough info to know what's wrong , and because I didn't make too much change , curious on why the job failed... can anyone provide any hint on what happened there? thanks [1]https://review.openstack.org/#/c/523387 [2]http://logs.openstack.org/87/523387/51/check/requirements-check/3598ba0/job-output.txt.gz Looking at your change and the state of the global requirements repo I see the following contradiction https://github.com/openstack/requirements/blob/a07ef1c282a37a4bcc93166ddf4cdc97f7626d5d/lower-constraints.txt#L151 says zVMCloudConnector===0.3.2 while https://review.openstack.org/#/c/523387/51/lower-constraints.txt@173 says zVMCloudConnector==1.1.1 Based on the history of the lower-constraints.txt in the global repo you have to manually bump the lower constraint there as well https://github.com/openstack/requirements/commits/master/lower-constraints.txt Cheers, gibi Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82451493 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'
on patch [1] , PS 50 and PS51 just a minor rebase but PS51 start to fail on requirements-check with following error in [2] Validating lower constraints of test-requirements.txt *** Incompatible requirement found! *** See http://docs.openstack.org/developer/requirements but it doesn't provide enough info to know what's wrong , and because I didn't make too much change , curious on why the job failed... can anyone provide any hint on what happened there? thanks [1]https://review.openstack.org/#/c/523387 [2] http://logs.openstack.org/87/523387/51/check/requirements-check/3598ba0/job-output.txt.gz Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82451493 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
