Re: [openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
Excerpts from Tony Breeds's message of 2018-08-14 15:28:07 +1000: > On Tue, Aug 14, 2018 at 12:11:53AM -0500, Matthew Thode wrote: > > > Maybe it'd be better to figure out what's using that removed method and > > those would need the update? > > Given we have per-project deps in rocky only those that *need* the > exclusion will need to apply it. Right. Now that we no longer sync dependencies, releases no longer automatically trigger updates in the consuming projects. We could exclude the bad version in the global list, but I don't think we need to make that a prerequisite for anything else. > I think it's fair to accept the U-c bump and block 0.11.0 in > global-requirements. Then any project that find they're broken next > week can just add the exclusion themselves and move on. Exactly. Our main concern should be about the potential breadth of impact to our own CI systems, which we can mitigate with the constraints list. In this case we know we have a version of something we manage that broke several other things we manage. We should be able to go ahead with the release and keep an eye on things in case we introduce any new breakages. Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
On Tue, Aug 14, 2018 at 12:11:53AM -0500, Matthew Thode wrote: > Maybe it'd be better to figure out what's using that removed method and > those would need the update? Given we have per-project deps in rocky only those that *need* the exclusion will need to apply it. I think it's fair to accept the U-c bump and block 0.11.0 in global-requirements. Then any project that find they're broken next week can just add the exclusion themselves and move on. Yours Tony. signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
On 18-08-14 13:56:28, Akihiro Motoki wrote: > 2018年8月14日(火) 13:38 Matthew Thode : > > > > On 18-08-14 13:19:27, Akihiro Motoki wrote: > > > Hi, > > > > > > I would like to request FFE for osc-lib 1.11.1 release. > > > > > > https://review.openstack.org/591556 > > > > > > osc-iib commit e3d772050f3f4de6369b3dd1ba1269e2903666f7 replaced > > > issubclass() with isinstance() unexpectedly. > > > As a result, osc-lib 1.11.0 breaks existing OSC plugins and > > > the neutronclient OSC plugin gate is now broken. > > > To fix the gate, osc-lib 1.11.1 release would be appreciated. > > > > > > upper-constraints is bumped to osc-lib 1.11.1. > > > It is better to block osc-lib 1.11.0 but I am familiar whether we need > > > to block it or not. > > > > > > > What libs (further down the dep tree) would need the exclusion? They'd > > likely also need a FFE for at least a UC bump. > > You have my (and requirements) ack for a UC only bump at least. > > AFAIK all OSC plugins and OSC directly consume osc-lib and there is no > libs to consume osc-lib. > In this case, we don't need to block a specific version of osc-lib, right? > Perhaps it is just because I don't understand the current policy well. > > From neutronclient and other OSC plugin perspective, it is fine to bump UC > only. > The current list is the following. ++-+--+---+ | Repository | Filename | Line | Text | ++-+--+---+ | openstack-zuul-jobs| playbooks/legacy/requirements-integration-dsvm/run.yaml | 76 | export PROJECTS="openstack/osc-lib $PROJECTS" | | openstack-zuul-jobs| playbooks/legacy/requirements-integration-dsvm-ubuntu-trusty/run.yaml | 77 | export PROJECTS="openstack/osc-lib $PROJECTS" | | osc-placement | requirements.txt |8 | osc-lib>=1.2.0 # Apache-2.0 | | osops-tools-contrib| ansible_requirements.txt | 31 | osc-lib==1.1.0 | | python-adjutantclient | requirements.txt |9 | osc-lib>=1.5.1 # Apache-2.0 | | python-aodhclient | requirements.txt |7 | osc-lib>=1.0.1 # Apache-2.0 | | python-cyborgclient| requirements.txt | 16 | osc-lib>=1.8.0 # Apache-2.0 | | python-designateclient | requirements.txt |6 | osc-lib>=1.8.0 # Apache-2.0 | | python-distilclient| requirements.txt |4 | osc-lib>=1.7.0 # Apache-2.0 | | python-glareclient | requirements.txt | 13 | osc-lib>=1.7.0 # Apache-2.0 | | python-heatclient | requirements.txt |9 | osc-lib>=1.8.0 # Apache-2.0 | | python-iotronicclient | requirements.txt |9 | osc-lib>=1.2.0 # Apache-2.0 | | python-ironic-inspector-client | requirements.txt |5 | osc-lib>=1.8.0 # Apache-2.0 | | python-ironicclient| requirements.txt |9 | osc-lib>=1.10.0 # Apache-2.0 | | python-karborclient| requirements.txt | 11 | osc-lib>=1.8.0 # Apache-2.0 | | python-kingbirdclient | requirements.txt |5 | osc-lib>=1.2.0 # Apache-2.0
Re: [openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
2018年8月14日(火) 13:38 Matthew Thode : > > On 18-08-14 13:19:27, Akihiro Motoki wrote: > > Hi, > > > > I would like to request FFE for osc-lib 1.11.1 release. > > > > https://review.openstack.org/591556 > > > > osc-iib commit e3d772050f3f4de6369b3dd1ba1269e2903666f7 replaced > > issubclass() with isinstance() unexpectedly. > > As a result, osc-lib 1.11.0 breaks existing OSC plugins and > > the neutronclient OSC plugin gate is now broken. > > To fix the gate, osc-lib 1.11.1 release would be appreciated. > > > > upper-constraints is bumped to osc-lib 1.11.1. > > It is better to block osc-lib 1.11.0 but I am familiar whether we need > > to block it or not. > > > > What libs (further down the dep tree) would need the exclusion? They'd > likely also need a FFE for at least a UC bump. > You have my (and requirements) ack for a UC only bump at least. AFAIK all OSC plugins and OSC directly consume osc-lib and there is no libs to consume osc-lib. In this case, we don't need to block a specific version of osc-lib, right? Perhaps it is just because I don't understand the current policy well. From neutronclient and other OSC plugin perspective, it is fine to bump UC only. Thanks, Akihiro Motoki (amotoki) > > -- > Matthew Thode (prometheanfire) > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
On 18-08-14 13:19:27, Akihiro Motoki wrote: > Hi, > > I would like to request FFE for osc-lib 1.11.1 release. > > https://review.openstack.org/591556 > > osc-iib commit e3d772050f3f4de6369b3dd1ba1269e2903666f7 replaced > issubclass() with isinstance() unexpectedly. > As a result, osc-lib 1.11.0 breaks existing OSC plugins and > the neutronclient OSC plugin gate is now broken. > To fix the gate, osc-lib 1.11.1 release would be appreciated. > > upper-constraints is bumped to osc-lib 1.11.1. > It is better to block osc-lib 1.11.0 but I am familiar whether we need > to block it or not. > What libs (further down the dep tree) would need the exclusion? They'd likely also need a FFE for at least a UC bump. You have my (and requirements) ack for a UC only bump at least. -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [requirements][release][osc] FFE osc-lib 1.11.1 release
Hi, I would like to request FFE for osc-lib 1.11.1 release. https://review.openstack.org/591556 osc-iib commit e3d772050f3f4de6369b3dd1ba1269e2903666f7 replaced issubclass() with isinstance() unexpectedly. As a result, osc-lib 1.11.0 breaks existing OSC plugins and the neutronclient OSC plugin gate is now broken. To fix the gate, osc-lib 1.11.1 release would be appreciated. upper-constraints is bumped to osc-lib 1.11.1. It is better to block osc-lib 1.11.0 but I am familiar whether we need to block it or not. Thanks, Akihiro Motoki (amotoki) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
