Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Sergey Lukjanov]

It wasn't get enough reviews, so, FFE rejected.

On Thu, Mar 10, 2016 at 2:09 PM, Sergey Lukjanov 
wrote:

> Yup,
>
> I'm expecting all FFEs to be merged by the EOW, otherwise we'll be
> revisiting case by case with reject by default.
>
> On Thu, Mar 10, 2016 at 1:38 PM, Doug Hellmann 
> wrote:
>
>> Excerpts from lu jander's message of 2016-03-07 14:28:21 +0800:
>> > Hi folks,
>> >
>> > I would like to request a FFE for the feature “Resume EDP job”:
>> >
>> >
>> >
>> > BP:
>> >
>> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
>> > 
>> >
>> >
>> > 
>> >
>> > Spec has been merged. https://review.openstack.org/#/c/198264/
>> >
>> >
>> > Suspend EDP patch has been merged.
>> > https://review.openstack.org/#/c/201448/
>> > 
>> >
>> >
>> > 
>> >
>> > Code Review: https://review.openstack.org/#/c/285839/
>> > 
>> >
>> >
>> >
>> > code is ready for review.
>> >
>> >
>> >
>> > The Benefits for this change: after suspend job, we can resume this job.
>> >
>> >
>> >
>> > The Risk: The risk would be low for this patch, since the code of
>> suspend
>> > patch has been long time reviewed.
>> >
>> >
>> >
>> > Thanks,
>> >
>> > luhuichun
>>
>> Both https://review.openstack.org/#/c/285839/ and
>> https://review.openstack.org/#/c/218638/ have -1 votes on them. We will
>> be tagging RC1 next week, so if the team wants to include this feature
>> you should work on getting the patches into shape tomorrow to give you
>> time to test them before the release candidate is tagged.
>>
>> Doug
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Sincerely yours,
> Sergey Lukjanov
> Principal Software Engineer
> Mirantis Inc.
>



-- 
Sincerely yours,
Sergey Lukjanov
Principal Software Engineer
Mirantis Inc.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Sergey Lukjanov]

Yup,

I'm expecting all FFEs to be merged by the EOW, otherwise we'll be
revisiting case by case with reject by default.

On Thu, Mar 10, 2016 at 1:38 PM, Doug Hellmann 
wrote:

> Excerpts from lu jander's message of 2016-03-07 14:28:21 +0800:
> > Hi folks,
> >
> > I would like to request a FFE for the feature “Resume EDP job”:
> >
> >
> >
> > BP:
> >
> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
> > 
> >
> >
> > 
> >
> > Spec has been merged. https://review.openstack.org/#/c/198264/
> >
> >
> > Suspend EDP patch has been merged.
> > https://review.openstack.org/#/c/201448/
> > 
> >
> >
> > 
> >
> > Code Review: https://review.openstack.org/#/c/285839/
> > 
> >
> >
> >
> > code is ready for review.
> >
> >
> >
> > The Benefits for this change: after suspend job, we can resume this job.
> >
> >
> >
> > The Risk: The risk would be low for this patch, since the code of suspend
> > patch has been long time reviewed.
> >
> >
> >
> > Thanks,
> >
> > luhuichun
>
> Both https://review.openstack.org/#/c/285839/ and
> https://review.openstack.org/#/c/218638/ have -1 votes on them. We will
> be tagging RC1 next week, so if the team wants to include this feature
> you should work on getting the patches into shape tomorrow to give you
> time to test them before the release candidate is tagged.
>
> Doug
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Sincerely yours,
Sergey Lukjanov
Principal Software Engineer
Mirantis Inc.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Doug Hellmann]

Excerpts from lu jander's message of 2016-03-07 14:28:21 +0800:
> Hi folks,
> 
> I would like to request a FFE for the feature “Resume EDP job”:
> 
> 
> 
> BP:
> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
> 
> 
> 
> 
> 
> Spec has been merged. https://review.openstack.org/#/c/198264/
> 
> 
> Suspend EDP patch has been merged.
> https://review.openstack.org/#/c/201448/
> 
> 
> 
> 
> 
> Code Review: https://review.openstack.org/#/c/285839/
> 
> 
> 
> 
> code is ready for review.
> 
> 
> 
> The Benefits for this change: after suspend job, we can resume this job.
> 
> 
> 
> The Risk: The risk would be low for this patch, since the code of suspend
> patch has been long time reviewed.
> 
> 
> 
> Thanks,
> 
> luhuichun

Both https://review.openstack.org/#/c/285839/ and
https://review.openstack.org/#/c/218638/ have -1 votes on them. We will
be tagging RC1 next week, so if the team wants to include this feature
you should work on getting the patches into shape tomorrow to give you
time to test them before the release candidate is tagged.

Doug

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Sergey Lukjanov]

FFE granted. This feature seems to be low risk and part of already merged
feature.

Thanks.

On Mon, Mar 7, 2016 at 9:34 AM, Chad Roberts  wrote:

> +1 to Trevor's $0.02.  Seems like low risk to break any existing
> functionality and it's a good feature that really makes sense.
>
> On Mon, Mar 7, 2016 at 9:42 AM, Trevor McKay  wrote:
>
>> My 2 cents, I agree that it is low risk -- the impl for resume is
>> analogous/parallel to the impl for suspend. And, it makes little
>> sense to me to include suspend without resume.
>>
>> In my mind, these two operations are halves of the same feature,
>> and since it is already partially implemented and approved, I the
>> FFE should be granted.
>>
>> Best,
>>
>> Trev
>>
>> On Mon, 2016-03-07 at 09:07 -0500, Trevor McKay wrote:
>> > For some reason the link below is wrong for me, it goes to a different
>> > review. Here is a good one (I hope!):
>> >
>> > https://review.openstack.org/#/c/285839/
>> >
>> > Trev
>> >
>> > On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote:
>> > > Hi folks,
>> > >
>> > > I would like to request a FFE for the feature “Resume EDP job”:
>> > >
>> > >
>> > >
>> > > BP:
>> > >
>> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
>> > >
>> > >
>> > > Spec has been merged. https://review.openstack.org/#/c/198264/
>> > >
>> > >
>> > > Suspend EDP patch has been merged.
>> > >  https://review.openstack.org/#/c/201448/
>> > >
>> > >
>> > > Code Review: https://review.openstack.org/#/c/285839/
>> > >
>> > >
>> > >
>> > > code is ready for review.
>> > >
>> > >
>> > >
>> > > The Benefits for this change: after suspend job, we can resume this
>> > > job.
>> > >
>> > >
>> > >
>> > > The Risk: The risk would be low for this patch, since the code of
>> > > suspend patch has been long time reviewed.
>> > >
>> > >
>> > >
>> > > Thanks,
>> > >
>> > > luhuichun
>> > >
>> > >
>> > >
>> > >
>> __
>> > > OpenStack Development Mailing List (not for usage questions)
>> > > Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>> >
>> >
>> >
>> __
>> > OpenStack Development Mailing List (not for usage questions)
>> > Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Sincerely yours,
Sergey Lukjanov
Principal Software Engineer
Mirantis Inc.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Chad Roberts]

+1 to Trevor's $0.02.  Seems like low risk to break any existing
functionality and it's a good feature that really makes sense.

On Mon, Mar 7, 2016 at 9:42 AM, Trevor McKay  wrote:

> My 2 cents, I agree that it is low risk -- the impl for resume is
> analogous/parallel to the impl for suspend. And, it makes little
> sense to me to include suspend without resume.
>
> In my mind, these two operations are halves of the same feature,
> and since it is already partially implemented and approved, I the
> FFE should be granted.
>
> Best,
>
> Trev
>
> On Mon, 2016-03-07 at 09:07 -0500, Trevor McKay wrote:
> > For some reason the link below is wrong for me, it goes to a different
> > review. Here is a good one (I hope!):
> >
> > https://review.openstack.org/#/c/285839/
> >
> > Trev
> >
> > On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote:
> > > Hi folks,
> > >
> > > I would like to request a FFE for the feature “Resume EDP job”:
> > >
> > >
> > >
> > > BP:
> > >
> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
> > >
> > >
> > > Spec has been merged. https://review.openstack.org/#/c/198264/
> > >
> > >
> > > Suspend EDP patch has been merged.
> > >  https://review.openstack.org/#/c/201448/
> > >
> > >
> > > Code Review: https://review.openstack.org/#/c/285839/
> > >
> > >
> > >
> > > code is ready for review.
> > >
> > >
> > >
> > > The Benefits for this change: after suspend job, we can resume this
> > > job.
> > >
> > >
> > >
> > > The Risk: The risk would be low for this patch, since the code of
> > > suspend patch has been long time reviewed.
> > >
> > >
> > >
> > > Thanks,
> > >
> > > luhuichun
> > >
> > >
> > >
> > >
> __
> > > OpenStack Development Mailing List (not for usage questions)
> > > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> >
> >
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Trevor McKay]

My 2 cents, I agree that it is low risk -- the impl for resume is
analogous/parallel to the impl for suspend. And, it makes little 
sense to me to include suspend without resume.

In my mind, these two operations are halves of the same feature,
and since it is already partially implemented and approved, I the
FFE should be granted.

Best,

Trev

On Mon, 2016-03-07 at 09:07 -0500, Trevor McKay wrote:
> For some reason the link below is wrong for me, it goes to a different
> review. Here is a good one (I hope!):
> 
> https://review.openstack.org/#/c/285839/
> 
> Trev
> 
> On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote:
> > Hi folks,
> > 
> > I would like to request a FFE for the feature “Resume EDP job”: 
> > 
> >  
> > 
> > BP:
> > https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
> > 
> > 
> > Spec has been merged. https://review.openstack.org/#/c/198264/  
> > 
> > 
> > Suspend EDP patch has been merged.
> >  https://review.openstack.org/#/c/201448/ 
> > 
> > 
> > Code Review: https://review.openstack.org/#/c/285839/
> > 
> >  
> > 
> > code is ready for review. 
> > 
> >  
> > 
> > The Benefits for this change: after suspend job, we can resume this
> > job.
> > 
> >  
> > 
> > The Risk: The risk would be low for this patch, since the code of
> > suspend patch has been long time reviewed.
> > 
> >  
> > 
> > Thanks,
> > 
> > luhuichun
> > 
> > 
> > 
> > __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [sahara]FFE Request for resume EDP job

[Trevor McKay]

For some reason the link below is wrong for me, it goes to a different
review. Here is a good one (I hope!):

https://review.openstack.org/#/c/285839/

Trev

On Mon, 2016-03-07 at 14:28 +0800, lu jander wrote:
> Hi folks,
> 
> I would like to request a FFE for the feature “Resume EDP job”: 
> 
>  
> 
> BP:
> https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs
> 
> 
> Spec has been merged. https://review.openstack.org/#/c/198264/  
> 
> 
> Suspend EDP patch has been merged.
>  https://review.openstack.org/#/c/201448/ 
> 
> 
> Code Review: https://review.openstack.org/#/c/285839/
> 
>  
> 
> code is ready for review. 
> 
>  
> 
> The Benefits for this change: after suspend job, we can resume this
> job.
> 
>  
> 
> The Risk: The risk would be low for this patch, since the code of
> suspend patch has been long time reviewed.
> 
>  
> 
> Thanks,
> 
> luhuichun
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [sahara]FFE Request for resume EDP job

[lu jander]

Hi folks,

I would like to request a FFE for the feature “Resume EDP job”:



BP:
https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs





Spec has been merged. https://review.openstack.org/#/c/198264/


Suspend EDP patch has been merged.
https://review.openstack.org/#/c/201448/





Code Review: https://review.openstack.org/#/c/285839/




code is ready for review.



The Benefits for this change: after suspend job, we can resume this job.



The Risk: The risk would be low for this patch, since the code of suspend
patch has been long time reviewed.



Thanks,

luhuichun
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev