Re: [openstack-dev] [stable][infra][neutron] ZUUL_BRANCH not set for periodic stable jobs

[Brandon Logan]

+1 thanks for being on top of this Ihar

On Mon, 2015-11-09 at 20:10 -0500, Assaf Muller wrote:
> On Mon, Nov 9, 2015 at 5:30 PM, Ihar Hrachyshka  wrote:
> > Jeremy Stanley  wrote:
> >
> >> On 2015-11-09 17:31:00 +0100 (+0100), Ihar Hrachyshka wrote:
> >> [...]
> >>>
> >>> From the failure log, I determined that the tests fail because they
> >>> assume
> >>> neutron/liberty code, but actually run against neutron/master (that does
> >>> not
> >>> have that neutron.plugins.embrane.* namespace because the plugin was
> >>> removed
> >>> in Mitaka).
> >>>
> >>> I then compared how we fetch neutron in gate and in periodic jobs, and I
> >>> see
> >>> that ZUUL branch is not set in the latter jobs.
> >>
> >> [...]
> >>
> >> Short answer is that the periodic trigger in Zuul is changeless and
> >> thus branchless. It just wakes up at the specified time and starts a
> >> list of jobs associated with that pipeline for any projects. This is
> >> why the working periodic jobs have different names than their gerrit
> >> triggered pipeline equivalents... they need to hard-code a branch
> >> (usually as a JJB parameter).
> >> --
> >> Jeremy Stanley
> >
> >
> > UPD: we discussed the matter with Jeremy in irc in more details and came up
> > to agreement that the best way is actually modifying tools/tox_install.sh in
> > neutron-lbaas (and other projects affected) to set ZUUL_BRANCH if not passed
> > from Jenkins.
> >
> > For neutron-lbaas, I came up with the following patch:
> > https://review.openstack.org/#/c/24/
> >
> > Once it’s validated and reviewed, I will propose some more for other
> > projects (I believe at least vpnaas should be affected).
> >
> > Once it’s merged in master, I will propose backports for Liberty.
> 
> Great work Ihar, thanks for taking this on.
> 
> >
> > Ihar
> > __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [stable][infra][neutron] ZUUL_BRANCH not set for periodic stable jobs

[Jeremy Stanley]

On 2015-11-09 17:31:00 +0100 (+0100), Ihar Hrachyshka wrote:
[...]
> From the failure log, I determined that the tests fail because they assume
> neutron/liberty code, but actually run against neutron/master (that does not
> have that neutron.plugins.embrane.* namespace because the plugin was removed
> in Mitaka).
> 
> I then compared how we fetch neutron in gate and in periodic jobs, and I see
> that ZUUL branch is not set in the latter jobs.
[...]

Short answer is that the periodic trigger in Zuul is changeless and
thus branchless. It just wakes up at the specified time and starts a
list of jobs associated with that pipeline for any projects. This is
why the working periodic jobs have different names than their gerrit
triggered pipeline equivalents... they need to hard-code a branch
(usually as a JJB parameter).
-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [stable][infra][neutron] ZUUL_BRANCH not set for periodic stable jobs

[Ihar Hrachyshka]

Hi all,

I noticed that neutron-lbaas jobs for liberty fail when in periodic jobs:

http://logs.openstack.org/periodic-stable/periodic-neutron-lbaas-python27-liberty/3da452c/

But they don’t fail in that way when running in gate:

https://review.openstack.org/#/c/242534/

From the failure log, I determined that the tests fail because they assume  
neutron/liberty code, but actually run against neutron/master (that does  
not have that neutron.plugins.embrane.* namespace because the plugin was  
removed in Mitaka).


I then compared how we fetch neutron in gate and in periodic jobs, and I  
see that ZUUL branch is not set in the latter jobs.


For gate jobs, I see:

“””
INFO:zuul.Cloner:Creating repo openstack/neutron from cache  
file:///opt/git/openstack/neutron
INFO:zuul.Cloner:Updating origin remote in repo openstack/neutron to  
git://git.openstack.org/openstack/neutron

INFO:zuul.Cloner:upstream repo has branch stable/liberty
INFO:zuul.Cloner:Falling back to branch stable/liberty
INFO:zuul.Cloner:Prepared openstack/neutron repo with branch stable/liberty  
at commit 4f8e95b0eb84a3659d7f26eeb58425a754bd3606

“”"

But for periodic jobs, I see:

“””
INFO:zuul.Cloner:Creating repo openstack/neutron from cache  
file:///opt/git/openstack/neutron
INFO:zuul.Cloner:Updating origin remote in repo openstack/neutron to  
git://git.openstack.org/openstack/neutron

INFO:zuul.Cloner:upstream repo is missing branch None
INFO:zuul.Cloner:Falling back to branch master
INFO:zuul.Cloner:Prepared openstack/neutron repo with branch master at  
commit 669dcc41bb04b8c0e0b914d95b84321ecd44be69

“”"

(all snippets are from tox/py27-1.log files in log dirs.)

For lbaas/liberty, we fetch neutron code using the following code:

https://github.com/openstack/neutron-lbaas/blob/stable/liberty/tools/tox_install.sh#L24

Note that we *don’t* pass --branch or --zuul_branch as an argument to  
zuul-cloner. I guess if we would add the argument there, it would correctly  
fetch neutron/liberty for us, and everything would work.


Now, before I go to neutron-lbaas and other neutron repos that use similar  
approach to fetch neutron code and fix it with explicit branch argument, I  
wonder whether a better fix would be to actually set ZUUL_BRANCH for those  
periodic jobs, making them more in line with gate.


So, I have several questions:
- is there any technical reason not to pass the envvar for those jobs?
- if not, then where I can enforce it in infra repos? [I tried to locate  
the proper place myself, but apparently my jjb-fu is not good enough.]


Thanks
Ihar

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [stable][infra][neutron] ZUUL_BRANCH not set for periodic stable jobs

[Ihar Hrachyshka]

Jeremy Stanley  wrote:


On 2015-11-09 17:31:00 +0100 (+0100), Ihar Hrachyshka wrote:
[...]

From the failure log, I determined that the tests fail because they assume
neutron/liberty code, but actually run against neutron/master (that does  
not
have that neutron.plugins.embrane.* namespace because the plugin was  
removed

in Mitaka).

I then compared how we fetch neutron in gate and in periodic jobs, and I  
see

that ZUUL branch is not set in the latter jobs.

[...]

Short answer is that the periodic trigger in Zuul is changeless and
thus branchless. It just wakes up at the specified time and starts a
list of jobs associated with that pipeline for any projects. This is
why the working periodic jobs have different names than their gerrit
triggered pipeline equivalents... they need to hard-code a branch
(usually as a JJB parameter).
--
Jeremy Stanley


UPD: we discussed the matter with Jeremy in irc in more details and came up  
to agreement that the best way is actually modifying tools/tox_install.sh  
in neutron-lbaas (and other projects affected) to set ZUUL_BRANCH if not  
passed from Jenkins.


For neutron-lbaas, I came up with the following patch:  
https://review.openstack.org/#/c/24/


Once it’s validated and reviewed, I will propose some more for other  
projects (I believe at least vpnaas should be affected).


Once it’s merged in master, I will propose backports for Liberty.

Ihar

signature.asc
Description: Message signed with OpenPGP using GPGMail
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [stable][infra][neutron] ZUUL_BRANCH not set for periodic stable jobs

[Assaf Muller]

On Mon, Nov 9, 2015 at 5:30 PM, Ihar Hrachyshka  wrote:
> Jeremy Stanley  wrote:
>
>> On 2015-11-09 17:31:00 +0100 (+0100), Ihar Hrachyshka wrote:
>> [...]
>>>
>>> From the failure log, I determined that the tests fail because they
>>> assume
>>> neutron/liberty code, but actually run against neutron/master (that does
>>> not
>>> have that neutron.plugins.embrane.* namespace because the plugin was
>>> removed
>>> in Mitaka).
>>>
>>> I then compared how we fetch neutron in gate and in periodic jobs, and I
>>> see
>>> that ZUUL branch is not set in the latter jobs.
>>
>> [...]
>>
>> Short answer is that the periodic trigger in Zuul is changeless and
>> thus branchless. It just wakes up at the specified time and starts a
>> list of jobs associated with that pipeline for any projects. This is
>> why the working periodic jobs have different names than their gerrit
>> triggered pipeline equivalents... they need to hard-code a branch
>> (usually as a JJB parameter).
>> --
>> Jeremy Stanley
>
>
> UPD: we discussed the matter with Jeremy in irc in more details and came up
> to agreement that the best way is actually modifying tools/tox_install.sh in
> neutron-lbaas (and other projects affected) to set ZUUL_BRANCH if not passed
> from Jenkins.
>
> For neutron-lbaas, I came up with the following patch:
> https://review.openstack.org/#/c/24/
>
> Once it’s validated and reviewed, I will propose some more for other
> projects (I believe at least vpnaas should be affected).
>
> Once it’s merged in master, I will propose backports for Liberty.

Great work Ihar, thanks for taking this on.

>
> Ihar
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev