Re: [openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
Emilien Macchi writes: > A bit of an update here: > > - We merged the patch in openstack/paunch that stop the Docker container if > we try to start a Podman container. > - We switched the undercloud upgrade job to test upgrades from Docker to > Podman (for now containers are stopped in Docker and then started in > Podman). > - We are now looking how and where to remove the Docker containers once the > upgrade finished. For that work, I started with the Undercloud and patched > tripleoclient to run the post_upgrade_tasks which to me is a good candidate > to run docker rm. +1 > > Please look: > - tripleoclient / run post_upgrade_tasks when upgrading > standalone/undercloud: https://review.openstack.org/614349 > - THT: prototype on how we would remove the Docker containers: > https://review.openstack.org/611092 > reviewed. > Note: for now we assume that Docker is still available on the host after > the upgrade as we are testing things under centos7. I'm aware that this > assumption can change in the future but we'll probably re-iterate. > > What I need from the upgrade team is feedback on this workflow, and see if > we can re-use these bits originally tested on Undercloud / Standalone, for > the Overcloud as well. > So that workflow won't break in any case for the overcloud. For an inplace upgrade then we need that clean up anyway given how paunch detect the need for an upgrade. For other upgrade scenario this won't do anything bad. So +1 for me. > Thanks for the feedback, > > > On Fri, Oct 19, 2018 at 8:00 AM Emilien Macchi wrote: > >> On Fri, Oct 19, 2018 at 4:24 AM Giulio Fidente >> wrote: >> >>> 1) create the podman systemd unit >>> 2) delete the docker container >>> >> >> We finally went with "stop the docker container" >> >> 3) start the podman container >>> >> >> and 4) delete the docker container later in THT upgrade_tasks. >> >> And yes +1 to do the same in ceph-ansible if possible. >> -- >> Emilien Macchi >> > > > -- > Emilien Macchi -- Sofer Athlan-Guyot __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
A bit of an update here: - We merged the patch in openstack/paunch that stop the Docker container if we try to start a Podman container. - We switched the undercloud upgrade job to test upgrades from Docker to Podman (for now containers are stopped in Docker and then started in Podman). - We are now looking how and where to remove the Docker containers once the upgrade finished. For that work, I started with the Undercloud and patched tripleoclient to run the post_upgrade_tasks which to me is a good candidate to run docker rm. Please look: - tripleoclient / run post_upgrade_tasks when upgrading standalone/undercloud: https://review.openstack.org/614349 - THT: prototype on how we would remove the Docker containers: https://review.openstack.org/611092 Note: for now we assume that Docker is still available on the host after the upgrade as we are testing things under centos7. I'm aware that this assumption can change in the future but we'll probably re-iterate. What I need from the upgrade team is feedback on this workflow, and see if we can re-use these bits originally tested on Undercloud / Standalone, for the Overcloud as well. Thanks for the feedback, On Fri, Oct 19, 2018 at 8:00 AM Emilien Macchi wrote: > On Fri, Oct 19, 2018 at 4:24 AM Giulio Fidente > wrote: > >> 1) create the podman systemd unit >> 2) delete the docker container >> > > We finally went with "stop the docker container" > > 3) start the podman container >> > > and 4) delete the docker container later in THT upgrade_tasks. > > And yes +1 to do the same in ceph-ansible if possible. > -- > Emilien Macchi > -- Emilien Macchi __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
On Fri, Oct 19, 2018 at 4:24 AM Giulio Fidente wrote: > 1) create the podman systemd unit > 2) delete the docker container > We finally went with "stop the docker container" 3) start the podman container > and 4) delete the docker container later in THT upgrade_tasks. And yes +1 to do the same in ceph-ansible if possible. -- Emilien Macchi __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
Hi, On Fri, Oct 19, 2018 at 10:24 AM Giulio Fidente wrote: > On 10/14/18 5:07 PM, Emilien Macchi wrote: > > I recently wrote a blog post about how we could upgrade an host from > > Docker containers to Podman containers. > > > > > http://my1.fr/blog/openstack-containerization-with-podman-part-3-upgrades/ > thanks Emilien this looks nice and I believe the basic approach > consisting of: > > 1) create the podman systemd unit > 2) delete the docker container > 3) start the podman container > What about several chained containers? You may delete one and next one will fail. It would be better to stop container and delete it once all dependent containers are migrated, started, validated. What Emilien described works for all cases. It would be nice to have the same procedure for Ceph cases as well, IMHO. > could be used to upgrade the Ceph containers as well (via ceph-ansible) > -- > Giulio Fidente > GPG KEY: 08D733BA > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Best Regards, Sergii Golovatiuk __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
On 10/14/18 5:07 PM, Emilien Macchi wrote: > I recently wrote a blog post about how we could upgrade an host from > Docker containers to Podman containers. > > http://my1.fr/blog/openstack-containerization-with-podman-part-3-upgrades/ thanks Emilien this looks nice and I believe the basic approach consisting of: 1) create the podman systemd unit 2) delete the docker container 3) start the podman container could be used to upgrade the Ceph containers as well (via ceph-ansible) -- Giulio Fidente GPG KEY: 08D733BA __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [tripleo] request for feedback/review on docker2podman upgrade
I recently wrote a blog post about how we could upgrade an host from Docker containers to Podman containers. http://my1.fr/blog/openstack-containerization-with-podman-part-3-upgrades/ I managed to get this prototype actually tested in CI: https://review.openstack.org/#/c/608463/ http://logs.openstack.org/63/608463/10/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/c958861/logs/undercloud/var/log/extra/docker/docker_allinfo.log.txt.gz http://logs.openstack.org/63/608463/10/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/c958861/logs/undercloud/var/log/extra/podman/podman_allinfo.log.txt.gz Therefore, I am requesting feedback and reviews on: - openstack/paunch: rm the docker container during upgrade - https://review.openstack.org/#/c/608319/ - openstack/tripleo-upgrade: set container_cli for undercloud - https://review.openstack.org/#/c/608462/ - openstack/tripleo-quickstart: fs050: upgrade the undercloud to Podman containers - https://review.openstack.org/#/c/608463/ Thanks, -- Emilien Macchi __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
