Re: [openstack-dev] [vitrage] valid source and target for add_causal_relationship

2016-08-18 Thread Yujun Zhang
Fix proposed in https://review.openstack.org/#/c/356974/

To enable validation of definition content, I have also made a refactoring
to the validator as in https://review.openstack.org/#/c/356947/

--
Yujun

On Wed, Aug 17, 2016 at 10:29 PM Har-Tal, Liat (Nokia - IL) <
liat.har-...@nokia.com> wrote:

> Yes, it should be limited to ‘ALARM’
>
>
>
> *From:* Yujun Zhang [mailto:zhangyujun+...@gmail.com]
> *Sent:* Wednesday, August 17, 2016 9:00 AM
> *To:* OpenStack Development Mailing List (not for usage questions)
> *Subject:* [openstack-dev] [vitrage] valid source and target for
> add_causal_relationship
>
>
>
> The issue comes from my carelessness that creating a causal relationship
> between two relationship instead of entities [1].
>
>
>
> But it seems not be detected by the template validator.
>
>
>
> I wonder what could be a valid `source` and `target` for causal
> relationship? Should it be limited to `ALARM`?
>
>
>
> [1]
> https://github.com/openzero-zte/vitrage-demo/commit/ce82f6f03e1b7168499233de431323e3cba43f9d#diff-aef3ec3ecbcccbad905bf3c57bb47e95R49
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [vitrage] valid source and target for add_causal_relationship

2016-08-17 Thread Har-Tal, Liat (Nokia - IL)
Yes, it should be limited to ‘ALARM’

From: Yujun Zhang [mailto:zhangyujun+...@gmail.com]
Sent: Wednesday, August 17, 2016 9:00 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [openstack-dev] [vitrage] valid source and target for 
add_causal_relationship

The issue comes from my carelessness that creating a causal relationship 
between two relationship instead of entities [1].

But it seems not be detected by the template validator.

I wonder what could be a valid `source` and `target` for causal relationship? 
Should it be limited to `ALARM`?

[1] 
https://github.com/openzero-zte/vitrage-demo/commit/ce82f6f03e1b7168499233de431323e3cba43f9d#diff-aef3ec3ecbcccbad905bf3c57bb47e95R49
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [vitrage] valid source and target for add_causal_relationship

2016-08-17 Thread Yujun Zhang
The issue comes from my carelessness that creating a causal relationship
between two relationship instead of entities [1].

But it seems not be detected by the template validator.

I wonder what could be a valid `source` and `target` for causal
relationship? Should it be limited to `ALARM`?

[1]
https://github.com/openzero-zte/vitrage-demo/commit/ce82f6f03e1b7168499233de431323e3cba43f9d#diff-aef3ec3ecbcccbad905bf3c57bb47e95R49
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev