Re: [openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
Yeah, I have been reviewing these, so happy to sponsor them too. Patches have been re-approved. Thanks, John On 5 September 2014 00:23, Michael Still mi...@stillhq.com wrote: So, that's your three. This exception is approved. Michael On Thu, Sep 4, 2014 at 9:05 AM, Nikola Đipanov ndipa...@redhat.com wrote: On 09/04/2014 03:46 PM, Daniel P. Berrange wrote: On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote: I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. They're all internal to the VMWare driver, have multiple ACKs from VMWare maintainers as well as core, so don't require extra review time. So I think it is reasonable request. ACK, I'll sponsor it. +1 here - I've already looked at a number of those. N. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote: I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. They're all internal to the VMWare driver, have multiple ACKs from VMWare maintainers as well as core, so don't require extra review time. So I think it is reasonable request. ACK, I'll sponsor it. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
On 04/09/14 14:46, Daniel P. Berrange wrote: On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote: I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. They're all internal to the VMWare driver, have multiple ACKs from VMWare maintainers as well as core, so don't require extra review time. So I think it is reasonable request. ACK, I'll sponsor it. Thanks, Dan. John Garbutt has also said he'll sponsor the previously approved patches, so that's 2. Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
On 09/04/2014 03:46 PM, Daniel P. Berrange wrote: On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote: I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. They're all internal to the VMWare driver, have multiple ACKs from VMWare maintainers as well as core, so don't require extra review time. So I think it is reasonable request. ACK, I'll sponsor it. +1 here - I've already looked at a number of those. N. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [vmware][nova][FFE] vmware-spawn-refactor
So, that's your three. This exception is approved. Michael On Thu, Sep 4, 2014 at 9:05 AM, Nikola Đipanov ndipa...@redhat.com wrote: On 09/04/2014 03:46 PM, Daniel P. Berrange wrote: On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote: I'd like to request a FFE for the remaining changes from vmware-spawn-refactor. They are: https://review.openstack.org/#/c/109754/ https://review.openstack.org/#/c/109755/ https://review.openstack.org/#/c/114817/ https://review.openstack.org/#/c/117467/ https://review.openstack.org/#/c/117283/ https://review.openstack.org/#/c/98322/ All but the last had +A, and were in the gate at the time it was closed. The last had not yet been approved, but is ready for core review. It has recently had some orthogonal changes split out to simplify it considerably. It is largely a code motion patch, and has been given +1 by VMware CI multiple times. They're all internal to the VMWare driver, have multiple ACKs from VMWare maintainers as well as core, so don't require extra review time. So I think it is reasonable request. ACK, I'll sponsor it. +1 here - I've already looked at a number of those. N. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
