On Tue, Oct 11, 2016 at 4:02 AM, Davanum Srinivas <dava...@gmail.com> wrote:
> Clay, > > Apologies for the top post. Oh goodness, none needed my friend! > https://github.com/openstack/requirements#global- > requirements-for-openstack-projects > > Eternal wells of gratitude for that read! There was so many good gems in the review guidelines section! Loved this bit: Everyone likes everyone else to use the latest version of their code. However, deployers really don't like to be constantly updating things. Unless it's actually impossible to use the minimum version specified in global-requirements.txt, it should not be changed. Leave that decision to deployers and distros. https://github.com/openstack/requirements#for-upgrading-requirements-versions There is a requirements team, you can reach them on the > #openstack-requirements channel > Cool I might stop by... Seems like there's some good knowledge to glean from the requirement team's experience and focus. Even simple stuff like the links to different distro packaging search/status: https://github.com/openstack/requirements#finding-distro-status ... is very helpful! > https://wiki.openstack.org/wiki/Requirements Hrmm... minor upstream version updates should be considered routine/cursory review https://wiki.openstack.org/wiki/Requirements#Review_Criteria Maybe my lens is off - seems like there's some conflicting attitudes on the wiki and the published guidelines on at least version bumps? Also those guidelines focus mostly on the requirements team - not the program teams (which is more what I'm looking for right now). There's the bit on the bot updates to requirements.txt: This is intended as a time saving device for projects, as they can fast approve requirements syncs and not have to manually worry about whether or not they are up to date with the global definition. https://github.com/openstack/requirements#automatic-sync-of-accepted-requirements But if it *is* just a connivence function what's the big deal that some projects (only swift?) are particularly sensitive to the minimum dependency version issue? There's the bit on the *process* of projects electing to participate in the very welcome and helpful requriements team review: This job ensures that a project can not change any dependencies to versions not compatible with global-requirements.txt https://github.com/openstack/requirements#enforcement-in-projects ... but beyond "dependencies must meet the global requirements teams minimum bar and be added to global-requirements *first*" (which based on that teams review guidelines is *great* service to the community btw) - it's obviously meant to be just the starting point? A proposed change to global requirements is supposed to reference the already in review change on the program code and the discussion about the appropriateness of outsourcing this impossible to live without functionality and coupling your project's fate to the dependency is obviously meant to happen by the program team? Is there any other information out there that's more focused on consistent guidelines for the *program* teams wrt to dependency hygiene - or is it cool everyone just sorta does their own thing within the bounds of reason (which are kept in check by the global requirements process)? -Clay
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
