subject:"Re\: \[openstack\-dev\] \[ python\-novaclient\]\[ python\-glanceclient\]\[ python\-cinderclient\]\[ python\-neutronclient\] Remove x\-openstack\-request\-id logging code as it is logged twice"

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-23 Thread Kekane, Abhishek

Hi Dims,

Thank you for the update.

As of now patches for updating requirements.txt in individual clients has been 
proposed by bot, out of which patch for python-novaclient is already merged.
Following patches are still in review queue:

Python-glanceclient: https://review.openstack.org/#/c/423678
Python-cinderclient: https://review.openstack.org/#/c/423674
Python-neutronclient: https://review.openstack.org/#/c/422968

I have submitted patches in python-glanceclient [1], python-cinderclient [2] 
and python-neutronclient [3] to address this issue with dependency on above 
patches.

As client library release is targeted in this week, we need to make sure these 
patches get through and are part of the release otherwise we can hit the issue 
of logging request-id mapping twice in the logs if SessionClient is used.

[1] https://review.openstack.org/422591
[2] https://review.openstack.org/#/c/423940 (one +2)
[3] https://review.openstack.org/#/c/423921


Thank you,

Abhishek Kekane


-Original Message-
From: Davanum Srinivas [mailto:dava...@gmail.com] 
Sent: Saturday, January 21, 2017 6:05 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ 
python-cinderclient][ python-neutronclient] Remove x-openstack-request-id 
logging code as it is logged twice

"keystoneauth1 >= 2.17.0" implies python-novaclient with your fix will work for 
any version including 2.17.0 which is not true. you need to either do 
"keystoneauth1 >= 2.18.0" or "keystoneauth1 > 2.17.0" and we prefer the ">=" 
notation i think.

Thanks,
Dims

On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek 
<abhishek.kek...@nttdata.com> wrote:
> Hi Dims,
>
> Thank you for reply. I will propose a patch soon. Just for curiosity,
> keystoneauth1 >= 2.17.0 will not install 2.18.0?
>
> Abhishek
> 
> From: Davanum Srinivas <dava...@gmail.com>
> Sent: Saturday, January 21, 2017 8:27:56 AM
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [ python-novaclient][ 
> python-glanceclient][ python-cinderclient][ python-neutronclient] 
> Remove x-openstack-request-id logging code as it is logged twice
>
> Abhishek,
>
> 1) requirements.txt for all 4 python-*client you mentioned have 
> "keystoneauth1>=2.17.0",
> 2) i do not see a review request to bump the minimum version in global 
> requirements for keystoneauth1 to "keystoneauth1>=2.18.0"
> (https://review.openstack.org/#/q/project:openstack/requirements+is:op
> en)
>
> Can you please file one?
>
> Thanks,
> Dims
>
>
> On Fri, Jan 20, 2017 at 12:52 AM, Kekane, Abhishek 
> <abhishek.kek...@nttdata.com> wrote:
>> Hi Devs,
>>
>>
>>
>> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is 
>> logged for every HTTP response. This keystoneauth1 version will be 
>> used for ocata.
>>
>> The same request id is also logged in 'request' method of 
>> SessionClient class for python-novaclient, python-glanceclient, 
>> python-cinderclient and python-neutronclient. Once requirements.txt 
>> is synced with global-requirements and it uses keystoneauth1 version 
>> 2.18.0 and above, x-openstack-request-id will be logged twice for these 
>> clients.
>>
>>
>>
>> I have submitted patches for python-novaclient [1] and 
>> python-glanceclient [2] and created patches for python-cinderclient 
>> and python-neutronclient but same will not be reviewed unless and 
>> until the requirements.txt is synced with global-requirements and it 
>> uses keystoneauth1 version 2.18.0.
>>
>>
>>
>> As final releases for client libraries are scheduled in the next week 
>> (between Jan 23 - Jan 27) we want to address these issues in the 
>> above mentioned clients.
>>
>>
>>
>> Please let us know your opinion about the same.
>>
>>
>>
>> [1] https://review.openstack.org/422602
>>
>> [2] https://review.openstack.org/422591
>>
>>
>> _
>> _
>> Disclaimer: This email and any attachments are sent in strictest 
>> confidence for the sole use of the addressee and may contain legally 
>> privileged, confidential, and proprietary data. If you are not the 
>> intended recipient, please advise the sender by replying promptly to 
>> this email and then delete and destroy this email and any attachments 
>> without any further use, copying or forwarding.
>>
>> __

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-21 Thread Davanum Srinivas

"keystoneauth1 >= 2.17.0" implies python-novaclient with your fix will
work for any version including 2.17.0 which is not true. you need to
either do "keystoneauth1 >= 2.18.0" or "keystoneauth1 > 2.17.0" and we
prefer the ">=" notation i think.

Thanks,
Dims

On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek
<abhishek.kek...@nttdata.com> wrote:
> Hi Dims,
>
> Thank you for reply. I will propose a patch soon. Just for curiosity,
> keystoneauth1 >= 2.17.0 will not install 2.18.0?
>
> Abhishek
> 
> From: Davanum Srinivas <dava...@gmail.com>
> Sent: Saturday, January 21, 2017 8:27:56 AM
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [ python-novaclient][ python-glanceclient][
> python-cinderclient][ python-neutronclient] Remove x-openstack-request-id
> logging code as it is logged twice
>
> Abhishek,
>
> 1) requirements.txt for all 4 python-*client you mentioned have
> "keystoneauth1>=2.17.0",
> 2) i do not see a review request to bump the minimum version in global
> requirements for keystoneauth1 to "keystoneauth1>=2.18.0"
> (https://review.openstack.org/#/q/project:openstack/requirements+is:open)
>
> Can you please file one?
>
> Thanks,
> Dims
>
>
> On Fri, Jan 20, 2017 at 12:52 AM, Kekane, Abhishek
> <abhishek.kek...@nttdata.com> wrote:
>> Hi Devs,
>>
>>
>>
>> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is
>> logged
>> for every HTTP response. This keystoneauth1 version will be used for
>> ocata.
>>
>> The same request id is also logged in 'request' method of SessionClient
>> class for python-novaclient, python-glanceclient, python-cinderclient and
>> python-neutronclient. Once requirements.txt is synced with
>> global-requirements and it uses keystoneauth1 version 2.18.0 and above,
>> x-openstack-request-id will be logged twice for these clients.
>>
>>
>>
>> I have submitted patches for python-novaclient [1] and python-glanceclient
>> [2] and created patches for python-cinderclient and python-neutronclient
>> but
>> same will not be reviewed unless and until the requirements.txt is synced
>> with global-requirements and it uses keystoneauth1 version 2.18.0.
>>
>>
>>
>> As final releases for client libraries are scheduled in the next week
>> (between Jan 23 - Jan 27) we want to address these issues in the above
>> mentioned clients.
>>
>>
>>
>> Please let us know your opinion about the same.
>>
>>
>>
>> [1] https://review.openstack.org/422602
>>
>> [2] https://review.openstack.org/422591
>>
>>
>> __
>> Disclaimer: This email and any attachments are sent in strictest
>> confidence
>> for the sole use of the addressee and may contain legally privileged,
>> confidential, and proprietary data. If you are not the intended recipient,
>> please advise the sender by replying promptly to this email and then
>> delete
>> and destroy this email and any attachments without any further use,
>> copying
>> or forwarding.
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> Disclaimer: This email and any attachments are sent in strictest confidence
> for the sole use of the addressee and may contain legally privileged,
> confidential, and proprietary data. If you are not the intended recipient,
> please advise the sender by replying promptly to this email and then delete
> and destroy this email and any attachments without any further use, copying
> or forwarding.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-21 Thread Kekane, Abhishek

Hi Steve,

Thank you for the update. I have already submitted patches for 
python-novaclient and python-novaclient for reviews and ready with 
python-cinderclient and python-novaclient patches. I will submit them ASAP when 
requirements.txt is synced with updated version of keystoneauth1.

Thank you,

Abhishek

From: Steve Martinelli <s.martine...@gmail.com>
Sent: Saturday, January 21, 2017 10:07:04 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ 
python-cinderclient][ python-neutronclient] Remove x-openstack-request-id 
logging code as it is logged twice

On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek 
<abhishek.kek...@nttdata.com<mailto:abhishek.kek...@nttdata.com>> wrote:
Hi Dims,

Thank you for reply. I will propose a patch soon. Just for curiosity, 
keystoneauth1 >= 2.17.0 will not install 2.18.0?

It will, but if we make 2.18.0 the minimum then it will for sure install only 
that level.

> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is logged
> for every HTTP response. This keystoneauth1 version will be used for ocata.
>
> The same request id is also logged in 'request' method of SessionClient
> class for python-novaclient, python-glanceclient, python-cinderclient and
> python-neutronclient. Once requirements.txt is synced with
> global-requirements and it uses keystoneauth1 version 2.18.0 and above,
> x-openstack-request-id will be logged twice for these clients.

So I approved this change (sorry it took so long to review and merge), but I 
didn't realize it was going to impact python-{nova | glance | cinder | 
neutron}client. I think it's slightly unrealistic to ask four teams to remove 
the logging in the last week we release clients (I'm assuming we want to remove 
the functionality and not log things twice).

 - Would folks prefer I revert the keystoneauth change and re-release without 
it, and we can bring it back in Pike?
- Do teams have the bandwidth to remove the request id logging in the next few 
days?

Sorry for the confusion this caused.

__
Disclaimer: This email and any attachments are sent in strictest confidence
for the sole use of the addressee and may contain legally privileged,
confidential, and proprietary data. If you are not the intended recipient,
please advise the sender by replying promptly to this email and then delete
and destroy this email and any attachments without any further use, copying
or forwarding.__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-20 Thread Steve Martinelli

On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek <
abhishek.kek...@nttdata.com> wrote:

> Hi Dims,
>
> Thank you for reply. I will propose a patch soon. Just for curiosity,
> keystoneauth1 >= 2.17.0 will not install 2.18.0?
>

It will, but if we make 2.18.0 the minimum then it will for sure install
only that level.

> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is
> logged
> > for every HTTP response. This keystoneauth1 version will be used for
> ocata.
> >
> > The same request id is also logged in 'request' method of SessionClient
> > class for python-novaclient, python-glanceclient, python-cinderclient and
> > python-neutronclient. Once requirements.txt is synced with
> > global-requirements and it uses keystoneauth1 version 2.18.0 and above,
> > x-openstack-request-id will be logged twice for these clients.
>

So I approved this change (sorry it took so long to review and merge), but
I didn't realize it was going to impact python-{nova | glance | cinder |
neutron}client. I think it's slightly unrealistic to ask four teams to
remove the logging in the last week we release clients (I'm assuming we
want to remove the functionality and not log things twice).

 - Would folks prefer I revert the keystoneauth change and re-release
without it, and we can bring it back in Pike?
- Do teams have the bandwidth to remove the request id logging in the next
few days?

Sorry for the confusion this caused.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-20 Thread Kekane, Abhishek

Hi Dims,

Thank you for reply. I will propose a patch soon. Just for curiosity, 
keystoneauth1 >= 2.17.0 will not install 2.18.0?

Abhishek

From: Davanum Srinivas <dava...@gmail.com>
Sent: Saturday, January 21, 2017 8:27:56 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ 
python-cinderclient][ python-neutronclient] Remove x-openstack-request-id 
logging code as it is logged twice

Abhishek,

1) requirements.txt for all 4 python-*client you mentioned have
"keystoneauth1>=2.17.0",
2) i do not see a review request to bump the minimum version in global
requirements for keystoneauth1 to "keystoneauth1>=2.18.0"
(https://review.openstack.org/#/q/project:openstack/requirements+is:open)

Can you please file one?

Thanks,
Dims


On Fri, Jan 20, 2017 at 12:52 AM, Kekane, Abhishek
<abhishek.kek...@nttdata.com> wrote:
> Hi Devs,
>
>
>
> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is logged
> for every HTTP response. This keystoneauth1 version will be used for ocata.
>
> The same request id is also logged in 'request' method of SessionClient
> class for python-novaclient, python-glanceclient, python-cinderclient and
> python-neutronclient. Once requirements.txt is synced with
> global-requirements and it uses keystoneauth1 version 2.18.0 and above,
> x-openstack-request-id will be logged twice for these clients.
>
>
>
> I have submitted patches for python-novaclient [1] and python-glanceclient
> [2] and created patches for python-cinderclient and python-neutronclient but
> same will not be reviewed unless and until the requirements.txt is synced
> with global-requirements and it uses keystoneauth1 version 2.18.0.
>
>
>
> As final releases for client libraries are scheduled in the next week
> (between Jan 23 - Jan 27) we want to address these issues in the above
> mentioned clients.
>
>
>
> Please let us know your opinion about the same.
>
>
>
> [1] https://review.openstack.org/422602
>
> [2] https://review.openstack.org/422591
>
>
> __
> Disclaimer: This email and any attachments are sent in strictest confidence
> for the sole use of the addressee and may contain legally privileged,
> confidential, and proprietary data. If you are not the intended recipient,
> please advise the sender by replying promptly to this email and then delete
> and destroy this email and any attachments without any further use, copying
> or forwarding.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



--
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
Disclaimer: This email and any attachments are sent in strictest confidence
for the sole use of the addressee and may contain legally privileged,
confidential, and proprietary data. If you are not the intended recipient,
please advise the sender by replying promptly to this email and then delete
and destroy this email and any attachments without any further use, copying
or forwarding.__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

2017-01-20 Thread Davanum Srinivas

Abhishek,

1) requirements.txt for all 4 python-*client you mentioned have
"keystoneauth1>=2.17.0",
2) i do not see a review request to bump the minimum version in global
requirements for keystoneauth1 to "keystoneauth1>=2.18.0"
(https://review.openstack.org/#/q/project:openstack/requirements+is:open)

Can you please file one?

Thanks,
Dims


On Fri, Jan 20, 2017 at 12:52 AM, Kekane, Abhishek
 wrote:
> Hi Devs,
>
>
>
> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is logged
> for every HTTP response. This keystoneauth1 version will be used for ocata.
>
> The same request id is also logged in 'request' method of SessionClient
> class for python-novaclient, python-glanceclient, python-cinderclient and
> python-neutronclient. Once requirements.txt is synced with
> global-requirements and it uses keystoneauth1 version 2.18.0 and above,
> x-openstack-request-id will be logged twice for these clients.
>
>
>
> I have submitted patches for python-novaclient [1] and python-glanceclient
> [2] and created patches for python-cinderclient and python-neutronclient but
> same will not be reviewed unless and until the requirements.txt is synced
> with global-requirements and it uses keystoneauth1 version 2.18.0.
>
>
>
> As final releases for client libraries are scheduled in the next week
> (between Jan 23 - Jan 27) we want to address these issues in the above
> mentioned clients.
>
>
>
> Please let us know your opinion about the same.
>
>
>
> [1] https://review.openstack.org/422602
>
> [2] https://review.openstack.org/422591
>
>
> __
> Disclaimer: This email and any attachments are sent in strictest confidence
> for the sole use of the addressee and may contain legally privileged,
> confidential, and proprietary data. If you are not the intended recipient,
> please advise the sender by replying promptly to this email and then delete
> and destroy this email and any attachments without any further use, copying
> or forwarding.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

Re: [openstack-dev] [ python-novaclient][ python-glanceclient][ python-cinderclient][ python-neutronclient] Remove x-openstack-request-id logging code as it is logged twice

6 matches

Site Navigation

Mail list logo

Footer information