Re: [openstack-dev] [horizon][plugins] Horizon plugins validation on CI
Hi Tony, I like the idea to get functional tests instead of tempest. We can extend our functional tests to plugins. Personally, I don't have a strong opinion on what way we should go forward. I'll support any community decision which helps us to get cross projects CI up and running. Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Thu, Oct 18, 2018 at 4:55 AM Tony Breeds wrote: > On Wed, Oct 17, 2018 at 04:18:26PM +0300, Ivan Kolodyazhny wrote: > > Hi all, > > > > We discussed this topic at PTG both with Horizon and other teams. Sounds > > like everybody is interested to have some cross-project CI jobs to verify > > that plugins are not broken with the latest Horizon changes. > > > > The initial idea was to use tempest plugins for this effort like we do > for > > Horizon [1]. We've got a very simple test to verify that Horizon is up > and > > running and a user is able to login. > > > > It's easy to implement such tests for any existing horizon plugin. I > tried > > it for Heat and Manila dashboards. > > Given that I know very little about this but isn't it just as simple as > running the say the octavia-dashboard[1] npm tests on all horizon changes? > This would be similar to the way we run the nova[2] functional tests on all > constraints changes in openstack/requirements. > > Yours Tony. > > [1] Of course all dashbaords/plugins > [2] Not just nova but you get the idea > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon][plugins] Horizon plugins validation on CI
On Wed, Oct 17, 2018 at 04:18:26PM +0300, Ivan Kolodyazhny wrote: > Hi all, > > We discussed this topic at PTG both with Horizon and other teams. Sounds > like everybody is interested to have some cross-project CI jobs to verify > that plugins are not broken with the latest Horizon changes. > > The initial idea was to use tempest plugins for this effort like we do for > Horizon [1]. We've got a very simple test to verify that Horizon is up and > running and a user is able to login. > > It's easy to implement such tests for any existing horizon plugin. I tried > it for Heat and Manila dashboards. Given that I know very little about this but isn't it just as simple as running the say the octavia-dashboard[1] npm tests on all horizon changes? This would be similar to the way we run the nova[2] functional tests on all constraints changes in openstack/requirements. Yours Tony. [1] Of course all dashbaords/plugins [2] Not just nova but you get the idea signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon][plugins] Horizon plugins validation on CI
Hi Ivan, As Octavia PTL I have no issue with adding a tempest-plugin repository for the octavia-dashboard. I think we have had examples with the main tempest tests and plugins where trying to do a suite of tests in one repository becomes messy. We may also want to consider doing a horizon-tempest-lib type of repository that can host common code/tools for the dashboard plugins to leverage. I'm thinking things like login code, etc. Michael On Wed, Oct 17, 2018 at 6:19 AM Ivan Kolodyazhny wrote: > > Hi all, > > We discussed this topic at PTG both with Horizon and other teams. Sounds like > everybody is interested to have some cross-project CI jobs to verify that > plugins are not broken with the latest Horizon changes. > > The initial idea was to use tempest plugins for this effort like we do for > Horizon [1]. We've got a very simple test to verify that Horizon is up and > running and a user is able to login. > > It's easy to implement such tests for any existing horizon plugin. I tried it > for Heat and Manila dashboards. > > If I understand correctly how tempest plugins work, for such case we've got > such options: > > a) to create the same tempest plugins for each plugin - it this case, we need > to maintain new repos for tempest plugins > b) add these tests to Horizon tempest plugin - in such case, it will be > harder for plugin maintainers to support these tests. > > If we don't want to go forward with tempest plugins, we can create similar > tests based on Horizon functional tests. > > I want to get more feedback both from Horizon and plugins teams on which > direction we should go and start implementation. > > > [1] > https://github.com/openstack/tempest-horizon/blob/master/tempest_horizon/tests/scenario/test_dashboard_basic_ops.py#L138 > > Regards, > Ivan Kolodyazhny, > http://blog.e0ne.info/ > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
