Re: [OpenStack-Infra] proposal: custom favicon for review.o.o
Ian Wienand writes: > On Wed, Jan 29, 2020 at 06:35:28AM +, Sorin Sbarnea wrote: >> I guess that means that you are not against the idea. > > I know it's probably not what you want to hear, but as it seems > favicons are becoming a component of branding like a logo I think > you'd do well to run your proposed work by someone with the expertise > to evaluate it with-respect-to whatever branding standards we have (I > imagine someone on the TC would have such contacts from the Foundation > or whoever does marketing). > > If you just make something up and send it, you're probably going to > get review questions like "how can we know this meets the branding > standards to be the logo on our most popular website" or "is this the > right size, format etc. for browsers in 2020" which are things > upstream marketing and web people could sign off on. So, personally, > I'd suggest a bit of pre-coordination there would mean any resulting > technical changes would be very non-controversial. That bridge has been crossed for opendev.org, which has a well-thought-out favicon. I think adding the same one to review.opendev.org is a technical exercise at this point. -Jim ___ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
Re: [OpenStack-Infra] proposal: custom favicon for review.o.o
On Wed, Jan 29, 2020 at 06:35:28AM +, Sorin Sbarnea wrote: > I guess that means that you are not against the idea. I know it's probably not what you want to hear, but as it seems favicons are becoming a component of branding like a logo I think you'd do well to run your proposed work by someone with the expertise to evaluate it with-respect-to whatever branding standards we have (I imagine someone on the TC would have such contacts from the Foundation or whoever does marketing). If you just make something up and send it, you're probably going to get review questions like "how can we know this meets the branding standards to be the logo on our most popular website" or "is this the right size, format etc. for browsers in 2020" which are things upstream marketing and web people could sign off on. So, personally, I'd suggest a bit of pre-coordination there would mean any resulting technical changes would be very non-controversial. -i ___ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
Re: [OpenStack-Infra] proposal: custom favicon for review.o.o
I guess that means that you are not against the idea. Clearly I will wait for the container to be ready in that case. In fact it would be easier to override the file during container building. On Wed, 29 Jan 2020 at 05:15, Ian Wienand wrote: > On Fri, Jan 24, 2020 at 09:32:00AM +, Sorin Sbarnea wrote: > > We are currently using default Gerrit favicon on > > https://review.opendev.org and I would like to propose changing it > > in order to ease differentiation between it and other gerrit servers > > we may work with. > > I did notice google started putting this next to search results > recently too, but then maybe reverted the change. > > > How hard it would be to override it? (where) > > I'm 99% sure it's built-in from [2] and there's no way to runtime > override it. It looks like for robots.txt we tell the apache that > fronts gerrit to look elsewhere [3]; I imagine the same would need to > be done for favicon.ico. > > ... also be aware that upcoming containerisation of gerrit probably > invalidates all that. > > -i > > [1] > https://www.theverge.com/2020/1/24/21080424/google-search-result-ads-desktop-favicon-redesign-backtrack-controversial-experiment > [2] > https://opendev.org/opendev/gerrit/src/branch/openstack/2.13.12/gerrit-war/src/main/webapp > [3] > https://opendev.org/opendev/puppet-gerrit/src/branch/master/templates/gerrit.vhost.erb#L71 > > -- -- /sorin ___ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
Re: [OpenStack-Infra] proposal: custom favicon for review.o.o
On Fri, Jan 24, 2020 at 09:32:00AM +, Sorin Sbarnea wrote: > We are currently using default Gerrit favicon on > https://review.opendev.org and I would like to propose changing it > in order to ease differentiation between it and other gerrit servers > we may work with. I did notice google started putting this next to search results recently too, but then maybe reverted the change. > How hard it would be to override it? (where) I'm 99% sure it's built-in from [2] and there's no way to runtime override it. It looks like for robots.txt we tell the apache that fronts gerrit to look elsewhere [3]; I imagine the same would need to be done for favicon.ico. ... also be aware that upcoming containerisation of gerrit probably invalidates all that. -i [1] https://www.theverge.com/2020/1/24/21080424/google-search-result-ads-desktop-favicon-redesign-backtrack-controversial-experiment [2] https://opendev.org/opendev/gerrit/src/branch/openstack/2.13.12/gerrit-war/src/main/webapp [3] https://opendev.org/opendev/puppet-gerrit/src/branch/master/templates/gerrit.vhost.erb#L71 ___ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
[OpenStack-Infra] proposal: custom favicon for review.o.o
We are currently using default Gerrit favicon on https://review.opendev.org and I would like to propose changing it in order to ease differentiation between it and other gerrit servers we may work with. How hard it would be to override it? (where) If others find useful I can propose a small alteration that make it bit different than vanilla one, while not making it too different, considering reusing od "pink". Thanks Sorin ___ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
