commit spice-vdagent for openSUSE:Factory

2020-11-05 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2020-11-05 21:54:57

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.11331 (New)


Package is "spice-vdagent"

Thu Nov  5 21:54:57 2020 rev:20 rq:846097 version:0.20.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2020-08-19 18:57:53.259881103 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.11331/spice-vdagent.changes   
2020-11-05 21:55:56.796045680 +0100
@@ -1,0 +2,25 @@
+Mon Nov  2 23:11:32 UTC 2020 - Bruce Rogers 
+
+- Fix multiple security issues as outlined in bsc#1173749
+  bsc#1177780 bsc#1177781 bsc#1177782 bsc#1177783
+  CVE-2020-25650 CVE-2020-25651 CVE-2020-25652 CVE-2020-25653
+  systemd-login-Avoid-a-crash-on-container.patch
+  vdagentd-Use-bool-for-agent_owns_clipboard-and-clien.patch
+  vdagentd-Automatically-release-agent_data.patch
+  vdagent-connection-Pass-err-to-g_credentials_get_uni.patch
+  vdagentd-Better-check-for-vdagent_connection_get_pee.patch
+  vdagentd-Avoid-calling-chmod.patch
+  Avoids-unchecked-file-transfer-IDs-allocation-and-us.patch
+  Avoids-uncontrolled-active_xfers-allocations.patch
+  Avoids-unlimited-agent-connections.patch
+  Avoids-user-session-hijacking.patch
+  Better-check-for-sessions.patch
+  vdagentd-Limit-number-of-agents-per-session-to-1.patch
+  cleanup-active_xfers-when-the-client-disconnects.patch
+  vdagentd-do-not-allow-to-use-an-already-used-file-xf.patch
+  Add-a-test-for-session_info.patch
+- Add a check section to run internal tests. Note that by default
+  the added session_info test is not run, as it doesn't work in
+  context of build service
+
+---

New:

  Add-a-test-for-session_info.patch
  Avoids-unchecked-file-transfer-IDs-allocation-and-us.patch
  Avoids-uncontrolled-active_xfers-allocations.patch
  Avoids-unlimited-agent-connections.patch
  Avoids-user-session-hijacking.patch
  Better-check-for-sessions.patch
  cleanup-active_xfers-when-the-client-disconnects.patch
  systemd-login-Avoid-a-crash-on-container.patch
  vdagent-connection-Pass-err-to-g_credentials_get_uni.patch
  vdagentd-Automatically-release-agent_data.patch
  vdagentd-Avoid-calling-chmod.patch
  vdagentd-Better-check-for-vdagent_connection_get_pee.patch
  vdagentd-Limit-number-of-agents-per-session-to-1.patch
  vdagentd-Use-bool-for-agent_owns_clipboard-and-clien.patch
  vdagentd-do-not-allow-to-use-an-already-used-file-xf.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.TI6hyb/_old  2020-11-05 21:55:58.240042434 +0100
+++ /var/tmp/diff_new_pack.TI6hyb/_new  2020-11-05 21:55:58.244042424 +0100
@@ -17,6 +17,9 @@
 #
 
 
+#This test doesn't work right in build service, but does outside of it
+%bcond_with session_info_test
+
 Name:   spice-vdagent
 Version:0.20.0
 Release:0
@@ -29,6 +32,22 @@
 Source2:%{name}.keyring
 Patch1: vdagentd-work-around-GLib-s-fork-issues.patch
 Patch2: vdagentd-init-static-uinput-before-fork.patch
+Patch3: systemd-login-Avoid-a-crash-on-container.patch
+Patch4: vdagentd-Use-bool-for-agent_owns_clipboard-and-clien.patch
+Patch5: vdagentd-Automatically-release-agent_data.patch
+Patch6: vdagent-connection-Pass-err-to-g_credentials_get_uni.patch
+Patch7: vdagentd-Better-check-for-vdagent_connection_get_pee.patch
+Patch8: vdagentd-Avoid-calling-chmod.patch
+Patch9: Avoids-unchecked-file-transfer-IDs-allocation-and-us.patch
+Patch10:Avoids-uncontrolled-active_xfers-allocations.patch
+Patch11:Avoids-unlimited-agent-connections.patch
+Patch12:Avoids-user-session-hijacking.patch
+Patch13:Better-check-for-sessions.patch
+Patch14:vdagentd-Limit-number-of-agents-per-session-to-1.patch
+Patch15:cleanup-active_xfers-when-the-client-disconnects.patch
+Patch16:vdagentd-do-not-allow-to-use-an-already-used-file-xf.patch
+Patch17:Add-a-test-for-session_info.patch
+
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  libXfixes-devel
@@ -65,13 +84,34 @@
 %setup -q
 %patch1 -p1
 %patch2 -p1
+%patch3 -p1
+%patch4 -p1
+%patch5 -p1
+%patch6 -p1
+%patch7 -p1
+%patch8 -p1
+%patch9 -p1
+%patch10 -p1
+%patch11 -p1
+%patch12 -p1
+%patch13 -p1
+%patch14 -p1
+%patch15 -p1
+%patch16 -p1
+%if %{with session_info_test}
+%patch17 -p1
+%endif
 
 %build
+autoreconf
 %configure \
   --with-session-info=systemd \
   --with-init-script=systemd
 make %{?_smp_mflags} V=2
 
+%check
+make check V=2
+
 %install
 make install

commit spice-vdagent for openSUSE:Factory

2020-08-19 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2020-08-19 18:56:47

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.3399 (New)


Package is "spice-vdagent"

Wed Aug 19 18:56:47 2020 rev:19 rq:827755 version:0.20.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2020-03-26 23:37:27.306865621 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.3399/spice-vdagent.changes
2020-08-19 18:57:53.259881103 +0200
@@ -1,0 +2,5 @@
+Wed Aug 19 08:23:02 UTC 2020 - Dominique Leuenberger 
+
+- Fix invalid usage of %{_libexecdir} to reference udev/rules.d.
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.TKKg0s/_old  2020-08-19 18:57:59.083884198 +0200
+++ /var/tmp/diff_new_pack.TKKg0s/_new  2020-08-19 18:57:59.087884200 +0200
@@ -106,13 +106,11 @@
 %defattr(-,root,root)
 %doc CHANGELOG.md README.md
 %license COPYING
-%dir %{_libexecdir}/udev
-%dir %{_libexecdir}/udev/rules.d
 %ghost /run/spice-vdagentd
-%{_libexecdir}/udev/rules.d/70-spice-vdagentd.rules
+%{_udevrulesdir}/70-spice-vdagentd.rules
 %{_unitdir}/spice-vdagentd.service
 %{_unitdir}/spice-vdagentd.socket
-%{_libexecdir}/tmpfiles.d/spice-vdagentd.conf
+%{_tmpfilesdir}/spice-vdagentd.conf
 %{_bindir}/spice-vdagent
 %{_sbindir}/spice-vdagentd
 %{_sbindir}/rcspice-vdagentd

commit spice-vdagent for openSUSE:Factory

2020-03-26 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2020-03-26 23:37:22

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.3160 (New)


Package is "spice-vdagent"

Thu Mar 26 23:37:22 2020 rev:18 rq:788597 version:0.20.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2020-03-14 09:55:07.619100738 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.3160/spice-vdagent.changes
2020-03-26 23:37:27.306865621 +0100
@@ -1,0 +2,8 @@
+Thu Mar 26 15:33:15 UTC 2020 - Bruce Rogers 
+
+- Fix issue of spice-vdagentd not shutting down (bsc#1166895)
+  vdagentd-work-around-GLib-s-fork-issues.patch
+  (This patch fixes a related issue)
+  vdagentd-init-static-uinput-before-fork.patch
+
+---

New:

  vdagentd-init-static-uinput-before-fork.patch
  vdagentd-work-around-GLib-s-fork-issues.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.WrmfSC/_old  2020-03-26 23:37:31.670867196 +0100
+++ /var/tmp/diff_new_pack.WrmfSC/_new  2020-03-26 23:37:31.674867198 +0100
@@ -27,6 +27,8 @@
 Source: 
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Source1:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2.sig
 Source2:%{name}.keyring
+Patch1: vdagentd-work-around-GLib-s-fork-issues.patch
+Patch2: vdagentd-init-static-uinput-before-fork.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  libXfixes-devel
@@ -61,6 +63,8 @@
 
 %prep
 %setup -q
+%patch1 -p1
+%patch2 -p1
 
 %build
 %configure \



++ vdagentd-init-static-uinput-before-fork.patch ++
>From 7b0435ef66af088c1a1be20b6bc6b0fcb76e4e1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Jank=C5=AF?= 
Date: Fri, 20 Mar 2020 17:18:32 +0100
Subject: [PATCH] vdagentd: init static uinput before fork
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Otherwise the caller doesn't know that the init failed
because we're returning 0 in the parent and 1 in child.

Signed-off-by: Jakub Janků 
Acked-by: Frediano Ziglio 
[BR: BSC#1166895]
Signed-off-by: Bruce Rogers 
---
 src/vdagentd/vdagentd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
index 1b63ec8..753c9bf 100644
--- a/src/vdagentd/vdagentd.c
+++ b/src/vdagentd/vdagentd.c
@@ -1224,9 +1224,6 @@ int main(int argc, char *argv[])
 }
 }
 
-if (do_daemonize)
-daemonize();
-
 #ifdef WITH_STATIC_UINPUT
 uinput = vdagentd_uinput_create(uinput_device, 1024, 768, NULL, 0,
 debug > 1, uinput_fake);
@@ -1236,6 +1233,9 @@ int main(int argc, char *argv[])
 }
 #endif
 
+if (do_daemonize)
+daemonize();
+
 g_unix_signal_add(SIGINT, signal_handler, NULL);
 g_unix_signal_add(SIGHUP, signal_handler, NULL);
 g_unix_signal_add(SIGTERM, signal_handler, NULL);
-- 
2.25.1

++ vdagentd-work-around-GLib-s-fork-issues.patch ++
>From 9b8c0ebb9fb573e6ce3c5416371509f416503d0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Jank=C5=AF?= 
Date: Fri, 20 Mar 2020 10:36:03 +0100
Subject: [PATCH] vdagentd: work around GLib's fork issues
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Creating threads is not compatible with forking as only the thread
that calls fork() is inherited.

Handlers registered with g_unix_signal_add() create a thread so
move these calls after fork.

Also call g_socket_service_start() after fork to avoid creation of
new threads before it is necessary.

Fixes: https://gitlab.freedesktop.org/spice/linux/vd_agent/issues/18

Also see: https://gitlab.gnome.org/GNOME/glib/issues/2073

Signed-off-by: Jakub Janků 
Acked-by: Frediano Ziglio 
[BR: BSC#1166895]
Signed-off-by: Bruce Rogers 
---
 src/udscs.c | 6 ++
 src/udscs.h | 2 ++
 src/vdagentd/vdagentd.c | 9 +
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/udscs.c b/src/udscs.c
index 4de75f8..7c99eed 100644
--- a/src/udscs.c
+++ b/src/udscs.c
@@ -186,6 +186,7 @@ struct udscs_server *udscs_server_new(
 server->read_callback = read_callback;
 server->error_cb = error_cb;
 server->service = g_socket_service_new();
+g_socket_service_stop(server->service);
 
 g_signal_connect(server->service, "incoming",
 G_CALLBACK(udscs_server_accept_cb), server);
@@ -223,6 +224,11 @@ void udscs_server_listen_to_address(struct udscs_server 
*server,

commit spice-vdagent for openSUSE:Factory

2020-03-14 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2020-03-14 09:55:01

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.3160 (New)


Package is "spice-vdagent"

Sat Mar 14 09:55:01 2020 rev:17 rq:783559 version:0.20.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2020-01-13 22:23:16.682567034 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.3160/spice-vdagent.changes
2020-03-14 09:55:07.619100738 +0100
@@ -1,0 +2,15 @@
+Tue Mar 10 21:19:18 UTC 2020 - Bruce Rogers 
+
+- Update to 0.20.0
+  * Add gio-unix and gobject dependency >= 2.50
+  * Bump gtk+ >= 3.22 (optional dependency)
+  * Last release with gtk+ being optional
+  * !4 - Race fixes between client and guest clipboard
+  * !2 - Fix session lookup for new GNOME versions
+  * !3 - Now using GMainLoop and GIO to handle I/O of messages
+  * Several minor covscan fixes
+- Discovered GLib dependency is now >= 2.58
+- Patch dropped (contained in update):
+  vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
+
+---

Old:

  spice-vdagent-0.19.0.tar.bz2
  spice-vdagent-0.19.0.tar.bz2.sig
  vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch

New:

  spice-vdagent-0.20.0.tar.bz2
  spice-vdagent-0.20.0.tar.bz2.sig



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.J2zkEe/_old  2020-03-14 09:55:08.791101598 +0100
+++ /var/tmp/diff_new_pack.J2zkEe/_new  2020-03-14 09:55:08.791101598 +0100
@@ -18,7 +18,7 @@
 
 
 Name:   spice-vdagent
-Version:0.19.0
+Version:0.20.0
 Release:0
 Summary:Agent for Spice guests
 License:GPL-3.0-or-later
@@ -27,20 +27,21 @@
 Source: 
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Source1:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2.sig
 Source2:%{name}.keyring
-Patch0: vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
-BuildRequires:  glib2-devel
 BuildRequires:  libXfixes-devel
 BuildRequires:  libXinerama-devel
-BuildRequires:  libXrandr-devel
-BuildRequires:  libdrm-devel
-BuildRequires:  libpciaccess-devel
+BuildRequires:  libXrandr-devel >= 1.3
+BuildRequires:  libpciaccess-devel >= 0.10
 BuildRequires:  libtool
-BuildRequires:  spice-protocol-devel >= 0.12.8
 BuildRequires:  pkgconfig(dbus-1)
-BuildRequires:  pkgconfig(glib-2.0) >= 2.34
+BuildRequires:  pkgconfig(gio-2.0) >= 2.50
+BuildRequires:  pkgconfig(glib-2.0) >= 2.58
+BuildRequires:  pkgconfig(gobject-2.0) >= 2.50
+BuildRequires:  pkgconfig(gtk+-3.0) >= 3.22
+BuildRequires:  pkgconfig(libdrm)
 BuildRequires:  pkgconfig(libsystemd)
+BuildRequires:  pkgconfig(spice-protocol) >= 0.14.1
 BuildRequires:  pkgconfig(systemd)
 BuildRequires:  pkgconfig(udev)
 Supplements:modalias(xorg-x11-server:virtio:d0003v*)
@@ -60,7 +61,6 @@
 
 %prep
 %setup -q
-%patch0 -p1
 
 %build
 %configure \

++ spice-vdagent-0.19.0.tar.bz2 -> spice-vdagent-0.20.0.tar.bz2 ++
 4356 lines of diff (skipped)

commit spice-vdagent for openSUSE:Factory

2020-01-13 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2020-01-13 22:23:11

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.6675 (New)


Package is "spice-vdagent"

Mon Jan 13 22:23:11 2020 rev:16 rq:764107 version:0.19.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2019-12-18 14:48:22.169940019 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.6675/spice-vdagent.changes
2020-01-13 22:23:16.682567034 +0100
@@ -1,0 +2,6 @@
+Thu Dec 19 15:18:43 UTC 2019 - Dominique Leuenberger 
+
+- BuildRequire pkgconfig(libsystemd) instead of systemd-devel:
+  Allow OBS to shortcut through the -mini flavors.
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.QGjMuB/_old  2020-01-13 22:23:17.902567600 +0100
+++ /var/tmp/diff_new_pack.QGjMuB/_new  2020-01-13 22:23:17.906567602 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2019 SUSE LLC
+# Copyright (c) 2020 SUSE LLC
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -38,10 +38,10 @@
 BuildRequires:  libpciaccess-devel
 BuildRequires:  libtool
 BuildRequires:  spice-protocol-devel >= 0.12.8
-BuildRequires:  systemd
-BuildRequires:  systemd-devel
 BuildRequires:  pkgconfig(dbus-1)
 BuildRequires:  pkgconfig(glib-2.0) >= 2.34
+BuildRequires:  pkgconfig(libsystemd)
+BuildRequires:  pkgconfig(systemd)
 BuildRequires:  pkgconfig(udev)
 Supplements:modalias(xorg-x11-server:virtio:d0003v*)
 %{?systemd_requires}

commit spice-vdagent for openSUSE:Factory

2019-12-18 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2019-12-18 14:45:11

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.4691 (New)


Package is "spice-vdagent"

Wed Dec 18 14:45:11 2019 rev:15 rq:757597 version:0.19.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2019-12-12 23:19:17.862207374 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.4691/spice-vdagent.changes
2019-12-18 14:48:22.169940019 +0100
@@ -1,0 +2,8 @@
+Tue Dec 17 16:51:54 UTC 2019 - Bruce Rogers 
+
+- Since the 0.19.0 update, this patch is no longer needed:
+  spice-vdagent-var_run.patch
+- For sometime now we've not had any rsyslog config files, so clean
+  up where the spec file would remove the rsyslog.d dir and content
+
+---

Old:

  spice-vdagent-var_run.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.JnD8wH/_old  2019-12-18 14:48:22.593940213 +0100
+++ /var/tmp/diff_new_pack.JnD8wH/_new  2019-12-18 14:48:22.593940213 +0100
@@ -27,8 +27,7 @@
 Source: 
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Source1:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2.sig
 Source2:%{name}.keyring
-Patch0: spice-vdagent-var_run.patch
-Patch1: vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
+Patch0: vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
@@ -62,7 +61,6 @@
 %prep
 %setup -q
 %patch0 -p1
-%patch1 -p1
 
 %build
 %configure \
@@ -72,8 +70,6 @@
 
 %install
 make install DESTDIR=%{buildroot} V=2
-# remove rsyslogd config
-rm -rf %{buildroot}%{_sysconfdir}/rsyslog.d
 # create rc symlink
 ln -s  service %{buildroot}%{_sbindir}/rcspice-vdagentd

commit spice-vdagent for openSUSE:Factory

2019-12-12 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2019-12-12 23:19:11

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.4691 (New)


Package is "spice-vdagent"

Thu Dec 12 23:19:11 2019 rev:14 rq:755921 version:0.19.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2019-06-19 20:57:45.825948210 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.4691/spice-vdagent.changes
2019-12-12 23:19:17.862207374 +0100
@@ -1,0 +2,7 @@
+Wed Dec 11 17:33:36 UTC 2019 - Bruce Rogers 
+
+- Add upstream fix for spice-vdagent running on recent GNOME (eg.
+  3.34) with systemd integration (boo#1157235)
+  vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
+
+---

New:

  vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.3ktD6I/_old  2019-12-12 23:19:18.498207317 +0100
+++ /var/tmp/diff_new_pack.3ktD6I/_new  2019-12-12 23:19:18.498207317 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LLC
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -23,11 +23,12 @@
 Summary:Agent for Spice guests
 License:GPL-3.0-or-later
 Group:  System/Daemons
-Url:http://spice-space.org/
+URL:http://spice-space.org/
 Source: 
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Source1:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2.sig
 Source2:%{name}.keyring
 Patch0: spice-vdagent-var_run.patch
+Patch1: vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
@@ -61,6 +62,7 @@
 %prep
 %setup -q
 %patch0 -p1
+%patch1 -p1
 
 %build
 %configure \



++ vdagentd-Fix-session-lookup-for-new-GNOME-versions.patch ++
>From b67ff71f1b30992f5b8d4583cc93adb789d247fa Mon Sep 17 00:00:00 2001
From: Benjamin Berg 
Date: Fri, 13 Sep 2019 17:00:27 +0200
Subject: [PATCH] vdagentd: Fix session lookup for new GNOME versions

New GNOME versions have started to manage the session using the systemd
user instance. The effect of this is that the spice-vdagent running in
the user session is forked off (indirectly) from the systemd user
instance and does technically not belong to any session.

The correct way of handling this situation is to simply assume that the
process belongs to the users graphical session. Add a heuristic to find
the graphical session based on the UID, fixing spice-vdagent running on
GNOME 3.34 with systemd integration.

Acked-by: Victor Toso 
[BR: boo#1157235]
Signed-off-by: Bruce Rogers 
---
 src/vdagentd/systemd-login.c | 59 +---
 1 file changed, 55 insertions(+), 4 deletions(-)

diff --git a/src/vdagentd/systemd-login.c b/src/vdagentd/systemd-login.c
index a11b66d..0b8f3c1 100644
--- a/src/vdagentd/systemd-login.c
+++ b/src/vdagentd/systemd-login.c
@@ -286,15 +286,66 @@ const char *session_info_get_active_session(struct 
session_info *si)
 
 char *session_info_session_for_pid(struct session_info *si, uint32_t pid)
 {
+int i;
 int r;
+GStrv sessions = NULL;
 char *session = NULL;
+uid_t uid;
 
 r = sd_pid_get_session(pid, );
-if (r < 0)
-syslog(LOG_ERR, "Error getting session for pid %u: %s",
-pid, strerror(-r));
-else if (si->verbose)
+if (r >= 0) {
+goto out;
+}
+
+/* If we could not get a session for the pid then the agent is probably
+ * running in a systemd managed session. In that case we simply assume
+ * it is actually part of the newest graphical session we can find. */
+r = sd_pid_get_owner_uid(pid, );
+if (r < 0) {
+syslog(LOG_ERR, "Error getting owner UID for pid %u: %s",
+   pid, strerror(-r));
+goto out;
+}
+
+r = sd_uid_get_sessions(uid, 0, );
+if (r < 0) {
+syslog(LOG_ERR, "Error getting sessions for UID %d: %s",
+   (int) uid, strerror(-r));
+goto out;
+}
+
+for (i = 0; sessions[i] != NULL; i++) {
+char *session_type = NULL;
+
+r = sd_session_get_type(sessions[i], _type);
+
+if (r < 0) {
+syslog(LOG_ERR, "Error getting session type for session %s: %s",
+   sessions[i], strerror(-r));
+

commit spice-vdagent for openSUSE:Factory

2019-06-19 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2019-06-19 20:57:31

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new.4811 (New)


Package is "spice-vdagent"

Wed Jun 19 20:57:31 2019 rev:13 rq:703830 version:0.19.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2017-12-14 10:54:27.920355998 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new.4811/spice-vdagent.changes
2019-06-19 20:57:45.825948210 +0200
@@ -1,0 +2,41 @@
+Fri May 17 20:34:45 UTC 2019 - Bruce Rogers 
+
+- Update to 0.19.0
+  * Add libdrm dependency
+  * Fix file descriptor leak on failed connections
+  * Handle new VD_AGENT_GRAPHICS_DEVICE_INFO message advertised by
+VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability
+  * Session agent autostart changed to WindowManager ([rhbz#1623947])
+This fixes possible race with xdg-user-dirs
+  * Fix of sending empty screen resolution messages ([rhbz#1641723])
+  * Fix 'Dependency failed for Activation socket' with systemd ([rhbz#1545212])
+  * Fix error messages about on selecting text on host ([rhbz#1594876])
+this was also fixed with Gtk backend
+  * Update paths from /var/run → /run
+  * Fix Session agent restart
+  * Add test for file creation
+  * Prefer GLib memory functions stdlib.h ones
+  * Several code and logs improvements
+  * Add GTK+ framework to handle x11 backend such as clipboard
+  * Deprecate X11 backend in favor of GTK+ framework
+  * Ask pkg-config to appropriate directory to install udev rules
+  * Fix leak of udscs's file descriptor
+  * Better quote directory path when calling xdg-open to save file transfer
+  * Bump GLib to 2.34
+  * Add systemd socket activation (rhbz#1340160)
+  * Add support to detailed errors on file transfers
+  * Add check for available free space in guest before starting a file transfer
+  * Use better names for duplicated files on file transfer
+  * Improve support on big endian guests (#5)
+  * Use IdleHint to check if a session is locked over console-kit 
(rhbz#1412673)
+  * Fixes double free on errors over udscs by improving memory ownership
+  * Hide autostart file on Unity
+  * Improve command line messages for vdagentd
+  * Fix typo in --enable-static-uinput configure option
+  * Code repository moved to gitlab.freedesktop.org
+- Add keyring and tarball signature files
+- obsoleted patches removed:
+  8ba17481-quote-save-dir-before-passing-to-shell.patch
+  vdagentd-do-endian-swapping.patch
+
+---

Old:

  8ba17481-quote-save-dir-before-passing-to-shell.patch
  spice-vdagent-0.17.0.tar.bz2
  vdagentd-do-endian-swapping.patch

New:

  spice-vdagent-0.19.0.tar.bz2
  spice-vdagent-0.19.0.tar.bz2.sig
  spice-vdagent.keyring



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.XfePg1/_old  2019-06-19 20:57:46.441948723 +0200
+++ /var/tmp/diff_new_pack.XfePg1/_new  2019-06-19 20:57:46.441948723 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -13,34 +13,36 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
 Name:   spice-vdagent
-Version:0.17.0
+Version:0.19.0
 Release:0
 Summary:Agent for Spice guests
-License:GPL-3.0+
-Group:  Applications/System
+License:GPL-3.0-or-later
+Group:  System/Daemons
 Url:http://spice-space.org/
-Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
+Source: 
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
+Source1:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2.sig
+Source2:%{name}.keyring
 Patch0: spice-vdagent-var_run.patch
-Patch1: vdagentd-do-endian-swapping.patch
-Patch2: 8ba17481-quote-save-dir-before-passing-to-shell.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
 BuildRequires:  libXfixes-devel
 BuildRequires:  libXinerama-devel
 BuildRequires:  libXrandr-devel
+BuildRequires:  libdrm-devel
 BuildRequires:  libpciaccess-devel
 BuildRequires:  libtool

commit spice-vdagent for openSUSE:Factory

2017-12-14 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2017-12-14 10:54:23

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Thu Dec 14 10:54:23 2017 rev:12 rq:554572 version:0.17.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2017-08-28 16:17:24.292788554 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2017-12-14 10:54:27.920355998 +0100
@@ -1,0 +2,7 @@
+Tue Dec  5 16:12:24 UTC 2017 - cbosdon...@suse.com
+
+- Fix potential shell command injection.
+  8ba17481-quote-save-dir-before-passing-to-shell.patch
+  CVE-2017-15108 (bsc#1070724)
+
+---

New:

  8ba17481-quote-save-dir-before-passing-to-shell.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.2mftRs/_old  2017-12-14 10:54:29.012303286 +0100
+++ /var/tmp/diff_new_pack.2mftRs/_new  2017-12-14 10:54:29.016303093 +0100
@@ -27,6 +27,7 @@
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Patch0: spice-vdagent-var_run.patch
 Patch1: vdagentd-do-endian-swapping.patch
+Patch2: 8ba17481-quote-save-dir-before-passing-to-shell.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
@@ -59,6 +60,7 @@
 %setup -q
 %patch0 -p1
 %patch1 -p1
+%patch2 -p1
 
 %build
 %configure \

++ 8ba17481-quote-save-dir-before-passing-to-shell.patch ++
>From 8ba174816d245757e743e636df357910e1d5eb61 Mon Sep 17 00:00:00 2001
From: Jonathon Jongsma 
Date: Wed, 25 Oct 2017 10:33:11 -0500
Subject: [PATCH] Quote the save directory before passing to shell

Thanks to a report from Seth Arnold :
- vdagent_file_xfers_data() does not escape xfers->save_dir before giving
  it to the shell
- vdagent_file_xfers_data() does not check snprintf() return code; a
  too-long xfers->save_dir could cause the & or ' or any number of other
  characters to go missing.

To fix these issues, we use g_spawn_async(). This avoids the need to
quote the filename and also avoids the snprintf issue.

In the case that the spawn fails, we also print a warning to the syslog
now.

Signed-off-by: Jonathon Jongsma 
Acked-by: Frediano Ziglio 
---
 src/vdagent/file-xfers.c | 13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Index: spice-vdagent-0.17.0/src/vdagent-file-xfers.c
===
--- spice-vdagent-0.17.0.orig/src/vdagent-file-xfers.c
+++ spice-vdagent-0.17.0/src/vdagent-file-xfers.c
@@ -293,9 +293,16 @@ void vdagent_file_xfers_data(struct vdag
 if (xfers->open_save_dir &&
 task->file_xfer_nr == task->file_xfer_total &&
 g_hash_table_size(xfers->xfers) == 1) {
-char buf[PATH_MAX];
-snprintf(buf, PATH_MAX, "xdg-open '%s'&", xfers->save_dir);
-status = system(buf);
+GError *error = NULL;
+gchar *argv[] = { "xdg-open", xfers->save_dir, NULL };
+if (!g_spawn_async(NULL, argv, NULL,
+   G_SPAWN_SEARCH_PATH,
+   NULL, NULL, NULL, )) {
+syslog(LOG_WARNING,
+   "file-xfer: failed to open save directory: %s",
+   error->message);
+g_error_free(error);
+}
 }
 status = VD_AGENT_FILE_XFER_STATUS_SUCCESS;
 } else {

commit spice-vdagent for openSUSE:Factory

2017-08-28 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2017-08-28 16:17:23

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Mon Aug 28 16:17:23 2017 rev:11 rq:519134 version:0.17.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2017-03-12 20:03:01.130087155 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2017-08-28 16:17:24.292788554 +0200
@@ -1,0 +2,5 @@
+Thu Jul 27 12:20:36 UTC 2017 - msucha...@suse.com
+
+- Fix warning in vdagentd-do-endian-swapping.patch
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.BTcGu3/_old  2017-08-28 16:17:25.528614882 +0200
+++ /var/tmp/diff_new_pack.BTcGu3/_new  2017-08-28 16:17:25.552611509 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2017 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties

++ vdagentd-do-endian-swapping.patch ++
--- /var/tmp/diff_new_pack.BTcGu3/_old  2017-08-28 16:17:25.680593524 +0200
+++ /var/tmp/diff_new_pack.BTcGu3/_new  2017-08-28 16:17:25.692591838 +0200
@@ -717,3 +717,34 @@
 -- 
 2.10.2
 
+From 69e5fd82bf5d9282a640ae8f4069e3cd1bf6abb8 Mon Sep 17 00:00:00 2001
+From: Pavel Grunt 
+Date: Thu, 23 Mar 2017 12:26:28 +0100
+Subject: [PATCH] vdagentd: Handle VD_AGENT_CLIPBOARD_RELEASE
+
+In fact do nothing but avoid a runtime warning
+ vdagent_message_clipboard_from_le: code should not be reached
+
+Introduced in 99d9d3583143aef7143ec986cebe2980fdeeb776
+
+Acked-by: Victor Toso 
+---
+ src/vdagentd/vdagentd.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/vdagentd.c b/src/vdagentd.c
+index 954bba12cca8..aef5b9616318 100644
+--- a/src/vdagentd.c
 b/src/vdagentd.c
+@@ -410,6 +410,8 @@ static void 
vdagent_message_clipboard_from_le(VDAgentMessage *message_header,
+ case VD_AGENT_CLIPBOARD_GRAB:
+ virtio_msg_uint32_from_le(data, message_header->size, min_size);
+ break;
++case VD_AGENT_CLIPBOARD_RELEASE:
++break;
+ default:
+ g_warn_if_reached();
+ }
+-- 
+2.10.2
+

commit spice-vdagent for openSUSE:Factory

2017-03-12 Thread root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2017-03-12 20:03:00

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Sun Mar 12 20:03:00 2017 rev:10 rq:477557 version:0.17.0

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2016-12-02 16:43:46.0 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2017-03-12 20:03:01.130087155 +0100
@@ -1,0 +2,6 @@
+Mon Feb 20 13:56:35 UTC 2017 - msucha...@suse.com
+
+- Add endian swapping to run on BE guests (boo#1012215).
+  vdagentd-do-endian-swapping.patch
+
+---

New:

  vdagentd-do-endian-swapping.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.AfapH4/_old  2017-03-12 20:03:01.805991514 +0100
+++ /var/tmp/diff_new_pack.AfapH4/_new  2017-03-12 20:03:01.809990948 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX Products GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -26,6 +26,7 @@
 Url:http://spice-space.org/
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Patch0: spice-vdagent-var_run.patch
+Patch1: vdagentd-do-endian-swapping.patch
 BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
@@ -57,6 +58,7 @@
 %prep
 %setup -q
 %patch0 -p1
+%patch1 -p1
 
 %build
 %configure \

++ vdagentd-do-endian-swapping.patch ++
 719 lines (skipped)

commit spice-vdagent for openSUSE:Factory

2016-12-02 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2016-12-02 16:43:45

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2016-09-07 11:48:38.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2016-12-02 16:43:46.0 +0100
@@ -1,0 +2,25 @@
+Fri Nov 25 18:53:15 UTC 2016 - zai...@opensuse.org
+
+- Add pkgconfig(glib-2.0) BuildRequires: Explicit dependency.
+- Handle spice-vdagentd.target in pre/post/preun/postun.
+- Handle spice-vdagentd.conf in post via tmpfiles_create macro.
+
+---
+Fri Nov 25 18:53:14 UTC 2016 - seife+...@b1-systems.com
+
+- Update to 0.17.0
+  * Denies file-transfer in locked sessions
+  * Denies file-transfer in login screen
+  * Bump glib version to 2.28
+  * Set exit code to 1 instead of 0 when virtio device cannot be
+opened
+  * Fix double-free on uinput->screen_info (rhbz#1262635)
+  * Code improvement over unix domain client server support (udcs)
+  * Fix build compatiblity with different libsystemd versions
+(fdo#94209)
+- obsoleted patches removed:
+  8c465007-vdagentd-fixes-small-leak.patch
+  f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch
+- package: add explicit buildrequires for pkgconfig(dbus-1)
+
+---

Old:

  8c465007-vdagentd-fixes-small-leak.patch
  f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch
  spice-vdagent-0.16.0.tar.bz2

New:

  spice-vdagent-0.17.0.tar.bz2



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.x3ihrN/_old  2016-12-02 16:43:47.0 +0100
+++ /var/tmp/diff_new_pack.x3ihrN/_new  2016-12-02 16:43:47.0 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2016 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -18,7 +18,7 @@
 
 
 Name:   spice-vdagent
-Version:0.16.0
+Version:0.17.0
 Release:0
 Summary:Agent for Spice guests
 License:GPL-3.0+
@@ -26,9 +26,7 @@
 Url:http://spice-space.org/
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Patch0: spice-vdagent-var_run.patch
-Patch1: 8c465007-vdagentd-fixes-small-leak.patch
-Patch2: f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch
-BuildRequires:  alsa-devel
+BuildRequires:  alsa-devel  >= 1.0.22
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
 BuildRequires:  libXfixes-devel
@@ -36,9 +34,11 @@
 BuildRequires:  libXrandr-devel
 BuildRequires:  libpciaccess-devel
 BuildRequires:  libtool
-BuildRequires:  spice-protocol-devel >= 0.12.6
+BuildRequires:  spice-protocol-devel >= 0.12.8
 BuildRequires:  systemd
 BuildRequires:  systemd-devel
+BuildRequires:  pkgconfig(dbus-1)
+BuildRequires:  pkgconfig(glib-2.0) >= 2.28
 Supplements:modalias(xorg-x11-server:virtio:d0003v*)
 %{?systemd_requires}
 
@@ -57,8 +57,6 @@
 %prep
 %setup -q
 %patch0 -p1
-%patch1 -p1
-%patch2 -p1
 
 %build
 %configure \
@@ -83,18 +81,23 @@
 
 %pre
 %service_add_pre spice-vdagentd.service
+%service_add_pre spice-vdagentd.target
 
 %post
 %service_add_post spice-vdagentd.service
 if [ "$1" -eq 1 ]; then
 systemctl -q enable spice-vdagentd.service || :
 fi
+%service_add_post spice-vdagentd.target
+%tmpfiles_create %_tmpfilesdir/spice-vdagentd.conf
 
 %preun
 %service_del_preun spice-vdagentd.service
+%service_del_preun spice-vdagentd.target
 
 %postun
 %service_del_postun spice-vdagentd.service
+%service_del_postun spice-vdagentd.target
 
 %files
 %defattr(-,root,root)

++ spice-vdagent-0.16.0.tar.bz2 -> spice-vdagent-0.17.0.tar.bz2 ++
 3427 lines of diff (skipped)

commit spice-vdagent for openSUSE:Factory

2016-09-07 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2016-09-07 11:48:28

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2016-06-14 23:07:07.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2016-09-07 11:48:38.0 +0200
@@ -1,0 +2,7 @@
+Tue Sep  6 12:56:15 UTC 2016 - cbosdon...@suse.com
+
+- Fix crash when changing guest display's resolution (bsc#997236)
+  8c465007-vdagentd-fixes-small-leak.patch
+  f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch
+
+---

New:

  8c465007-vdagentd-fixes-small-leak.patch
  f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.YSAiEZ/_old  2016-09-07 11:48:40.0 +0200
+++ /var/tmp/diff_new_pack.YSAiEZ/_new  2016-09-07 11:48:40.0 +0200
@@ -26,6 +26,8 @@
 Url:http://spice-space.org/
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Patch0: spice-vdagent-var_run.patch
+Patch1: 8c465007-vdagentd-fixes-small-leak.patch
+Patch2: f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch
 BuildRequires:  alsa-devel
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
@@ -55,6 +57,8 @@
 %prep
 %setup -q
 %patch0 -p1
+%patch1 -p1
+%patch2 -p1
 
 %build
 %configure \

++ 8c465007-vdagentd-fixes-small-leak.patch ++
>From 8c465007b4baba5dc02adfda1c889ef4c1b595dc Mon Sep 17 00:00:00 2001
From: Victor Toso 
Date: Tue, 15 Sep 2015 10:24:53 +0200
Subject: [PATCH] vdagentd: fixes small leak

This correctly fixes the leak from reverted patch
4835df0b642dfc963e7

==2648== HEAP SUMMARY:
==2648== in use at exit: 104,699 bytes in 1,459 blocks
==2648==   total heap usage: 14,177 allocs, 12,718 frees, 1,190,456 bytes 
allocated
==2648==
==2648== 16 bytes in 1 blocks are definitely lost in loss record 16 of 130
==2648==at 0x4C29BCF: malloc (in 
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==2648==by 0x10B530: agent_read_complete (vdagentd.c:715)
==2648==by 0x10E8DC: udscs_read_complete (udscs.c:460)
==2648==by 0x10EAFC: udscs_do_read (udscs.c:515)
==2648==by 0x10E490: udscs_client_handle_fds (udscs.c:349)
==2648==by 0x10E402: udscs_server_handle_fds (udscs.c:337)
==2648==by 0x10BAB1: main_loop (vdagentd.c:844)
==2648==by 0x10A3E6: main (vdagentd.c:974)
==2648==
==2648== LEAK SUMMARY:
==2648== definitely lost: 16 bytes in 1 blocks
==2648== indirectly lost: 0 bytes in 0 blocks
==2648== possibly lost: 41,483 bytes in 1,268 blocks
==2648== still reachable: 63,200 bytes in 190 blocks
==2648== suppressed: 0 bytes in 0 blocks
==2648== Reachable blocks (those to which a pointer was found) are not 
shown.
==2648== To see them, rerun with: --leak-check=full --show-leak-kinds=all
---
 src/vdagentd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vdagentd.c b/src/vdagentd.c
index 14c5be1..8f7ab85 100644
--- a/src/vdagentd.c
+++ b/src/vdagentd.c
@@ -687,6 +687,7 @@ void agent_disconnect(struct udscs_connection *conn)
 agent_data->session = NULL;
 update_active_session_connection(NULL);
 
+free(agent_data->screen_info);
 free(agent_data);
 }
 
-- 
2.9.3

++ f97751fa-revert-uinput-fix-small-leak-of-screen_info.patch ++
>From f97751faf0f5c66ec5ccbf5547ca7982d360cbf9 Mon Sep 17 00:00:00 2001
From: Victor Toso 
Date: Tue, 15 Sep 2015 10:23:06 +0200
Subject: [PATCH] Revert "uinput: fix small leak of screen_info"

This reverts commit 4835df0b642dfc963e7cbaabfe93da86482f0b93.

uinput only holds reference to screen_info and should not free it.
The leak should be fixed somewhere else.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1262635
---
 src/vdagentd-uinput.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/vdagentd-uinput.c b/src/vdagentd-uinput.c
index 1ce9918..47e1b45 100644
--- a/src/vdagentd-uinput.c
+++ b/src/vdagentd-uinput.c
@@ -76,10 +76,6 @@ void vdagentd_uinput_destroy(struct vdagentd_uinput 
**uinputp)
 
 if (uinput->fd != -1)
 close(uinput->fd);
-
-if (uinput->screen_info != NULL)
-free(uinput->screen_info);
-
 free(uinput);
 *uinputp = NULL;
 }
-- 
2.9.3

commit spice-vdagent for openSUSE:Factory

2016-06-14 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2016-06-14 23:07:05

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is "spice-vdagent"

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2015-08-01 11:38:30.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2016-06-14 23:07:07.0 +0200
@@ -1,0 +2,5 @@
+Thu Jun  2 11:36:40 UTC 2016 - cbosdon...@suse.com
+
+- fate#320079
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.zPyqIU/_old  2016-06-14 23:07:08.0 +0200
+++ /var/tmp/diff_new_pack.zPyqIU/_new  2016-06-14 23:07:08.0 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX Products GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties

commit spice-vdagent for openSUSE:Factory

2015-08-01 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2015-08-01 11:38:29

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is spice-vdagent

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2014-07-16 16:22:14.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2015-08-01 11:38:30.0 +0200
@@ -1,0 +2,13 @@
+Tue Jul 21 18:52:21 UTC 2015 - mplus...@suse.com
+
+- Update tp 0.16.0
+  * Xspice support
+  * Release clipboard on client disconnect if owned by client 
+(rhbz#1003977)
+  * Turn some error messages into debugging messages (rhbz#918310)
+  * Not having the virtio channel is not an error; instead silently 
+do nothing
+- Cleanup spec file with spec-cleaner
+- Actually apply spice-vdagent-var_run.patch
+
+---

Old:

  spice-vdagent-0.15.0.tar.bz2

New:

  spice-vdagent-0.16.0.tar.bz2



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.fFMrlW/_old  2015-08-01 11:38:30.0 +0200
+++ /var/tmp/diff_new_pack.fFMrlW/_new  2015-08-01 11:38:30.0 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package spice-vdagent
 #
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
 # Copyright (c) 2014 B1 Systems GmbH, Vohburg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -18,7 +18,7 @@
 
 
 Name:   spice-vdagent
-Version:0.15.0
+Version:0.16.0
 Release:0
 Summary:Agent for Spice guests
 License:GPL-3.0+
@@ -26,6 +26,7 @@
 Url:http://spice-space.org/
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
 Patch0: spice-vdagent-var_run.patch
+BuildRequires:  alsa-devel
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
 BuildRequires:  libXfixes-devel
@@ -36,8 +37,8 @@
 BuildRequires:  spice-protocol-devel = 0.12.6
 BuildRequires:  systemd
 BuildRequires:  systemd-devel
-%{?systemd_requires}
 Supplements:modalias(xorg-x11-server:virtio:d0003v*)
+%{?systemd_requires}
 
 %description
 Spice agent for Linux guests offering the following features:
@@ -53,9 +54,12 @@
 
 %prep
 %setup -q
+%patch0 -p1
 
 %build
-%configure --with-session-info=systemd --with-init-script=systemd
+%configure \
+  --with-session-info=systemd \
+  --with-init-script=systemd
 make %{?_smp_mflags} V=2
 
 %install

++ spice-vdagent-0.15.0.tar.bz2 - spice-vdagent-0.16.0.tar.bz2 ++
 3331 lines of diff (skipped)
retrying with extended exclude list
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/spice-vdagent-0.15.0/Makefile.am new/spice-vdagent-0.16.0/Makefile.am
--- old/spice-vdagent-0.15.0/Makefile.am2013-10-14 14:52:01.0 
+0200
+++ new/spice-vdagent-0.16.0/Makefile.am2015-06-30 17:08:42.0 
+0200
@@ -4,9 +4,14 @@
 bin_PROGRAMS = src/spice-vdagent
 sbin_PROGRAMS = src/spice-vdagentd
 
-src_spice_vdagent_CFLAGS = $(X_CFLAGS) $(SPICE_CFLAGS) $(GLIB2_CFLAGS)
-src_spice_vdagent_LDADD = $(X_LIBS) $(SPICE_LIBS) $(GLIB2_LIBS)
-src_spice_vdagent_SOURCES = src/vdagent.c src/vdagent-x11.c 
src/vdagent-x11-randr.c src/vdagent-file-xfers.c src/udscs.c
+src_spice_vdagent_CFLAGS = $(X_CFLAGS) $(SPICE_CFLAGS) $(GLIB2_CFLAGS) 
$(ALSA_CFLAGS)
+src_spice_vdagent_LDADD = $(X_LIBS) $(SPICE_LIBS) $(GLIB2_LIBS) $(ALSA_LIBS)
+src_spice_vdagent_SOURCES = src/vdagent.c \
+src/vdagent-x11.c \
+src/vdagent-x11-randr.c \
+src/vdagent-file-xfers.c \
+src/vdagent-audio.c \
+src/udscs.c
 
 src_spice_vdagentd_CFLAGS = $(DBUS_CFLAGS) $(LIBSYSTEMD_LOGIN_CFLAGS) \
   $(PCIACCESS_CFLAGS) $(SPICE_CFLAGS) $(GLIB2_CFLAGS) $(PIE_CFLAGS)
@@ -30,6 +35,7 @@
 noinst_HEADERS = src/glib-compat.h \
  src/session-info.h \
  src/udscs.h \
+ src/vdagent-audio.h \
  src/vdagent-file-xfers.h \
  src/vdagent-virtio-port.h \
  src/vdagent-x11.h \
@@ -42,15 +48,15 @@
 xdgautostartdir = $(sysconfdir)/xdg/autostart
 xdgautostart_DATA = $(top_srcdir)/data/spice-vdagent.desktop

commit spice-vdagent for openSUSE:Factory

2014-07-16 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2014-07-16 16:19:42

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is spice-vdagent

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2014-07-10 14:55:27.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2014-07-16 16:22:14.0 +0200
@@ -1,0 +2,7 @@
+Wed Jul  9 16:21:19 UTC 2014 - fcro...@suse.com
+
+- Add supplements on virtio_console to automatically install
+  spice-vdagent when X11 server is installed on KVM with Spice
+  enabled.
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.4VwanG/_old  2014-07-16 16:22:16.0 +0200
+++ /var/tmp/diff_new_pack.4VwanG/_new  2014-07-16 16:22:16.0 +0200
@@ -37,6 +37,7 @@
 BuildRequires:  systemd
 BuildRequires:  systemd-devel
 %{?systemd_requires}
+Supplements:modalias(xorg-x11-server:virtio:d0003v*)
 
 %description
 Spice agent for Linux guests offering the following features:

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

commit spice-vdagent for openSUSE:Factory

2014-07-10 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2014-07-10 14:55:16

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is spice-vdagent

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2014-05-27 12:03:11.0 +0200
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2014-07-10 14:55:27.0 +0200
@@ -1,0 +2,6 @@
+Tue Jul  1 14:10:31 UTC 2014 - fcro...@suse.com
+
+- Enable systemd service at initial install, it is needed for
+  udev rules to properly start the agent.
+
+---



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.VRPtix/_old  2014-07-10 14:55:28.0 +0200
+++ /var/tmp/diff_new_pack.VRPtix/_new  2014-07-10 14:55:28.0 +0200
@@ -67,11 +67,19 @@
 # create rc symlink
 ln -s  service %{buildroot}%{_sbindir}/rcspice-vdagentd
 
+mkdir -p %{buildroot}%{_datadir}/gdm/greeter/autostart
+
+mv %{buildroot}%{_datadir}/gdm/autostart/LoginWindow/*.desktop 
%{buildroot}%{_datadir}/gdm/greeter/autostart
+rm -fr %{buildroot}%{_datadir}/gdm/autostart
+
 %pre
 %service_add_pre spice-vdagentd.service
 
 %post
 %service_add_post spice-vdagentd.service
+if [ $1 -eq 1 ]; then
+systemctl -q enable spice-vdagentd.service || :
+fi
 
 %preun
 %service_del_preun spice-vdagentd.service

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org

commit spice-vdagent for openSUSE:Factory

2014-05-27 Thread h_root 
Hello community,

here is the log from the commit of package spice-vdagent for openSUSE:Factory 
checked in at 2014-05-27 12:03:10

Comparing /work/SRC/openSUSE:Factory/spice-vdagent (Old)
 and  /work/SRC/openSUSE:Factory/.spice-vdagent.new (New)


Package is spice-vdagent

Changes:

--- /work/SRC/openSUSE:Factory/spice-vdagent/spice-vdagent.changes  
2014-02-06 06:55:22.0 +0100
+++ /work/SRC/openSUSE:Factory/.spice-vdagent.new/spice-vdagent.changes 
2014-05-27 12:03:11.0 +0200
@@ -1,0 +2,6 @@
+Tue May 27 08:45:45 CEST 2014 - oher...@suse.de
+
+- fix /var/run handling
+  spice-vdagent-var_run.patch
+
+---

New:

  spice-vdagent-var_run.patch



Other differences:
--
++ spice-vdagent.spec ++
--- /var/tmp/diff_new_pack.PqqFBv/_old  2014-05-27 12:03:13.0 +0200
+++ /var/tmp/diff_new_pack.PqqFBv/_new  2014-05-27 12:03:13.0 +0200
@@ -25,6 +25,7 @@
 Group:  Applications/System
 Url:http://spice-space.org/
 Source0:
http://spice-space.org/download/releases/%{name}-%{version}.tar.bz2
+Patch0: spice-vdagent-var_run.patch
 BuildRequires:  desktop-file-utils
 BuildRequires:  glib2-devel
 BuildRequires:  libXfixes-devel
@@ -78,7 +79,6 @@
 %postun
 %service_del_postun spice-vdagentd.service
 
-
 %files
 %defattr(-,root,root)
 %doc COPYING ChangeLog README TODO
@@ -91,7 +91,6 @@
 %{_bindir}/spice-vdagent
 %{_sbindir}/spice-vdagentd
 %{_sbindir}/rcspice-vdagentd
-%ghost %{_var}/run/spice-vdagentd
 %{_sysconfdir}/xdg/autostart/spice-vdagent.desktop
 # For /usr/share/gdm/autostart/LoginWindow/spice-vdagent.desktop
 # We own the dir too, otherwise we must Require gdm

++ spice-vdagent-var_run.patch ++
---
 Makefile.am |1 -
 Makefile.in |1 -
 data/spice-vdagentd |1 +
 data/spice-vdagentd.service |1 +
 4 files changed, 2 insertions(+), 2 deletions(-)

Index: spice-vdagent-0.15.0/Makefile.am
===
--- spice-vdagent-0.15.0.orig/Makefile.am
+++ spice-vdagent-0.15.0/Makefile.am
@@ -46,7 +46,6 @@ gdmautostartdir = $(datadir)/gdm/autosta
 gdmautostart_DATA = $(top_srcdir)/data/spice-vdagent.desktop
 
 install-data-local:
-   $(mkdir_p) $(DESTDIR)$(localstatedir)/run/spice-vdagentd
 
 rsyslogdir = $(sysconfdir)/rsyslog.d
 rsyslog_DATA = $(top_srcdir)/data/rsyslog.d/spice-vdagentd.conf
Index: spice-vdagent-0.15.0/Makefile.in
===
--- spice-vdagent-0.15.0.orig/Makefile.in
+++ spice-vdagent-0.15.0/Makefile.in
@@ -1366,7 +1366,6 @@ uninstall-am: uninstall-binPROGRAMS unin
 
 
 install-data-local:
-   $(mkdir_p) $(DESTDIR)$(localstatedir)/run/spice-vdagentd
 
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
Index: spice-vdagent-0.15.0/data/spice-vdagentd
===
--- spice-vdagent-0.15.0.orig/data/spice-vdagentd
+++ spice-vdagent-0.15.0/data/spice-vdagentd
@@ -37,6 +37,7 @@ start() {
 [ -x $exec ] || exit 5
 [ -c $port ] || exit 0
 modprobe uinput  /dev/null 21
+mkdir -p /var/run/spice-vdagentd
 # In case the previous running vdagentd crashed
 rm -f /var/run/spice-vdagentd/spice-vdagent-sock
 echo -n $Starting $prog: 
-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org