Re: [Openvpn-devel] OpenVPN 2.1_rc19 released

2009-07-16 Thread James Yonan

Matthias Andree wrote:

James Yonan schrieb:


2009.07.16 -- Version 2.1_rc19

...


* In configure.ac, use datadir instead of datarootdir for compatibility
   with 

Dear Jim,

This is backwards.  Please don't do that, but revert that change and
instead update the argument of AC_PREREQ in configure.ac to read this:
AC_PREREQ(2.60)

Since you're using autoconf/automake, configure.ac changes and
requirements have zero impact on end users who download the tarball that
you generate through "make dist". Such changes only affects developers
who want to hack configure.ac or use the SVN version, and you can simply
expect them to have an autoconf version no older than 36 months.

In my experience, newer autoconf versions are more portable, have less
bugs, and are good for a much smoother ride than older versions.

I'm happy to look into updating configure.ac, which in general needs an
overhaul anyways - unless you say "no configure.ac updates before 2.1
release".


We need to be able to build OpenVPN on older Linux distros, such as RHEL 
4, that use pre-2.60 versions of autoconf.


Before I made this change, I found that the previous code (using 
datarootdir instead of datadir on RHEL 4, autoconf-2.59-5) would 
generate a make install script that violated the --prefix argument -- 
i.e. make install would try to write stuff outside the --prefix dir.  I 
was running the make install as a non-root user, so the jailbreak out of 
--prefix was obvious because it tried to write to parts of the 
filesystem that generated "permission denied" errors and halted the script.


I'm not an autoconf/automake expert, so if there's a better way to fix 
the issue, I'm open to it.


James



Re: [Openvpn-devel] OpenVPN 2.1_rc19 released

2009-07-16 Thread Matthias Andree
James Yonan schrieb:

> 2009.07.16 -- Version 2.1_rc19
...

> * In configure.ac, use datadir instead of datarootdir for compatibility
>with 

[Openvpn-devel] OpenVPN 2.1_rc19 released

2009-07-16 Thread James Yonan
This release fixes an issue with the Windows TAP driver that can cause 
BSODs on Vista (normally seen in the OpenVPN client).  The problem is 
that Windows has always restricted kernel threads to a very small stack 
size (12KB on x86 32-bit).  If they go over this limit, Windows will 
crash with a BSOD.  Apparently Vista has added a bit more bloat to its 
kernel stack usage, and as a result, when the TAP driver is called, and 
then it in turn calls other kernel-level functions, there is a chance 
that the kernel stack can overflow in a particular sequence of code that 
is executed when the client initially connects and gets an IP address 
assignment from the server.  Apparently because XP is more efficient in 
its use of stack space, the same build of the TAP driver running on XP 
does not exhibit this defect.


2009.07.16 -- Version 2.1_rc19

* In Windows TAP driver, refactor DHCP/ARP packet injection code to
  use a DPC (deferred procedure call) to defer packet injection until
  IRQL < DISPATCH_LEVEL, rather than calling NdisMEthIndicateReceive
  in the context of AdapterTransmit.  This is an attempt to reduce kernel
  stack usage, and prevent EXCEPTION_DOUBLE_FAULT BSODs that have been
  observed on Vista.  Updated TAP driver version number to 9.6.

* In configure.ac, use datadir instead of datarootdir for compatibility
  with