Re: [Openvpn-devel] [PATCH] fix 2.2.0 build failure when management interface disabled

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 11/05/11 23:57, Matthew L. Creech wrote:
> Hi,
> 
> I just upgraded to 2.2.0, and my build fails with:
> 
> ps.c: In function 'port_share_open':
> ps.c:778:7: error: 'management' undeclared (first use in this function)
> ps.c:778:7: note: each undeclared identifier is reported only once for
> each function it appears in
> make[5]: *** [ps.o] Error 1
> 
> The attached patch fixed the problem.

Hi,

Thanks a lot for your patch.  Your patch is applied to master and
cherry-picked for the next 2.2 release.

commit 76ef46144f7e3ecc760dcb9f25a7ecb769d39c59 (master)
commit e7fa867d2685e6c455ce49042d4c0cbffdd68ff9 (release/2.2)
Author: Matthew L. Creech 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed May 11 17:57:28 2011 -0400

Mailing-list: http://thread.gmane.org/gmane.network.openvpn.devel/4639
Signed-off-by: Matthew L. Creech 
Acked-by: Gert Doering 
Signed-off-by: David Sommerseth 


Next time, please commit your patch to your local tree and mail a patch
file generated by 'git format-patch' (or use 'git send-email' directly).
That saves the time processing submitted patches.  For more info, see our
"Git Crash Course" [1].


kind regards,

David Sommerseth


[1] 
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk3VQlAACgkQDC186MBRfroUTACglKbhoSMlRzlTwg4MY0XiiQx/
RnoAoI6q5pHya/HHqOtlPjRKljQhNaoR
=OFBB
-END PGP SIGNATURE-

Re: [Openvpn-devel] +++ route.c 2011-05-18 09:15:17.000000000 +0200

[Peter Stuge]

David Sommerseth wrote:
> Please do a git commit -s to your local git tree (you have all rights to do
> so, its all on your own computer) then do 'git format-patch HEAD~1' and
> send the 0001-whatever-comes-here.patch via git send-email.

git send-email HEAD~1 # is shorthand for that


//Peter

[Openvpn-devel] Topics for today's meeting

[Samuli Seppänen]

Hi,

We're having an IRC meeting today, starting at 18:00 UTC on
#openvpn-de...@irc.freenode.net. Current topic list is here:



If you have any other things you'd like to bring up, respond to this
mail, send me mail privately or add them to the list yourself.

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

Re: [Openvpn-devel] +++ route.c 2011-05-18 09:15:17.000000000 +0200

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


In addition to Gert's comments, I would like to see a complete commit
patch.  It seems you just did "git diff | git send-email", which makes this
patch more difficult to apply.

Please do a git commit -s to your local git tree (you have all rights to do
so, its all on your own computer) then do 'git format-patch HEAD~1' and
send the 0001-whatever-comes-here.patch via git send-email.

When doing git commit -s, you need to put in an explanation/comment to your
commit.  First a short one-line summary, a blank line and a more verbose
description of why this change is needed.

But you might want to get answer Gert's comment before submitting a new patch.


Kind regards,

David Sommerseth


On 18/05/11 16:38, Xavier Franquet wrote:
>if (!r->defined)
>  return;
> @@ -1113,23 +1114,26 @@ add_route (struct route *r, const struct tuntap *tt, 
> unsigned int flags, const s
>  
>  #if defined(TARGET_LINUX)
>  #ifdef CONFIG_FEATURE_IPROUTE
> -  argv_printf (, "%s route add %s/%d via %s",
> +  argv_printf (, "%s route add %s/%d via %s dev %s",
> iproute_path,
> network,
> count_netmask_bits(netmask),
> -   gateway);
> +   gateway,
> +   device);
>if (r->metric_defined)
>  argv_printf_cat (, "metric %d", r->metric);
>  
>  #else
> -  argv_printf (, "%s add -net %s netmask %s gw %s",
> +  argv_printf (, "%s add -net %s netmask %s gw %s dev %s",
>   ROUTE_PATH,
> network,
> netmask,
> -   gateway);
> +   gateway,
> +   device);
>if (r->metric_defined)
>  argv_printf_cat (, "metric %d", r->metric);
>  #endif  /*CONFIG_FEATURE_IPROUTE*/
> +
>argv_msg (D_ROUTE, );
>status = openvpn_execve_check (, es, 0, "ERROR: Linux route add 
> command failed");
>  
> @@ -1452,6 +1456,7 @@ delete_route (const struct route *r, const struct 
> tuntap *tt, unsigned int flags
>const char *network;
>const char *netmask;
>const char *gateway;
> +  const char *device = tt->actual_name;
>  
>if (!r->defined)
>  return;
> @@ -1465,16 +1470,18 @@ delete_route (const struct route *r, const struct 
> tuntap *tt, unsigned int flags
>  
>  #if defined(TARGET_LINUX)
>  #ifdef CONFIG_FEATURE_IPROUTE
> -  argv_printf (, "%s route del %s/%d",
> +  argv_printf (, "%s route del %s/%d dev %s",
> iproute_path,
> network,
> -   count_netmask_bits(netmask));
> +   count_netmask_bits(netmask),
> +   device);
>  #else
>  
> -  argv_printf (, "%s del -net %s netmask %s",
> +  argv_printf (, "%s del -net %s netmask %s dev %s",
>   ROUTE_PATH,
> network,
> -   netmask);
> +   netmask,
> +   device);
>  #endif /*CONFIG_FEATURE_IPROUTE*/
>if (r->metric_defined)
>  argv_printf_cat (, "metric %d", r->metric);
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk3U81UACgkQDC186MBRfroMHwCgirtiLfD2eYx4kUd36m5URLAb
nUUAn05ktAbALzn21y5miaclKtMSs8tH
=j4/1
-END PGP SIGNATURE-