Re: [Openvpn-devel] [PATCH] Added client-ip option to NAT

2016-04-28 Thread Arne Schwabe 
Am 28.04.16 um 04:01 schrieb Rafael Gava:
> Hi Arne, 
> 
> what a surprise I thought that the NAT patch had been dropped. :-)

More or less forgotten. IIrc the active FTP part was controversal. This
part is okay.

> So, please, should I change the code based on your comments and resend
> the patch?

Yes, please.

Arne

[Openvpn-devel] [PATCH applied] Re: Implemented x509-track for PolarSSL.

2016-04-28 Thread Gert Doering 
Your patch has been applied to the master branch.

commit fab49d17d36053189cf504d57e53a8b0cb907f6f
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sat Mar 5 17:08:22 2016 +0100

 Implemented x509-track for PolarSSL.

 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id: 

 URL: http://article.gmane.org/gmane.network.openvpn.devel/11350
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering

[Openvpn-devel] [PATCH applied] Re: PolarSSL x509_get_sha1_hash now returns correct SHA1 fingerprint.

2016-04-28 Thread Gert Doering 
Your patch has been applied to the master branch.  

(Changes.rst had to be manually applied as it conflicted with an 
intermediate change)

commit dd2fbc26eb7b32325793ae3f7d215f46e881e68c (master)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Mon Apr 4 21:59:38 2016 +0200

 PolarSSL x509_get_sha1_hash now returns correct SHA1 fingerprint.

 Signed-off-by: James Yonan 
 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id:

Re: [Openvpn-devel] [PATCH 07/10] Implemented x509-track for PolarSSL.

2016-04-28 Thread Arne Schwabe 
Am 09.03.16 um 00:10 schrieb Steffan Karger:
> Hi,
> 
> This addition is welcome and the code does the job it promises to do,
> but after reviewing the code I would like to propose a different
> implementation.  The reasons for this are gives as inline replies
> below.  The alternative patch proposal is attached.

Code looks good to me, ACK.

Arne