Re: [Openvpn-devel] [PATCH] Remove 1 second delay before running netsh
Hi! I've sent a new patch that uses management_sleep(0) instead. I've also added your explanation why management_sleep(0) is used. Regards, Domagoj On Mon, Dec 21, 2020 at 10:06:57AM +0200, Lev Stipakov wrote: > Hi, > > > Lev: do you have a particular opinion on this change? You do more > > testing with wintun... > > Wintun uses iservice where we don't have those delays. > > I tend to agree with Vladislav (themiron), let's use management_sleep(0) which > processes any pending actions on the management interface without any wait. > > -Lev ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH v2] Remove 1 second delay before running netsh
When running various netsh commands before each 1 second sleep is added.
As more netsh commands are run, especially for Wintun adapters, that can
add to a noticable delayed connecting time.
This should be safe. No problems were found in tests and all netsh
commands executed properly with delay removed. Also, no delays are used
in a similar code in interactive service and netsh command executions
are guarded with a semaphore.
Instead of removing management_sleep(1), management_sleep(0) is used as
a replacement to allow processing any pending actions on the management
interface without any wait.
Signed-off-by: Domagoj Pensa
---
src/openvpn/tun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 400a50ca..0751ae46 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -5207,7 +5207,7 @@ netsh_command(const struct argv *a, int n, int msglevel)
for (i = 0; i < n; ++i)
{
bool status;
-management_sleep(1);
+management_sleep(0);
netcmd_semaphore_lock();
argv_msg_prefix(M_INFO, a, "NETSH");
status = openvpn_execve_check(a, NULL, 0, "ERROR: netsh command
failed");
--
2.29.2
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] Travis-ci is changing billing
we can move to Github Actions. or to Azure Pipelines both support amd64 linux / osx / windows, very versatile setup. unfortunately, no support for s390, arm64, ppc64le (unless own build agents attached) чт, 24 дек. 2020 г. в 06:42, tincanteksup : > > > On 23/12/2020 18:03, Илья Шипицин wrote: > > On Wed, Dec 23, 2020, 10:42 PM Gert Doering wrote: > > > >> Hi, > >> > >> On Wed, Dec 23, 2020 at 04:06:26PM +, tincanteksup wrote: > >>> This may help shed some light: > >>> > >>> https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing > >> > >> I'm more confused than before. So is what we do still free? Do we > >> need to apply somewhere? > >> > > > > It is one time 1000 minutes free tier. > > Once it is used the free game is over. > > > > In theory we can contact and ask for permanent OSS free limit, but Travis > > did not reply to anybody > > > > > > Travis did claim "abuse" as their reasoning, which sounds feasible. > > On the up-side, builds do seem to be faster :-) > > > > > > > > >> Do we do MacOS builds? If yes, we might consider removing them (we > >> do have a MacOS buildslave)... > >> > >> gert > >> -- > >> "If was one thing all people took for granted, was conviction that if > you > >> feed honest figures into a computer, honest figures come out. Never > >> doubted > >> it myself till I met a computer with a sense of humor." > >> Robert A. Heinlein, The Moon is a Harsh > >> Mistress > >> > >> Gert Doering - Munich, Germany > >> g...@greenie.muc.de > >> ___ > >> Openvpn-devel mailing list > >> Openvpn-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/openvpn-devel > >> > > > ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
