[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions
Attention is currently required from: cron2, flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions .. Patch Set 5: (1 comment) File tests/unit_tests/openvpn/test_buffer.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/4a0f4211_d038f0d1 : PS4, Line 401: #pragma GCC diagnostic pop > yeah, although it seems work this way as well. Will fix. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac Gerrit-Change-Number: 547 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Fri, 03 May 2024 16:48:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions
Attention is currently required from: cron2, flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions .. Patch Set 4: (2 comments) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/aac61c1c_be6f9120 : PS4, Line 966: > Why this spurious change? What do you mean with spurious? It changes openvpn_snprintf to snprintf File tests/unit_tests/openvpn/test_buffer.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/e325e787_1f2bea7f : PS4, Line 401: #pragma GCC diagnostic pop > Should that be "clang" instead of "GCC"? yeah, although it seems work this way as well. Will fix. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac Gerrit-Change-Number: 547 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Fri, 03 May 2024 16:44:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions .. Patch Set 4: Code-Review-1 (2 comments) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/44a4b5a4_ab3ddf72 : PS4, Line 966: Why this spurious change? File tests/unit_tests/openvpn/test_buffer.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/9f564a6c_9986bda3 : PS4, Line 401: #pragma GCC diagnostic pop Should that be "clang" instead of "GCC"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac Gerrit-Change-Number: 547 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: ordex Gerrit-Comment-Date: Fri, 03 May 2024 15:49:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
