Re: [Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

[Gert Doering]

Hi,

On Wed, Aug 01, 2018 at 01:21:35AM +0800, Antonio Quartulli wrote:
> On 21/11/17 09:43, selva.n...@gmail.com wrote:
> > From: Selva Nair 
> > 
> > - This is an opaque pointer so the change should not affect
> >   existing plugins. But it makes the code consistent and clears up
> >   the documentation as the handle pointer is treated as of type
> >   "openvpn_plugin_handle_t" in the rest of the code.
> > 
> > Signed-off-by: Selva Nair 
> 
> Will make some noise during application (git pw patch apply 87), such as:
> "Falling back to patching base and 3-way merge..."
> 
> But it won't generate any conflict.
> 
> Acked-by: Antonio Quartulli 

Oh, we had the patch on the list already.  Thanks for finding it & ACK.

I'll apply tomorrow or thursday, on the road right now.

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
 Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany g...@greenie.muc.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

[Antonio Quartulli]

Hi,

On 21/11/17 09:43, selva.n...@gmail.com wrote:
> From: Selva Nair 
> 
> - This is an opaque pointer so the change should not affect
>   existing plugins. But it makes the code consistent and clears up
>   the documentation as the handle pointer is treated as of type
>   "openvpn_plugin_handle_t" in the rest of the code.
> 
> Signed-off-by: Selva Nair 

Will make some noise during application (git pw patch apply 87), such as:
"Falling back to patching base and 3-way merge..."

But it won't generate any conflict.

Acked-by: Antonio Quartulli 



-- 
Antonio Quartulli



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

[selva . nair]

From: Selva Nair 

- This is an opaque pointer so the change should not affect
  existing plugins. But it makes the code consistent and clears up
  the documentation as the handle pointer is treated as of type
  "openvpn_plugin_handle_t" in the rest of the code.

Signed-off-by: Selva Nair 
---
 v2: no change

 include/openvpn-plugin.h.in | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/openvpn-plugin.h.in b/include/openvpn-plugin.h.in
index f29b3a0..dfc8e1e 100644
--- a/include/openvpn-plugin.h.in
+++ b/include/openvpn-plugin.h.in
@@ -355,7 +355,7 @@ struct openvpn_plugin_args_open_in
  *  type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_CONNECT)
  * | 
OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_DISCONNECT)
  *
- * *handle :Pointer to a global plug-in context, created by the plug-in.  
This pointer
+ * handle : Pointer to a global plug-in context, created by the plug-in.  
This pointer
  *  is passed on to the other plug-in calls.
  *
  * return_list : used to return data back to OpenVPN.
@@ -364,7 +364,7 @@ struct openvpn_plugin_args_open_in
 struct openvpn_plugin_args_open_return
 {
 int type_mask;
-openvpn_plugin_handle_t *handle;
+openvpn_plugin_handle_t handle;
 struct openvpn_plugin_string_list **return_list;
 };
 
@@ -386,9 +386,9 @@ struct openvpn_plugin_args_open_return
  *these variables are not actually written to the "official"
  *environmental variable store of the process.
  *
- * *handle : Pointer to a global plug-in context, created by the plug-in's 
openvpn_plugin_open_v3().
+ * handle : Pointer to a global plug-in context, created by the plug-in's 
openvpn_plugin_open_v3().
  *
- * *per_client_context : the per-client context pointer which was returned by
+ * per_client_context : the per-client context pointer which was returned by
  *openvpn_plugin_client_constructor_v1, if defined.
  *
  * current_cert_depth : Certificate depth of the certificate being passed over 
(only if compiled with ENABLE_CRYPTO defined)
-- 
2.1.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

[selva . nair]

From: Selva Nair 

- This is an opaque pointer so the change should not affect existing plugins.
  But it makes the code consistent and clears up the documentation as the handle
  pointer is treated as of type "openvpn_plugin_handle_t" in the rest of the 
code.

Signed-off-by: Selva Nair 
---
 include/openvpn-plugin.h.in | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/openvpn-plugin.h.in b/include/openvpn-plugin.h.in
index 5e6f874..b745307 100644
--- a/include/openvpn-plugin.h.in
+++ b/include/openvpn-plugin.h.in
@@ -355,7 +355,7 @@ struct openvpn_plugin_args_open_in
  *  type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_CONNECT)
  * | 
OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_DISCONNECT)
  *
- * *handle :Pointer to a global plug-in context, created by the plug-in.  
This pointer
+ * handle : Pointer to a global plug-in context, created by the plug-in.  
This pointer
  *  is passed on to the other plug-in calls.
  *
  * return_list : used to return data back to OpenVPN.
@@ -364,7 +364,7 @@ struct openvpn_plugin_args_open_in
 struct openvpn_plugin_args_open_return
 {
 int type_mask;
-openvpn_plugin_handle_t *handle;
+openvpn_plugin_handle_t handle;
 struct openvpn_plugin_string_list **return_list;
 };
 
@@ -386,9 +386,9 @@ struct openvpn_plugin_args_open_return
  *these variables are not actually written to the "official"
  *environmental variable store of the process.
  *
- * *handle : Pointer to a global plug-in context, created by the plug-in's 
openvpn_plugin_open_v3().
+ * handle : Pointer to a global plug-in context, created by the plug-in's 
openvpn_plugin_open_v3().
  *
- * *per_client_context : the per-client context pointer which was returned by
+ * per_client_context : the per-client context pointer which was returned by
  *openvpn_plugin_client_constructor_v1, if defined.
  *
  * current_cert_depth : Certificate depth of the certificate being passed over 
(only if compiled with ENABLE_CRYPTO defined)
-- 
2.1.4


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel