Re: [Openvpn-devel] [PATCH] resolvconf fails with -p

2021-11-06 Thread Greg Cox
On Sat, Nov 6, 2021 at 7:37 PM David Sommerseth <
open...@sf.lists.topphemmelig.net> wrote:

> I quickly checked resolveconf on Ubuntu {18,20,21}.04 and Debian 9-11.
> Neither of them supports the '-p' argument.
>
> I've checked Fedora 34, RHEL-{7,8} too, where I could not find any
> obvious alternative to the old version of resolvconf tool.  On RHEL-8
> and Fedora, systemd-resolved is available and provides a different
> resolveconf which targets to replace this old utility.  This replacement
> neither support '-p'.
>
> This option got added in commit 3adf2f558e157ef508 back in 2010, but
> there's too little information why it was needed back then.  But given
> that neither relevant Linux distributions supports this option today,
> it's reasonable to remove it now.
>

Openresolv uses it, and Arch offers that package.
https://github.com/NetworkConfiguration/openresolv/blob/master/resolvconf.in#L108
has a -p

That's my best guess where this came from.  And then, since this is off
buried in 'contrib', "nobody" noticed it for years.

(I don't disagree with removing it, I just like forensics).
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


Re: [Openvpn-devel] [PATCH] resolvconf fails with -p

2021-11-06 Thread David Sommerseth

On 29/05/2021 03:35, sergio wrote:

From: "Sergio E. Nemirowski" 

resolvconf -p
resolvconf: Error: Command not recognized

Signed-off-by: Sergio E. Nemirowski 
---
  contrib/pull-resolv-conf/client.up | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/pull-resolv-conf/client.up 
b/contrib/pull-resolv-conf/client.up
index f0769740..220aeb74 100644
--- a/contrib/pull-resolv-conf/client.up
+++ b/contrib/pull-resolv-conf/client.up
@@ -91,7 +91,7 @@ out="# resolv.conf autogenerated by ${0} 
(${dev})${nl}${dns}${ds}${domains}"
  
  # use resolvconf if it's available

  if type resolvconf >/dev/null 2>&1; then
-  printf "%s\n" "${out}" | resolvconf -p -a "${dev}"
+  printf "%s\n" "${out}" | resolvconf -a "${dev}"
  else
# Preserve the existing resolv.conf
if [ -e /etc/resolv.conf ] ; then



I quickly checked resolveconf on Ubuntu {18,20,21}.04 and Debian 9-11. 
Neither of them supports the '-p' argument.


I've checked Fedora 34, RHEL-{7,8} too, where I could not find any 
obvious alternative to the old version of resolvconf tool.  On RHEL-8 
and Fedora, systemd-resolved is available and provides a different 
resolveconf which targets to replace this old utility.  This replacement 
neither support '-p'.


This option got added in commit 3adf2f558e157ef508 back in 2010, but 
there's too little information why it was needed back then.  But given 
that neither relevant Linux distributions supports this option today, 
it's reasonable to remove it now.


Acked-By: David Sommerseth 

--
kind regards,

David Sommerseth
OpenVPN Inc



OpenPGP_signature
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


Re: [Openvpn-devel] [PATCH] resolvconf fails with -p

2021-05-29 Thread sergio




Which platform does this fail on?  The fact that the -p is currently there
hints at "on some other platforms this works and is useful"...


Debian bullseye & sid, v1.87



--
sergio.


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


Re: [Openvpn-devel] [PATCH] resolvconf fails with -p

2021-05-29 Thread Gert Doering
Hi,

On Sat, May 29, 2021 at 04:35:16AM +0300, sergio wrote:
> From: "Sergio E. Nemirowski" 
> 
> resolvconf -p
> resolvconf: Error: Command not recognized

Which platform does this fail on?  The fact that the -p is currently there
hints at "on some other platforms this works and is useful"...

gert
-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
 Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany g...@greenie.muc.de


signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [PATCH] resolvconf fails with -p

2021-05-28 Thread sergio
From: "Sergio E. Nemirowski" 

resolvconf -p
resolvconf: Error: Command not recognized

Signed-off-by: Sergio E. Nemirowski 
---
 contrib/pull-resolv-conf/client.up | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/pull-resolv-conf/client.up 
b/contrib/pull-resolv-conf/client.up
index f0769740..220aeb74 100644
--- a/contrib/pull-resolv-conf/client.up
+++ b/contrib/pull-resolv-conf/client.up
@@ -91,7 +91,7 @@ out="# resolv.conf autogenerated by ${0} 
(${dev})${nl}${dns}${ds}${domains}"
 
 # use resolvconf if it's available
 if type resolvconf >/dev/null 2>&1; then
-  printf "%s\n" "${out}" | resolvconf -p -a "${dev}"
+  printf "%s\n" "${out}" | resolvconf -a "${dev}"
 else
   # Preserve the existing resolv.conf
   if [ -e /etc/resolv.conf ] ; then
-- 
2.32.0.rc0



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel