Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

[Selva Nair]

On Fri, Dec 2, 2016 at 6:28 AM, Gert Doering  wrote:

> On Thu, Dec 01, 2016 at 05:25:49PM -0500, Selva Nair wrote:
> > Do we want this in 2.3.14 as well ? If so I'll send a patch with service
> > part removed (note to self: remember to include docs and Changes.rst
> edits)
>
> My gut feeling is "leave 2.3 as it is, this could actually be *necessary*
> on XP".
>
> We're so close to 2.4 release that telling windows users that run into
> this issue to "just upgrade to 2.4, it will no longer restart dnscache
> *and* brings lots of more goodness anyway!" can be done with good faith.


Agreed. Also, on further thought, 2.3 needs to run openvpn as admin, so
replacing --register-dns with a script is a viable option for those who do
not want dns service restart.

Selva
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

[Gert Doering]

Hi,

On Thu, Dec 01, 2016 at 05:25:49PM -0500, Selva Nair wrote:
> Do we want this in 2.3.14 as well ? If so I'll send a patch with service
> part removed (note to self: remember to include docs and Changes.rst edits)

My gut feeling is "leave 2.3 as it is, this could actually be *necessary* 
on XP".

We're so close to 2.4 release that telling windows users that run into
this issue to "just upgrade to 2.4, it will no longer restart dnscache
*and* brings lots of more goodness anyway!" can be done with good faith.

It's not like we've had tons of bug reports about that so far...

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

[Selva Nair]

Hi,

On Thu, Dec 1, 2016 at 3:21 AM, Gert Doering  wrote:

> ACK, thanks.
>
> Code looks good, and test compiles.  Have not test-run yet but do not
> expect any surprises there.
>
> I have added a Changes.rst entry (someone *might* notice and wonder if
> this was intentional :) ) and updated doc/openvpn.8 and the help text
> in options.c which both used to list all the commands run...
>
> Your patch has been applied to the master branch.
>

Do we want this in 2.3.14 as well ? If so I'll send a patch with service
part removed (note to self: remember to include docs and Changes.rst edits)

Selva
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

[Gert Doering]

ACK, thanks.

Code looks good, and test compiles.  Have not test-run yet but do not
expect any surprises there.

I have added a Changes.rst entry (someone *might* notice and wonder if
this was intentional :) ) and updated doc/openvpn.8 and the help text
in options.c which both used to list all the commands run...

Your patch has been applied to the master branch.

commit fb56058a98dcc81b34cffbdc46417d672b8926e1
Author: Selva Nair
Date:   Wed Nov 30 16:51:36 2016 -0500

 Do not restart dns client service as a part of --register-dns processing

 Signed-off-by: Selva Nair 
 Acked-by: Gert Doering 
 Message-Id: <1480542696-7123-1-git-send-email-selva.n...@gmail.com>
 URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13331.html
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering


--
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel