Re: [Openvpn-devel] [PATCH] OpenSolaris/OpenIllumos: use /bin/bash if available for test scripts.

2019-10-10 Thread David Sommerseth
On 09/10/2019 14:00, Gert Doering wrote:
> t_client.sh relies on "echo -e" and "echo -n" to produce nicely
> looking output, which fails on Solaris /bin/sh - force SHELL=/bin/bash
> on recent-enough Solaris variants that have it.
> 
> Signed-off-by: Gert Doering 
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index c7fd7a84..4159e450 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -306,6 +306,7 @@ case "$host" in
>   AC_DEFINE([TARGET_SOLARIS], [1], [Are we running on Solaris?])
>   AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["S"], [Target prefix])
>   CPPFLAGS="$CPPFLAGS -D_XPG4_2"
> + test -x /bin/bash && SHELL="/bin/bash"
>   ;;
>   *-*-openbsd*)
>   AC_DEFINE([TARGET_OPENBSD], [1], [Are we running on OpenBSD?])
> 

I have not tested this (don't have access to Solaris environments), but looks
like a reasonable solution.

Acked-By: David Sommerseth 

-- 
kind regards,

David Sommerseth
OpenVPN Inc




signature.asc
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


Re: [Openvpn-devel] [PATCH] OpenSolaris/OpenIllumos: use /bin/bash if available for test scripts.

2019-10-09 Thread Casper . Dik


>t_client.sh relies on "echo -e" and "echo -n" to produce nicely
>looking output, which fails on Solaris /bin/sh - force SHELL=/bin/bash
>on recent-enough Solaris variants that have it.


Where recent is "Solaris 8 or later"

I.e., just under 20 years old. :-)

Can't tell how which version of bash it was shipped with, though...

Casper



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel