Re: [OpenWrt-Devel] changeset 40948 breaks loading ath9k calibration data from EEPROM

2014-06-15 Thread John Crispin


On 14/06/2014 23:08, José Vázquez wrote:
 The main problem with the wifi in the Lantiq target are the ARV 
 boards: a lot of people, John included, spent a lot of time an
 still there are some problems, as you see.

bollocks .. i never spent any time on that code. i don't even have the
boards so i cannot test which is why its most likely why its broken.
if people had spend that much time on the code it would be woring and
not ugly and broken.

as for the patches you sent, they were not merged because they are a
big pile of copy pasta churn that adds lots of redunancy and
duplication. it would make the code even uglier than it is now.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 0/4] dnsmasq: DNSSEC support

2014-06-15 Thread Steven Barth

Hi Andre,

could you please add nettle-mini support and make this a build variant 
instead of a config option, please?
Build variant has the advantage that we can precompile it as ipks 
because we cannot enable dnssec by default.


Otherwise thanks for your work.


Cheers,

Steven
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] changeset 40948 breaks loading ath9k calibration data from EEPROM

2014-06-15 Thread José Vázquez
2014-06-15 8:03 GMT+02:00, John Crispin j...@phrozen.org:


 On 14/06/2014 23:08, José Vázquez wrote:
 The main problem with the wifi in the Lantiq target are the ARV
 boards: a lot of people, John included, spent a lot of time an
 still there are some problems, as you see.

 bollocks .. i never spent any time on that code. i don't even have the
 boards so i cannot test which is why its most likely why its broken.
 if people had spend that much time on the code it would be woring and
 not ugly and broken.

 as for the patches you sent, they were not merged because they are a
 big pile of copy pasta churn that adds lots of redundancy and
 duplication. it would make the code even uglier than it is now.

You are right: those patches had a lot of redundant code. I will take
more care next time, but the original code was not mine.
I have a question flying around my head: why nobody realized, apart of
you, the potential problems of those patches and the redundant code,
and told something to improve them?

My apologies:

José Vázquez
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] lantiq BTHOMEHUBV2B - update dts for automatic detection of ubi partition and rootfs type

2014-06-15 Thread Ben Mulvihill

This patches the BTHOMEHUB2B device tree to make use of the
new code for automatic detection of the ubi partition and the
rootfs type within it. Gets rid of the ugly alternative bootargs
lines.


Signed-off-by: Ben Mulvihill ben.mulvih...@gmail.com

---

--- a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts  2014-06-14 07:24:27.022339541 
+0200
+++ b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts  2014-06-15 06:56:30.578024477 
+0200
@@ -6,10 +6,7 @@
model = BTHOMEHUBV2B - BT Home Hub 2B;  /* SoC: Lantiq Danube-S PSB 
50712 @ 333MHz V1.3/1.5 */
 
chosen {
-   // uncomment for overlayfs on top of ubi
-   bootargs = console=ttyLTQ0,115200 init=/etc/preinit 
ubi.mtd=rootfs_ubi,256 root=/dev/mtdblock8;
-   // uncomment for ubifs
-// bootargs = console=ttyLTQ0,115200 init=/etc/preinit 
ubi.mtd=rootfs_ubi,256 root=ubi0:rootfs rootfstype=ubifs;
+   bootargs = console=ttyLTQ0,115200 init=/etc/preinit;
};
 
memory@0 {/* RAM: Samsung K4H511638F-LC 
64MB */
@@ -88,7 +85,7 @@
};
 
partition@164000 {
-   label = rootfs_ubi;
+   label = ubi;
reg = 0x164000 0x1E9C000;
};
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] lantiq BTHOMEHUBV2B - update dts for automatic detection of ubi partition and rootfs type

2014-06-15 Thread Daniel
Looks good.

On 06/15/2014 05:01 PM, Ben Mulvihill wrote:
 This patches the BTHOMEHUB2B device tree to make use of the
 new code for automatic detection of the ubi partition and the
 rootfs type within it. Gets rid of the ugly alternative bootargs
 lines.
 
 
 Signed-off-by: Ben Mulvihill ben.mulvih...@gmail.com
Acked-by: Daniel Golle dan...@makrotopia.org
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 0/4] dnsmasq: DNSSEC support

2014-06-15 Thread Yousong Zhou
On 15 June 2014 17:13, Steven Barth cy...@openwrt.org wrote:
 Hi Andre,

 could you please add nettle-mini support and make this a build variant
 instead of a config option, please?
 Build variant has the advantage that we can precompile it as ipks because we
 cannot enable dnssec by default.

There exists need for compilation with the combination of multiple
features enabled.  With dnssec and dhcpv6, 4 variants are needed to
cover all the possibilities.  So I prefer keeping them in the form of
configurable options as there are other features in dnsmasq to be
enabled like ipset support, and serious users would enable/compile on
their own.


yousong


 Otherwise thanks for your work.


 Cheers,

 Steven

 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel