[OpenWrt-Devel] [PATCHv2] 6rd: Remove sourcerouting parameter registration
Commit 31214c38c8dd0f70366b523f9b0335145b9386bd removes IPv6 unneeded source-dest-routing workarounds; as a result sourcerouting parameter is unused and can be removed. Signed-off-by: Hans Dedecker dedec...@gmail.com --- package/network/ipv6/6rd/files/6rd.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6rd/files/6rd.sh b/package/network/ipv6/6rd/files/6rd.sh index 6c68b3b..62d35b6 100644 --- a/package/network/ipv6/6rd/files/6rd.sh +++ b/package/network/ipv6/6rd/files/6rd.sh @@ -94,7 +94,6 @@ proto_6rd_init_config() { proto_config_add_string ip6prefixlen proto_config_add_string ip4prefixlen proto_config_add_string tunlink - proto_config_add_boolean sourcerouting proto_config_add_string zone } -- 1.9.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCHv2] 6to4: Remove sourcerouting parameter registration
Commit 31214c38c8dd0f70366b523f9b0335145b9386bd removes IPv6 unneeded source-dest-routing workarounds; as a result sourcerouting parameter is unused and can be removed. Signed-off-by: Hans Dedecker dedec...@gmail.com --- package/network/ipv6/6to4/files/6to4.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6to4/files/6to4.sh b/package/network/ipv6/6to4/files/6to4.sh index 57efc52..a5d0567 100755 --- a/package/network/ipv6/6to4/files/6to4.sh +++ b/package/network/ipv6/6to4/files/6to4.sh @@ -91,7 +91,6 @@ proto_6to4_init_config() { proto_config_add_int mtu proto_config_add_int ttl proto_config_add_string tos - proto_config_add_boolean sourcerouting } [ -n $INCLUDE_ONLY ] || { -- 1.9.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] strongswan CVE-2015-3991 CVE-2015-4171
Thanks for the hint, I updated the package-definitions. Cheers, Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 2/3] 6to4: Remove sourcerouting parameter registration
Hi, On Wed, Jun 10, 2015 at 10:39 AM, Hans Dedecker dedec...@gmail.com wrote: Signed-off-by: Hans Dedecker dedec...@gmail.com Please don't submit patches with empty commit logs. Why is it okay to remove it? Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 1/3] 6rd: Remove sourcerouting parameter registration
Hi, On Wed, Jun 10, 2015 at 10:39 AM, Hans Dedecker dedec...@gmail.com wrote: Signed-off-by: Hans Dedecker dedec...@gmail.com Please don't submit patches with empty commit logs. Why is it okay to remove it? Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] grub2: disable stack-protector
Hi, On Tue, Jun 9, 2015 at 12:14 PM, Dirk Neukirchen dirkneukirc...@web.de wrote: - enabling -fstack-protector results in build errors - Upstream explicitly tests disables it reference: upstream commit baa2a121e004a95a12e2bb7f2419de6625a30c2d Signed-off-by: Dirk Neukirchen dirkneukirc...@web.de --- package/boot/grub2/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/package/boot/grub2/Makefile b/package/boot/grub2/Makefile index 64a3058..ca59a87 100644 --- a/package/boot/grub2/Makefile +++ b/package/boot/grub2/Makefile @@ -43,6 +43,10 @@ define Package/grub2-editenv/description Edit grub2 environment files. endef +ifeq ($(strip $(PKG_CC_STACKPROTECTOR_REGULAR)),1) + TARGET_CFLAGS := $(filter-out -fstack-protector,$(TARGET_CFLAGS)) +endif + Why not just filter it out unconditionally? If -fstack-protecor isn't present in the CFLAGS it's just a nop. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 2/3] 6to4: Remove sourcerouting parameter registration
It's fine, he's just cleaning up after me *ducks and hides*. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
Hello Bastian, i like the idea, but please use at least: command . $i or ( . $i ) I think this will not work, as /etc/profile (and these additional files) is expected to be executed in the current shell context. Otherwise adding shell variables or extending $PATH will not work. So you cannot execute them in a subshell. otherwise a syntax error / file error will prevent a login. Maybe it is possible to skip this for FAILSAFE mode? If there are errors, they can be corrected in this way. also use the unofficial simplified OpenWrt style here, it is OK to: for FILE in /etc/profile.d/*; do [ -e $FILE ] ( . $FILE ) done The same issue with subshell... i'am also unsure if 'unset FILE' is maybe overkill... bye, bastian Best Regards, Thomas --- There are two hard things in computer science: cache invalidation, naming things, and off-by-one errors. --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
OpenWrt should support an optinal /etc/profile.d directory like most other Linux distributions. This allows packages to install their own scripts into /etc/profile.d/. --- package/base-files/files/etc/profile | 9 + 1 file changed, 9 insertions(+) diff --git a/package/base-files/files/etc/profile b/package/base-files/files/etc/profile index 3dd58e1..c9e805f 100644 --- a/package/base-files/files/etc/profile +++ b/package/base-files/files/etc/profile @@ -14,3 +14,12 @@ export PS1='\u@\h:\w\$ ' [ -x /usr/bin/arp ] || arp() { cat /proc/net/arp; } [ -x /usr/bin/ldd ] || ldd() { LD_TRACE_LOADED_OBJECTS=1 $*; } + +if [ -d /etc/profile.d ]; then + for i in /etc/profile.d/* ; do +if [ -r $i ]; then + . $i +fi + done + unset i +fi -- 2.4.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
* Hendrik Lüth hend...@linux-nerds.de [10.06.2015 12:58]: + for i in /etc/profile.d/* ; do +if [ -r $i ]; then + . $i +fi + done + unset i +fi i like the idea, but please use at least: command . $i or ( . $i ) otherwise a syntax error / file error will prevent a login. also use the unofficial simplified OpenWrt style here, it is OK to: for FILE in /etc/profile.d/*; do [ -e $FILE ] ( . $FILE ) done i'am also unsure if 'unset FILE' is maybe overkill... bye, bastian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] Openwrt on RB850gx2
Hi I need information regarding rb850gx2 which i unable to find online. I am trying to find out whether rb850gx2 supports openwrt platform or not. I checked openwrt website to know about the same but it looks like they have not updated regarding the device yet. Can anybody provide the required information about the device. Regards, Ravin Goyal ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Openwrt on RB850gx2
On 06/10/2015 04:57 PM, ravin goyal wrote: Hi I need information regarding rb850gx2 which i unable to find online. I am trying to find out whether rb850gx2 supports openwrt platform or not. I checked openwrt website to know about the same but it looks like they have not updated regarding the device yet. Can anybody provide the required information about the device. By seeing [1] openwrt support this target I just did *make menuconfig* to search for this platform. Target System -- Atheros AR7xxx/AR9xxx Subtarget -- Mikrotik devices with NAND flash I hope it will help. [1]:https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/files/arch/mips/ath79/mach-rb4xx.c?rev=34239 -- Varka Bhadram ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 1/3] 6rd: Remove sourcerouting parameter registration
Signed-off-by: Hans Dedecker dedec...@gmail.com --- package/network/ipv6/6rd/files/6rd.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6rd/files/6rd.sh b/package/network/ipv6/6rd/files/6rd.sh index 6c68b3b..62d35b6 100644 --- a/package/network/ipv6/6rd/files/6rd.sh +++ b/package/network/ipv6/6rd/files/6rd.sh @@ -94,7 +94,6 @@ proto_6rd_init_config() { proto_config_add_string ip6prefixlen proto_config_add_string ip4prefixlen proto_config_add_string tunlink - proto_config_add_boolean sourcerouting proto_config_add_string zone } -- 1.9.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support
Adds PPP unnumbered support via the parameter unnumbered which points to a logical OpenWRT interface. The PPP proto shell handler will borrow an IP address from the unnumbered interface (if multiple IP addresses are present the longest prefix different from 32 will be borrowed) for which a host dependency will be created. Due to the host dependency the PPP unnumbered interface will only borrow an IP address from an interface which is up. The borrowed IP address will be shared as local IP address by the PPP daemon and no other local IP will be accepted from the peer in the IPCP negotiation. A typical use case is the usage of a public IP subnet on the Lan interface which will be shared by the PPP interface as local IP address. Signed-off-by: Hans Dedecker dedec...@gmail.com --- package/network/services/ppp/files/ppp.sh | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/package/network/services/ppp/files/ppp.sh b/package/network/services/ppp/files/ppp.sh index 1a72a1e..6770db3 100755 --- a/package/network/services/ppp/files/ppp.sh +++ b/package/network/services/ppp/files/ppp.sh @@ -4,10 +4,63 @@ [ -n $INCLUDE_ONLY ] || { . /lib/functions.sh + . /lib/functions/network.sh . ../netifd-proto.sh init_proto $@ } +ppp_mask2cidr() +{ + local x=${1##*255.} + # count the number of leading all ones + local allones=$(( (${#1} - ${#x}) * 2 )) + # conversion table based on blocks containing + # 4 characters to count the number of trailing bits + local tbl=0^^^128^192^224^240^248^252^254^ + + # count the number of four character blocks + x=${tbl%%${x%%.*}*} + echo $(( $allones + (${#x}/4) )) +} + +ppp_select_ipaddr() +{ + local interface=$1 + local addrs=$(uci_get network.${interface}.ipaddr) + local netmask=$(uci_get network.${interface}.netmask) + local res + local res_mask + + if [ -n $netmask ]; then + [ $netmask != ${netmask##*.} ] netmask=$(ppp_mask2cidr $netmask) + else + netmask=32 + fi + + for entry in $addrs; do + local addr=${entry%%/*} + local mask=${entry#*/} + + if [ $addr != $mask ]; then + [ $mask != ${mask##*.} ] mask=$(ppp_mask2cidr $mask) + else + mask=$netmask + fi + + if [ -n $res_mask -a $mask != 32 ]; then + [ $mask -gt $res_mask ] || [ $res_mask = 32 ] { + res=$addr + res_mask=$mask + } + elif [ -z $res_mask ]; then + res=$addr + res_mask=$mask + fi + done + + echo $res +} + ppp_exitcode_tostring() { local errorcode=$1 @@ -53,12 +106,14 @@ ppp_generic_init_config() { proto_config_add_boolean authfail proto_config_add_int mtu proto_config_add_string pppname + proto_config_add_string unnumbered } ppp_generic_setup() { local config=$1; shift + local localip - json_get_vars ipv6 demand keepalive keepalive_adaptive username password pppd_options pppname + json_get_vars ipv6 demand keepalive keepalive_adaptive username password pppd_options pppname unnumbered if [ $ipv6 = 0 ]; then ipv6= elif [ -z $ipv6 -o $ipv6 = auto ]; then @@ -73,6 +128,14 @@ ppp_generic_setup() { fi [ -n $mtu ] || json_get_var mtu mtu [ -n $pppname ] || pppname=${proto:-ppp}-$config + [ -n $unnumbered ] { + localip=$(ppp_select_ipaddr $unnumbered) + [ -n $localip ] || { + proto_block_restart $config + return + } + ( proto_add_host_dependency $config $localip $unnumbered ) + } local lcp_failure=${keepalive%%[, ]*} local lcp_interval=${keepalive##*[, ]} @@ -86,6 +149,7 @@ ppp_generic_setup() { proto_run_command $config /usr/sbin/pppd \ nodetach ipparam $config \ ifname $pppname \ + ${localip:+$localip:} \ ${lcp_failure:+lcp-echo-interval $lcp_interval lcp-echo-failure $lcp_failure $lcp_adaptive} \ ${ipv6:++ipv6} \ nodefaultroute \ -- 1.9.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Openwrt on RB850gx2
On 06/10/2015 05:11 PM, Varka Bhadram wrote: On 06/10/2015 04:57 PM, ravin goyal wrote: Hi I need information regarding rb850gx2 which i unable to find online. I am trying to find out whether rb850gx2 supports openwrt platform or not. I checked openwrt website to know about the same but it looks like they have not updated regarding the device yet. Can anybody provide the required information about the device. By seeing [1] openwrt support this target I just did *make menuconfig* to search for this platform. Target System -- Atheros AR7xxx/AR9xxx Subtarget -- Mikrotik devices with NAND flash I hope it will help. [1]:https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/files/arch/mips/ath79/mach-rb4xx.c?rev=34239 I gave you the wrong info. Sorry for the noise -- Varka Bhadram ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Openwrt on RB850gx2
I mean to say that openwrt supported hardware list don't have rb850gx2 ,I wonder will I be able to run openwrt on RB850gx2 or not. On 10 June 2015 at 17:22, Varka Bhadram varkabhad...@gmail.com wrote: On 06/10/2015 05:11 PM, Varka Bhadram wrote: On 06/10/2015 04:57 PM, ravin goyal wrote: Hi I need information regarding rb850gx2 which i unable to find online. I am trying to find out whether rb850gx2 supports openwrt platform or not. I checked openwrt website to know about the same but it looks like they have not updated regarding the device yet. Can anybody provide the required information about the device. By seeing [1] openwrt support this target I just did *make menuconfig* to search for this platform. Target System -- Atheros AR7xxx/AR9xxx Subtarget -- Mikrotik devices with NAND flash I hope it will help. [1]:https://dev.openwrt.org/browser/trunk/target/linux/ar71xx/files/arch/mips/ath79/mach-rb4xx.c?rev=34239 I gave you the wrong info. Sorry for the noise -- Varka Bhadram ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support
Thanks, I already applied the other two. On 10.06.2015 10:39, Hans Dedecker wrote: +ppp_select_ipaddr() +{ + local interface=$1 + local addrs=$(uci_get network.${interface}.ipaddr) + local netmask=$(uci_get network.${interface}.netmask) Any particular reason you are reading from UCI here and do not use the interface status parsing via e.g. network_get_subnets from /lib/functions/network.sh? This would seem more clear to me and would avoid the awkward parsing of netmasks as well. Additionally this would make it work with non-static protos as well. Cheers, Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
On 06/10/2015 02:01 PM, Bastian Bittorf wrote: * thomas.lan...@lantiq.com thomas.lan...@lantiq.com [10.06.2015 13:59]: I think this will not work, as /etc/profile (and these additional files) is expected to be executed in the current shell context. Otherwise adding shell variables or extending $PATH will not work. So you cannot execute them in a subshell. ok, then please: [ -e $FILE ] sh -n $FILE . $FILE Maybe it is possible to skip this for FAILSAFE mode? If there are errors, they can be corrected in this way. this is a good point: [ -z $FAILSAFE ] { ...yourlogic... } bye, bastian Why should errors in these files cause login issues? This is shell and there's no -e, problematic lines will print an error and be skipped. Hendrik's patch adds exactly the lines used by Debian. On Arch Linux, it looks very similar. The only way to break login using profile snippets is causing the shell to exit explicitly (using `exit` or something like that), but there's no sane way to protect against that... Matthias signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
* Matthias Schiffer mschif...@universe-factory.net [10.06.2015 14:26]: Why should errors in these files cause login issues? This is shell and there's no -e, problematic lines will print an error and be skipped. i have seen a lot of strange things. think about flash readerrors or stack corruption or $youridea 8-) i think we can agree that we will not use a subshell, but ignore profile.d in failsafe mode, ok? the 'sh -n' thing is just a small 'insurance' - do you think it hurts/is too much? bye, bastian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support
On Wed, Jun 10, 2015 at 2:03 PM, Steven Barth cy...@openwrt.org wrote: Thanks, I already applied the other two. On 10.06.2015 10:39, Hans Dedecker wrote: +ppp_select_ipaddr() +{ + local interface=$1 + local addrs=$(uci_get network.${interface}.ipaddr) + local netmask=$(uci_get network.${interface}.netmask) Any particular reason you are reading from UCI here and do not use the interface status parsing via e.g. network_get_subnets from /lib/functions/network.sh? This would seem more clear to me and would avoid the awkward parsing of netmasks as well. Additionally this would make it work with non-static protos as well UCI is read as network_get_subnets only returns info for active interfaces; e.g. if the referred interface in the unnumbered parameter is down it's not possible to install the host dependency based on the IP address for the PPP interface. Did not (yet) find a way to circumvent this issue. Hans Cheers, Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
* thomas.lan...@lantiq.com thomas.lan...@lantiq.com [10.06.2015 13:59]: I think this will not work, as /etc/profile (and these additional files) is expected to be executed in the current shell context. Otherwise adding shell variables or extending $PATH will not work. So you cannot execute them in a subshell. ok, then please: [ -e $FILE ] sh -n $FILE . $FILE Maybe it is possible to skip this for FAILSAFE mode? If there are errors, they can be corrected in this way. this is a good point: [ -z $FAILSAFE ] { ...yourlogic... } bye, bastian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH 2/3] 6to4: Remove sourcerouting parameter registration
Signed-off-by: Hans Dedecker dedec...@gmail.com --- package/network/ipv6/6to4/files/6to4.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/package/network/ipv6/6to4/files/6to4.sh b/package/network/ipv6/6to4/files/6to4.sh index 57efc52..a5d0567 100755 --- a/package/network/ipv6/6to4/files/6to4.sh +++ b/package/network/ipv6/6to4/files/6to4.sh @@ -91,7 +91,6 @@ proto_6to4_init_config() { proto_config_add_int mtu proto_config_add_int ttl proto_config_add_string tos - proto_config_add_boolean sourcerouting } [ -n $INCLUDE_ONLY ] || { -- 1.9.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Linux 4.x
2015-06-10 9:09 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: On 06/10/2015 12:35 PM, Baptiste Clenet wrote: 2015-06-09 6:05 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: On 06/08/2015 07:32 PM, Baptiste Clenet wrote: 2015-06-08 15:23 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: (...) Thanks Varka for your help! It compiles now without those module: - kmod-bluetooth - kmod-bluetooth_6lowpan - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers - kmod-mac802154 - kmod-wpan-at86rf230 - wpan-tools It's basically the same conf as yours. I don't get why those module would make an error since they worked well with Linux 3.18. Here are my tries: - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers Have you added this ? - kmod-mac802154 - kmod-wpan-at86rf230 Yes this packages weren't in OPENWRT Tree. I removed them and use the right ones now. - kmod-wpan-at86rf230 doesn't exist either, perhaps you meant kmod-at86rf230 under Wireless? Yes.. :-) I added: - kmod-at86rf230 - kmod-ieee802154 - kmod-mac802154 - kmod-ipv6 I got the following error: Package kmod-at86rf230 is missing dependencies for the following libraries: regmap-core.ko regmap-spi.ko Try this patch: diff --git a/package/kernel/linux/modules/wpan.mk b/package/kernel/linux/modules/wpan.mk index 6b07809..412d70e 100644 --- a/package/kernel/linux/modules/wpan.mk +++ b/package/kernel/linux/modules/wpan.mk @@ -71,7 +71,7 @@ $(eval $(call KernelPackage,fakelb)) define KernelPackage/at86rf230 SUBMENU:=$(WPAN_MENU) TITLE:=AT86RF230 transceiver driver - DEPENDS:=+kmod-mac802154 + DEPENDS:=+kmod-mac802154 +kmod-regmap KCONFIG:=CONFIG_IEEE802154_AT86RF230 \ CONFIG_SPI=y \ CONFIG_SPI_MASTER=y @@ -107,7 +107,7 @@ $(eval $(call KernelPackage,cc2520)) define KernelPackage/ieee802154_6lowpan SUBMENU:=$(WPAN_MENU) TITLE:= 6LoWPAN support over IEEE-802.15.4 - DEPENDS:=@LINUX_4_0 +kmod-6lowpan + DEPENDS:=@LINUX_4_0 +kmod-6lowpan +kmod-ieee802154 KCONFIG:=CONFIG_IEEE802154_6LOWPAN FILES:= \ $(LINUX_DIR)/net/ieee802154/6lowpan/ieee802154_6lowpan.ko@ge4.0 \ -- 1.7.9.5 -- Varka Bhadram Thanks Varka, works well now! Next step is making at86rf230 work seamlessly. Cheers, Baptiste ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] b53 kernel memory corruption fix
On 9 June 2015 at 11:57, blmink blm...@mink.su wrote: Hi, We usually don't want hi and hello it commit messages ;) this patch fixes kernel memory corruption in b53 driver during device global reset, which causes kernel panic especially on 64bit platforms. There is sth wrong with patch format I guess, patchwork didn't notice it :( You may want to e.g. use git send-email in the future. Signed-off-by: Fedor Konstantinov blm...@mink.su --- This is a magic place (in patch format) where you can add messages that won't be applied with e.g. git am. So it's perfect place for hi etc. :) Thanks for your patch. Index: target/linux/generic/files/drivers/net/phy/b53/b53_common.c === --- target/linux/generic/files/drivers/net/phy/b53/b53_common.c (revision 45932) +++ target/linux/generic/files/drivers/net/phy/b53/b53_common.c (working copy) @@ -803,8 +803,8 @@ priv-enable_jumbo = 0; priv-allow_vid_4095 = 0; - memset(priv-vlans, 0, sizeof(priv-vlans) * dev-vlans); - memset(priv-ports, 0, sizeof(priv-ports) * dev-ports); + memset(priv-vlans, 0, sizeof(struct b53_vlan) * dev-vlans); + memset(priv-ports, 0, sizeof(struct b53_port) * dev-ports); return b53_switch_reset(priv); } -- Rafał ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Automatically update CRC on TG582N board when rootfs changes.
Hi, On Thu, Jun 4, 2015 at 11:06 AM, Kejia Hu (Terry) kejia...@codethink.co.uk wrote: Signed-off-by: kejia Hu kejia...@codethink.co.uk The signed-off-by needs to be in the actual patch description. Also don't send cover letters (is this one?) for single patches. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] Add tg582n to the list of do_fixtrx.
Hi, On Thu, Jun 4, 2015 at 11:06 AM, Kejia Hu (Terry) kejia...@codethink.co.uk wrote: From: Kejia Hu kejia...@codethink.co.uk This will update CRC after rootfs has been changed, thus aovid bootloader's CRC verification failure. This would also require a sign-off-by. Just merge this patch into your patch 2/3 of your tg582n patch series instead of resending it. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] b53 kernel memory corruption fix
Hi, On Tue, Jun 9, 2015 at 11:57 AM, blmink blm...@mink.su wrote: You should fix your email client to have your full name here, or add a proper From: line into the description. This isn't important for svn, but any git requires it for proper patch ownership. Hi, this patch fixes kernel memory corruption in b53 driver during device global reset, which causes kernel panic especially on 64bit platforms. Signed-off-by: Fedor Konstantinov blm...@mink.su Good catch. Unfortunately this patch doesn't apply because it was mangled by your email. So I committed a fix in a slightly different way. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 0/3] Add support for Thomson TG582n DANT-1 board
Hi, On Wed, Jun 3, 2015 at 2:28 PM, Kejia Hu (Terry) kejia...@codethink.co.uk wrote: From: Kejia Hu kejia...@codethink.co.uk This set of patches added support for Thomson TG582n DANT-1 board. They have been tested by building a CFE image, and loaded to the board using a customised CFE. support for DANT-T board may be possible with these patches with limited modification, but I can't test this due to lack of hardware. Please sign off all your individual patches. I cannot take them without it. Also see individual patches for comments. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 1/3] Add support for EON EN25Q128 flash chip.
Hi, please prefix your patch subjects with an appropriate subject, e.g. kernel:, or brcm63xx:. On Wed, Jun 3, 2015 at 2:28 PM, Kejia Hu (Terry) kejia...@codethink.co.uk wrote: From: Kejia Hu kejia...@codethink.co.uk This is part of the work to add support for Thomson TG582n router. You don't need to state this, the patch numbering already makes this clear. There are 2 variants for the board, namely DANT-T and DANT-1, EN25Q128 is used on DANT-1 only. Is this also submitted upstream to linux-mtd? Also note that there also are also patches-4.0, so it would need this patch as well. Furthermore please note the rules for patches to generic found in target/linux/generic/PATCHES. Regards Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Linux 4.x
On 06/10/2015 12:35 PM, Baptiste Clenet wrote: 2015-06-09 6:05 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: On 06/08/2015 07:32 PM, Baptiste Clenet wrote: 2015-06-08 15:23 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: (...) Thanks Varka for your help! It compiles now without those module: - kmod-bluetooth - kmod-bluetooth_6lowpan - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers - kmod-mac802154 - kmod-wpan-at86rf230 - wpan-tools It's basically the same conf as yours. I don't get why those module would make an error since they worked well with Linux 3.18. Here are my tries: - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers Have you added this ? - kmod-mac802154 - kmod-wpan-at86rf230 Yes this packages weren't in OPENWRT Tree. I removed them and use the right ones now. - kmod-wpan-at86rf230 doesn't exist either, perhaps you meant kmod-at86rf230 under Wireless? Yes.. :-) I added: - kmod-at86rf230 - kmod-ieee802154 - kmod-mac802154 - kmod-ipv6 I got the following error: Package kmod-at86rf230 is missing dependencies for the following libraries: regmap-core.ko regmap-spi.ko Try this patch: diff --git a/package/kernel/linux/modules/wpan.mk b/package/kernel/linux/modules/wpan.mk index 6b07809..412d70e 100644 --- a/package/kernel/linux/modules/wpan.mk +++ b/package/kernel/linux/modules/wpan.mk @@ -71,7 +71,7 @@ $(eval $(call KernelPackage,fakelb)) define KernelPackage/at86rf230 SUBMENU:=$(WPAN_MENU) TITLE:=AT86RF230 transceiver driver - DEPENDS:=+kmod-mac802154 + DEPENDS:=+kmod-mac802154 +kmod-regmap KCONFIG:=CONFIG_IEEE802154_AT86RF230 \ CONFIG_SPI=y \ CONFIG_SPI_MASTER=y @@ -107,7 +107,7 @@ $(eval $(call KernelPackage,cc2520)) define KernelPackage/ieee802154_6lowpan SUBMENU:=$(WPAN_MENU) TITLE:= 6LoWPAN support over IEEE-802.15.4 - DEPENDS:=@LINUX_4_0 +kmod-6lowpan + DEPENDS:=@LINUX_4_0 +kmod-6lowpan +kmod-ieee802154 KCONFIG:=CONFIG_IEEE802154_6LOWPAN FILES:= \ $(LINUX_DIR)/net/ieee802154/6lowpan/ieee802154_6lowpan.ko@ge4.0 \ -- 1.7.9.5 -- Varka Bhadram ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
Am 10.06.2015 um 14:31 schrieb Bastian Bittorf: * Matthias Schiffer mschif...@universe-factory.net [10.06.2015 14:26]: Why should errors in these files cause login issues? This is shell and there's no -e, problematic lines will print an error and be skipped. i have seen a lot of strange things. think about flash readerrors or stack corruption or $youridea 8-) i think we can agree that we will not use a subshell, but ignore profile.d in failsafe mode, ok? the 'sh -n' thing is just a small 'insurance' - do you think it hurts/is too much? bye, bastian I'd like to see, that the scripts in profile.d are getting called without the 'sh' because those scripts could be written in Lua, too. Weather a script needs to get called in failsafe mode or not depends on the script, so I'd like to not skip it. regards, Hendrik ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
On 06/10/2015 04:27 PM, Hendrik Lüth wrote: Am 10.06.2015 um 14:31 schrieb Bastian Bittorf: * Matthias Schiffer mschif...@universe-factory.net [10.06.2015 14:26]: Why should errors in these files cause login issues? This is shell and there's no -e, problematic lines will print an error and be skipped. i have seen a lot of strange things. think about flash readerrors or stack corruption or $youridea 8-) i think we can agree that we will not use a subshell, but ignore profile.d in failsafe mode, ok? the 'sh -n' thing is just a small 'insurance' - do you think it hurts/is too much? bye, bastian I'd like to see, that the scripts in profile.d are getting called without the 'sh' because those scripts could be written in Lua, too. Weather a script needs to get called in failsafe mode or not depends on the script, so I'd like to not skip it. regards, Hendrik That's not at all what profile.d is about. profile.d is for shell snippets that are *sourced* into the login shell, not executed, so they must be shell code. If you want to call Lua scripts, just call Lua from the shell code. I agree that it would make sense to skip profile.d in failsafe mode. signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
On Jun 10, 2015 6:30 PM, Hendrik Lüth hend...@linux-nerds.de wrote: OpenWrt should support an optinal /etc/profile.d directory like most other Linux distributions. This allows packages to install their own scripts into /etc/profile.d/. IMO, OpenWrt is not like most of other Linux distributions. So what are those other packages that need this and the current specific use cases? yousong --- package/base-files/files/etc/profile | 9 + 1 file changed, 9 insertions(+) diff --git a/package/base-files/files/etc/profile b/package/base-files/files/etc/profile index 3dd58e1..c9e805f 100644 --- a/package/base-files/files/etc/profile +++ b/package/base-files/files/etc/profile @@ -14,3 +14,12 @@ export PS1='\u@\h:\w\$ ' [ -x /usr/bin/arp ] || arp() { cat /proc/net/arp; } [ -x /usr/bin/ldd ] || ldd() { LD_TRACE_LOADED_OBJECTS=1 $*; } + +if [ -d /etc/profile.d ]; then + for i in /etc/profile.d/* ; do +if [ -r $i ]; then + . $i +fi + done + unset i +fi -- 2.4.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Linux 4.x
2015-06-09 6:05 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: On 06/08/2015 07:32 PM, Baptiste Clenet wrote: 2015-06-08 15:23 GMT+02:00 Varka Bhadram varkabhad...@gmail.com: (...) Thanks Varka for your help! It compiles now without those module: - kmod-bluetooth - kmod-bluetooth_6lowpan - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers - kmod-mac802154 - kmod-wpan-at86rf230 - wpan-tools It's basically the same conf as yours. I don't get why those module would make an error since they worked well with Linux 3.18. Here are my tries: - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers Have you added this ? - kmod-mac802154 - kmod-wpan-at86rf230 Yes this packages weren't in OPENWRT Tree. I removed them and use the right ones now. - kmod-wpan-at86rf230 doesn't exist either, perhaps you meant kmod-at86rf230 under Wireless? I added: - kmod-at86rf230 - kmod-ieee802154 - kmod-mac802154 - kmod-ipv6 I got the following error: Package kmod-at86rf230 is missing dependencies for the following libraries: regmap-core.ko regmap-spi.ko Same error if I add kmod-regmap (which should add those missing libraries, shouldn't it?) Baptiste This also. I don't see these packages in OpenWrt tree. Please use already existing package stuff... All these packages available in Kernel Modules - Wireless Drivers in your menuconfig. - wpan-tools -- ERROR: module '/trunk/build_dir/target-mipsel_24kec+dsp_uClibc-0.9.33.2/linux-ramips_mt7628/linux-4.0.4/net/ieee802154/af_802154.ko' is missing. - kmod-bluetooth - kmod-bluetooth_6lowpan - kmod-6lowpan - kmod-ieee802154 - kmod-ieee802154-6lowpan - kmod-ieee802154-drivers - kmod-mac802154 - kmod-wpan-at86rf230 - wpan-tools ---ERROR: module '/trunk/build_dir/target-mipsel_24kec+dsp_uClibc-0.9.33.2/linux-ramips_mt7628/linux-4.0.4/net/bluetooth/rfcomm/rfcomm.ko' is missing. -- Varka Bhadram ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support
On Wed, Jun 10, 2015 at 8:42 PM, Steven Barth cy...@openwrt.org wrote: I just pushed http://git.openwrt.org/?p=project/netifd.git;a=commit;h=5cf30b59baa03db2448570c78e7e92873555d2ec (not yet bumped in trunk) which allows generic dependencies to interfaces by using an empty address, with that you can add a host dependency and once fulfilled use network_* to get the addresses. Thx I will try to find some time in the coming days to rework the PPP unnumbered implementation based on this approach. Hans Please let me know if that works for you. Cheers, Steven On 10.06.2015 14:52, Steven Barth wrote: UCI is read as network_get_subnets only returns info for active interfaces; e.g. if the referred interface in the unnumbered parameter is down it's not possible to install the host dependency based on the IP address for the PPP interface. Did not (yet) find a way to circumvent this issue. Understood, I think the sane way around here would be to add a host_dependency on the interface itself (without a specific IP-address). Let me see if this can be added to netifd easily. Cheers, Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support
I just pushed http://git.openwrt.org/?p=project/netifd.git;a=commit;h=5cf30b59baa03db2448570c78e7e92873555d2ec (not yet bumped in trunk) which allows generic dependencies to interfaces by using an empty address, with that you can add a host dependency and once fulfilled use network_* to get the addresses. Please let me know if that works for you. Cheers, Steven On 10.06.2015 14:52, Steven Barth wrote: UCI is read as network_get_subnets only returns info for active interfaces; e.g. if the referred interface in the unnumbered parameter is down it's not possible to install the host dependency based on the IP address for the PPP interface. Did not (yet) find a way to circumvent this issue. Understood, I think the sane way around here would be to add a host_dependency on the interface itself (without a specific IP-address). Let me see if this can be added to netifd easily. Cheers, Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
* Hendrik Lüth hend...@linux-nerds.de [10.06.2015 20:38]: Weather a script needs to get called in failsafe mode or not depends on the script, so I'd like to not skip it. no, failsafe is failsafe is failsafe and should do mostly nothing. bye, bastian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
* Yousong Zhou yszhou4t...@gmail.com [10.06.2015 20:38]: distributions. This allows packages to install their own scripts into /etc/profile.d/. IMO, OpenWrt is not like most of other Linux distributions. So what are those other packages that need this and the current specific use cases? I agree, that OpenWrt differs - and i have a usecase: 1) we like to have special helpers like alias n='wget -qO - http://127.0.0.1:2006/neighbours' (for OLSRd) and we source/include a special 'metascript' which makes adminstration much easier. for now we patch /etc/profile but having it in profile.d is more clean and: it is automatically removed if package XY is also removed... bye, bastian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support
On 06/10/2015 07:46 PM, Bastian Bittorf wrote: * Yousong Zhou yszhou4t...@gmail.com [10.06.2015 20:38]: distributions. This allows packages to install their own scripts into /etc/profile.d/. IMO, OpenWrt is not like most of other Linux distributions. So what are those other packages that need this and the current specific use cases? I agree, that OpenWrt differs - and i have a usecase: 1) we like to have special helpers like alias n='wget -qO - http://127.0.0.1:2006/neighbours' (for OLSRd) and we source/include a special 'metascript' which makes adminstration much easier. for now we patch /etc/profile but having it in profile.d is more clean and: it is automatically removed if package XY is also removed... Right. Also something more simple: I'd like to have ll='ls -la' on my systems and OpenWRT based mini-distributions. Right now I have to change package/base-files/etc/profile or override /etc/profile completely from the files/ folder. In this case it's not too complicated, but its not maintainable very well. Another maybe more interesting example is the Java VM jamvm. It depends on classpath which is quite big and one of my systems has to be installed on the SD card. Because the libraries are on /mnt/sd/ I need export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/mnt/sd/usr/lib/classpath for jamvm to work properly. That could go into a system and distribution specific package which puts it into /etc/profile.d/... which is much cleaner than overriding /etc/profile or -worse- messing with /etc/profile in a postinst script... bruno ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] x86_64 packages missing
Currently, there is no x86_64 trunk available under downloads.openwrt.org/snapshots/trunk but it was there a few weeks ago. Could those packages be regenerated and put there, so that opkg update works? Thanks!, *William Haynes* ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] x86_64 packages missing
Hi, the 64 target is now a subtarget of x86, so you can find those packages here: https://downloads.openwrt.org/snapshots/trunk/x86/64/packages/ Basically replace x86_64 with x86/64 in your opkg.conf HTH, Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel