[OpenWrt-Devel] RFC: uClibc and xattr

[Maxim Storchak]

Hello,

I was trying to fix https://github.com/openwrt/packages/issues/1703
(lsof compilation on mips64) and discovered that a) mips64* were the
only targets using uCLibc; b) xattr was disabled in uClibc config.
I tried to add DEPENDS:=@(!(USE_UCLIBC)) to libattr, but that created
recursive dependencies for musl targets:
tmp/.config-package.in:55568:error: recursive dependency detected!
tmp/.config-package.in:55568:   symbol PACKAGE_rsnapshot depends on
RSYNC_xattr
tmp/.config-package.in:34393:   symbol RSYNC_xattr depends on PACKAGE_rsync
tmp/.config-package.in:34365:   symbol PACKAGE_rsync is selected by
PACKAGE_rsnapshot
I tried several approaches, but didn't get any further.

My questions are:
- is xattr disabled in uClibc for purpose?
- would it make sense to enable it to make feature sets of libc
implementations closer to each other?

-- 
Best regards,
Maxim Storchak
mailto:m.storc...@gmail.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] libpcap: USB support by default if usbmon is enabled

[Bjørn Mork]

If building usbmon support then you'll likely want to have
USB support in libpcap as well.

Signed-off-by: Bjørn Mork 
---
 package/libs/libpcap/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libs/libpcap/Config.in b/package/libs/libpcap/Config.in
index 5fee75a59597..60b53a76fce1 100644
--- a/package/libs/libpcap/Config.in
+++ b/package/libs/libpcap/Config.in
@@ -4,7 +4,7 @@ menu "Configuration"
 config PCAP_HAS_USB
bool "Include USB support"
depends on PACKAGE_kmod-usb-core
-   default n
+   default PACKAGE_kmod-usbmon
 
 config PCAP_HAS_BT
bool "Include bluetooth support"
-- 
2.1.4
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Firmware Upgrade - Mikrotik - ar71xx

[Nishant Sharma]

Hi,

I have around 50 boxes (ar71xx Mikrotik RB951Ui-2HnD) in the field, 
running AA or BB (custom compiled).


I have checked through the documentation, but could not find any way to 
upgrade the firmware.


Is there a way, that I could upgrade them to the newly compiled firmware 
remotely or only option I have is to recall the boxes back and re-flash 
them?


Thanks in advance.

Regards,
Nishant
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 1/2] [netifd] multicast flag control

[Podolak, Nicholas]

From: Nick Podolak 

This patch set allows for interfaces defined in UCI to enable and disable 
multicast support on their underlying device.  This has particular use on GRE 
tunnels which previously did NOT enable multicast by default.  Since GRE is 
commonly used to create router to router links that support multicast for use 
by routing protocols (e.g. OSPF, EIGRP, etc), or specifically for multicast 
applications, this modification seemed necessary.

This first patch adds the multicast capability to all interfaces/devices.


Signed-off-by: Nick Podolak 

Index: netifd-2015-09-27/device.c
===
--- netifd-2015-09-27.orig/device.c2015-10-13 15:21:54.358124119 -0400
+++ netifd-2015-09-27/device.c2015-10-13 15:21:54.346124119 -0400
@@ -40,6 +40,7 @@
 [DEV_ATTR_ENABLED] = { .name = "enabled", .type = BLOBMSG_TYPE_BOOL },
 [DEV_ATTR_IPV6] = { .name = "ipv6", .type = BLOBMSG_TYPE_BOOL },
 [DEV_ATTR_PROMISC] = { .name = "promisc", .type = BLOBMSG_TYPE_BOOL },
+[DEV_ATTR_MULTICAST] = { .name = "multicast", .type = BLOBMSG_TYPE_BOOL },
 [DEV_ATTR_RPFILTER] = { .name = "rpfilter", .type = BLOBMSG_TYPE_STRING },
 [DEV_ATTR_ACCEPTLOCAL] = { .name = "acceptlocal", .type = 
BLOBMSG_TYPE_BOOL },
 [DEV_ATTR_IGMPVERSION] = { .name = "igmpversion", .type = 
BLOBMSG_TYPE_INT32 },
@@ -162,6 +163,7 @@
 sizeof(n->macaddr));
 n->ipv6 = s->flags & DEV_OPT_IPV6 ? s->ipv6 : os->ipv6;
 n->promisc = s->flags & DEV_OPT_PROMISC ? s->promisc : os->promisc;
+n->multicast = s->flags & DEV_OPT_MULTICAST ? s->multicast : os->multicast;
 n->rpfilter = s->flags & DEV_OPT_RPFILTER ? s->rpfilter : os->rpfilter;
 n->acceptlocal = s->flags & DEV_OPT_ACCEPTLOCAL ? s->acceptlocal : 
os->acceptlocal;
 n->igmpversion = s->flags & DEV_OPT_IGMPVERSION ? s->igmpversion : 
os->igmpversion;
@@ -222,6 +224,11 @@
 s->flags |= DEV_OPT_PROMISC;
 }

+if ((cur = tb[DEV_ATTR_MULTICAST])) {
+s->multicast = blobmsg_get_bool(cur);
+s->flags |= DEV_OPT_MULTICAST;
+}
+
 if ((cur = tb[DEV_ATTR_RPFILTER])) {
 if (system_resolve_rpfilter(blobmsg_data(cur), >rpfilter))
 s->flags |= DEV_OPT_RPFILTER;
@@ -899,6 +906,8 @@
 blobmsg_add_u8(b, "ipv6", st.ipv6);
 if (st.flags & DEV_OPT_PROMISC)
 blobmsg_add_u8(b, "promisc", st.promisc);
+if (st.flags & DEV_OPT_MULTICAST)
+blobmsg_add_u8(b, "multicast", st.multicast);
 if (st.flags & DEV_OPT_RPFILTER)
 blobmsg_add_u32(b, "rpfilter", st.rpfilter);
 if (st.flags & DEV_OPT_ACCEPTLOCAL)
Index: netifd-2015-09-27/system-linux.c
===
--- netifd-2015-09-27.orig/system-linux.c2015-10-13 15:21:54.358124119 -0400
+++ netifd-2015-09-27/system-linux.c2015-10-13 15:21:54.350124119 -0400
@@ -1091,6 +1091,11 @@
 s->flags |= DEV_OPT_PROMISC;
 }

+if (ioctl(sock_ioctl, SIOCGIFFLAGS, ) == 0) {
+s->multicast = ifr.ifr_flags & IFF_MULTICAST;
+s->flags |= DEV_OPT_MULTICAST;
+}
+
 if (!system_get_rpfilter(dev, buf, sizeof(buf))) {
 s->rpfilter = strtoul(buf, NULL, 0);
 s->flags |= DEV_OPT_RPFILTER;
@@ -1193,6 +1198,11 @@
 !s->promisc ? IFF_PROMISC : 0) < 0)
 s->flags &= ~DEV_OPT_PROMISC;
 }
+if (s->flags & DEV_OPT_MULTICAST & apply_mask) {
+if (system_if_flags(dev->ifname, s->multicast ? IFF_MULTICAST : 0,
+!s->multicast ? IFF_MULTICAST : 0) < 0)
+s->flags &= ~DEV_OPT_MULTICAST;
+}
 if (s->flags & DEV_OPT_RPFILTER & apply_mask) {
 snprintf(buf, sizeof(buf), "%d", s->rpfilter);
 system_set_rpfilter(dev, buf);
Index: netifd-2015-09-27/device.h
===
--- netifd-2015-09-27.orig/device.h2015-10-13 15:21:54.358124119 -0400
+++ netifd-2015-09-27/device.h2015-10-13 15:21:54.350124119 -0400
@@ -34,6 +34,7 @@
 DEV_ATTR_ENABLED,
 DEV_ATTR_IPV6,
 DEV_ATTR_PROMISC,
+DEV_ATTR_MULTICAST,
 DEV_ATTR_RPFILTER,
 DEV_ATTR_ACCEPTLOCAL,
 DEV_ATTR_IGMPVERSION,
@@ -88,6 +89,7 @@
 DEV_OPT_DADTRANSMITS= (1 << 13),
 DEV_OPT_MULTICAST_TO_UNICAST= (1 << 14),
 DEV_OPT_MULTICAST_ROUTER= (1 << 15),
+DEV_OPT_MULTICAST= (1 << 16),
 };

 /* events broadcasted to all users of a device */
@@ -136,6 +138,7 @@
 uint8_t macaddr[6];
 bool ipv6;
 bool promisc;
+bool multicast;
 unsigned int rpfilter;
 bool acceptlocal;
 unsigned int igmpversion;
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Firmaware size MT7628

[Baptiste Clenet]

2015-10-20 20:28 GMT+02:00 Baptiste Clenet :
> Hi,
>
> I edited the firmware size of the MT7628 board from 4 to 16Mo because
> I've got 16Mo flash. I began with 8Mo ant it worked well but 16Mo
> seems to make the board crash at boot with error messages:
>
> [0.859932] jffs2: Flash size not aligned to erasesize, reducing to 6720KiB
> [0.874195] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x: 0x7368 instead
> [0.892987] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x0004: 0x0551 instead
> ...
> [1.043215] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x0030: 0xfb3a instead
> [1.061987] jffs2: Further such events for this erase block will
> not be printed
> [1.080861] jffs2: Empty flash at 0x0038 ends at 0x0040
> [1.164315] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x0001: 0xadd7 instead
> [1.183110] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x00010004: 0x7f0d instead
> ...
> [1.611456] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
> not found at 0x00020024: 0xeae7 instead
> [1.630228] jffs2: Further such events for this erase block will
> not be printed
> [1.691809] jffs2: Old JFFS2 bitmask found at 0x000295cc
> [1.702326] jffs2: You cannot use older JFFS2 filesystems with newer 
> kernels
>
> I don't know if the problem comes from the flash driver or something
> else. Any input would be great if you have already encountered this
> problem?

I edited the Makefile in target/linux/ramips/image:
Image/Build/Profile/MT7628=$(call
BuildFirmware/Default4M/$(1),$(1),mt7628,MT7628)
To
Image/Build/Profile/MT7628=$(call
BuildFirmware/Default16M/$(1),$(1),mt7628,MT7628)
>
> Regards,
>
> --
> Baptiste



-- 
Baptiste
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Firmaware size MT7628

[Baptiste Clenet]

Hi,

I edited the firmware size of the MT7628 board from 4 to 16Mo because
I've got 16Mo flash. I began with 8Mo ant it worked well but 16Mo
seems to make the board crash at boot with error messages:

[0.859932] jffs2: Flash size not aligned to erasesize, reducing to 6720KiB
[0.874195] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x: 0x7368 instead
[0.892987] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x0004: 0x0551 instead
...
[1.043215] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x0030: 0xfb3a instead
[1.061987] jffs2: Further such events for this erase block will
not be printed
[1.080861] jffs2: Empty flash at 0x0038 ends at 0x0040
[1.164315] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x0001: 0xadd7 instead
[1.183110] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x00010004: 0x7f0d instead
...
[1.611456] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
not found at 0x00020024: 0xeae7 instead
[1.630228] jffs2: Further such events for this erase block will
not be printed
[1.691809] jffs2: Old JFFS2 bitmask found at 0x000295cc
[1.702326] jffs2: You cannot use older JFFS2 filesystems with newer kernels

I don't know if the problem comes from the flash driver or something
else. Any input would be great if you have already encountered this
problem?

Regards,

-- 
Baptiste
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] CC: ramips: WIZnet WizFi630A Platfrom support - board detection

[Tobias Welz]

This patch is adding the missing board detection of WIZnet WizFi630A board.
ramips.sh was not submitted with the former patch.

This belongs to to the backport of patch r46921

Signed-off-by: Tobias Welz 
---
 target/linux/ramips/base-files/lib/ramips.sh |3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/linux/ramips/base-files/lib/ramips.sh 
b/target/linux/ramips/base-files/lib/ramips.sh
index 82a1f91397cb..70f22a72b392 100755
--- a/target/linux/ramips/base-files/lib/ramips.sh
+++ b/target/linux/ramips/base-files/lib/ramips.sh
@@ -331,6 +331,9 @@ ramips_board_detect() {
*"WHR-G300N")
name="whr-g300n"
;;
+   *"WizFi630A")
+   name="wizfi630a"
+   ;;
*"Sitecom WL-341 v3")
name="wl341v3"
;;
-- 
1.7.10.4
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] libpcap: USB support by default if usbmon is enabled

[Karl Palsson]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Sounds good to me, I missed this the first time I was building
with usbmon :)

Bjørn Mork  wrote:
> If building usbmon support then you'll likely want to have USB
> support in libpcap as well.
> 
> Signed-off-by: Bjørn Mork 
> ---
>  package/libs/libpcap/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libs/libpcap/Config.in
> b/package/libs/libpcap/Config.in index
> 5fee75a59597..60b53a76fce1 100644
> --- a/package/libs/libpcap/Config.in
> +++ b/package/libs/libpcap/Config.in
> @@ -4,7 +4,7 @@ menu "Configuration"
>  config PCAP_HAS_USB
>   bool "Include USB support"
>   depends on PACKAGE_kmod-usb-core
> - default n
> + default PACKAGE_kmod-usbmon
>  
>  config PCAP_HAS_BT
>   bool "Include bluetooth support"
> -- 
> 2.1.4

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJWJm4tAAoJEBmotQ/U1cr2ll4P/ApmiMGPHl5J33JjqjV6N+n+
JSKeQjErIhjP7i7BG98YWPBn8OD2h+YAOzYQd+Aj2+C62NJMzY1PG41jsQMYXtPp
qgg1hpDcGv0IGZcHSnmWPDq34IpPbv2Vzfsyp6J37FE5BJHF+6H2xaxlbmkkGjQX
SoGBbqJ6hafvFhcUCboSSXt4MazrE649utIQAWEMlpKri1Q4HFkBp9GdAQVA9Coq
3CwRuvHxpU/AqvqFPEmpzG84sI+QnyycHjhTSETdHVPn8x+jzt2Xs/2dVddyVKfl
b+ugT1qpwqL22elKz+ktA90rcCDW2IUy6wEmAzz7Vps6GA/438XJdyj/jnEWgcRb
w1ziqvpIxfqAb0d70J4Dv/8sOUxinSg2v75ONWyEq3XCtPS3GYlFPHztJCy7i1W7
xIy6N0c2vktdPSLdMlBY6303TCzYXomsIB0RcAh0oB0PxkYSMaiid1+Rf5dLQs6+
+02pGMueuwn+1Kb79PCgKwD3hCJtXUdDxmU4tXJ3U1lpbc/2yPyk6FMRJ+Cf5cV3
4o3ji5UmWvONZwWoT/EPe8Y/2cuFxqDDDrys6f+fLnnkOdR8i+r+MHcKqwyVbAlc
SqszBqmfgaWFmDhTgEwTSQ0YJH/mbXQJbLsNmqXo3KvovDnk8CU3JfTi7kd91DYk
gnKHpdXePB6ZjvpSdGkS
=6XdL
-END PGP SIGNATURE-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Firmware Upgrade - Mikrotik - ar71xx

[David Hutchison]

I think sysupgrade now works with the rb951ui; however I haven't tested it.

I wrote my own upgrade process before sysupgrade was available for the
rb95x series:

- Create a sysupgrade.tgz; this is the kept files you want (
configurations; scripts; etc. )
tar -czf /tmp/sysupgrade.tgz /etc/dropbear /etc/passwd /etc/group
/etc/rc.local ${upgrade_dirs} &> /dev/null


- Make a new root directory in /tmp ( /tmp/root/* )

mkdir -p /tmp/root/dev /tmp/root/sbin /tmp/root/bin /tmp/root/proc
/tmp/root/tmp /tmp/root/mnt /tmp/root/lib
mkdir -p /tmp/root/etc /tmp/root/root /tmp/root/var/log
/tmp/root/usr/bin /tmp/root/usr/sbin /tmp/root/oldroot

- Copy over sbin/* necessary bins

cd /sbin
cp -rp `ls -A /sbin | grep -vE
"mount.nfs|hotplug2|hotplug-call|udevd|swconfig|uci"` /tmp/root/sbin/.
cd /bin
cp -rp `ls -A /bin | grep -v bash` /tmp/root/bin/.
cd /
cp -p /lib/* /tmp/root/lib/. &> /dev/null
cp -rp /usr/bin/wget /usr/bin/md5sum /usr/bin/killall /usr/bin/awk
/usr/bin/hexdump /usr/bin/bzcat /usr/bin/printf /usr/bin/wc
/usr/bin/passwd /usr/bin/ssh /usr/bin/scp /tmp/root/usr/bin/.
cp -rp /etc/passwd /etc/group /etc/dropbear /etc/inittab /etc/shells
/etc/rc.local /tmp/root/etc/.

- Pivot the root filesystem into the memory

mount -o bind /tmp/root /tmp/root
mount -o move /proc /tmp/root/proc
pivot_root /tmp/root /tmp/root/oldroot
mount -o move /oldroot/dev /dev
mount -o move /oldroot/tmp /tmp

- Now you can write your kernel / rootfs partitions

mkdir -p /mnt/kernel; mount -t yaffs2 /dev/${kernel_mtdblock} /mnt/kernel;
gunzip -c /tmp/OpenWRT.kernel.gz > /mnt/kernel/kernel;  # Note, this
is only a .gz because I gzipped it prior to SCP. I have low bandwidth
deployments.. Just put the kernel file in /mnt/kernel/kernel and
ensure executable
chmod +x /mnt/kernel/kernel;
umount /mnt/kernel;
echo 'Kernel Flashed';
umount /oldroot/sys/kernel/debug;
umount /oldroot/sys;
rm -rf /oldroot/*;
ls -la /oldroot;
cd /oldroot;
tar -xzf /tmp/OpenWRT.rootfs;
echo 'Rootfs Flashed';
echo 'Overlay /tmp/sysupgrade.tgz';
tar -xzf /tmp/sysupgrade.tgz;
echo 'Overlay completed!';
sync;
echo 'Upgrade Complete';
reboot;

I of course scripted it. * HOWEVER IF SYSUPGRADE IS CONFIRMED WORKING
WITH THE RB951Ui, USE THAT !!!*
My way is not very well vetted; while I use I have a *very* custom
rb951ui OpenWRT build. I can't emphasis that enough, test sysupgrade
*FIRST!*

-- Davey

On Tue, Oct 20, 2015 at 1:28 AM, Nishant Sharma  wrote:
> Hi,
>
> I have around 50 boxes (ar71xx Mikrotik RB951Ui-2HnD) in the field, running
> AA or BB (custom compiled).
>
> I have checked through the documentation, but could not find any way to
> upgrade the firmware.
>
> Is there a way, that I could upgrade them to the newly compiled firmware
> remotely or only option I have is to recall the boxes back and re-flash
> them?
>
> Thanks in advance.
>
> Regards,
> Nishant
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Firmaware size MT7628

[Baptiste Clenet]

2015-10-20 21:03 GMT+02:00 Baptiste Clenet :
> 2015-10-20 20:28 GMT+02:00 Baptiste Clenet :
>> Hi,
>>
>> I edited the firmware size of the MT7628 board from 4 to 16Mo because
>> I've got 16Mo flash. I began with 8Mo ant it worked well but 16Mo
>> seems to make the board crash at boot with error messages:
>>
>> [0.859932] jffs2: Flash size not aligned to erasesize, reducing to 
>> 6720KiB
>> [0.874195] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x: 0x7368 instead
>> [0.892987] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x0004: 0x0551 instead
>> ...
>> [1.043215] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x0030: 0xfb3a instead
>> [1.061987] jffs2: Further such events for this erase block will
>> not be printed
>> [1.080861] jffs2: Empty flash at 0x0038 ends at 0x0040
>> [1.164315] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x0001: 0xadd7 instead
>> [1.183110] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x00010004: 0x7f0d instead
>> ...
>> [1.611456] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985
>> not found at 0x00020024: 0xeae7 instead
>> [1.630228] jffs2: Further such events for this erase block will
>> not be printed
>> [1.691809] jffs2: Old JFFS2 bitmask found at 0x000295cc
>> [1.702326] jffs2: You cannot use older JFFS2 filesystems with newer 
>> kernels
>>
>> I don't know if the problem comes from the flash driver or something
>> else. Any input would be great if you have already encountered this
>> problem?
>
> I edited the Makefile in target/linux/ramips/image:
> Image/Build/Profile/MT7628=$(call
> BuildFirmware/Default4M/$(1),$(1),mt7628,MT7628)
> To
> Image/Build/Profile/MT7628=$(call
> BuildFirmware/Default16M/$(1),$(1),mt7628,MT7628)
>>
>> Regards,
>>
>> --
>> Baptiste
>
>
>
> --
> Baptiste

Found out my problem by editing the .dts file



-- 
Baptiste
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] omcproxy: fix PKG_LICENSE string

[Daniel Golle]

Signed-off-by: Daniel Golle 
---
 package/network/services/omcproxy/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/services/omcproxy/Makefile 
b/package/network/services/omcproxy/Makefile
index eafa289..75997fe 100644
--- a/package/network/services/omcproxy/Makefile
+++ b/package/network/services/omcproxy/Makefile
@@ -17,7 +17,7 @@ PKG_SOURCE_URL:=https://github.com/sbyx/omcproxy.git
 PKG_SOURCE_PROTO:=git
 PKG_SOURCE_VERSION:=8de9fa84e018e152e45c342f10b5b5140b63e4b1
 PKG_MAINTAINER:=Steven Barth 
-PKG_LICENSE:=APACHE-2.0
+PKG_LICENSE:=Apache-2.0
 
 include $(INCLUDE_DIR)/package.mk
 include $(INCLUDE_DIR)/cmake.mk
-- 
2.6.0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [packages] broken package: procd is broken in 15.05 (#1879)

[Daniel Golle]

Hi!

This has been an argument going on between the gcc and the glibc people
for about 10 years now.
See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509

It seems like commit b6618ffa which added the symlinks silently broke
things when building with glibc.
Don't ask me why glibc enabled warn_unused_result for symlink(3) but
doesn't for found mount(2) or mkdir(3)...

A way around it would be to take things as they are and simply make
sure to surpress the warning as shown in
http://www.redhat.com/archives/rhl-devel-list/2007-March/msg00692.html

Please try the following patch on procd and see if that helps 'fixing'
the unused-return-value warning:
---
diff --git a/initd/early.c b/initd/early.c
index f410256..f82ce54 100644
--- a/initd/early.c
+++ b/initd/early.c
@@ -66,7 +66,7 @@ early_mounts(void)
mount("sysfs", "/sys", "sysfs", MS_NOATIME | MS_NODEV | MS_NOEXEC | 
MS_NOSUID, 0);
mount("cgroup", "/sys/fs/cgroup", "cgroup",  MS_NODEV | MS_NOEXEC | 
MS_NOSUID, 0);
mount("tmpfs", "/dev", "tmpfs", MS_NOATIME | MS_NOSUID, 
"mode=0755,size=512K");
-   symlink("/tmp/shm", "/dev/shm");
+   ignore(symlink("/tmp/shm", "/dev/shm"));
mkdir("/dev/pts", 0755);
mount("devpts", "/dev/pts", "devpts", MS_NOATIME | MS_NOEXEC | 
MS_NOSUID, "mode=600");
early_dev();
diff --git a/plug/coldplug.c b/plug/coldplug.c
index 123e17d..74e345d 100644
--- a/plug/coldplug.c
+++ b/plug/coldplug.c
@@ -45,7 +45,7 @@ void procd_coldplug(void)
umount2("/dev/pts", MNT_DETACH);
umount2("/dev/", MNT_DETACH);
mount("tmpfs", "/dev", "tmpfs", MS_NOSUID, "mode=0755,size=512K");
-   symlink("/tmp/shm", "/dev/shm");
+   ignore(symlink("/tmp/shm", "/dev/shm"));
mkdir("/dev/pts", 0755);
umask(oldumask);
mount("devpts", "/dev/pts", "devpts", MS_NOEXEC | MS_NOSUID, 0);
diff --git a/procd.h b/procd.h
index 66d183c..204a2bb 100644
--- a/procd.h
+++ b/procd.h
@@ -56,4 +56,5 @@ void watch_add(const char *_name, void *id);
 void watch_del(void *id);
 void watch_ubus(struct ubus_context *ctx);
 
+inline __attribute__((always_inline)) int ignore(int x) {return x;}
 #endif



---

On Tue, Oct 20, 2015 at 03:34:07PM -0700, ClaymorePT wrote:
> procd is broken in x86-64
> 
> The compile output follows:
> 
> [claymore@manjaro 15.05]$ make  ./package/system/procd/compile V=s
> make[1]: Entering directory '/home/ArkHDD/OpenWRT/15.05'
> make[2]: Entering directory 
> '/home/ArkHDD/OpenWRT/15.05/package/libs/toolchain'
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then rm -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
>  
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean;
>  fi; echo "libc" >> 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then rm -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
>  
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean;
>  fi; echo "libgcc" >> 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then rm -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
>  
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean;
>  fi; echo "libatomic" >> 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then rm -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
>  
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean;
>  fi; echo "libssp" >> 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then rm -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
>  
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean;
>  fi; echo "libstdcpp" >> 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install
> if [ -f 
> /home/ArkHDD/OpenWRT/15.05/staging_dir/target-x86_64_glibc-2.21/pkginfo/toolchain.default.install.clean
>  ]; then