[OpenWrt-Devel] [PATCH 04/13] package/om-watchdog: add OpenMesh OM2P-HSv3 support

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 package/kernel/om-watchdog/files/om-watchdog.init | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kernel/om-watchdog/files/om-watchdog.init 
b/package/kernel/om-watchdog/files/om-watchdog.init
index 79819ad..4c6ac45 100644
--- a/package/kernel/om-watchdog/files/om-watchdog.init
+++ b/package/kernel/om-watchdog/files/om-watchdog.init
@@ -19,6 +19,7 @@ get_gpio() {
"om2p" | \
"om2p-hs" | \
"om2p-hsv2" | \
+   "om2p-hsv3" | \
"om5p-acv2")
return 12
;;
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 13/13] ar71xx: add MR1750v2 to the MR1750 profile

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/generic/profiles/openmesh.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/generic/profiles/openmesh.mk 
b/target/linux/ar71xx/generic/profiles/openmesh.mk
index eb972ee..15b974a 100644
--- a/target/linux/ar71xx/generic/profiles/openmesh.mk
+++ b/target/linux/ar71xx/generic/profiles/openmesh.mk
@@ -61,12 +61,12 @@ endef
 $(eval $(call Profile,MR900))
 
 define Profile/MR1750
-NAME:=OpenMesh MR1750
+NAME:=OpenMesh MR1750/MR1750v2
 PACKAGES:=kmod-ath9k kmod-ath10k
 endef
 
 define Profile/MR1750/Description
-Package set optimized for the OpenMesh MR1750.
+Package set optimized for the OpenMesh MR1750/MR1750v2.
 endef
 
 $(eval $(call Profile,MR1750))
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 12/13] ar71xx: extract ath10k wifi board.bin for the OpenMesh MR1750v2 board

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata 
b/target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
index 8fc3ab3..f01c6d3 100644
--- a/target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
+++ b/target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
@@ -72,6 +72,7 @@ case "$FIRMWARE" in
ath10kcal_patch_mac $(macaddr_add $(cat 
/sys/class/net/eth0/address) +1)
;;
mr1750 | \
+   mr1750v2 | \
om5p-acv2)
ath10kcal_extract "ART" 20480 2116
ath10kcal_patch_mac $(macaddr_add $(cat 
/sys/class/net/eth0/address) +16)
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 11/13] package/uboot-envtools: add OpenMesh MR1750v2 support

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 package/boot/uboot-envtools/files/ar71xx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/boot/uboot-envtools/files/ar71xx 
b/package/boot/uboot-envtools/files/ar71xx
index dc7583f..986fdef 100644
--- a/package/boot/uboot-envtools/files/ar71xx
+++ b/package/boot/uboot-envtools/files/ar71xx
@@ -25,6 +25,7 @@ eap300v2 | \
 hornet-ub | \
 hornet-ub-x2 | \
 mr1750 | \
+mr1750v2 | \
 mr600 | \
 mr600v2 | \
 mr900 | \
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 10/13] package/om-watchdog: add OpenMesh MR1750v2 support

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 package/kernel/om-watchdog/files/om-watchdog.init | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kernel/om-watchdog/files/om-watchdog.init 
b/package/kernel/om-watchdog/files/om-watchdog.init
index 4c6ac45..4ed178d 100644
--- a/package/kernel/om-watchdog/files/om-watchdog.init
+++ b/package/kernel/om-watchdog/files/om-watchdog.init
@@ -39,7 +39,8 @@ get_gpio() {
;;
"mr900" | \
"mr900v2" | \
-   "mr1750")
+   "mr1750" | \
+   "mr1750v2")
return 16
;;
esac
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 09/13] ar71xx: enable sysupgrade for the OpenMesh MR1750v2

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/base-files/lib/upgrade/platform.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
index 2e01419..2ce5331 100755
--- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
+++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
@@ -313,6 +313,7 @@ platform_check_image() {
return 0;
;;
mr1750 | \
+   mr1750v2 | \
mr600 | \
mr600v2 | \
mr900 | \
@@ -572,6 +573,7 @@ platform_do_upgrade() {
platform_do_upgrade_dir825b "$ARGV"
;;
mr1750 | \
+   mr1750v2 | \
mr600 | \
mr600v2 | \
mr900 | \
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 08/13] ar71xx: add user-space support for the OpenMesh MR1750v2

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/base-files/etc/board.d/01_leds | 3 ++-
 target/linux/ar71xx/base-files/etc/board.d/02_network  | 1 +
 target/linux/ar71xx/base-files/etc/diag.sh | 3 ++-
 target/linux/ar71xx/base-files/lib/ar71xx.sh   | 3 +++
 target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh | 1 +
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/base-files/etc/board.d/01_leds 
b/target/linux/ar71xx/base-files/etc/board.d/01_leds
index e003ebaa..66a031f 100755
--- a/target/linux/ar71xx/base-files/etc/board.d/01_leds
+++ b/target/linux/ar71xx/base-files/etc/board.d/01_leds
@@ -322,7 +322,8 @@ mr600)
ucidef_set_led_wlan "wlan58" "WLAN58" "mr600:green:wlan58" "phy0tpt"
;;
 
-mr1750)
+mr1750 | \
+mr1750v2)
ucidef_set_led_netdev "lan" "LAN" "mr1750:blue:wan" "eth0"
ucidef_set_led_wlan "wlan58" "WLAN58" "mr1750:blue:wlan58" "phy0tpt"
ucidef_set_led_wlan "wlan24" "WLAN24" "mr1750:blue:wlan24" "phy1tpt"
diff --git a/target/linux/ar71xx/base-files/etc/board.d/02_network 
b/target/linux/ar71xx/base-files/etc/board.d/02_network
index 67adf33..6a4cdaf 100755
--- a/target/linux/ar71xx/base-files/etc/board.d/02_network
+++ b/target/linux/ar71xx/base-files/etc/board.d/02_network
@@ -335,6 +335,7 @@ eap7660d |\
 el-mini |\
 loco-m-xw |\
 mr1750 |\
+mr1750v2 |\
 mr18 |\
 mr600 |\
 mr600v2 |\
diff --git a/target/linux/ar71xx/base-files/etc/diag.sh 
b/target/linux/ar71xx/base-files/etc/diag.sh
index ec89470..e296b56 100644
--- a/target/linux/ar71xx/base-files/etc/diag.sh
+++ b/target/linux/ar71xx/base-files/etc/diag.sh
@@ -176,7 +176,8 @@ get_status_led() {
mr600v2)
status_led="mr600:blue:power"
;;
-   mr1750)
+   mr1750 | \
+   mr1750v2)
status_led="mr1750:blue:power"
;;
mr900 | \
diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh 
b/target/linux/ar71xx/base-files/lib/ar71xx.sh
index d00ef8e..12bc9e3 100755
--- a/target/linux/ar71xx/base-files/lib/ar71xx.sh
+++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh
@@ -595,6 +595,9 @@ ar71xx_board_detect() {
*MR1750)
name="mr1750"
;;
+   *MR1750v2)
+   name="mr1750v2"
+   ;;
*MR600)
name="mr600"
;;
diff --git a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
index 270ef40..87b6516 100644
--- a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
+++ b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
@@ -65,6 +65,7 @@ platform_check_image_target_openmesh()
;;
MR1750)
[ "$board" = "mr1750" ] && return 0
+   [ "$board" = "mr1750v2" ] && return 0
echo "Invalid image board target ($img_board_target) 
for this platform: $board. Use the correct image for this platform"
return 1
;;
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 07/13] ar71xx: add kernel support for the OpenMesh MR1750v2

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-mr1750.c | 1 +
 target/linux/ar71xx/files/arch/mips/ath79/machtypes.h   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-mr1750.c 
b/target/linux/ar71xx/files/arch/mips/ath79/mach-mr1750.c
index e3c04e7..18101ce 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-mr1750.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-mr1750.c
@@ -168,3 +168,4 @@ static void __init mr1750_setup(void)
 }
 
 MIPS_MACHINE(ATH79_MACH_MR1750, "MR1750", "OpenMesh MR1750", mr1750_setup);
+MIPS_MACHINE(ATH79_MACH_MR1750V2, "MR1750v2", "OpenMesh MR1750v2", 
mr1750_setup);
diff --git a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h 
b/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
index e5341f1..0e88996 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
+++ b/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
@@ -96,6 +96,7 @@ enum ath79_mach_type {
ATH79_MACH_MR16,/* Cisco Meraki MR16 */
ATH79_MACH_MR18,/* Cisco Meraki MR18 */
ATH79_MACH_MR1750,  /* OpenMesh MR1750 */
+   ATH79_MACH_MR1750V2,/* OpenMesh MR1750v2 */
ATH79_MACH_MR600V2, /* OpenMesh MR600v2 */
ATH79_MACH_MR600,   /* OpenMesh MR600 */
ATH79_MACH_MR900,   /* OpenMesh MR900 */
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 06/13] ar71xx: add OM2P-HSv3 to the OM2P profile

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/generic/profiles/openmesh.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/generic/profiles/openmesh.mk 
b/target/linux/ar71xx/generic/profiles/openmesh.mk
index 6817c59..eb972ee 100644
--- a/target/linux/ar71xx/generic/profiles/openmesh.mk
+++ b/target/linux/ar71xx/generic/profiles/openmesh.mk
@@ -6,12 +6,12 @@
 #
 
 define Profile/OM2P
-   NAME:=OpenMesh OM2P/OM2Pv2/OM2P-HS/OM2P-HSv2/OM2P-LC
+   NAME:=OpenMesh OM2P/OM2Pv2/OM2P-HS/OM2P-HSv2/OM2P-HSv3/OM2P-LC
PACKAGES:=kmod-ath9k om-watchdog
 endef
 
 define Profile/OM2P/Description
-   Package set optimized for the OpenMesh 
OM2P/OM2Pv2/OM2P-HS/OM2P-HSv2/OM2P-LC.
+   Package set optimized for the OpenMesh 
OM2P/OM2Pv2/OM2P-HS/OM2P-HSv2/OM2P-HSv3/OM2P-LC.
 endef
 
 $(eval $(call Profile,OM2P))
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 05/13] package/uboot-envtools: add OpenMesh OM2P-HSv3 support

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 package/boot/uboot-envtools/files/ar71xx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/boot/uboot-envtools/files/ar71xx 
b/package/boot/uboot-envtools/files/ar71xx
index 32e7269..dc7583f 100644
--- a/package/boot/uboot-envtools/files/ar71xx
+++ b/package/boot/uboot-envtools/files/ar71xx
@@ -44,6 +44,7 @@ om2p | \
 om2pv2 | \
 om2p-hs | \
 om2p-hsv2 | \
+om2p-hsv3 | \
 om2p-lc)
ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x4" "0x4"
;;
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 03/13] ar71xx: enable sysupgrade for the OpenMesh OM2P-HSv3

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh | 1 +
 target/linux/ar71xx/base-files/lib/upgrade/platform.sh | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
index bc362a7..270ef40 100644
--- a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
+++ b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
@@ -47,6 +47,7 @@ platform_check_image_target_openmesh()
[ "$board" = "om2p-lc" ] && return 0
[ "$board" = "om2p-hs" ] && return 0
[ "$board" = "om2p-hsv2" ] && return 0
+   [ "$board" = "om2p-hsv3" ] && return 0
echo "Invalid image board target ($img_board_target) 
for this platform: $board. Use the correct image for this platform"
return 1
;;
diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
index 9f8a14b..2e01419 100755
--- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
+++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
@@ -321,6 +321,7 @@ platform_check_image() {
om2pv2 | \
om2p-hs | \
om2p-hsv2 | \
+   om2p-hsv3 | \
om2p-lc | \
om5p | \
om5p-an | \
@@ -579,6 +580,7 @@ platform_do_upgrade() {
om2pv2 | \
om2p-hs | \
om2p-hsv2 | \
+   om2p-hsv3 | \
om2p-lc | \
om5p | \
om5p-an | \
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 02/13] ar71xx: add user-space support for the OpenMesh OM2P-HSv3

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/base-files/etc/board.d/01_leds | 1 +
 target/linux/ar71xx/base-files/etc/diag.sh | 1 +
 target/linux/ar71xx/base-files/lib/ar71xx.sh   | 3 +++
 3 files changed, 5 insertions(+)

diff --git a/target/linux/ar71xx/base-files/etc/board.d/01_leds 
b/target/linux/ar71xx/base-files/etc/board.d/01_leds
index 39b21ca..e003ebaa 100755
--- a/target/linux/ar71xx/base-files/etc/board.d/01_leds
+++ b/target/linux/ar71xx/base-files/etc/board.d/01_leds
@@ -383,6 +383,7 @@ om2p | \
 om2pv2 | \
 om2p-hs | \
 om2p-hsv2 | \
+om2p-hsv3 | \
 om2p-lc)
ucidef_set_led_netdev "port1" "port1" "om2p:blue:wan" "eth0"
ucidef_set_led_netdev "port2" "port2" "om2p:blue:lan" "eth1"
diff --git a/target/linux/ar71xx/base-files/etc/diag.sh 
b/target/linux/ar71xx/base-files/etc/diag.sh
index f95a72d..ec89470 100644
--- a/target/linux/ar71xx/base-files/etc/diag.sh
+++ b/target/linux/ar71xx/base-files/etc/diag.sh
@@ -207,6 +207,7 @@ get_status_led() {
om2pv2 | \
om2p-hs | \
om2p-hsv2 | \
+   om2p-hsv3 | \
om2p-lc)
status_led="om2p:blue:power"
;;
diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh 
b/target/linux/ar71xx/base-files/lib/ar71xx.sh
index d71b8ba..d00ef8e 100755
--- a/target/linux/ar71xx/base-files/lib/ar71xx.sh
+++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh
@@ -640,6 +640,9 @@ ar71xx_board_detect() {
*"OM2P HSv2")
name="om2p-hsv2"
;;
+   *"OM2P HSv3")
+   name="om2p-hsv3"
+   ;;
*"OM2P LC")
name="om2p-lc"
;;
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 01/13] ar71xx: add kernel support for the OpenMesh OM2P-HSv3

2016-05-20 Thread Sven Eckelmann 
Signed-off-by: Sven Eckelmann 
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-om2p.c | 1 +
 target/linux/ar71xx/files/arch/mips/ath79/machtypes.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-om2p.c 
b/target/linux/ar71xx/files/arch/mips/ath79/mach-om2p.c
index 6b0bdc3..3b282a3 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-om2p.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-om2p.c
@@ -223,3 +223,4 @@ static void __init om2p_hs_setup(void)
 
 MIPS_MACHINE(ATH79_MACH_OM2P_HS, "OM2P-HS", "OpenMesh OM2P HS", om2p_hs_setup);
 MIPS_MACHINE(ATH79_MACH_OM2P_HSv2, "OM2P-HSv2", "OpenMesh OM2P HSv2", 
om2p_hs_setup);
+MIPS_MACHINE(ATH79_MACH_OM2P_HSv3, "OM2P-HSv3", "OpenMesh OM2P HSv3", 
om2p_hs_setup);
diff --git a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h 
b/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
index 4879255..e5341f1 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
+++ b/target/linux/ar71xx/files/arch/mips/ath79/machtypes.h
@@ -109,6 +109,7 @@ enum ath79_mach_type {
ATH79_MACH_NBG6616, /* Zyxel NBG6616 */
ATH79_MACH_NBG6716, /* Zyxel NBG6716 */
ATH79_MACH_OM2P_HSv2,   /* OpenMesh OM2P-HSv2 */
+   ATH79_MACH_OM2P_HSv3,   /* OpenMesh OM2P-HSv3 */
ATH79_MACH_OM2P_HS, /* OpenMesh OM2P-HS */
ATH79_MACH_OM2P_LC, /* OpenMesh OM2P-LC */
ATH79_MACH_OM2Pv2,  /* OpenMesh OM2Pv2 */
-- 
2.8.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed 
Hi,
Please add raw triggers to only the interfaces specified in the list.

Regards,
Amine.

On Fri, May 20, 2016 at 4:11 PM, Hans Dedecker  wrote:
> On Fri, May 20, 2016 at 3:59 PM, Conor O'Gorman  wrote:
>>
>>
>> On 20/05/16 14:43, Hans Dedecker wrote:
>>>
>>> On Fri, May 20, 2016 at 3:18 PM, David Lang  wrote:

 On Fri, 20 May 2016, Jo-Philipp Wich wrote:

> Hi Hans,
>
>> I wanted to preserve the ntp server behavior and only change the
>> behavior when configured in order to keep backwards compatibility. You
>> favour enabling DHCP ntp server config without explicit config ?
>
>
> Personally I do because thats likely what most users expect, but then
> trusting foreign NTP server advertisements might be a security sensitive
> topic - on the other hand one trusts the default gateway and DNS
> advertisements too, so I don't know.


 NTP isn't signed.

 If I can control your DNS, I can probably control your NTP by giving you
 the
 wrong IP for the NTP server

 If I can control your gateway, I can redirect all your NTP queries to
 someone else (NAT, redirects, etc)

 so why not trust the NTP server being provided?
>>>
>>> OK let's make the concensus to enable use_dhcp by default
>>>
>>>
>> If there are none from dhcp, it'll fall back to the configured list?
>>
>> Servers from dhcp are extra? or replacing the configured?
> Servers from DHCP are extra; thus on top of the configured ones
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Hans Dedecker 
On Fri, May 20, 2016 at 3:59 PM, Conor O'Gorman  wrote:
>
>
> On 20/05/16 14:43, Hans Dedecker wrote:
>>
>> On Fri, May 20, 2016 at 3:18 PM, David Lang  wrote:
>>>
>>> On Fri, 20 May 2016, Jo-Philipp Wich wrote:
>>>
 Hi Hans,

> I wanted to preserve the ntp server behavior and only change the
> behavior when configured in order to keep backwards compatibility. You
> favour enabling DHCP ntp server config without explicit config ?


 Personally I do because thats likely what most users expect, but then
 trusting foreign NTP server advertisements might be a security sensitive
 topic - on the other hand one trusts the default gateway and DNS
 advertisements too, so I don't know.
>>>
>>>
>>> NTP isn't signed.
>>>
>>> If I can control your DNS, I can probably control your NTP by giving you
>>> the
>>> wrong IP for the NTP server
>>>
>>> If I can control your gateway, I can redirect all your NTP queries to
>>> someone else (NAT, redirects, etc)
>>>
>>> so why not trust the NTP server being provided?
>>
>> OK let's make the concensus to enable use_dhcp by default
>>
>>
> If there are none from dhcp, it'll fall back to the configured list?
>
> Servers from dhcp are extra? or replacing the configured?
Servers from DHCP are extra; thus on top of the configured ones
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Conor O'Gorman 



On 20/05/16 14:43, Hans Dedecker wrote:

On Fri, May 20, 2016 at 3:18 PM, David Lang  wrote:

On Fri, 20 May 2016, Jo-Philipp Wich wrote:


Hi Hans,


I wanted to preserve the ntp server behavior and only change the
behavior when configured in order to keep backwards compatibility. You
favour enabling DHCP ntp server config without explicit config ?


Personally I do because thats likely what most users expect, but then
trusting foreign NTP server advertisements might be a security sensitive
topic - on the other hand one trusts the default gateway and DNS
advertisements too, so I don't know.


NTP isn't signed.

If I can control your DNS, I can probably control your NTP by giving you the
wrong IP for the NTP server

If I can control your gateway, I can redirect all your NTP queries to
someone else (NAT, redirects, etc)

so why not trust the NTP server being provided?

OK let's make the concensus to enable use_dhcp by default



If there are none from dhcp, it'll fall back to the configured list?

Servers from dhcp are extra? or replacing the configured?
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Hans Dedecker 
On Fri, May 20, 2016 at 3:18 PM, David Lang  wrote:
> On Fri, 20 May 2016, Jo-Philipp Wich wrote:
>
>> Hi Hans,
>>
>>> I wanted to preserve the ntp server behavior and only change the
>>> behavior when configured in order to keep backwards compatibility. You
>>> favour enabling DHCP ntp server config without explicit config ?
>>
>>
>> Personally I do because thats likely what most users expect, but then
>> trusting foreign NTP server advertisements might be a security sensitive
>> topic - on the other hand one trusts the default gateway and DNS
>> advertisements too, so I don't know.
>
>
> NTP isn't signed.
>
> If I can control your DNS, I can probably control your NTP by giving you the
> wrong IP for the NTP server
>
> If I can control your gateway, I can redirect all your NTP queries to
> someone else (NAT, redirects, etc)
>
> so why not trust the NTP server being provided?
OK let's make the concensus to enable use_dhcp by default

Hans
>
> David Lang
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread David Lang 

On Fri, 20 May 2016, Jo-Philipp Wich wrote:


Hi Hans,


I wanted to preserve the ntp server behavior and only change the
behavior when configured in order to keep backwards compatibility. You
favour enabling DHCP ntp server config without explicit config ?


Personally I do because thats likely what most users expect, but then
trusting foreign NTP server advertisements might be a security sensitive
topic - on the other hand one trusts the default gateway and DNS
advertisements too, so I don't know.


NTP isn't signed.

If I can control your DNS, I can probably control your NTP by giving you the 
wrong IP for the NTP server


If I can control your gateway, I can redirect all your NTP queries to someone 
else (NAT, redirects, etc)


so why not trust the NTP server being provided?

David Lang
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed 
Hi,
Please add raw triggers to only the interfaces specified in the list.

Regards,
Amine.

On Thu, May 19, 2016 at 6:57 PM, Hans Dedecker  wrote:
> The busybox ntpd utility currently uses ntp servers specified in uci.
> This patch allows the ntpd utility to use NTP servers received via DHCP(v6)
> Following uci parameters have been added:
> use_dhcp : enables NTP server config via DHCP(v6)
> dhcp_interface : use NTP servers received only on the specified DHCP(v6) 
> interfaces; if empty all interfaces are considered
>
> Signed-off-by: Hans Dedecker 
> ---
>
> The patch is based on a previous discussion held on the OpenWRT-devel mailing 
> list
> (https://lists.openwrt.org/pipermail/openwrt-devel/2016-January/039081.html) 
> as per Felix's
> comments this solution is based on procd interface service triggers
>
>  package/utils/busybox/Makefile  |  2 +-
>  package/utils/busybox/files/sysntpd | 43 
> -
>  2 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/package/utils/busybox/Makefile b/package/utils/busybox/Makefile
> index 24c064c..24e0e11 100644
> --- a/package/utils/busybox/Makefile
> +++ b/package/utils/busybox/Makefile
> @@ -42,7 +42,7 @@ define Package/busybox
>MAINTAINER:=Felix Fietkau 
>TITLE:=Core utilities for embedded Linux
>URL:=http://busybox.net/
> -  DEPENDS:=+BUSYBOX_USE_LIBRPC:librpc +BUSYBOX_CONFIG_PAM:libpam
> +  DEPENDS:=+BUSYBOX_USE_LIBRPC:librpc +BUSYBOX_CONFIG_PAM:libpam +jsonfilter
>MENU:=1
>  endef
>
> diff --git a/package/utils/busybox/files/sysntpd 
> b/package/utils/busybox/files/sysntpd
> index f73bb83..5c663d7 100755
> --- a/package/utils/busybox/files/sysntpd
> +++ b/package/utils/busybox/files/sysntpd
> @@ -7,13 +7,35 @@ USE_PROCD=1
>  PROG=/usr/sbin/ntpd
>  HOTPLUG_SCRIPT=/usr/sbin/ntpd-hotplug
>
> +get_dhcp_ntp_servers() {
> +   local interfaces="$1"
> +   local filter="*"
> +   local network_dump interface ntpservers ntpserver
> +
> +   network_dump=$(ubus call network.interface dump)
> +   for interface in $interfaces; do
> +   [ "$filter" = "*" ] && filter="@.interface='$interface'" || 
> filter="$filter,@.interface='$interface'"
> +   done
> +
> +   ntpservers=$(jsonfilter -s "$network_dump" -e 
> "@.interface[$filter]['data']['ntpserver']")
> +
> +   for ntpserver in $ntpservers; do
> +   local duplicate=0
> +   local entry
> +   for entry in $server; do
> +   [ "$ntpserver" = "$entry" ] && duplicate=1
> +   done
> +   [ "$duplicate" = 0 ] && server="$server $ntpserver"
> +   done
> +}
> +
>  validate_ntp_section() {
> uci_validate_section system timeserver "${1}" \
> -   'server:list(host)' 'enabled:bool:1' 'enable_server:bool:0'
> +   'server:list(host)' 'enabled:bool:1' 'enable_server:bool:0' 
> 'use_dhcp:bool:0' 'dhcp_interface:list(string)'
>  }
>
>  start_service() {
> -   local server enabled enable_server peer
> +   local server enabled enable_server use_dhcp dhcp_interface peer
>
> validate_ntp_section ntp || {
> echo "validation failed"
> @@ -22,6 +44,8 @@ start_service() {
>
> [ $enabled = 0 ] && return
>
> +   [ $use_dhcp = 1 ] && get_dhcp_ntp_servers "$dhcp_interface"
> +
> [ -z "$server" ] && return
>
> procd_open_instance
> @@ -35,8 +59,17 @@ start_service() {
> procd_close_instance
>  }
>
> -service_triggers()
> -{
> -   procd_add_reload_trigger "system"
> +service_triggers() {
> +   local script name
> +
> +   script=$(readlink -f "$initscript")
> +   name=$(basename ${script:-$initscript})
> +
> +   procd_open_trigger
> +   procd_add_config_trigger "config.change" "system" /etc/init.d/$name 
> reload
> +
> +   procd_add_raw_trigger "interface.*" 2000 /etc/init.d/$name reload
> +   procd_close_trigger
> +
> procd_add_validation validate_ntp_section
>  }
> --
> 1.9.1
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed 
Hi,
One feature that was requested is the ability to specify a list of
interfaces to get servers from.
You can save the list as an option to the config file and add a trigger to
only those interfaces.
Regards,
Amine.

On Thu, May 19, 2016 at 6:57 PM, Hans Dedecker  wrote:

> The busybox ntpd utility currently uses ntp servers specified in uci.
> This patch allows the ntpd utility to use NTP servers received via DHCP(v6)
> Following uci parameters have been added:
> use_dhcp : enables NTP server config via DHCP(v6)
> dhcp_interface : use NTP servers received only on the specified
> DHCP(v6) interfaces; if empty all interfaces are considered
>
> Signed-off-by: Hans Dedecker 
> ---
>
> The patch is based on a previous discussion held on the OpenWRT-devel
> mailing list
> (
> https://lists.openwrt.org/pipermail/openwrt-devel/2016-January/039081.html)
> as per Felix's
> comments this solution is based on procd interface service triggers
>
>  package/utils/busybox/Makefile  |  2 +-
>  package/utils/busybox/files/sysntpd | 43
> -
>  2 files changed, 39 insertions(+), 6 deletions(-)
>
> diff --git a/package/utils/busybox/Makefile
> b/package/utils/busybox/Makefile
> index 24c064c..24e0e11 100644
> --- a/package/utils/busybox/Makefile
> +++ b/package/utils/busybox/Makefile
> @@ -42,7 +42,7 @@ define Package/busybox
>MAINTAINER:=Felix Fietkau 
>TITLE:=Core utilities for embedded Linux
>URL:=http://busybox.net/
> -  DEPENDS:=+BUSYBOX_USE_LIBRPC:librpc +BUSYBOX_CONFIG_PAM:libpam
> +  DEPENDS:=+BUSYBOX_USE_LIBRPC:librpc +BUSYBOX_CONFIG_PAM:libpam
> +jsonfilter
>MENU:=1
>  endef
>
> diff --git a/package/utils/busybox/files/sysntpd
> b/package/utils/busybox/files/sysntpd
> index f73bb83..5c663d7 100755
> --- a/package/utils/busybox/files/sysntpd
> +++ b/package/utils/busybox/files/sysntpd
> @@ -7,13 +7,35 @@ USE_PROCD=1
>  PROG=/usr/sbin/ntpd
>  HOTPLUG_SCRIPT=/usr/sbin/ntpd-hotplug
>
> +get_dhcp_ntp_servers() {
> +   local interfaces="$1"
> +   local filter="*"
> +   local network_dump interface ntpservers ntpserver
> +
> +   network_dump=$(ubus call network.interface dump)
> +   for interface in $interfaces; do
> +   [ "$filter" = "*" ] && filter="@.interface='$interface'"
> || filter="$filter,@.interface='$interface'"
> +   done
> +
> +   ntpservers=$(jsonfilter -s "$network_dump" -e
> "@.interface[$filter]['data']['ntpserver']")
> +
> +   for ntpserver in $ntpservers; do
> +   local duplicate=0
> +   local entry
> +   for entry in $server; do
> +   [ "$ntpserver" = "$entry" ] && duplicate=1
> +   done
> +   [ "$duplicate" = 0 ] && server="$server $ntpserver"
> +   done
> +}
> +
>  validate_ntp_section() {
> uci_validate_section system timeserver "${1}" \
> -   'server:list(host)' 'enabled:bool:1' 'enable_server:bool:0'
> +   'server:list(host)' 'enabled:bool:1'
> 'enable_server:bool:0' 'use_dhcp:bool:0' 'dhcp_interface:list(string)'
>  }
>
>  start_service() {
> -   local server enabled enable_server peer
> +   local server enabled enable_server use_dhcp dhcp_interface peer
>
> validate_ntp_section ntp || {
> echo "validation failed"
> @@ -22,6 +44,8 @@ start_service() {
>
> [ $enabled = 0 ] && return
>
> +   [ $use_dhcp = 1 ] && get_dhcp_ntp_servers "$dhcp_interface"
> +
> [ -z "$server" ] && return
>
> procd_open_instance
> @@ -35,8 +59,17 @@ start_service() {
> procd_close_instance
>  }
>
> -service_triggers()
> -{
> -   procd_add_reload_trigger "system"
> +service_triggers() {
> +   local script name
> +
> +   script=$(readlink -f "$initscript")
> +   name=$(basename ${script:-$initscript})
> +
> +   procd_open_trigger
> +   procd_add_config_trigger "config.change" "system"
> /etc/init.d/$name reload
> +
> +   procd_add_raw_trigger "interface.*" 2000 /etc/init.d/$name reload
> +   procd_close_trigger
> +
> procd_add_validation validate_ntp_section
>  }
> --
> 1.9.1
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed 
Hi,
One feature that was requested is the ability to specify a list of
interfaces to get servers from.
You can save the list as an option to the config file and add a trigger to
only those interfaces.
Regards,
Amine.

On Fri, May 20, 2016 at 11:01 AM, Jo-Philipp Wich  wrote:

> Hi Hans,
>
> > I wanted to preserve the ntp server behavior and only change the
> > behavior when configured in order to keep backwards compatibility. You
> > favour enabling DHCP ntp server config without explicit config ?
>
> Personally I do because thats likely what most users expect, but then
> trusting foreign NTP server advertisements might be a security sensitive
> topic - on the other hand one trusts the default gateway and DNS
> advertisements too, so I don't know.
>
>
> > Regarding the improvements do you want me to send a patch containing
> > the diff with the already staged commit or do you prefer a v2 patch ?
>
> Whatever you prefer - I think a v2 is the easiest and I can just replace
> the commit in my tree.
>
> ~ Jo
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>



-- 

Amine Hamed | Software Engineer



Ocedo GmbH | Hirschstrasse 7 | 76133 Karlsruhe | Germany

Email aha...@ocedo.com




REGISTERED OFFICE: KARLSRUHE | DISTRICT COURT: MANNHEIM | REGISTER NUMBER:
HRB 717873
MANAGING DIRECTOR: MARKUS HENNIG|JAN HICHERT
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Jo-Philipp Wich 
Hi Hans,

> I wanted to preserve the ntp server behavior and only change the
> behavior when configured in order to keep backwards compatibility. You
> favour enabling DHCP ntp server config without explicit config ?

Personally I do because thats likely what most users expect, but then
trusting foreign NTP server advertisements might be a security sensitive
topic - on the other hand one trusts the default gateway and DNS
advertisements too, so I don't know.


> Regarding the improvements do you want me to send a patch containing
> the diff with the already staged commit or do you prefer a v2 patch ?

Whatever you prefer - I think a v2 is the easiest and I can just replace
the commit in my tree.

~ Jo
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] conntrack: enable support for netfilter conntrack zones

2016-05-20 Thread Alin Năstac 
Hi Jo,

You have my ACK. ;)
Sorry about that, I will sign my patches from now on.

BR,
Alin

On Thu, May 19, 2016 at 6:21 PM, Jo-Philipp Wich  wrote:
> Hi Alin,
>
> I merged your patch into my staging tree at
>
> https://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=6c9231baa9c5341c6ee2e213618dcde72d42288b
>
> Since your change lacked a proper Signed-off-by I added it on your
> behalf. Please review the link above and give me your ACK, then I'll
> push it to master after some compile testing.
>
> Regards,
> Jo
>
> On 05/19/2016 09:54 AM, Alin Nastac wrote:
>> Storage of such zones is provided by a nf_ct_ext struct, hence conntrack
>> memory foot print will not be increased if zones are not used.
>> ---
>>  package/kernel/linux/modules/netfilter.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/kernel/linux/modules/netfilter.mk 
>> b/package/kernel/linux/modules/netfilter.mk
>> index 3b623e4..4d9c116 100644
>> --- a/package/kernel/linux/modules/netfilter.mk
>> +++ b/package/kernel/linux/modules/netfilter.mk
>> @@ -68,6 +68,7 @@ define KernelPackage/nf-conntrack
>>KCONFIG:= \
>>  CONFIG_NETFILTER=y \
>>  CONFIG_NETFILTER_ADVANCED=y \
>> +CONFIG_NF_CONNTRACK_ZONES=y \
>>   $(KCONFIG_NF_CONNTRACK)
>>FILES:=$(foreach mod,$(NF_CONNTRACK-m),$(LINUX_DIR)/net/$(mod).ko)
>>AUTOLOAD:=$(call AutoProbe,$(notdir $(NF_CONNTRACK-m)))
>>
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel