[OpenWrt-Devel] Important Notification
Dear Recipent , This email address has won Three Million Pounds on the o2 mobile sweepstakes.Please Contact Payment Cordinator Mat on email : mrw...@o2loto.co.uk for explanation and payment processing . Yours Faithfully Debbie Spence Cordinator O2 Mobile Promotional Sweepstakes. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: mir3g: reduce usb power flapping at boot
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- > On 11 Jun 2018, at 15:56, Mathias Kresin wrote: > > 08.06.2018 20:45, Kevin Darbyshire-Bryant: >> Define USB port power as set on by bootloader (which it is) The power >> gets cycled at kernel boot, but by defining as 'regulator-boot-on' >> reduces the power off to power on at driver initial load & setup from >> around 5 seconds to around 2 seconds. >> Signed-off-by: Kevin Darbyshire-Bryant >> --- >> target/linux/ramips/dts/MIR3G.dts | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/target/linux/ramips/dts/MIR3G.dts >> b/target/linux/ramips/dts/MIR3G.dts >> index 44dfc1796c..1ca085e6c4 100644 >> --- a/target/linux/ramips/dts/MIR3G.dts >> +++ b/target/linux/ramips/dts/MIR3G.dts >> @@ -72,6 +72,7 @@ >> regulator-min-microvolt = <500>; >> regulator-max-microvolt = <500>; >> gpio = < 12 GPIO_ACTIVE_HIGH>; >> +regulator-boot-on; >> enable-active-high; >> }; > > NAK on this one. > > Following our conversation on IRC, I had a look at the fixed regulator code > to see what it really does. By default the regulator is disabled during > driver load[0]. The "regulator-boot-on" inverts the logic and enables the > regulator while loading the fixed regulator driver. > > In my opinion, enabling the fixed regulator unconditionally on boot > contradicts your initial "switch to fixed regulator" patch. Without the > "regulator-boot-on", the GPIO is pulled LOW (usb pwr disabled) on boot and > it's the usb driver which enables the usb pwr (pulls HIGH) == controls the > power supply. This way the usb pwr stays/is off, if someone decides to not > include or load the usb driver. > > Mathias > > [0] > https://github.com/torvalds/linux/blob/master/drivers/regulator/fixed.c#L159 I ack your nack. Absolutely fine reasoning. Cheers, Kevin D-B 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: mir3g: reduce usb power flapping at boot
08.06.2018 20:45, Kevin Darbyshire-Bryant: Define USB port power as set on by bootloader (which it is) The power gets cycled at kernel boot, but by defining as 'regulator-boot-on' reduces the power off to power on at driver initial load & setup from around 5 seconds to around 2 seconds. Signed-off-by: Kevin Darbyshire-Bryant --- target/linux/ramips/dts/MIR3G.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/ramips/dts/MIR3G.dts b/target/linux/ramips/dts/MIR3G.dts index 44dfc1796c..1ca085e6c4 100644 --- a/target/linux/ramips/dts/MIR3G.dts +++ b/target/linux/ramips/dts/MIR3G.dts @@ -72,6 +72,7 @@ regulator-min-microvolt = <500>; regulator-max-microvolt = <500>; gpio = < 12 GPIO_ACTIVE_HIGH>; + regulator-boot-on; enable-active-high; }; NAK on this one. Following our conversation on IRC, I had a look at the fixed regulator code to see what it really does. By default the regulator is disabled during driver load[0]. The "regulator-boot-on" inverts the logic and enables the regulator while loading the fixed regulator driver. In my opinion, enabling the fixed regulator unconditionally on boot contradicts your initial "switch to fixed regulator" patch. Without the "regulator-boot-on", the GPIO is pulled LOW (usb pwr disabled) on boot and it's the usb driver which enables the usb pwr (pulls HIGH) == controls the power supply. This way the usb pwr stays/is off, if someone decides to not include or load the usb driver. Mathias [0] https://github.com/torvalds/linux/blob/master/drivers/regulator/fixed.c#L159 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] base-files: exit if mtd write command fails during sysupgrade
From: Rafał Miłecki
It avoids confusing situations like:
> Could not get image magic
> Image check failed.
> Upgrade completed
> Rebooting system...
Signed-off-by: Rafał Miłecki
---
package/base-files/files/lib/upgrade/common.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/base-files/files/lib/upgrade/common.sh
b/package/base-files/files/lib/upgrade/common.sh
index 5f5c9dc8a3..2305bbea19 100644
--- a/package/base-files/files/lib/upgrade/common.sh
+++ b/package/base-files/files/lib/upgrade/common.sh
@@ -222,6 +222,7 @@ default_do_upgrade() {
else
get_image "$1" "$2" | mtd write - "${PART_NAME:-image}"
fi
+ [ $? -ne 0 ] && exit 1
}
do_upgrade_stage2() {
--
2.13.7
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel
Re: [OpenWrt-Devel] sysupgrade broken by 30f61a34b4cf ("base-files: always use staged sysupgrade")
On Sun, 10 Jun 2018 at 15:53, Matthias Schiffer
wrote:
> On 06/09/2018 02:54 PM, Rafał Miłecki wrote:
> > brcm47xx and bcm53xx targets support multiple firmware formats, most
> > of them are TRX files with vendor-specific header prepended.
> >
> > They are handled in [0]
> > target/linux/bcm53xx/base-files/lib/upgrade/platform.sh
> > by the platform_do_upgrade() which builds a proper command for
> > extracting TRX out of vendor-specific format.
> >
> > Example:
> > To sysupgrade using Linksys's CyberTAN format something like this is called:
> > default_do_upgrade "/tmp/linksys-foo.bin" "dd bs=64 skip=1"
> >
> > The problem is above commit introduced a regression breaking
> > sysupgrade using all these formats. The string returned by get_image()
> > has changed
> >
> > Before:
> > cat /tmp/linksys-foo.bin | dd skip=32 iflag=skip_bytes
> >
> > After:
> > dd skip=32 iflag=skip_bytes /tmp/linksys-foo.bin 2>/dev/null
> >
> > As you can see command generated by get_image() after commit [1]
> > 30f61a34b4cf ("base-files: always use staged sysupgrade") has changed,
> > is wrong and can't work.
> >
> > Matthias: can you look at this, please?
>
> Hi,
> please check if the fix in my staging fixes the issue.
If does, thank you!
--
Rafał
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] iproute2: update to 4.17.0
Hi,
On Sun, Jun 10, 2018 at 11:54 PM Russell Senior
wrote:
>
>
> Signed-off-by: Russell Senior
> ---
I get the following compile issues if the rdma utility is enabled :
CC rdma.o
In file included from
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/resolv.h:6:0,
from ../include/utils.h:7,
from rdma.h:25,
from rdma.c:12:
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/netinet/in.h:23:8:
error: redefinition of 'struct in6_addr'
struct in6_addr {
^~~~
In file included from ./include/uapi/rdma/rdma_user_cm.h:39:0,
from rdma.h:20,
from rdma.c:12:
../include/uapi/linux/in6.h:33:8: note: originally defined here
struct in6_addr {
^~~~
In file included from
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/resolv.h:6:0,
from ../include/utils.h:7,
from rdma.h:25,
from rdma.c:12:
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/netinet/in.h:34:8:
error: redefinition of 'struct sockaddr_in6'
struct sockaddr_in6 {
^~~~
In file included from ./include/uapi/rdma/rdma_user_cm.h:39:0,
from rdma.h:20,
from rdma.c:12:
../include/uapi/linux/in6.h:50:8: note: originally defined here
struct sockaddr_in6 {
^~~~
In file included from
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/resolv.h:6:0,
from ../include/utils.h:7,
from rdma.h:25,
from rdma.c:12:
/home/dedeckeh/arm_virt_staging/staging_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-7.3.0_musl_eabi/include/netinet/in.h:42:8:
error: redefinition of 'struct ipv6_mreq'
struct ipv6_mreq {
^
In file included from ./include/uapi/rdma/rdma_user_cm.h:39:0,
from rdma.h:20,
from rdma.c:12:
../include/uapi/linux/in6.h:60:8: note: originally defined here
struct ipv6_mreq {
^
make[4]: *** [../config.mk:33: rdma.o] Error 1
make[3]: *** [Makefile:70: all] Error 2
> package/network/utils/iproute2/Makefile | 6 +-
> ...int-fix-hidden-64-bit-type-promotion.patch | 288 --
> .../utils/iproute2/patches/008-no_netem.patch | 4 +-
> .../iproute2/patches/110-extra-ccopts.patch | 2 +-
> .../iproute2/patches/120-libnetlink-pic.patch | 2 +-
> .../utils/iproute2/patches/300-ip_tiny.patch | 8 +-
> .../iproute2/patches/950-add-cake-to-tc.patch | 11 -
> 7 files changed, 11 insertions(+), 310 deletions(-)
> delete mode 100644
> package/network/utils/iproute2/patches/002-json_print-fix-hidden-64-bit-type-promotion.patch
>
> diff --git a/package/network/utils/iproute2/Makefile
> b/package/network/utils/iproute2/Makefile
> index 88a4851748..c5e9c5a66e 100644
> --- a/package/network/utils/iproute2/Makefile
> +++ b/package/network/utils/iproute2/Makefile
> @@ -8,12 +8,12 @@
> include $(TOPDIR)/rules.mk
>
> PKG_NAME:=iproute2
> -PKG_VERSION:=4.16.0
> -PKG_RELEASE:=3
> +PKG_VERSION:=4.17.0
> +PKG_RELEASE:=1
>
> PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
> PKG_SOURCE_URL:=@KERNEL/linux/utils/net/iproute2
> -PKG_HASH:=0c5c24020fd7349fe25728c5edee9fb6a1bc8a38f08e23be5c57a6301e55ee0a
> +PKG_HASH:=6fa991b092315887775b9e47dc6a89af7ae09dd3ad4ccff754d055c566b4be6e
> PKG_BUILD_PARALLEL:=1
> PKG_BUILD_DEPENDS:=iptables
> PKG_LICENSE:=GPL-2.0
> diff --git
> a/package/network/utils/iproute2/patches/002-json_print-fix-hidden-64-bit-type-promotion.patch
>
> b/package/network/utils/iproute2/patches/002-json_print-fix-hidden-64-bit-type-promotion.patch
> deleted file mode 100644
> index ad93973215..00
> ---
> a/package/network/utils/iproute2/patches/002-json_print-fix-hidden-64-bit-type-promotion.patch
> +++ /dev/null
> @@ -1,288 +0,0 @@
> -From 8de9593bb9dc05cb1be593a237682e8707e41aa9 Mon Sep 17 00:00:00 2001
> -From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?=
> -Date: Wed, 25 Apr 2018 16:19:35 +0200
> -Subject: [PATCH] json_print: Fix hidden 64-bit type promotion
> -MIME-Version: 1.0
> -Content-Type: text/plain; charset=UTF-8
> -Content-Transfer-Encoding: 8bit
> -
> -print_uint() will silently promote its variable type to uint64_t, but there
> -is nothing that ensures that the format string specifier passed along with
> -it fits (and the function name suggest to pass "%u").
> -
> -Fix this by changing print_uint() to use a native 'unsigned int' type, and
> -introduce a separate print_u64() function for printing 64-bit values. All
> -call sites that were actually printing 64-bit values using print_uint() are
> -converted to use print_u64() instead.
> -
> -Since print_int() was already using native int types,
