Re: [OpenWrt-Devel] Regarding UCI for multi-point GRE on OpenWRT

2019-08-22 Thread Simonas Tamošaitis 

Hello,

try to use peeraddr '0.0.0.0'

Pagarbiai,
Simonas Tamošaitis

On 8/22/19 10:21 AM, pothuganti sridhar wrote:

Hello All,

I am trying to implement DMVPN with OpenWRT. That requires multipoint 
GRE tunnels. In case of the multipoint GRE tunnel, the remote 
endpoint/peer address will be resolved dynamically using NHRPD 
protocol/daemon.


I have gone through the GRE documentation at the following link.

https://openwrt.org/docs/guide-user/network/tunneling_interface_protocols

In the above documentation, it is mentioned that "peeraddr" is the 
must require field.


Is anyone tried to create multipoint GRE using UCI?

To make it(peeraddr) optional field, what are the changes required?

Any points will be helpful.

Thanks in advance.

Regards,
Sridhar

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 7/7] ath79: image: disable sysupgrade images for routerstations and ja76pf2

2019-08-22 Thread mail 
Hi,

> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Tomasz Maciej Nowak
> Sent: Donnerstag, 22. August 2019 20:59
> To: openwrt-devel@lists.openwrt.org
> Cc: Matt Merhar 
> Subject: [OpenWrt-Devel] [PATCH 7/7] ath79: image: disable sysupgrade
> images for routerstations and ja76pf2
> 

...

> -  IMAGES += factory.bin
> +  IMAGES := factory.bin

I just wonder: If we remove support for sysupgrade, wouldn't it be tidier to 
remove the IMAGE/sysupgrade entries, too (and those commented lines ...)?
One could still get them back by just reverting the patch or using git blame...

Best

Adrian


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

2019-08-22 Thread mail 
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of Paul Spooren
> Sent: Donnerstag, 22. August 2019 21:07
> To: John Crispin ; openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget
> 
> 
> On 22.08.19 00:11, John Crispin wrote:
> >
> > On 22/08/2019 08:47, Paul Spooren wrote:
> >> Hi John,
> >>> This commit adds the Generic subtarget resulting in consistent naming.
> >>
> >> and
> >>
> >>> already uses `x/generic/` as subfolder as if the subtarget would exist.
> >>
> >> I'm very much in favor of consistent names[0][1][2] as it reduces the
> >> hassle when trying automate things, like building images via an API[3].
> >>
> >> Is the subtarget causing any harm except for eight additional
> >> characters per filename?
> >>
> >> Paul
> >>
> >> [0]: https://github.com/openwrt/openwrt/pull/2330
> >> [1]: https://github.com/openwrt/openwrt/pull/2334
> >> [2]: https://github.com/openwrt/openwrt/pull/2326
> >> [3]: https://github.com/aparcar/attendedsysupgrade-server
> >>
> > dont really care, just wondering why
> 
> If you don't mind please merge it, I think it's the last target without a 
> defined
> subtarget.
> 
> Paul
> 

Just to back Paul up, I also think this will be helpful, as we just have one 
special case to deal with (i.e. targets without subtarget) less and it doesn't 
hurt much.

Best

Adrian


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

2019-08-22 Thread Paul Spooren 



On 22.08.19 00:11, John Crispin wrote:


On 22/08/2019 08:47, Paul Spooren wrote:

Hi John,
This commit adds the Generic subtarget resulting in consistent naming. 


and

already uses `x/generic/` as subfolder as if the subtarget would exist. 


I'm very much in favor of consistent names[0][1][2] as it reduces the 
hassle when trying automate things, like building images via an API[3].


Is the subtarget causing any harm except for eight additional 
characters per filename?


Paul

[0]: https://github.com/openwrt/openwrt/pull/2330
[1]: https://github.com/openwrt/openwrt/pull/2334
[2]: https://github.com/openwrt/openwrt/pull/2326
[3]: https://github.com/aparcar/attendedsysupgrade-server


dont really care, just wondering why


If you don't mind please merge it, I think it's the last target without 
a defined subtarget.


Paul



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 5/7] ath79: image: add supported string for routerstations and ja76pf2

2019-08-22 Thread Tomasz Maciej Nowak 
Now that the md5 check is fixed and metadata present, sysupgrade on
ar71xx will complain about device not being supported by the image.
Since the cause is not matching strings for supported devices add them
accordingly.

Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ath79/image/generic-ubnt.mk | 2 ++
 target/linux/ath79/image/generic.mk  | 1 +
 2 files changed, 3 insertions(+)

diff --git a/target/linux/ath79/image/generic-ubnt.mk 
b/target/linux/ath79/image/generic-ubnt.mk
index 3af1f2676e..c696aac3a8 100644
--- a/target/linux/ath79/image/generic-ubnt.mk
+++ b/target/linux/ath79/image/generic-ubnt.mk
@@ -223,6 +223,7 @@ define Device/ubnt_routerstation
   UBNT_TYPE := RSx
   UBNT_CHIP := ar7100
   DEVICE_PACKAGES += -swconfig
+  SUPPORTED_DEVICES += routerstation
 endef
 TARGET_DEVICES += ubnt_routerstation
 
@@ -232,6 +233,7 @@ define Device/ubnt_routerstation-pro
   UBNT_BOARD := RSPRO
   UBNT_TYPE := RSPRO
   UBNT_CHIP := ar7100pro
+  SUPPORTED_DEVICES += routerstation-pro
 endef
 TARGET_DEVICES += ubnt_routerstation-pro
 
diff --git a/target/linux/ath79/image/generic.mk 
b/target/linux/ath79/image/generic.mk
index c1cd347baf..b4e709de3e 100644
--- a/target/linux/ath79/image/generic.mk
+++ b/target/linux/ath79/image/generic.mk
@@ -648,6 +648,7 @@ define Device/jjplus_ja76pf2
   KERNEL := kernel-bin | append-dtb | lzma | pad-to $$(BLOCKSIZE)
   KERNEL_INITRAMFS := kernel-bin | append-dtb
   IMAGE_SIZE := 16000k
+  SUPPORTED_DEVICES += ja76pf2
 endef
 TARGET_DEVICES += jjplus_ja76pf2
 
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 7/7] ath79: image: disable sysupgrade images for routerstations and ja76pf2

2019-08-22 Thread Tomasz Maciej Nowak 
Because a bug in handling partial erase blocks in 4.19 kernel, using
sysupgrade images will hard brick devices that use RedBoot bootloader
and have "FIS directory" with "RedBoot config" on the same erase block.
Since flashing the devices from bootloader is safe, and to not cause a
situation where external chip programmer or JTAG is needed, disable
sysupgrade images for affected boards while creating kernel.bin and
rootfs.bin for jjPlus JA76PF2 board, which doesn't have factory image.

To set up the JA76PF2 board follow "Installation" instructions in b3a0c97
("ath79: add support for jjPlus JA76PF2") except the part of loading
initramfs image and using sysupgrade image for flashing (point 6 and 7).
Enter following commands to flash the board from bootloader:
  fis init
  load -r -b 0x8006 
  fis create linux
  load -r -b %{FREEMEMLO} 
  fis create rootfs
  fis load -l linux
  exec -c ""

For RouterStations use TFTP recovery procedure.

Ref: FS#2428
Cc: Matt Merhar 
Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ath79/image/generic-ubnt.mk | 2 +-
 target/linux/ath79/image/generic.mk  | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/target/linux/ath79/image/generic-ubnt.mk 
b/target/linux/ath79/image/generic-ubnt.mk
index c696aac3a8..fd61261193 100644
--- a/target/linux/ath79/image/generic-ubnt.mk
+++ b/target/linux/ath79/image/generic-ubnt.mk
@@ -208,7 +208,7 @@ define Device/ubnt_routerstation_common
   DEVICE_VENDOR := Ubiquiti
   ATH_SOC := ar7161
   IMAGE_SIZE := 16128k
-  IMAGES += factory.bin
+  IMAGES := factory.bin
   IMAGE/factory.bin := append-rootfs | pad-rootfs | mkubntimage | check-size 
(IMAGE_SIZE)
   IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
append-metadata | check-size (IMAGE_SIZE)
 #  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | check-size 
(IMAGE_SIZE) | sysupgrade-tar rootfs=@ | append-metadata
diff --git a/target/linux/ath79/image/generic.mk 
b/target/linux/ath79/image/generic.mk
index b4e709de3e..437265a707 100644
--- a/target/linux/ath79/image/generic.mk
+++ b/target/linux/ath79/image/generic.mk
@@ -643,6 +643,9 @@ define Device/jjplus_ja76pf2
   DEVICE_VENDOR := jjPlus
   DEVICE_MODEL := JA76PF2
   DEVICE_PACKAGES += -kmod-ath9k -swconfig -wpad-mini -uboot-envtools fconfig
+  IMAGES := kernel.bin rootfs.bin
+  IMAGE/kernel.bin := append-kernel
+  IMAGE/rootfs.bin := append-rootfs | pad-rootfs
   IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
append-metadata | check-size (IMAGE_SIZE)
 #  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | check-size 
(IMAGE_SIZE) | sysupgrade-tar rootfs=@ | append-metadata
   KERNEL := kernel-bin | append-dtb | lzma | pad-to $$(BLOCKSIZE)
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 2/7] ath79: image: retire combined-image for Adtran/Bluesocket devices

2019-08-22 Thread Tomasz Maciej Nowak 
During review it slipped by that these devices use combined-image which
should never be used for newly added ones. Therefore switch to
sysupgrade-tar generated images introduced in 8f6f260 ("ath79:
routerstation: prepare to use sysupgrade-tar format image"). The
sysupgrade accepts both images for now so no reression should occur.

Cc: Brian Gonyer 
Cc: Daniel Gimpelevich 
Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ath79/image/generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ath79/image/generic.mk 
b/target/linux/ath79/image/generic.mk
index 6f1ad5b708..45a1baa632 100644
--- a/target/linux/ath79/image/generic.mk
+++ b/target/linux/ath79/image/generic.mk
@@ -108,7 +108,7 @@ define Device/adtran_bsap1880
   IMAGES += kernel.bin rootfs.bin
   IMAGE/kernel.bin := append-kernel | pad-to (BLOCKSIZE)
   IMAGE/rootfs.bin := append-rootfs | pad-rootfs
-  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
append-metadata | check-size (IMAGE_SIZE)
+  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | check-size 
(IMAGE_SIZE) | sysupgrade-tar rootfs=@ | append-metadata
 endef
 
 define Device/adtran_bsap1800-v2
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 4/7] ath79: image: append metadata to routerstations and ja76pf2 images

2019-08-22 Thread Tomasz Maciej Nowak 
This target enforces metadata check so add the necessary information. It
was previously removed because md5 sum check. When using these sysupgrade
images on ar71xx target the check would complain about them not matching.

Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ath79/image/generic-ubnt.mk | 2 +-
 target/linux/ath79/image/generic.mk  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ath79/image/generic-ubnt.mk 
b/target/linux/ath79/image/generic-ubnt.mk
index 6db083861f..3af1f2676e 100644
--- a/target/linux/ath79/image/generic-ubnt.mk
+++ b/target/linux/ath79/image/generic-ubnt.mk
@@ -210,7 +210,7 @@ define Device/ubnt_routerstation_common
   IMAGE_SIZE := 16128k
   IMAGES += factory.bin
   IMAGE/factory.bin := append-rootfs | pad-rootfs | mkubntimage | check-size 
(IMAGE_SIZE)
-  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
check-size (IMAGE_SIZE)
+  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
append-metadata | check-size (IMAGE_SIZE)
 #  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | check-size 
(IMAGE_SIZE) | sysupgrade-tar rootfs=@ | append-metadata
   KERNEL := kernel-bin | append-dtb | lzma | pad-to $$(BLOCKSIZE)
   KERNEL_INITRAMFS := kernel-bin | append-dtb
diff --git a/target/linux/ath79/image/generic.mk 
b/target/linux/ath79/image/generic.mk
index 45a1baa632..c1cd347baf 100644
--- a/target/linux/ath79/image/generic.mk
+++ b/target/linux/ath79/image/generic.mk
@@ -643,7 +643,7 @@ define Device/jjplus_ja76pf2
   DEVICE_VENDOR := jjPlus
   DEVICE_MODEL := JA76PF2
   DEVICE_PACKAGES += -kmod-ath9k -swconfig -wpad-mini -uboot-envtools fconfig
-  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
check-size (IMAGE_SIZE)
+  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | combined-image | 
append-metadata | check-size (IMAGE_SIZE)
 #  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | check-size 
(IMAGE_SIZE) | sysupgrade-tar rootfs=@ | append-metadata
   KERNEL := kernel-bin | append-dtb | lzma | pad-to $$(BLOCKSIZE)
   KERNEL_INITRAMFS := kernel-bin | append-dtb
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 6/7] ath79: fix FIS partition detection for 4.19 kernel

2019-08-22 Thread Tomasz Maciej Nowak 
When bumping to 4.19 the patch responsible for scaning flash for FIS
partition got left out. Without it devices with RedBoot bootloader using
automatic partitions detection in dts won't boot with the new kernel.

Fixes: 3771176 ("ath79: add support for linux 4.19")
Signed-off-by: Tomasz Maciej Nowak 
---
 .../408-mtd-redboot_partition_scan.patch  | 44 +++
 1 file changed, 44 insertions(+)
 create mode 100644 
target/linux/ath79/patches-4.19/408-mtd-redboot_partition_scan.patch

diff --git 
a/target/linux/ath79/patches-4.19/408-mtd-redboot_partition_scan.patch 
b/target/linux/ath79/patches-4.19/408-mtd-redboot_partition_scan.patch
new file mode 100644
index 00..cd41e7ceb2
--- /dev/null
+++ b/target/linux/ath79/patches-4.19/408-mtd-redboot_partition_scan.patch
@@ -0,0 +1,44 @@
+--- a/drivers/mtd/redboot.c
 b/drivers/mtd/redboot.c
+@@ -76,12 +76,18 @@ static int parse_redboot_partitions(stru
+   static char nullstring[] = "unallocated";
+ #endif
+ 
++  buf = vmalloc(master->erasesize);
++  if (!buf)
++  return -ENOMEM;
++
++ restart:
+   if ( directory < 0 ) {
+   offset = master->size + directory * master->erasesize;
+   while (mtd_block_isbad(master, offset)) {
+   if (!offset) {
+   nogood:
+   printk(KERN_NOTICE "Failed to find a non-bad 
block to check for RedBoot partition table\n");
++  vfree(buf);
+   return -EIO;
+   }
+   offset -= master->erasesize;
+@@ -94,10 +100,6 @@ static int parse_redboot_partitions(stru
+   goto nogood;
+   }
+   }
+-  buf = vmalloc(master->erasesize);
+-
+-  if (!buf)
+-  return -ENOMEM;
+ 
+   printk(KERN_NOTICE "Searching for RedBoot partition table in %s at 
offset 0x%lx\n",
+  master->name, offset);
+@@ -170,6 +172,11 @@ static int parse_redboot_partitions(stru
+   }
+   if (i == numslots) {
+   /* Didn't find it */
++  if (offset + master->erasesize < master->size) {
++  /* not at the end of the flash yet, maybe next block :) 
*/
++  directory++;
++  goto restart;
++  }
+   printk(KERN_NOTICE "No RedBoot partition table detected in 
%s\n",
+  master->name);
+   ret = 0;
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 1/7] ath79: dts: fix ja76pf2 spi frequency

2019-08-22 Thread Tomasz Maciej Nowak 
The frequency was filled acording the information from datasheet for
particular chip (Winbond 25Q128BVFG). Unfortunately this led to
coruption and introduced bad blocks on the chip. Reducing the frequency
to commonly used in ath79, made the board more stable and no new bad
blocks were spoted.

Fixes: b3a0c97 ("ath79: add support for jjPlus JA76PF2")
Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ath79/dts/ar7161_jjplus_ja76pf2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ath79/dts/ar7161_jjplus_ja76pf2.dts 
b/target/linux/ath79/dts/ar7161_jjplus_ja76pf2.dts
index 76f140fa55..b983d1b994 100644
--- a/target/linux/ath79/dts/ar7161_jjplus_ja76pf2.dts
+++ b/target/linux/ath79/dts/ar7161_jjplus_ja76pf2.dts
@@ -111,7 +111,7 @@
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
-   spi-max-frequency = <10400>;
+   spi-max-frequency = <2500>;
 
partitions {
#address-cells = <1>;
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 0/7] ath79: fixes for devices with RedBoot bootloader

2019-08-22 Thread Tomasz Maciej Nowak 
Few fixes with common denominator being RedBoot bootloader, mostly
related to images generation. Some of these will need a cherry-pick to
19.07 branch - I'll prepare the patches if theese will be commited.
I would like to also put some focus on FS#2428 [1] bug, which will
disable sysupgrade for few devices and which I don't have knowledge to
tackle. Hope someone will help.

1. https://bugs.openwrt.org/index.php?do=details_id=2428

Tomasz Maciej Nowak (7):
  ath79: dts: fix ja76pf2 spi frequency
  ath79: image: retire combined-image for Adtran/Bluesocket devices
  ar71xx: sysupgrade: accept ath79 combined-image
  ath79: image: append metadata to routerstations and ja76pf2 images
  ath79: image: add supported string for routerstations and ja76pf2
  ath79: fix FIS partition detection for 4.19 kernel
  ath79: image: disable sysupgrade images for routerstations and ja76pf2

 .../ar71xx/base-files/lib/upgrade/platform.sh |  2 +-
 .../linux/ath79/dts/ar7161_jjplus_ja76pf2.dts |  2 +-
 target/linux/ath79/image/generic-ubnt.mk  |  6 ++-
 target/linux/ath79/image/generic.mk   |  8 +++-
 .../408-mtd-redboot_partition_scan.patch  | 44 +++
 5 files changed, 56 insertions(+), 6 deletions(-)
 create mode 100644 
target/linux/ath79/patches-4.19/408-mtd-redboot_partition_scan.patch

-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 3/7] ar71xx: sysupgrade: accept ath79 combined-image

2019-08-22 Thread Tomasz Maciej Nowak 
There is md5 sum of whole image embedded in combined-image header which
is checked on sysupgrade. The check will fail for ath79 images which
may have embedded metadata. This is because metadata are appended after
the combined image is created. To allow smooth transition from ar71xx to
ath79, strip metadata before calculating md5 sum for whole image.

Signed-off-by: Tomasz Maciej Nowak 
---
 target/linux/ar71xx/base-files/lib/upgrade/platform.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh 
b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
index 6898c0e0c2..3853140702 100755
--- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
+++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
@@ -394,7 +394,7 @@ platform_check_image() {
}
 
local md5_img=$(dd if="$1" bs=2 skip=9 count=16 2>/dev/null)
-   local md5_chk=$(dd if="$1" bs=$CI_BLKSZ skip=1 2>/dev/null | 
md5sum -); md5_chk="${md5_chk%% *}"
+   local md5_chk=$(fwtool -q -t -i /dev/null "$1"; dd if="$1" 
bs=$CI_BLKSZ skip=1 2>/dev/null | md5sum -); md5_chk="${md5_chk%% *}"
 
if [ -n "$md5_img" -a -n "$md5_chk" ] && [ "$md5_img" = 
"$md5_chk" ]; then
return 0
-- 
2.23.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Regarding UCI for multi-point GRE on OpenWRT

2019-08-22 Thread Andre Valentin 
Hi!

What about setting peeraddr to 0.0.0.0 ?

Kind regards,

André

Am 22.08.19 um 09:21 schrieb pothuganti sridhar:
> Hello All,
> 
> I am trying to implement DMVPN with OpenWRT. That requires multipoint GRE 
> tunnels. In case of the multipoint GRE tunnel, the remote endpoint/peer 
> address will be resolved dynamically using NHRPD
> protocol/daemon.
> 
> I have gone through the GRE documentation at the following link.
> 
> https://openwrt.org/docs/guide-user/network/tunneling_interface_protocols 
>  
> In the above documentation, it is mentioned that "peeraddr" is the must 
> require field. 
> 
> Is anyone tried to create multipoint GRE using UCI? 
> 
> To make it(peeraddr) optional field, what are the changes required?
> 
> Any points will be helpful.
> 
> Thanks in advance.
> 
> Regards,
> Sridhar
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 


-- 
Mit freundlichen Grüßen
André Valentin

Systemadministration - Projektkoordination


--
MarcanT AG, Herforder Straße 163a, D - 33609 Bielefeld
Fon: +49 (521) 95945-0 | Fax: +49 (521) 95945-18
URL: http://www.marcant.net  | 
http://www.global-m2m.com 

Internet * Netzwerk * Mobile Daten

Vorstand:
Thorsten Hojas (Vorsitzender)
Marc-Henrik Delker
Dr. Anja-Christina Padberg
Handelsregister: AG Bielefeld, HRB 42260 USt-ID Nr.: DE 190203238



___
Ausserhalb unserer Geschäftszeiten (Montag bis Freitag von 8:30 Uhr bis
17:30 Uhr, ausgenommen gesetzliche Feiertage in NRW) stehen wir Ihnen
gemäß Ihrer jeweiligen Service-Level-Agreements unter der Ihnen
mitgeteilten Telefonnummer für Störungen und Notfälle zur Verfügung.
Sie können natürlich auch gerne jederzeit unter supp...@marcant.net ein
Ticket eröffnen, welches am nächsten Arbeitstag bearbeitet wird.

 




smime.p7s
Description: S/MIME Cryptographic Signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] ath10k_pci 0000:02:00.0: SWBA overrun on vdev 0, skipped old beacon

2019-08-22 Thread Кирилл Луконин 
Hello.


This bug was fixed in the master branch.
Please try latest snapshot.

Best Regards,
Lukonin Kirill


чт, 22 авг. 2019 г. в 23:06, Yaroslav Petrov :

> Hello all,
>
>
> I use OpenWrt 19.07 on BT Home Hub 5A, but it seams ath10k-ct driver is
> really unstable (it work only first 2-10 minutes). The ath10k driver
> work without problem. Can somebody help me with this issue ?
>
>
>  OpenWrt 19.07-SNAPSHOT, r10323-7d300326ee 
>
> dmesg:
> ...
> [   16.523669] ath10k_pci :02:00.0: qca988x hw2.0 target 0x4100016c
> chip_id 0x043202ff sub :
> [   16.531585] ath10k_pci :02:00.0: kconfig debug 0 debugfs 1
> tracing 0 dfs 1 testmode 0
> [   16.548528] ath10k_pci :02:00.0: firmware ver
> 10.1-ct-8x-__fW-022-fddd041b api 2 features
> wmi-10.x,has-wmi-mgmt-tx,adaptive-cca,mfp,txstatus-noack,wmi-10.x-CT,ratemask-CT,txrate-CT,get-temp-CT,tx-rc-CT,cust-stats-CT,retry-gt2-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT
>
> crc32 01d1f13e
> [   16.600527] ath10k_pci :02:00.0: Direct firmware load for
> ath10k/QCA988X/hw2.0/board-2.bin failed with error -2
> [   16.609654] ath10k_pci :02:00.0: Falling back to user helper
> [   16.865926] firmware ath10k!QCA988X!hw2.0!board-2.bin:
> firmware_loading_store: map pages failed
> [   16.874176] ath10k_pci :02:00.0: board_file api 1 bmi_id N/A
> crc32 bebc7c08
> [   17.754597] ath10k_pci :02:00.0: 10.1 wmi init: vdevs: 16 peers:
> 127  tid: 256
> [   17.769910] ath10k_pci :02:00.0: wmi print 'P 128 V 8 T 410'
> [   17.774908] ath10k_pci :02:00.0: wmi print 'msdu-desc: 1424
> sw-crypt: 0 ct-sta: 0'
> [   17.782548] ath10k_pci :02:00.0: wmi print 'alloc rem: 24648
> iram: 26168'
> [   17.846700] ath10k_pci :02:00.0: htt-ver 2.1 wmi-op 2 htt-op 2
> cal file max-sta 128 raw 0 hwcrypto 1
> [   17.858172] ath10k_pci :02:00.0: NOTE:  Firmware DBGLOG output
> disabled in debug_mask: 0x1000
> ...
> [ 9397.052366] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.154773] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.257174] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.359596] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.461992] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.564396] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.666805] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.769214] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.871646] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9397.974036] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.076445] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.178844] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.281259] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.383675] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.486071] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.588478] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.690883] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.793301] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.895708] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9398.998112] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.100512] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.202918] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.305328] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.407740] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.510149] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.612543] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.714959] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.817366] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9399.919780] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9400.022177] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9400.124590] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped
> old beacon
> [ 9400.184417] ath10k_pci :02:00.0: wmi command 36893 timeout,
> restarting hardware
> [ 9400.191096] ath10k_pci :02:00.0: failed to delete peer
> 99:99:99:99:99:99 for vdev 0: -11
> [ 9400.199527] ath10k_pci :02:00.0: found sta peer 99:99:99:99:99:99
> (ptr 8698a600 id 361) entry on vdev 0 after it was supposedly removed
> [ 9400.212109] [ cut here

[OpenWrt-Devel] ath10k_pci 0000:02:00.0: SWBA overrun on vdev 0, skipped old beacon

2019-08-22 Thread Yaroslav Petrov 

Hello all,


I use OpenWrt 19.07 on BT Home Hub 5A, but it seams ath10k-ct driver is 
really unstable (it work only first 2-10 minutes). The ath10k driver 
work without problem. Can somebody help me with this issue ?



 OpenWrt 19.07-SNAPSHOT, r10323-7d300326ee 

dmesg:
...
[   16.523669] ath10k_pci :02:00.0: qca988x hw2.0 target 0x4100016c 
chip_id 0x043202ff sub :
[   16.531585] ath10k_pci :02:00.0: kconfig debug 0 debugfs 1 
tracing 0 dfs 1 testmode 0
[   16.548528] ath10k_pci :02:00.0: firmware ver 
10.1-ct-8x-__fW-022-fddd041b api 2 features 
wmi-10.x,has-wmi-mgmt-tx,adaptive-cca,mfp,txstatus-noack,wmi-10.x-CT,ratemask-CT,txrate-CT,get-temp-CT,tx-rc-CT,cust-stats-CT,retry-gt2-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT 
crc32 01d1f13e
[   16.600527] ath10k_pci :02:00.0: Direct firmware load for 
ath10k/QCA988X/hw2.0/board-2.bin failed with error -2

[   16.609654] ath10k_pci :02:00.0: Falling back to user helper
[   16.865926] firmware ath10k!QCA988X!hw2.0!board-2.bin: 
firmware_loading_store: map pages failed
[   16.874176] ath10k_pci :02:00.0: board_file api 1 bmi_id N/A 
crc32 bebc7c08
[   17.754597] ath10k_pci :02:00.0: 10.1 wmi init: vdevs: 16 peers: 
127  tid: 256

[   17.769910] ath10k_pci :02:00.0: wmi print 'P 128 V 8 T 410'
[   17.774908] ath10k_pci :02:00.0: wmi print 'msdu-desc: 1424  
sw-crypt: 0 ct-sta: 0'
[   17.782548] ath10k_pci :02:00.0: wmi print 'alloc rem: 24648 
iram: 26168'
[   17.846700] ath10k_pci :02:00.0: htt-ver 2.1 wmi-op 2 htt-op 2 
cal file max-sta 128 raw 0 hwcrypto 1
[   17.858172] ath10k_pci :02:00.0: NOTE:  Firmware DBGLOG output 
disabled in debug_mask: 0x1000

...
[ 9397.052366] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.154773] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.257174] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.359596] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.461992] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.564396] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.666805] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.769214] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.871646] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9397.974036] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.076445] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.178844] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.281259] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.383675] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.486071] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.588478] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.690883] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.793301] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.895708] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9398.998112] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.100512] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.202918] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.305328] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.407740] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.510149] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.612543] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.714959] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.817366] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9399.919780] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9400.022177] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9400.124590] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9400.184417] ath10k_pci :02:00.0: wmi command 36893 timeout, 
restarting hardware
[ 9400.191096] ath10k_pci :02:00.0: failed to delete peer 
99:99:99:99:99:99 for vdev 0: -11
[ 9400.199527] ath10k_pci :02:00.0: found sta peer 99:99:99:99:99:99 
(ptr 8698a600 id 361) entry on vdev 0 after it was supposedly removed

[ 9400.212109] [ cut here ]
[ 9400.216791] WARNING: CPU: 1 PID: 3599 at 
backports-4.19.66-1/net/mac80211/sta_info.c:1004 
sta_set_sinfo+0xcdc/0xd88 [mac80211]
[ 9400.227825] ath10k_pci :02:00.0: SWBA overrun on vdev 0, skipped 
old beacon
[ 9400.235153] Modules linked in: ath9k ath9k_common ath9k_hw ath10k_pci 
ath10k_core ath

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Northbound Networks Zodiac GX

2019-08-22 Thread Enrico Mioso 

thanks a lot for your work, and answer!!

Enrico

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v4] ramips: add support for Edimax RG21S

2019-08-22 Thread Daniel Golle 
Hi,

I believe the PCI-IDs of the devices in your device tree are wrong,
see below:

On Sun, Jul 21, 2019 at 07:43:51AM +0200, Birger Koblitz wrote:
> ramips: add Edimax RG21S
> 
> SoC:  MediaTek MT7621AT dual-core @ 880MHz
> RAM:  256M (Nanya NT5CC128M)
> FLASH:16MB (Macronix MX25L12835F)
> WiFi: - 2.4GHz MediaTek MT7615N bgn
>   - 5GHz MediaTek MT7615N nac
> Switch: SoC integrated Gigabit Switch (4 x LAN, 1 x WAN)
> USB:  No
> BTN:  Reset, WPS
> LED:  4 red LEDs, indistinguishable when casing closed
> UART: UART is present as Pads marked J1 on the PCB.
>   3.3V - RX - GND - TX / 57600-8N1
>   3.3V is the square pad
> 
> Installation
> 
> Update the factory image via the OEM web-interface
> (by default:http://192.168.1.1)
> The sysupgrade image can be installed via TFTP from
> the U-Boot bootloader. Connect ethernet port 2.
> 
> Signed-off-by: Birger Koblitz 
> 
> ---
> 
> v3: Update to DEVICE_VENDOR / DEVICE_MODEL in mt7621.mk
> renamed .dts according to new conventions
> Removed memory node from .dts
> Correct image size
> Whitespace fixes
> v4: Added wifi0/1 labels to wifi nodes
> Model name corrected in dts
> Comments removed from .dts
> 
> diff --git a/target/linux/ramips/base-files/etc/board.d/02_network 
> b/target/linux/ramips/base-files/etc/board.d/02_network
> index a2b7d1cf33..252d2f4e50 100755
> --- a/target/linux/ramips/base-files/etc/board.d/02_network
> +++ b/target/linux/ramips/base-files/etc/board.d/02_network
> @@ -329,6 +329,10 @@ ramips_setup_interfaces()
>   ucidef_add_switch "switch1" \
>   "1:lan" "2:lan" "3:lan" "4:lan" "0:wan" "6@eth0"
>   ;;
> + edimax,rg21s)
> + ucidef_add_switch "switch0" \
> + "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "0:wan" "6@eth0"
> + ;;
>   gehua,ghl-r-001)
>   ucidef_add_switch "switch0" \
>   "0:lan" "1:lan" "2:lan" "4:wan" "6@eth0"
> @@ -587,6 +591,10 @@ ramips_setup_macs()
>   lan_mac=$(cat /sys/class/net/eth0/address)
>   wan_mac=$(macaddr_add "$lan_mac" 2)
>   ;;
> + edimax,rg21s)
> + lan_mac=$(mtd_get_mac_ascii u-boot-env ethaddr)
> + wan_mac=$(mtd_get_mac_ascii u-boot-env wanaddr)
> + ;;
>   elecom,wrc-1167ghbk2-s|\
>   elecom,wrc-1900gst|\
>   elecom,wrc-2533gst|\
> diff --git a/target/linux/ramips/dts/mt7621_edimax_rg21s.dts 
> b/target/linux/ramips/dts/mt7621_edimax_rg21s.dts
> new file mode 100644
> index 00..80b644b7a7
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7621_edimax_rg21s.dts
> @@ -0,0 +1,157 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/dts-v1/;
> +
> +#include "mt7621.dtsi"
> +
> +#include 
> +#include 
> +
> +/ {
> + compatible = "edimax,rg21s", "mediatek,mt7621-soc";
> + model = "Edimax RG21S";
> +
> + aliases {
> + led-boot = _power;
> + led-failsafe = _power;
> + led-running = _power;
> + led-upgrade = _power;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,57600";
> + };
> +
> + palmbus: palmbus@1E00 {
> + i2c@900 {
> + status = "okay";
> + };
> + };
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + reset {
> + label = "reset";
> + gpios = < 16 GPIO_ACTIVE_LOW>;
> + linux,code = ;
> + };
> +
> + wps {
> + label = "wps";
> + gpios = < 18 GPIO_ACTIVE_LOW>;
> + linux,code = ;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led_power: led_1 {
> + label = "rg21s:red:led1";
> + gpios = < 7 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led_2 {
> + label = "rg21s:red:led2";
> + gpios = < 12 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led_3 {
> + label = "rg21s:red:led3";
> + gpios = < 14 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led_4 {
> + label = "rg21s:red:led4";
> + gpios = < 15 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> + {
> + status = "okay";
> +};
> +
> + {
> + status = "okay";
> +
> + m25p80@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <1000>;
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "u-boot";
> + reg =

[OpenWrt-Devel] [PATCH] ath79: sort device definitions in image/*

2019-08-22 Thread Adrian Schmutzler 
This applies alphabetic sorting to devices in image/* files.

For certain cases, this patch deviates from strict sorting, e.g.
to ensure that v10 comes after v9.

While at it, fix an indent and remove some useless empty lines.

Signed-off-by: Adrian Schmutzler 

---

It would be nice if this was applied fast, as rebasing it won't be
fun.
---
 target/linux/ath79/image/common-buffalo.mk  |  16 +-
 target/linux/ath79/image/common-netgear.mk  |  20 +-
 target/linux/ath79/image/generic-tp-link.mk | 212 ++--
 target/linux/ath79/image/generic-ubnt.mk| 150 +++---
 target/linux/ath79/image/generic.mk | 205 +--
 target/linux/ath79/image/tiny-tp-link.mk|   1 -
 6 files changed, 301 insertions(+), 303 deletions(-)

diff --git a/target/linux/ath79/image/common-buffalo.mk 
b/target/linux/ath79/image/common-buffalo.mk
index 8870af691e..d62b7eea94 100644
--- a/target/linux/ath79/image/common-buffalo.mk
+++ b/target/linux/ath79/image/common-buffalo.mk
@@ -1,11 +1,3 @@
-define Build/buffalo-tftp-header
-   ( \
-   echo -n -e "# Airstation Public Fmt1" | dd bs=32 count=1 
conv=sync; \
-   dd if=$@; \
-   ) > $@.new
-  mv $@.new $@
-endef
-
 define Build/buffalo-tag
$(eval product=$(word 1,$(1)))
$(eval hwver=$(word 2,$(1)))
@@ -18,4 +10,10 @@ define Build/buffalo-tag
mv $@.new $@
 endef
 
-
+define Build/buffalo-tftp-header
+   ( \
+   echo -n -e "# Airstation Public Fmt1" | dd bs=32 count=1 
conv=sync; \
+   dd if=$@; \
+   ) > $@.new
+   mv $@.new $@
+endef
diff --git a/target/linux/ath79/image/common-netgear.mk 
b/target/linux/ath79/image/common-netgear.mk
index c722b82d27..8311222a91 100644
--- a/target/linux/ath79/image/common-netgear.mk
+++ b/target/linux/ath79/image/common-netgear.mk
@@ -1,5 +1,15 @@
 DEVICE_VARS += NETGEAR_KERNEL_MAGIC NETGEAR_BOARD_ID NETGEAR_HW_ID
 
+define Build/netgear-rootfs
+   mkimage \
+   -A mips -O linux -T filesystem -C none \
+   -M $(NETGEAR_KERNEL_MAGIC) \
+   -n '$(VERSION_DIST) filesystem' \
+   -d $(IMAGE_ROOTFS) $@.fs
+   cat $@.fs >> $@
+   rm -rf $@.fs
+endef
+
 define Build/netgear-squashfs
rm -rf $@.fs $@.squashfs
mkdir -p $@.fs/image
@@ -19,16 +29,6 @@ define Build/netgear-squashfs
rm -rf $@.squashfs $@.fs
 endef
 
-define Build/netgear-rootfs
-   mkimage \
-   -A mips -O linux -T filesystem -C none \
-   -M $(NETGEAR_KERNEL_MAGIC) \
-   -n '$(VERSION_DIST) filesystem' \
-   -d $(IMAGE_ROOTFS) $@.fs
-   cat $@.fs >> $@
-   rm -rf $@.fs
-endef
-
 define Build/netgear-uImage
$(call Build/uImage,$(1) -M $(NETGEAR_KERNEL_MAGIC))
 endef
diff --git a/target/linux/ath79/image/generic-tp-link.mk 
b/target/linux/ath79/image/generic-tp-link.mk
index c8d31b87e9..d035d0a5db 100644
--- a/target/linux/ath79/image/generic-tp-link.mk
+++ b/target/linux/ath79/image/generic-tp-link.mk
@@ -36,6 +36,17 @@ define Device/tplink_archer-c25-v1
 endef
 TARGET_DEVICES += tplink_archer-c25-v1
 
+define Device/tplink_archer-c5-v1
+  $(Device/tplink-16mlzma)
+  ATH_SOC := qca9558
+  DEVICE_MODEL := Archer C5
+  DEVICE_VARIANT := v1
+  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport 
kmod-ath10k-ct ath10k-firmware-qca988x-ct
+  TPLINK_HWID := 0xc501
+  SUPPORTED_DEVICES += archer-c5
+endef
+TARGET_DEVICES += tplink_archer-c5-v1
+
 define Device/tplink_archer-c58-v1
   $(Device/tplink-safeloader-uimage)
   ATH_SOC := qca9561
@@ -60,6 +71,17 @@ define Device/tplink_archer-c59-v1
 endef
 TARGET_DEVICES += tplink_archer-c59-v1
 
+define Device/tplink_archer-c6-v2
+  $(Device/tplink-safeloader-uimage)
+  ATH_SOC := qca9563
+  IMAGE_SIZE := 7808k
+  DEVICE_MODEL := Archer C6
+  DEVICE_VARIANT := v2
+  TPLINK_BOARD_ID := ARCHER-C6-V2
+  DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
+endef
+TARGET_DEVICES += tplink_archer-c6-v2
+
 define Device/tplink_archer-c60-v1
   $(Device/tplink-safeloader-uimage)
   ATH_SOC := qca9561
@@ -84,28 +106,6 @@ define Device/tplink_archer-c60-v2
 endef
 TARGET_DEVICES += tplink_archer-c60-v2
 
-define Device/tplink_archer-c6-v2
-  $(Device/tplink-safeloader-uimage)
-  ATH_SOC := qca9563
-  IMAGE_SIZE := 7808k
-  DEVICE_MODEL := Archer C6
-  DEVICE_VARIANT := v2
-  TPLINK_BOARD_ID := ARCHER-C6-V2
-  DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
-endef
-TARGET_DEVICES += tplink_archer-c6-v2
-
-define Device/tplink_archer-c5-v1
-  $(Device/tplink-16mlzma)
-  ATH_SOC := qca9558
-  DEVICE_MODEL := Archer C5
-  DEVICE_VARIANT := v1
-  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport 
kmod-ath10k-ct ath10k-firmware-qca988x-ct
-  TPLINK_HWID := 0xc501
-  SUPPORTED_DEVICES += archer-c5
-endef
-TARGET_DEVICES += tplink_archer-c5-v1
-
 define Device/tplink_archer-c7-v1
   $(Device/tplink-8mlzma)
   ATH_SOC := qca9558
@@

[OpenWrt-Devel] Fix handling of BUILD_SUFFIX in remote-gdb script

2019-08-22 Thread Langer, Thomas 
From: Thomas Langer 

When CONFIG_BUILD_SUFFIX is enabled, the target-* folders in build_dir
and staging_dir have this suffix in the name, but not the
toolchain directories. When detecting the names for "arch" and "libc",
also accept the suffix and do not use it for the toolchain path.

Signed-off-by: Thomas Langer 

diff --git a/scripts/remote-gdb b/scripts/remote-gdb
index 99c9d38..d8e2336 100755
--- a/scripts/remote-gdb
+++ b/scripts/remote-gdb
@@ -14,9 +14,9 @@ if( opendir SD, "$Bin/../staging_dir" )
 {
my ( $tid, $arch, $libc, @arches );
 
-   if( $ARGV[1] =~ m!\btarget-(.+?)_(([^/_]+libc|musl)[^/_]*)\b!i )
+   if( $ARGV[1] =~ m!\btarget-(.+?)_([^/_]+libc|musl)_?([^/]*).*\b!i )
{
-   print("Using target $1 ($2)\n");
+   print("Using target $1 ($2, $3)\n");
($arch, $libc) = ($1, $2);
}
else
@@ -26,10 +26,10 @@ if( opendir SD, "$Bin/../staging_dir" )
 
while( defined( my $e = readdir SD ) )
{
-   if( -d "$Bin/../staging_dir/$e" && $e =~ 
/^target-(.+?)_(([^_]+libc|musl).*)/i )
+   if( -d "$Bin/../staging_dir/$e" && $e =~ 
/^target-(.+?)_([^\/_]+libc|musl)_?([^\/]*).*/i )
{
push @arches, [ $1, $2 ];
-   printf(" %2d) %s (%s)\n", @arches + 0, $1, $2);
+   printf(" %2d) %s (%s %s)\n", @arches + 0, $1, 
$2, $3);
}
}

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] lantiq: sort device definitions in image/Makefile

2019-08-22 Thread Adrian Schmutzler 
This sorts the device definitions in image/Makefile alphabetically
for each subtarget/block.

The order of blocks has not been touched.

Signed-off-by: Adrian Schmutzler 

---

During updating lantiq to DEVICE_VENDOR/DEVICE_MODEL scheme, it
became obvious that there is almost no sorting left in this file.

In the long run, one might want to also rearrange the blocks or
create subfiles like the sole one for tp-link.
---
 target/linux/lantiq/image/Makefile | 711 ++---
 1 file changed, 355 insertions(+), 356 deletions(-)

diff --git a/target/linux/lantiq/image/Makefile 
b/target/linux/lantiq/image/Makefile
index 4cacaccba9..a583dd09d7 100644
--- a/target/linux/lantiq/image/Makefile
+++ b/target/linux/lantiq/image/Makefile
@@ -136,6 +136,34 @@ endif
 
 ifeq ($(SUBTARGET),xway_legacy)
 
+define Device/arcadyan_arv4518pwr01
+  DEVICE_VENDOR := Arcadyan
+  DEVICE_MODEL := ARV4518PWR01
+  IMAGE_SIZE := 3776k
+  DEVICE_DTS := ARV4518PWR01
+  DEVICE_PACKAGES := kmod-usb-dwc2 kmod-usb-ledtrig-usbport \
+   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
+   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
+   ltq-adsl-app ppp-mod-pppoa \
+   kmod-ath5k wpad-mini
+  SUPPORTED_DEVICES += ARV4518PWR01
+endef
+TARGET_DEVICES += arcadyan_arv4518pwr01
+
+define Device/arcadyan_arv4518pwr01a
+  DEVICE_VENDOR := Arcadyan
+  DEVICE_MODEL := ARV4518PWR01A
+  IMAGE_SIZE := 3776k
+  DEVICE_DTS := ARV4518PWR01A
+  DEVICE_PACKAGES := kmod-usb-dwc2 kmod-usb-ledtrig-usbport \
+   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
+   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
+   ltq-adsl-app ppp-mod-pppoa \
+   kmod-ath5k wpad-basic
+  SUPPORTED_DEVICES += ARV4518PWR01A
+endef
+TARGET_DEVICES += arcadyan_arv4518pwr01a
+
 define Device/arcadyan_arv4520pw
   DEVICE_VENDOR := Arcadyan
   DEVICE_MODEL := ARV4520PW
@@ -186,81 +214,12 @@ define Device/arcadyan_arv452cqw
 endef
 TARGET_DEVICES += arcadyan_arv452cqw
 
-define Device/arcadyan_arv4518pwr01
-  DEVICE_VENDOR := Arcadyan
-  DEVICE_MODEL := ARV4518PWR01
-  IMAGE_SIZE := 3776k
-  DEVICE_DTS := ARV4518PWR01
-  DEVICE_PACKAGES := kmod-usb-dwc2 kmod-usb-ledtrig-usbport \
-   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
-   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
-   ltq-adsl-app ppp-mod-pppoa \
-   kmod-ath5k wpad-mini
-  SUPPORTED_DEVICES += ARV4518PWR01
-endef
-TARGET_DEVICES += arcadyan_arv4518pwr01
-
-define Device/arcadyan_arv4518pwr01a
-  DEVICE_VENDOR := Arcadyan
-  DEVICE_MODEL := ARV4518PWR01A
-  IMAGE_SIZE := 3776k
-  DEVICE_DTS := ARV4518PWR01A
-  DEVICE_PACKAGES := kmod-usb-dwc2 kmod-usb-ledtrig-usbport \
-   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
-   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
-   ltq-adsl-app ppp-mod-pppoa \
-   kmod-ath5k wpad-basic
-  SUPPORTED_DEVICES += ARV4518PWR01A
-endef
-TARGET_DEVICES += arcadyan_arv4518pwr01a
-
 endif
 
 ifeq ($(SUBTARGET),xway)
 
 # Danube
 
-define Device/bt_homehub-v2b
-  $(Device/NAND)
-  DEVICE_VENDOR := British Telecom
-  DEVICE_MODEL := Home Hub 2
-  DEVICE_VARIANT := Type B
-  BOARD_NAME := BTHOMEHUBV2B
-  DEVICE_DTS := BTHOMEHUBV2B
-  DEVICE_PACKAGES := kmod-usb-dwc2 \
-   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
-   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
-   kmod-ltq-deu-danube \
-   ltq-adsl-app ppp-mod-pppoa \
-   kmod-ath9k kmod-owl-loader wpad-basic
-  SUPPORTED_DEVICES += BTHOMEHUBV2B
-endef
-TARGET_DEVICES += bt_homehub-v2b
-
-define Device/lantiq_easy50712
-  DEVICE_VENDOR := Lantiq
-  DEVICE_MODEL := Danube (EASY50712)
-  DEVICE_DTS := EASY50712
-  IMAGE_SIZE := 3776k
-endef
-TARGET_DEVICES += lantiq_easy50712
-
-define Device/audiocodes_mp-252
-  DEVICE_VENDOR := AudioCodes
-  DEVICE_MODEL := MediaPack MP-252
-  IMAGE_SIZE := 14848k
-  DEVICE_DTS := ACMP252
-  DEVICE_PACKAGES :=  kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
-   kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
-   kmod-ltq-tapi kmod-ltq-vmmc \
-   kmod-usb-ledtrig-usbport kmod-usb-dwc2 \
-   kmod-rt2800-pci \
-   ltq-adsl-app ppp-mod-pppoa \
-   wpad-basic
-  SUPPORTED_DEVICES += ACMP252
-endef
-TARGET_DEVICES += audiocodes_mp-252
-
 define Device/arcadyan_arv4510pw
   DEVICE_VENDOR := Arcadyan
   DEVICE_MODEL := ARV4510PW
@@ -278,22 +237,6 @@ define Device/arcadyan_arv4510pw
 endef
 TARGET_DEVICES += arcadyan_arv4510pw
 
-define Device/arcadyan_arv7525pw
-  DEVICE_VENDOR := Arcadyan
-  DEVICE_MODEL := ARV7525PW
-  DEVICE_ALT0_VENDOR := Telekom
-  DEVICE_ALT0_MODEL := Speedport W303V
-  DEVICE_ALT0_VARIANT := Typ A
-  IMAGE_SIZE := 3776k
-  DEVICE_DTS := ARV4510PW
-  DEVICE_PACKAGES := kmod-rt2800-pci wpad-basic \
-   kmod-ltq-adsl-danube-mei kmod-ltq-adsl-danube \
-   kmod-ltq-adsl-danube-fw-b kmod-ltq-atm-danube \
-   ltq-adsl-app ppp-mod-pppoa -swconfig
-  SUPPORTED_DEVICES += ARV4510PW
-endef
-TARGET_DEVICES += arcadyan_arv7525pw
-
 define

Re: [OpenWrt-Devel] [PATCH procd] system: support passing "options" to the "sysupgrade" ubus method

2019-08-22 Thread Rafał Miłecki 
On Sat, 17 Aug 2019 at 12:31, Jo-Philipp Wich  wrote:
> > [...]
> > +
> > + blobmsg_for_each_attr(option, options, rem) {
> > + const char *prefix = "UPGRADE_OPT_";
> > + char *name = malloc(strlen(prefix) + 
> > strlen(blobmsg_name(option)));
> > + char value[11];
> > + char *c;
> > + int tmp;
> > +
> > + if (!name) {
> > + continue;
> > + }
> > + sprintf(name, "%s%s", prefix, blobmsg_name(option));
> > + for (c = name + strlen(prefix); *c; c++) {
>
> I'd propose some more sanity checking here:

Pushed with your checks, thanks!

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

2019-08-22 Thread Paul Fertser 
Thank you for the reply.

On Thu, Aug 22, 2019 at 11:18:01AM +0200, m...@adrianschmutzler.de wrote:
> to the existing configuration of the "Xiaomi Mi Router 4A Gigabit
> Edition (R4AG/R4A Gigabit)" (without adding a new device).

There's also an issue of R4AG not present in upstream and I can't see
any relevant submission in the Patchwork. Adding patch author to Cc.

> Unless I misunderstood something, this has nothing to do with
> SUPPORTED_DEVICES which should be removed, unless Xiaomi ships an
> OpenWrt distro as vendor firmware.

Sorry for a confusing quote, I didn't mean to imply SUPPORTED_DEVICES
is to be used here.

In fact, Xiaomi does ship an OpenWrt-based distro, it seems to be an
illegal GPL-violating fork...

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

2019-08-22 Thread Paul Fertser 
Hey Rafał!

On Thu, Aug 22, 2019 at 01:02:03PM +0200, Rafał Miłecki wrote:
> On Tue, 13 Aug 2019 at 20:25, Paul Fertser  wrote:
> > diff --git a/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts 
> > b/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts
> > new file mode 100644
> > index 00..a1963d0072
> > --- /dev/null
> > +++ b/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts
> > @@ -0,0 +1,146 @@
> > +/dts-v1/;
> > +
> > +#include "mt7621.dtsi"
> 
> Please specify .dts file license, see:
> https://openwrt.org/submitting-patches#dts_checklist

Sure, noted.

I saw that page but guess I was confused by the lack of license in some
other DTS files there.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

2019-08-22 Thread Rafał Miłecki 
On Tue, 13 Aug 2019 at 20:25, Paul Fertser  wrote:
> diff --git a/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts 
> b/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts
> new file mode 100644
> index 00..a1963d0072
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7621_xiaomi_mir3g-v2.dts
> @@ -0,0 +1,146 @@
> +/dts-v1/;
> +
> +#include "mt7621.dtsi"

Please specify .dts file license, see:
https://openwrt.org/submitting-patches#dts_checklist

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH RFC 2/2] amp821xx: use newly added pad-squashfs for Meraki MR24

2019-08-22 Thread Russell Senior 


Using pad-squashfs ensures that the root.squashfs is assigned sufficient
LEBs on UBI such that all reads of the rootfs succeed, in order to avoid
read failures and kernel panics.

This fixes one such kernel panic observed on Meraki MR24 where an
inopportune-sized unpadded root.squashfs occurred.

Note: ext4-sysupgrade firmware binaries will build with this patch, but
they are as nonsensical as before the patch. Finding a way to disable
ext4 builds for Meraki MR24 is left as a TODO.

Signed-off-by: Russell Senior 
---
 target/linux/apm821xx/image/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/linux/apm821xx/image/Makefile 
b/target/linux/apm821xx/image/Makefile
index acfd478755..53192bb448 100644
--- a/target/linux/apm821xx/image/Makefile
+++ b/target/linux/apm821xx/image/Makefile
@@ -133,7 +133,8 @@ define Device/meraki_mr24
   IMAGE_SIZE := 8191k
   KERNEL := kernel-bin | lzma | uImage lzma | MerakiAdd-dtb | MerakiNAND
   KERNEL_INITRAMFS := kernel-bin | lzma | dtb | MuImage-initramfs lzma
-  IMAGE/sysupgrade.bin := sysupgrade-tar | append-metadata
+  IMAGE/sysupgrade.bin/squashfs := pad-squashfs | sysupgrade-tar | 
append-metadata
+  IMAGE/sysupgrade.bin/ext4 := sysupgrade-tar | append-metadata
   UBINIZE_OPTS := -E 5
   SUPPORTED_DEVICES += mr24
 endef
-- 
2.23.0


-- 
Russell Senior, President
russ...@personaltelco.net

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH RFC 1/2] build: add squashfs padding infrastructure

2019-08-22 Thread Russell Senior 


Normally, root.squashfs should not be padded for alignment purposes,
because particularly on NOR flash it is typically concatenated with
other objects, like the kernel and device tree. However, in some cases
we do want the root.squashfs to be padded, in particular when it is
written into a ubi volume by itself. The kernel wants to read the
squashfs in chunks, apparently either 1k or 4k bytes at a time. Because
ubi volumes are allocated in logical erase blocks (LEBs) which are
typically *not* powers of two (as some of the underlying space is used
for metadata), a non-padded squashfs can align on the LEBs in such a way
that a block read near the end of the squashfs can bleed into an area
that is not part of the ubi volume, resulting in a kernel panic.

One such kernel panic was recently observed in a corner case on Meraki
MR24.  On the MR24, the LEBs are 15.5 kiB in size.  If rootfs sizes were
uniformily distributed, it would be expected to see such a kernel panic
for about 1/4 of the possible rootfs sizes.

This commit adds some infrastucture to allow the padding of a
root.squashfs to 4k boundaries.

Signed-off-by: Russell Senior 
---
 include/image-commands.mk | 5 +
 1 file changed, 5 insertions(+)

diff --git a/include/image-commands.mk b/include/image-commands.mk
index 89c17aec5b..59dcf4e429 100644
--- a/include/image-commands.mk
+++ b/include/image-commands.mk
@@ -242,6 +242,11 @@ define Build/pad-rootfs
$(if $(BLOCKSIZE),$(BLOCKSIZE:%k=%),4 8 16 64 128 256)
 endef
 
+define Build/pad-squashfs
+   dd if=$(KDIR)/root.squashfs of=$(KDIR)/root.squashfs.new bs=4k conv=sync
+   mv $(KDIR)/root.squashfs.new $(KDIR)/root.squashfs
+endef
+
 define Build/pad-offset
let \
size="$$(stat -c%s $@)" \
-- 
2.23.0


-- 
Russell Senior, President
russ...@personaltelco.net

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

2019-08-22 Thread John Crispin 


On 22/08/2019 08:47, Paul Spooren wrote:

Hi John,
This commit adds the Generic subtarget resulting in consistent naming. 


and

already uses `x/generic/` as subfolder as if the subtarget would exist. 


I'm very much in favor of consistent names[0][1][2] as it reduces the 
hassle when trying automate things, like building images via an API[3].


Is the subtarget causing any harm except for eight additional 
characters per filename?


Paul

[0]: https://github.com/openwrt/openwrt/pull/2330
[1]: https://github.com/openwrt/openwrt/pull/2334
[2]: https://github.com/openwrt/openwrt/pull/2326
[3]: https://github.com/aparcar/attendedsysupgrade-server


dont really care, just wondering why

    John


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

2019-08-22 Thread mail 
Hi,

> > > +  DEVICE_MODEL := Mi router 3G v2
> >
> > Capitalize "router". Despite, use DEVICE_VARIANT, so:
> >
> > +  DEVICE_MODEL := Mi Router 3G
> > +  DEVICE_VARIANT := v2
> >
> > > +  SUPPORTED_DEVICES += mir3gv2
> >
> > Drop this line.
> 
> So apparently this "v2" is in fact an _officially_ relabled "Xiaomi Mi Router 
> 4A
> Gigabit Edition (R4AG/R4A Gigabit)", according to the reports from [1] and
> the related thread on "4pda.ru" forum. Insane, yes.
> 
> What course of actions would you recommend in this case?

Well, you essentially have two options then:

You could just add the new image anyway, if device names are different and 
there is a chance for taking the wrong image (i.e. mir3g because there is no 
v2), this is generally reasonable.

If the devices really are 100 % similar, you might instead want to exploit the 
syntax introduced in https://github.com/openwrt/openwrt/pull/2250 and just add
DEVICE_ALT0_VENDOR := Xiaomi
DEVICE_ALT0_MODEL := Mi Router 3G
DEVICE_ALT0_VARIANT := v2
to the existing configuration of the "Xiaomi Mi Router 4A Gigabit Edition 
(R4AG/R4A Gigabit)" (without adding a new device).

The second approach would have the advantage that you do not need to create the 
same image twice.
The disadvantage would be that the new name is only available in "make 
menuconfig" etc., i.e. when you build the image, but you won't get an 
additional image file with the new name.
Despite, the PR is already waiting for a long time, so this might additionally 
prolong your waiting (although device support typically has long waiting, too).

Since there is a "v1" for the mir3g, I personally would go for option 1 and 
just keep what you did so far.

Unless I misunderstood something, this has nothing to do with SUPPORTED_DEVICES 
which should be removed, unless Xiaomi ships an OpenWrt distro as vendor 
firmware.

Best

Adrian



> 
> TIA
> 
> [1] https://forum.openwrt.org/t/xiaomi-mi-router-4a-gigabit-edition-r4ag-
> r4a-gigabit-fully-supported-but-requires-overwriting-spi-flash-with-
> programmer/36685/41
> 
> --
> Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
> mailto:fercer...@gmail.com


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Regarding UCI for multi-point GRE on OpenWRT

2019-08-22 Thread pothuganti sridhar 
Hello All,

I am trying to implement DMVPN with OpenWRT. That requires multipoint GRE
tunnels. In case of the multipoint GRE tunnel, the remote endpoint/peer
address will be resolved dynamically using NHRPD protocol/daemon.

I have gone through the GRE documentation at the following link.

https://openwrt.org/docs/guide-user/network/tunneling_interface_protocols

In the above documentation, it is mentioned that "peeraddr" is the must
require field.

Is anyone tried to create multipoint GRE using UCI?

To make it(peeraddr) optional field, what are the changes required?

Any points will be helpful.

Thanks in advance.

Regards,
Sridhar
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

2019-08-22 Thread Paul Spooren 

Hi John,
This commit adds the Generic subtarget resulting in consistent naming. 


and

already uses `x/generic/` as subfolder as if the subtarget would exist. 


I'm very much in favor of consistent names[0][1][2] as it reduces the 
hassle when trying automate things, like building images via an API[3].


Is the subtarget causing any harm except for eight additional characters 
per filename?


Paul

[0]: https://github.com/openwrt/openwrt/pull/2330
[1]: https://github.com/openwrt/openwrt/pull/2334
[2]: https://github.com/openwrt/openwrt/pull/2326
[3]: https://github.com/aparcar/attendedsysupgrade-server


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

2019-08-22 Thread John Crispin 

On 22/08/2019 02:59, Paul Spooren wrote:

Both targets miss a subtarget causing an image naming style which is
different from other all othe targets, even tho it already uses
`x/generic/` as subfolder as if the subtarget would exist.

This commit adds the Generic subtarget resulting in consistent naming.

 ~/src/openwrt/openwrt/bin/targets/ipq806x/generic$ ls
 openwrt-ipq806x-generic-netgear_d7800-initramfs-uImage
 openwrt-ipq806x-generic-netgear-d7800.manifest
 openwrt-ipq806x-generic-netgear_d7800-squashfs-factory.img
 openwrt-ipq806x-generic-netgear_d7800-squashfs-sysupgrade.bin


Why would we need to have the generic in the name if there is no other 
non-generic subtarget ?


    John



CC: John Crispin 

Signed-off-by: Paul Spooren 
---
  target/linux/ipq40xx/Makefile  | 1 +
  target/linux/ipq40xx/generic/target.mk | 1 +
  target/linux/ipq806x/Makefile  | 1 +
  target/linux/ipq806x/generic/target.mk | 1 +
  4 files changed, 4 insertions(+)
  create mode 100644 target/linux/ipq40xx/generic/target.mk
  create mode 100644 target/linux/ipq806x/generic/target.mk

diff --git a/target/linux/ipq40xx/Makefile b/target/linux/ipq40xx/Makefile
index 9b78d1f1bf..9e26b277fa 100644
--- a/target/linux/ipq40xx/Makefile
+++ b/target/linux/ipq40xx/Makefile
@@ -7,6 +7,7 @@ FEATURES:=squashfs fpu ramdisk nand
  CPU_TYPE:=cortex-a7
  CPU_SUBTYPE:=neon-vfpv4
  MAINTAINER:=John Crispin 
+SUBTARGETS:=generic
  
  KERNEL_PATCHVER:=4.19
  
diff --git a/target/linux/ipq40xx/generic/target.mk b/target/linux/ipq40xx/generic/target.mk

new file mode 100644
index 00..f5cb1fb19b
--- /dev/null
+++ b/target/linux/ipq40xx/generic/target.mk
@@ -0,0 +1 @@
+BOARDNAME:=Generic
diff --git a/target/linux/ipq806x/Makefile b/target/linux/ipq806x/Makefile
index cd0e8b82ea..19ed015ebc 100644
--- a/target/linux/ipq806x/Makefile
+++ b/target/linux/ipq806x/Makefile
@@ -9,6 +9,7 @@ FEATURES:=squashfs nand fpu ramdisk
  CPU_TYPE:=cortex-a15
  CPU_SUBTYPE:=neon-vfpv4
  MAINTAINER:=John Crispin 
+SUBTARGETS:=generic
  
  KERNEL_PATCHVER:=4.14
  
diff --git a/target/linux/ipq806x/generic/target.mk b/target/linux/ipq806x/generic/target.mk

new file mode 100644
index 00..f5cb1fb19b
--- /dev/null
+++ b/target/linux/ipq806x/generic/target.mk
@@ -0,0 +1 @@
+BOARDNAME:=Generic


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel