Re: [OpenWrt-Devel] [PATCH] use strncpy instead of strcpy
On Tue, Dec 24, 2019 at 1:51 PM Petr Štetiar wrote:
> Khem Raj [2019-12-24 10:02:13]:
>
> Hi,
>
> use "PATCH libubox" subject prefix, because there is no blobmsg.c file in
> the
> main tree.
>
> > Fixes error: '__builtin_strcpy' offset 6 from the object at 'attr' is
> out of
> > the bounds of referenced subobject 'name' with type 'uint8_t[0]' {aka
> > 'unsigned char[0]'} at offset 6 [-Werror=array-bounds]
>
> out of curiosity, which target/compiler is that? I'm not able to reproduce
> it on any of the pre-selected CI targets[1].
This is gcc trunk
>
>
> 1. https://gitlab.com/ynezz/openwrt-libubox/pipelines/105374045/builds
>
> -- ynezz
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] use strncpy instead of strcpy
Khem Raj [2019-12-24 10:02:13]:
Hi,
use "PATCH libubox" subject prefix, because there is no blobmsg.c file in the
main tree.
> Fixes error: '__builtin_strcpy' offset 6 from the object at 'attr' is out of
> the bounds of referenced subobject 'name' with type 'uint8_t[0]' {aka
> 'unsigned char[0]'} at offset 6 [-Werror=array-bounds]
out of curiosity, which target/compiler is that? I'm not able to reproduce
it on any of the pre-selected CI targets[1].
1. https://gitlab.com/ynezz/openwrt-libubox/pipelines/105374045/builds
-- ynezz
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH v2] ath79: tp-link: use ath10k-ct-smallbuffers for 64 MiB devices
Signed-off-by: Paul Fertser --- target/linux/ath79/image/generic-tp-link.mk | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/linux/ath79/image/generic-tp-link.mk b/target/linux/ath79/image/generic-tp-link.mk index 8a030492c5..97c4bb9441 100644 --- a/target/linux/ath79/image/generic-tp-link.mk +++ b/target/linux/ath79/image/generic-tp-link.mk @@ -195,8 +195,8 @@ define Device/tplink_archer-d50-v1 DEVICE_VENDOR := TP-Link DEVICE_MODEL := Archer D50 DEVICE_VARIANT := v1 - DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct \ - ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport \ + kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct BOARDNAME := ARCHER-D50-V1 IMAGE_SIZE := 7808k TPLINK_HWID := 0xC121 @@ -366,7 +366,7 @@ define Device/tplink_re450-v2 IMAGE_SIZE := 6016k DEVICE_MODEL := RE450 DEVICE_VARIANT := v2 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct TPLINK_HWID := 0x0 TPLINK_HWREV := 0 TPLINK_BOARD_ID := RE450-V2 @@ -576,8 +576,9 @@ define Device/tplink_tl-wr902ac-v1 SOC := qca9531 DEVICE_MODEL := TL-WR902AC DEVICE_VARIANT := v1 - DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct \ - ath10k-firmware-qca9887-ct -swconfig -uboot-envtools + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport \ + kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct \ + -swconfig -uboot-envtools TPLINK_BOARD_ID := TL-WR902AC-V1 IMAGE_SIZE := 7360k TPLINK_HWID := 0x0 -- 2.20.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ath79: tp-link: use ath10k-ct-smallbuffers for 64 MiB devices
On Tue, Dec 24, 2019 at 09:27:21PM +0100, Lech Perczak wrote: > > On Tue, Dec 24, 2019 at 08:26:09PM +0100, Lech Perczak wrote: > > > I think that TL-WR902AC v1 should be included as well, as it is 64M device > > > and I also experienced issues with ath10k-ct on it while porting. > > Device like that requires the tweak, no doubt. But I'm not feeling > > like going through the whole ar71xx target since it's deprecated > > anyway and whoever cares should port the needed boards to ath79 AFAIK. > > > This device was just ported to ath79 recently. Indeed, it got right in-between. I'll send an amendment to this tp-link patch, thanks for noticing! > I think grepping by device trees could be used to determine devices which > need the changes. I have an impression that RAM amount is autodetected, so grepping through DTSes can't help here. In any case, I think it's all covered by now. Thank you! -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ath79: tp-link: use ath10k-ct-smallbuffers for 64 MiB devices
Hi, Answers inline. W dniu 2019-12-24 o 20:47, Paul Fertser pisze: Hi Lech, Any reason you omit the list from Cc? This way nobody but me is going to comment on your message and I'm obviously biased :) Just forgot to use "reply to all". On Tue, Dec 24, 2019 at 08:26:09PM +0100, Lech Perczak wrote: I think that TL-WR902AC v1 should be included as well, as it is 64M device and I also experienced issues with ath10k-ct on it while porting. Device like that requires the tweak, no doubt. But I'm not feeling like going through the whole ar71xx target since it's deprecated anyway and whoever cares should port the needed boards to ath79 AFAIK. So if one stays on ar71xx for the upcoming release the workaround would be to manually run opkg remove kmod-ath10k-ct && opkg install kmod-ath10k-ct-smallbuffers That said, I have no idea if patches to ar71xx are accepted or not. This device was just ported to ath79 recently. I think grepping by device trees could be used to determine devices which need the changes. -- With kind regards, Lech ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] use strncpy instead of strcpy
On Tue, Dec 24, 2019 at 10:10 AM Paul Fertser wrote: > Hi, > > On Tue, Dec 24, 2019 at 10:02:13AM -0800, Khem Raj wrote: > > + hdr->name[strlen((char*)hdr->name)] = '\0'; > > + strncpy((char *) hdr->name, (const char *)name, > strlen((char*)hdr->name)); > > strlen((char*)hdr->name) doesn't seem to be meaningful in this > context, are you sure you were not meaning to do something like this > instead? > > + strncpy((char *) hdr->name, (const char *)name, sizeof(hdr->name)); > + hdr->name[sizeof(hdr->name) - 1] = '\0'; Yes that is better I will send a v2 after tests > > > -- > Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! > mailto:fercer...@gmail.com > ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] OpenWrt 19.07 final timeline
Hi And what about this one? https://bugs.openwrt.org/index.php?do=details_id=2593 Some regulatorty bugs? ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] use strncpy instead of strcpy
Hi, On Tue, Dec 24, 2019 at 10:02:13AM -0800, Khem Raj wrote: > + hdr->name[strlen((char*)hdr->name)] = '\0'; > + strncpy((char *) hdr->name, (const char *)name, > strlen((char*)hdr->name)); strlen((char*)hdr->name) doesn't seem to be meaningful in this context, are you sure you were not meaning to do something like this instead? + strncpy((char *) hdr->name, (const char *)name, sizeof(hdr->name)); + hdr->name[sizeof(hdr->name) - 1] = '\0'; -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] use strncpy instead of strcpy
Fixes
error: '__builtin_strcpy' offset 6 from the object at 'attr' is out of the
bounds of referenced subobject 'name' with type 'uint8_t[0]' {aka 'unsigned
char[0]'} at offset 6 [-Werror=array-bounds]
Signed-off-by: Khem Raj
---
blobmsg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/blobmsg.c b/blobmsg.c
index a860483..63fada8 100644
--- a/blobmsg.c
+++ b/blobmsg.c
@@ -195,7 +195,8 @@ blobmsg_new(struct blob_buf *buf, int type, const char
*name, int payload_len, v
attr->id_len |= be32_to_cpu(BLOB_ATTR_EXTENDED);
hdr = blob_data(attr);
hdr->namelen = cpu_to_be16(namelen);
- strcpy((char *) hdr->name, (const char *)name);
+ hdr->name[strlen((char*)hdr->name)] = '\0';
+ strncpy((char *) hdr->name, (const char *)name,
strlen((char*)hdr->name));
pad_end = *data = blobmsg_data(attr);
pad_start = (char *) >name[namelen];
if (pad_start < pad_end)
--
2.24.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] ipq40xx: use ath10k-ct-smallbuffers for 128 MiB devices
Signed-off-by: Paul Fertser --- target/linux/ipq40xx/image/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/linux/ipq40xx/image/Makefile b/target/linux/ipq40xx/image/Makefile index fada35a49d..1fe563c7a5 100644 --- a/target/linux/ipq40xx/image/Makefile +++ b/target/linux/ipq40xx/image/Makefile @@ -128,7 +128,8 @@ define Device/asus_rt-ac58u # string and call it a day Yeah, we do the latter! UIMAGE_NAME:=$(shell echo -e '\03\01\01\01RT-AC58U') IMAGES := sysupgrade.bin - DEVICE_PACKAGES := kmod-usb-ledtrig-usbport + DEVICE_PACKAGES := -kmod-ath10k-ct kmod-ath10k-ct-smallbuffers \ + kmod-usb-ledtrig-usbport endef TARGET_DEVICES += asus_rt-ac58u @@ -494,6 +495,7 @@ define Device/zyxel_wre6606 DEVICE_DTS := qcom-ipq4018-wre6606 IMAGES := sysupgrade.bin IMAGE/sysupgrade.bin := append-kernel | append-rootfs | pad-rootfs | append-metadata + DEVICE_PACKAGES := -kmod-ath10k-ct kmod-ath10k-ct-smallbuffers endef TARGET_DEVICES += zyxel_wre6606 -- 2.20.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] ath79: tp-link: use ath10k-ct-smallbuffers for 64 MiB devices
Signed-off-by: Paul Fertser --- target/linux/ath79/image/generic-tp-link.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/linux/ath79/image/generic-tp-link.mk b/target/linux/ath79/image/generic-tp-link.mk index 8a030492c5..f4e16e6e43 100644 --- a/target/linux/ath79/image/generic-tp-link.mk +++ b/target/linux/ath79/image/generic-tp-link.mk @@ -195,8 +195,8 @@ define Device/tplink_archer-d50-v1 DEVICE_VENDOR := TP-Link DEVICE_MODEL := Archer D50 DEVICE_VARIANT := v1 - DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct \ - ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-usb2 kmod-usb-ledtrig-usbport \ + kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct BOARDNAME := ARCHER-D50-V1 IMAGE_SIZE := 7808k TPLINK_HWID := 0xC121 @@ -366,7 +366,7 @@ define Device/tplink_re450-v2 IMAGE_SIZE := 6016k DEVICE_MODEL := RE450 DEVICE_VARIANT := v2 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct TPLINK_HWID := 0x0 TPLINK_HWREV := 0 TPLINK_BOARD_ID := RE450-V2 -- 2.20.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] OpenWrt 19.07 final timeline
Hi, I would like to tag 18.06.6 release in the evening of Wednesday 1. January and then start the builders. I would like to tag 19.07 final release on Friday 3. January and the start the builders on Saturday or Sunday. Are there any objections to these dates? Both releases should fix all known security problems, this is release gating, but I think everything is fixed now. We now have the ath10k-ct small buffers version in master and 19.07, for the 19.07 branch it has to be selected, but Paul Fertser already proposed a patch. Here some people are complaining about bad 5GHz performance: https://bugs.openwrt.org/index.php?do=details_id=2682 https://forum.openwrt.org/t/openwrt-19-07-0-second-release-candidate/49593/41 This should be related to the hostapd update from 2.7 to 2.9. Does someone have time to debug this? It would be interesting which commit exactly causes this, we also have hostapd 2.8 in between. Hauke signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] petition: start an slightly frozen branch based on snapshot (future 20.x ? release)
Dear List, Most of the new devices that are coming, or that are useful for us as community networks are in the snapshot release [1] [2] [3]. I feel the new 19.07 is not benefiting this new devices that will remain unsupported by a stable branch (most of them, based on ath10k / 802.11ac). We are between: (1) buying legacy devices (ath9k and 802.11n), for example right now classic nanostation XW m5 is locked right now [4]), (2) second hand devices or (3) buying new devices using ath10k and 802.11ac (using the wiki procedure still you can unlock them and install openwrt) Our use case requires stable releases because in a community network we remotely upgrade firmwares. Based on previous experiences (releases 17, 18) it worked perfectly. I don't feel good introducing the usage of snapshot for building our firmwares (image builder and so on). In that circumstances, I think we prefer known bugs that new bugs approaching. I thought of having my custom patches on top of 19.07 branch. Maybe someone is already doing it. I'm sure more people have this need. I don't feel confortable leading that proposed frozen branch that could help as a pre-work/alpha for future 20.x openwrt release. Anyone in the same situation? But maybe is too much effort and we should continue focusing on the plan right now (get 19.07 release done) Cheers, Pedro [1] https://openwrt.org/toh/ubiquiti/ubiquiti_nanostation_ac_loco [2] https://openwrt.org/toh/hwdata/ubiquiti/ubiquiti_liteap_ac_lap-120 [3] v2 and v3 https://openwrt.org/toh/tp-link/cpe510 [4] https://forum.openwrt.org/t/hw-of-ubiquiti-nanostation-m5-has-changed/39225 0x9D64597C3A982DCA.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH for-19.07] ath79: use ath10k-ct-smallbuffers for 64 MiB devices
Signed-off-by: Paul Fertser --- target/linux/ath79/image/generic-tp-link.mk | 14 +++--- target/linux/ath79/image/generic-ubnt.mk| 8 target/linux/ath79/image/generic.mk | 6 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/linux/ath79/image/generic-tp-link.mk b/target/linux/ath79/image/generic-tp-link.mk index 468117aad4..304304799d 100644 --- a/target/linux/ath79/image/generic-tp-link.mk +++ b/target/linux/ath79/image/generic-tp-link.mk @@ -17,7 +17,7 @@ define Device/tplink_archer-c2-v3 ATH_SOC := qca9563 IMAGE_SIZE := 7808k DEVICE_TITLE := TP-Link Archer C2 v3 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct TPLINK_BOARD_ID := ARCHER-C2-V3 endef TARGET_DEVICES += tplink_archer-c2-v3 @@ -28,7 +28,7 @@ define Device/tplink_archer-c25-v1 IMAGE_SIZE := 7808k DEVICE_TITLE := TP-Link Archer C25 v1 TPLINK_BOARD_ID := ARCHER-C25-V1 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct SUPPORTED_DEVICES += archer-c25-v1 endef TARGET_DEVICES += tplink_archer-c25-v1 @@ -39,7 +39,7 @@ define Device/tplink_archer-c58-v1 IMAGE_SIZE := 7936k DEVICE_TITLE := TP-Link Archer C58 v1 TPLINK_BOARD_ID := ARCHER-C58-V1 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct SUPPORTED_DEVICES += archer-c58-v1 endef TARGET_DEVICES += tplink_archer-c58-v1 @@ -61,7 +61,7 @@ define Device/tplink_archer-c60-v1 IMAGE_SIZE := 7936k DEVICE_TITLE := TP-Link Archer C60 v1 TPLINK_BOARD_ID := ARCHER-C60-V1 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct SUPPORTED_DEVICES += archer-c60-v1 endef TARGET_DEVICES += tplink_archer-c60-v1 @@ -72,7 +72,7 @@ define Device/tplink_archer-c60-v2 IMAGE_SIZE := 7808k DEVICE_TITLE := TP-Link Archer C60 v2 TPLINK_BOARD_ID := ARCHER-C60-V2 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct SUPPORTED_DEVICES += archer-c60-v2 endef TARGET_DEVICES += tplink_archer-c60-v2 @@ -171,7 +171,7 @@ TARGET_DEVICES += tplink_cpe210-v3 define Device/tplink_archer-d50-v1 ATH_SOC := qca9531 DEVICE_TITLE := TP-Link Archer D50 v1 - DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct BOARDNAME := ARCHER-D50-V1 IMAGE_SIZE := 7808k TPLINK_HWID := 0xC121 @@ -206,7 +206,7 @@ define Device/tplink_re450-v2 ATH_SOC := qca9563 IMAGE_SIZE := 6016k DEVICE_TITLE := TP-Link RE450 v2 - DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct TPLINK_HWID := 0x0 TPLINK_HWREV := 0 TPLINK_BOARD_ID := RE450-V2 diff --git a/target/linux/ath79/image/generic-ubnt.mk b/target/linux/ath79/image/generic-ubnt.mk index 6601986e08..8bc4523f46 100644 --- a/target/linux/ath79/image/generic-ubnt.mk +++ b/target/linux/ath79/image/generic-ubnt.mk @@ -128,7 +128,7 @@ TARGET_DEVICES += ubnt_nanostation-m-xw define Device/ubnt_lap-120 $(Device/ubnt-wa) DEVICE_TITLE := Ubiquiti LiteAP ac (LAP-120) - DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct IMAGE_SIZE := 15744k IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage-split endef @@ -137,7 +137,7 @@ TARGET_DEVICES += ubnt_lap-120 define Device/ubnt_nanobeam-ac $(Device/ubnt-wa) DEVICE_TITLE := Ubiquiti NanoBeam AC - DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct rssileds + DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct rssileds IMAGE_SIZE := 15744k IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage-split endef @@ -146,7 +146,7 @@ TARGET_DEVICES += ubnt_nanobeam-ac define Device/ubnt_nanostation-ac $(Device/ubnt-wa) DEVICE_TITLE := Ubiquiti Nanostation AC - DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct rssileds + DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct rssileds IMAGE_SIZE := 15744k IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage-split endef @@ -155,7 +155,7 @@ TARGET_DEVICES += ubnt_nanostation-ac define Device/ubnt_nanostation-ac-loco $(Device/ubnt-wa) DEVICE_TITLE := Ubiquiti Nanostation AC loco - DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct + DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct IMAGE_SIZE := 15744k
