Re: [OpenWrt-Devel] [PATCH] rpcd: fix respawn settings

2020-03-11 Thread Michael Jones 
On Fri, Mar 6, 2020 at 1:19 AM Jo-Philipp Wich  wrote:

> Hi,
>
> > rpcd crashes for me daily, to the point where i have a script that
> restarts it
> > every 5 minutes.
> >
> > It also gets hung a lot without crashing, and stops serving responses to
> ubus
> > traffic.
>
> I've never heard about anything like that until now, not even in the forum
> or
> IRC chatter. Getting some details here would be interesting.
>
> ~ Jo
>

I've reviewed the mailing list for the previous year, and found this post:

http://lists.infradead.org/pipermail/openwrt-devel/2019-October/019592.html

Which appears to have been merged into rpcd with this commit :
https://git.openwrt.org/?p=project/rpcd.git;a=commit;h=bd0ed2521476c3e5b6c1a0e0bd2c386ea809d74b

This post / commit appears to identify the same crash that my scripts cause.

However, the commit for the OpenWRT 18.06 branch (Still receiving security
fixes, as far as I can tell), has this commit for RPCD

https://github.com/openwrt/openwrt/blob/openwrt-18.06/package/system/rpcd/Makefile

commit 3aa81d0dfae167eccc26203bd0c96f3e3450f253
Author: Jo-Philipp Wich 
Date:   Wed Nov 28 12:12:04 2018 +0100

file: access exec timeout via daemon ops structure

Since the plugin is not linked, but dlopen()'d with RTLD_LOCAL, we
cannot
access global rpcd variables but need to access them via the common ops
structure symbol.

Signed-off-by: Jo-Philipp Wich 



To see if that really fixed the issue, I will update my build of rpcd
from 3aa81d0dfae167eccc26203bd0c96f3e3450f253
to bd0ed2521476c3e5b6c1a0e0bd2c386ea809d74b (or git head, perhaps) to see
if the crash gets resolved.
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v5] build: refactor JSON info files to `profiles.json`

2020-03-11 Thread Paul Spooren 
On Wed Mar 11, 2020 at 2:12 AM PST, Petr Štetiar wrote:
> Paul Spooren  [2020-03-10 18:11:21]:
>
> > +  $$(_TARGET): $(BUILD_DIR)/json_info_files/$(call 
> > IMAGE_NAME,$(1),$(2)).json
> > +  $(BUILD_DIR)/json_info_files/$(call IMAGE_NAME,$(1),$(2)).json: 
> > $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2))$$(GZ_SUFFIX)
>
> This JSON file target is relatively long, used twice already, perhaps
> using
> common short variable would make sense here.

$(JSON_INFO_FILE) introduced

>
> > $(TOPDIR)/scripts/json_add_image_info.py \
>
> You're missing here that output file argument.

Now uses $$@

>
> > +  ROOTFS/$(1)/$(3) := \
> > +   $(KDIR)/root.$(1)$$(strip \
> > +   $$(if $$(FS_OPTIONS/$(1)),+fs=$$(call 
> > param_mangle,$$(FS_OPTIONS/$(1 \
> > +   )$$(strip \
> > +   $(if $(TARGET_PER_DEVICE_ROOTFS),+pkg=$$(ROOTFS_ID/$(3))) \
> > +   )
> > +  ifndef IB
> > +$$(ROOTFS/$(1)/$(3)): $(if 
> > $(TARGET_PER_DEVICE_ROOTFS),target-dir-$$(ROOTFS_ID/$(3)))
> > +  endif
> > +  $(KDIR)/tmp/$(call IMAGE_NAME,$(1),$(2)): $$(KDIR_KERNEL_IMAGE) 
> > $$(ROOTFS/$(1)/$(3))
> > +   @rm -f $$@
> > +   [ -f $$(word 1,$$^) -a -f $$(word 2,$$^) ]
> > +   $$(call concat_cmd,$(if 
> > $(IMAGE/$(2)/$(1)),$(IMAGE/$(2)/$(1)),$(IMAGE/$(2
> > +
> > +  .IGNORE: $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2))
> > +
> > +  $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)).gz: $(KDIR)/tmp/$(call 
> > IMAGE_NAME,$(1),$(2))
> > +   gzip -c -9n $$^ > $$@
> > +
> > +  $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)): $(KDIR)/tmp/$(call 
> > IMAGE_NAME,$(1),$(2))
> > +   cp $$^ $$@
> > +
>
> Is this reordering necessary? If so, I would probably do that in
> separate patch for
> easier review.

Now again in old order and still works

>
> > diff --git a/target/imagebuilder/files/Makefile 
> > b/target/imagebuilder/files/Makefile
> > index 15b3d5c35c..7d5eddaff6 100644
> > --- a/target/imagebuilder/files/Makefile
> > +++ b/target/imagebuilder/files/Makefile
> > @@ -118,6 +118,7 @@ _call_image: staging_dir/host/.prereq-build
> > $(MAKE) package_install
> > $(MAKE) -s prepare_rootfs
> > $(MAKE) -s build_image
> > +   $(if $(CONFIG_JSON_OVERVIEW_IMAGE_INFO),$(_SINGLE)$(SUBMAKE) -r 
> > json_overview_image_info)
> > $(MAKE) -s checksum
>
> Seems like copy from the `world` target. I think, that:
>
> $(MAKE) -s json_overview_image_info
>
> would make more sense here.

ACK, c indeed

> I would as well move that if somewhere else.

Where should I move it? Into the $(BIN_DIR)/profiles.json target?

>
> > world: prepare $(target/stamp-compile) $(package/stamp-compile) 
> > $(package/stamp-install) $(target/stamp-install) FORCE
> >$(_SINGLE)$(SUBMAKE) -r package/index
> > +   $(if $(CONFIG_JSON_OVERVIEW_IMAGE_INFO),$(_SINGLE)$(SUBMAKE) -r 
> > json_overview_image_info)
> > $(_SINGLE)$(SUBMAKE) -r checksum
>
> Same here, move that if and the common place to not repeat that
> condition two times etc.
>
> $(_SINGLE)$(SUBMAKE) -r json_overview_image_info

Updated, same question regarding the IF

Thanks,
Paul

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] V5.4: Probe of eth0 fails on TP-Link Archer A7V5

2020-03-11 Thread Steve Brown 
I get:

[0.541856] libphy: Fixed MDIO Bus: probed
[0.548637] ag71xx: probe of 1900.eth failed with error -2

On 4.19.98, I get:

[0.508331] libphy: Fixed MDIO Bus: probed
[1.199161] libphy: ag71xx_mdio: probed
[1.206146] switch0: Atheros AR8337 rev. 2 switch registered on mdio-bus.0
[1.860256] ag71xx 1900.eth: connected to PHY at mdio-bus.0:00 
[uid=004dd036, driver=Atheros AR8216/AR8236/AR8316]
[1.871927] eth0: Atheros AG71xx at 0xb900, irq 4, mode: sgmii

Result: no eth0

Both logs at commit id 14a07fa1f and ath79.

Steve



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] treewide: remove maintainer variable from targets

2020-03-11 Thread Piotr Dymacz 

Hi Petr,

On 11.03.2020 15:04, Petr Štetiar wrote:

There is no such role as target maintainer anymore, one should always
send corresponding changes for the review and anyone from the commiters
is allowed to merge them or eventually use the hand break and NACK them.

Lets make it clear, that it is solely a community doing the maintenance
tasks.


Acked-by: Piotr Dymacz 

--
Cheers,
Piotr



Signed-off-by: Petr Štetiar 
---
  target/linux/apm821xx/Makefile   | 2 --
  target/linux/arc770/Makefile | 1 -
  target/linux/archs38/Makefile| 1 -
  target/linux/armvirt/Makefile| 1 -
  target/linux/at91/Makefile   | 2 --
  target/linux/ath25/Makefile  | 1 -
  target/linux/bcm27xx/Makefile| 1 -
  target/linux/bcm47xx/Makefile| 1 -
  target/linux/bcm53xx/Makefile| 1 -
  target/linux/bcm63xx/Makefile| 1 -
  target/linux/cns3xxx/Makefile| 2 --
  target/linux/gemini/Makefile | 1 -
  target/linux/imx6/Makefile   | 1 -
  target/linux/ipq40xx/Makefile| 1 -
  target/linux/ipq806x/Makefile| 1 -
  target/linux/ipq807x/Makefile| 1 -
  target/linux/lantiq/Makefile | 1 -
  target/linux/layerscape/Makefile | 1 -
  target/linux/mediatek/Makefile   | 1 -
  target/linux/mpc85xx/Makefile| 1 -
  target/linux/mvebu/Makefile  | 1 -
  target/linux/mxs/Makefile| 1 -
  target/linux/octeon/Makefile | 1 -
  target/linux/octeontx/Makefile   | 2 --
  target/linux/omap/Makefile   | 2 --
  target/linux/oxnas/Makefile  | 2 --
  target/linux/pistachio/Makefile  | 1 -
  target/linux/ramips/Makefile | 1 -
  target/linux/rb532/Makefile  | 1 -
  target/linux/samsung/Makefile| 1 -
  target/linux/sunxi/Makefile  | 1 -
  target/linux/tegra/Makefile  | 1 -
  target/linux/x86/Makefile| 1 -
  target/linux/zynq/Makefile   | 1 -
  34 files changed, 40 deletions(-)

diff --git a/target/linux/apm821xx/Makefile b/target/linux/apm821xx/Makefile
index 9ba623535ee9..9697af77bb78 100644
--- a/target/linux/apm821xx/Makefile
+++ b/target/linux/apm821xx/Makefile
@@ -9,8 +9,6 @@ BOARD:=apm821xx
  BOARDNAME:=AppliedMicro APM821xx
  CPU_TYPE:=464fp
  FEATURES:=fpu dt gpio
-MAINTAINER:=Chris Blake , \
-   Christian Lamparter 
  SUBTARGETS:=nand sata
  
  KERNEL_PATCHVER:=4.19

diff --git a/target/linux/arc770/Makefile b/target/linux/arc770/Makefile
index b5e2d54065e4..8150f147c5aa 100644
--- a/target/linux/arc770/Makefile
+++ b/target/linux/arc770/Makefile
@@ -9,7 +9,6 @@ include $(TOPDIR)/rules.mk
  ARCH:=arc
  BOARD:=arc770
  BOARDNAME:=Synopsys DesignWare ARC 770D
-MAINTAINER:=Alexey Brodkin 
  SUBTARGETS:=generic
  
  KERNEL_PATCHVER:=4.14

diff --git a/target/linux/archs38/Makefile b/target/linux/archs38/Makefile
index be6be0472b5a..a6ac05b9dfb3 100644
--- a/target/linux/archs38/Makefile
+++ b/target/linux/archs38/Makefile
@@ -10,7 +10,6 @@ ARCH:=arc
  CPU_TYPE:=archs
  BOARD:=archs38
  BOARDNAME:=Synopsys DesignWare ARC HS38
-MAINTAINER:=Alexey Brodkin 
  SUBTARGETS:=generic
  
  KERNEL_PATCHVER:=4.14

diff --git a/target/linux/armvirt/Makefile b/target/linux/armvirt/Makefile
index 03adf4436cfc..4a8c6b092c91 100644
--- a/target/linux/armvirt/Makefile
+++ b/target/linux/armvirt/Makefile
@@ -10,7 +10,6 @@ BOARD:=armvirt
  BOARDNAME:=QEMU ARM Virtual Machine
  FEATURES:=fpu pci rtc usb
  FEATURES+=cpiogz ext4 ramdisk squashfs targz
-MAINTAINER:=Yousong Zhou 
  
  KERNEL_PATCHVER:=5.4
  
diff --git a/target/linux/at91/Makefile b/target/linux/at91/Makefile

index 6c1ba11c5510..4780210f36f8 100644
--- a/target/linux/at91/Makefile
+++ b/target/linux/at91/Makefile
@@ -8,8 +8,6 @@ include $(TOPDIR)/rules.mk
  
  ARCH:=arm

  BOARD:=at91
-MAINTAINER:=Claudio Mignanti  \
-   Sandeep Sheriker 
  BOARDNAME:=Microchip (Atmel AT91)
  FEATURES:=ext4 squashfs targz usb usbgadget ubifs
  SUBTARGETS:=sama5 sam9x
diff --git a/target/linux/ath25/Makefile b/target/linux/ath25/Makefile
index cb8b7ec1be3e..4fb082edfd67 100644
--- a/target/linux/ath25/Makefile
+++ b/target/linux/ath25/Makefile
@@ -10,7 +10,6 @@ ARCH:=mips
  BOARD:=ath25
  BOARDNAME:=Atheros AR231x/AR5312
  FEATURES:=squashfs low_mem small_flash
-MAINTAINER:=Sergey Ryazanov 
  
  KERNEL_PATCHVER:=4.14
  
diff --git a/target/linux/bcm27xx/Makefile b/target/linux/bcm27xx/Makefile

index 507690357af4..7cc2aab7009b 100644
--- a/target/linux/bcm27xx/Makefile
+++ b/target/linux/bcm27xx/Makefile
@@ -11,7 +11,6 @@ ARCH:=arm
  BOARD:=bcm27xx
  BOARDNAME:=Broadcom BCM27xx
  FEATURES:=ext4 audio usb usbgadget display gpio fpu squashfs rootfs-part 
boot-part
-MAINTAINER:=Álvaro Fernández Rojas 
  SUBTARGETS:=bcm2708 bcm2709 bcm2710 bcm2711
  
  KERNEL_PATCHVER:=4.19

diff --git a/target/linux/bcm47xx/Makefile b/target/linux/bcm47xx/Makefile
index 32c1e7d211b0..c5b5e69edad3 100644
--- a/target/linux/bcm47xx/Makefile
+++ b/target/linux/bcm47xx/Makefile
@@ -11,7 +11,6 @@ BOARD:=bcm47xx
  BOARDNAME:=Broadcom BCM47xx/53xx (MIPS)
  FEATURES:=squashfs usb
  SUBTARGETS:=generic mips74k legacy
-MAINTAINER:=Hauke

Re: [OpenWrt-Devel] [PATCH] treewide: remove maintainer variable from targets

2020-03-11 Thread Adrian Schmutzler 
> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of Petr Štetiar
> Sent: Mittwoch, 11. März 2020 15:05
> To: openwrt-devel@lists.openwrt.org
> Cc: Petr Štetiar 
> Subject: [OpenWrt-Devel] [PATCH] treewide: remove maintainer variable from
> targets
> 
> There is no such role as target maintainer anymore, one should always
> send corresponding changes for the review and anyone from the commiters
> is allowed to merge them or eventually use the hand break and NACK them.
> 
> Lets make it clear, that it is solely a community doing the maintenance
> tasks.

I like this change, particularly since frequently the study of the git history 
revealed a more honest picture anyway ...

Acked-by: Adrian Schmutzler 

> 
> Signed-off-by: Petr Štetiar 
> ---
>  target/linux/apm821xx/Makefile   | 2 --
>  target/linux/arc770/Makefile | 1 -
>  target/linux/archs38/Makefile| 1 -
>  target/linux/armvirt/Makefile| 1 -
>  target/linux/at91/Makefile   | 2 --
>  target/linux/ath25/Makefile  | 1 -
>  target/linux/bcm27xx/Makefile| 1 -
>  target/linux/bcm47xx/Makefile| 1 -
>  target/linux/bcm53xx/Makefile| 1 -
>  target/linux/bcm63xx/Makefile| 1 -
>  target/linux/cns3xxx/Makefile| 2 --
>  target/linux/gemini/Makefile | 1 -
>  target/linux/imx6/Makefile   | 1 -
>  target/linux/ipq40xx/Makefile| 1 -
>  target/linux/ipq806x/Makefile| 1 -
>  target/linux/ipq807x/Makefile| 1 -
>  target/linux/lantiq/Makefile | 1 -
>  target/linux/layerscape/Makefile | 1 -
>  target/linux/mediatek/Makefile   | 1 -
>  target/linux/mpc85xx/Makefile| 1 -
>  target/linux/mvebu/Makefile  | 1 -
>  target/linux/mxs/Makefile| 1 -
>  target/linux/octeon/Makefile | 1 -
>  target/linux/octeontx/Makefile   | 2 --
>  target/linux/omap/Makefile   | 2 --
>  target/linux/oxnas/Makefile  | 2 --
>  target/linux/pistachio/Makefile  | 1 -
>  target/linux/ramips/Makefile | 1 -
>  target/linux/rb532/Makefile  | 1 -
>  target/linux/samsung/Makefile| 1 -
>  target/linux/sunxi/Makefile  | 1 -
>  target/linux/tegra/Makefile  | 1 -
>  target/linux/x86/Makefile| 1 -
>  target/linux/zynq/Makefile   | 1 -
>  34 files changed, 40 deletions(-)
> 
> diff --git a/target/linux/apm821xx/Makefile b/target/linux/apm821xx/Makefile
> index 9ba623535ee9..9697af77bb78 100644
> --- a/target/linux/apm821xx/Makefile
> +++ b/target/linux/apm821xx/Makefile
> @@ -9,8 +9,6 @@ BOARD:=apm821xx
>  BOARDNAME:=AppliedMicro APM821xx
>  CPU_TYPE:=464fp
>  FEATURES:=fpu dt gpio
> -MAINTAINER:=Chris Blake , \
> - Christian Lamparter 
>  SUBTARGETS:=nand sata
> 
>  KERNEL_PATCHVER:=4.19
> diff --git a/target/linux/arc770/Makefile b/target/linux/arc770/Makefile
> index b5e2d54065e4..8150f147c5aa 100644
> --- a/target/linux/arc770/Makefile
> +++ b/target/linux/arc770/Makefile
> @@ -9,7 +9,6 @@ include $(TOPDIR)/rules.mk
>  ARCH:=arc
>  BOARD:=arc770
>  BOARDNAME:=Synopsys DesignWare ARC 770D
> -MAINTAINER:=Alexey Brodkin 
>  SUBTARGETS:=generic
> 
>  KERNEL_PATCHVER:=4.14
> diff --git a/target/linux/archs38/Makefile b/target/linux/archs38/Makefile
> index be6be0472b5a..a6ac05b9dfb3 100644
> --- a/target/linux/archs38/Makefile
> +++ b/target/linux/archs38/Makefile
> @@ -10,7 +10,6 @@ ARCH:=arc
>  CPU_TYPE:=archs
>  BOARD:=archs38
>  BOARDNAME:=Synopsys DesignWare ARC HS38
> -MAINTAINER:=Alexey Brodkin 
>  SUBTARGETS:=generic
> 
>  KERNEL_PATCHVER:=4.14
> diff --git a/target/linux/armvirt/Makefile b/target/linux/armvirt/Makefile
> index 03adf4436cfc..4a8c6b092c91 100644
> --- a/target/linux/armvirt/Makefile
> +++ b/target/linux/armvirt/Makefile
> @@ -10,7 +10,6 @@ BOARD:=armvirt
>  BOARDNAME:=QEMU ARM Virtual Machine
>  FEATURES:=fpu pci rtc usb
>  FEATURES+=cpiogz ext4 ramdisk squashfs targz
> -MAINTAINER:=Yousong Zhou 
> 
>  KERNEL_PATCHVER:=5.4
> 
> diff --git a/target/linux/at91/Makefile b/target/linux/at91/Makefile
> index 6c1ba11c5510..4780210f36f8 100644
> --- a/target/linux/at91/Makefile
> +++ b/target/linux/at91/Makefile
> @@ -8,8 +8,6 @@ include $(TOPDIR)/rules.mk
> 
>  ARCH:=arm
>  BOARD:=at91
> -MAINTAINER:=Claudio Mignanti  \
> -   Sandeep Sheriker 
>  BOARDNAME:=Microchip (Atmel AT91)
>  FEATURES:=ext4 squashfs targz usb usbgadget ubifs
>  SUBTARGETS:=sama5 sam9x
> diff --git a/target/linux/ath25/Makefile b/target/linux/ath25/Makefile
> index cb8b7ec1be3e..4fb082edfd67 100644
> --- a/target/linux/ath25/Makefile
> +++ b/target/linux/ath25/Makefile
> @@ -10,7 +10,6 @@ ARCH:=mips
>  BOARD:=ath25
>  BOARDNAME:=Atheros AR231x/AR5312
>  FEATURES:=squashfs low_mem small_flash
> -MAINTAINER:=Sergey Ryazanov 
> 
>  KERNEL_PATCHVER:=4.14
> 
> diff --git a/target/linux/bcm27xx/Makefile b/target/linux/bcm27xx/Makefile
> index 507690357af4..7cc2aab7009b 100644
> --- a/target/linux/bcm27xx/Makefile
> +++ b/target/linux/bcm27xx/Makefile
> @@ -11,7 +11,6 @@ ARCH:=arm
>  BOARD:=bcm27xx
>  BOARDNAME:=Broadcom BCM27xx
>

[OpenWrt-Devel] [PATCH v2] imx6: add support for GW5907/GW5910/GW5912/GW5913

2020-03-11 Thread Tim Harvey 
This patch adds support for GW5907/GW5910/GW5912/GW5913 IMX6 based boards
from the Gateworks Ventana Family[A]:
- backport upstream dt patches from 5.6 to 4.19 and 5.4
- add dtb's to ventana images
- add board-name and network config

A. 
https://www.gateworks.com/products/imx6-single-board-computer-gateworks-ventana-family

Flashing instructions for Ventana boards:

Using pre-flashed bootloader:
- Use appropriate ubi image depending on board NAND to flash via bootloader:
openwrt-imx6-ventana-squashfs-nand.ubi - 2KiB page size
openwrt-imx6-ventana-large-squashfs-nand.ubi - 4KiB page size
http://trac.gateworks.com/wiki/linux/ubi

Using Gateworks JTAG dongle:
- Use Gateworks mkimage_jtag script to create a JTAG image comprised of
pre-built bootloader and ubi image:
http://trac.gateworks.com/wiki/jtag_instructions

Signed-off-by: Tim Harvey 
---
v2:
 - more descriptive commit log
 - add dtb's to ventana images
 - add 5.4 support
---
 .../linux/imx6/base-files/etc/board.d/02_network   |   6 +-
 target/linux/imx6/base-files/lib/imx6.sh   |  20 +
 target/linux/imx6/image/Makefile   |  10 +-
 .../001-ARM-dts-imx-Add-GW5907-board-support.patch | 496 +
 .../002-ARM-dts-imx-Add-GW5910-board-support.patch | 597 +
 .../003-ARM-dts-imx-Add-GW5913-board-support.patch | 449 
 .../004-ARM-dts-imx-Add-GW5912-board-support.patch | 565 +++
 .../001-ARM-dts-imx-Add-GW5907-board-support.patch | 496 +
 .../002-ARM-dts-imx-Add-GW5910-board-support.patch | 597 +
 .../003-ARM-dts-imx-Add-GW5913-board-support.patch | 449 
 .../004-ARM-dts-imx-Add-GW5912-board-support.patch | 565 +++
 11 files changed, 4248 insertions(+), 2 deletions(-)
 create mode 100644 
target/linux/imx6/patches-4.19/001-ARM-dts-imx-Add-GW5907-board-support.patch
 create mode 100644 
target/linux/imx6/patches-4.19/002-ARM-dts-imx-Add-GW5910-board-support.patch
 create mode 100644 
target/linux/imx6/patches-4.19/003-ARM-dts-imx-Add-GW5913-board-support.patch
 create mode 100644 
target/linux/imx6/patches-4.19/004-ARM-dts-imx-Add-GW5912-board-support.patch
 create mode 100644 
target/linux/imx6/patches-5.4/001-ARM-dts-imx-Add-GW5907-board-support.patch
 create mode 100644 
target/linux/imx6/patches-5.4/002-ARM-dts-imx-Add-GW5910-board-support.patch
 create mode 100644 
target/linux/imx6/patches-5.4/003-ARM-dts-imx-Add-GW5913-board-support.patch
 create mode 100644 
target/linux/imx6/patches-5.4/004-ARM-dts-imx-Add-GW5912-board-support.patch

diff --git a/target/linux/imx6/base-files/etc/board.d/02_network 
b/target/linux/imx6/base-files/etc/board.d/02_network
index 48e5f0f..bc05313 100755
--- a/target/linux/imx6/base-files/etc/board.d/02_network
+++ b/target/linux/imx6/base-files/etc/board.d/02_network
@@ -13,7 +13,11 @@ case "$board" in
 cubox-i |\
 gw51xx |\
 gw52xx |\
-gw5904)
+gw5904 |\
+gw5907 |\
+gw5910 |\
+gw5912 |\
+gw5913)
ucidef_set_interface_lan 'eth0'
;;
 gw53xx |\
diff --git a/target/linux/imx6/base-files/lib/imx6.sh 
b/target/linux/imx6/base-files/lib/imx6.sh
index 68caaff..63fff0f 100755
--- a/target/linux/imx6/base-files/lib/imx6.sh
+++ b/target/linux/imx6/base-files/lib/imx6.sh
@@ -81,6 +81,26 @@ imx6_board_detect() {
name="gw5904"
;;
 
+   "Gateworks Ventana i.MX6 DualLite/Solo GW5907" |\
+   "Gateworks Ventana i.MX6 Dual/Quad GW5907")
+   name="gw5907"
+   ;;
+
+   "Gateworks Ventana i.MX6 DualLite/Solo GW5910" |\
+   "Gateworks Ventana i.MX6 Dual/Quad GW5910")
+   name="gw5910"
+   ;;
+
+   "Gateworks Ventana i.MX6 DualLite/Solo GW5912" |\
+   "Gateworks Ventana i.MX6 Dual/Quad GW5912")
+   name="gw5912"
+   ;;
+
+   "Gateworks Ventana i.MX6 DualLite/Solo GW5913" |\
+   "Gateworks Ventana i.MX6 Dual/Quad GW5913")
+   name="gw5913"
+   ;;
+
"SolidRun Cubox-i Solo/DualLite" |\
"SolidRun Cubox-i Dual/Quad")
name="cubox-i"
diff --git a/target/linux/imx6/image/Makefile b/target/linux/imx6/image/Makefile
index d1e9e90..232dc42 100644
--- a/target/linux/imx6/image/Makefile
+++ b/target/linux/imx6/image/Makefile
@@ -143,6 +143,10 @@ define Device/ventana
imx6dl-gw552x \
imx6dl-gw553x \
imx6dl-gw5904 \
+   imx6dl-gw5907 \
+   imx6dl-gw5910 \
+   imx6dl-gw5912 \
+   imx6dl-gw5913 \
imx6q-gw51xx \
imx6q-gw52xx \
imx6q-gw53xx \
@@ -151,7 +155,11 @@ define Device/ventana
imx6q-gw551x \
imx6q-gw552x \
imx6q-gw553x \
-   imx6q-gw5904
+   imx6q-gw5904 \
+   imx6q-gw5907 \
+   imx6q-gw5910 \
+   imx6q-gw5912 \
+   imx6q-gw5913
   DEVICE_PACKAGES := kmod-sky2 kmod-sound-core kmod-sound-soc-imx 
kmod-sound-soc-imx-sgtl5000 \
kmod-can

Re: [OpenWrt-Devel] [PATCH] runqueue: Fix the callbacks order in runqueue_task_kill()

2020-03-11 Thread Petr Štetiar 
Alban  [2019-07-01 16:23:42]:

Hi,

sorry for the late response, but I've just noticed, that it's related to
libubox and got interested. I would use "PATCH libubox" subject next time so
it's more clear at first sight.

> No, TBH I haven't tested this, but as there is no documentation I had
> to go through the code and noticed this suspicious construct. I then
> saw commit 6a7fb7d8d (runqueue: fix use-after-free bug) which confirmed
> that complete() is expected to free the task struct, which with the
> above code will clearly lead to an access after free.

Can I kindly ask you for additional favor, adding unit test case which would
expose this bug? It's going to help us in the future with possible regressions
etc. It's not mandatory (yet), but really nice and really helps
merging/reviewing the changes much faster (at least for me).

libubox contains unit tests already, tests are run on CI[1] automatically, one
of the test runs happens under Valgrind, another under various clang's
sanitizers, which should hopefully catch this use-after-free bugs.

You can find basic unit test for runqueue component in
`tests/test-runqueue.c`, perhaps you could adjust this test directly (or write
new one) in order to expose the bug.

Thanks!

1. http://lists.infradead.org/pipermail/openwrt-devel/2019-December/020831.html

-- ynezz


signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] x86: switch to 5.4 kernel

2020-03-11 Thread Petr Štetiar 
Seems to be working fine on apu2 and QEMU, it's 99.9% upstream stuff
anyway. Lets start wider userbase testing.

Signed-off-by: Petr Štetiar 
---
 target/linux/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/x86/Makefile b/target/linux/x86/Makefile
index 20a415382d2a..2960fe8a153d 100644
--- a/target/linux/x86/Makefile
+++ b/target/linux/x86/Makefile
@@ -13,7 +13,7 @@ FEATURES:=squashfs ext4 vdi vmdk pcmcia targz fpu
 SUBTARGETS:=generic legacy geode 64
 MAINTAINER:=Felix Fietkau 
 
-KERNEL_PATCHVER:=4.19
+KERNEL_PATCHVER:=5.4
 KERNEL_TESTING_PATCHVER:=5.4
 
 KERNELNAME:=bzImage

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] treewide: remove maintainer variable from targets

2020-03-11 Thread Petr Štetiar 
There is no such role as target maintainer anymore, one should always
send corresponding changes for the review and anyone from the commiters
is allowed to merge them or eventually use the hand break and NACK them.

Lets make it clear, that it is solely a community doing the maintenance
tasks.

Signed-off-by: Petr Štetiar 
---
 target/linux/apm821xx/Makefile   | 2 --
 target/linux/arc770/Makefile | 1 -
 target/linux/archs38/Makefile| 1 -
 target/linux/armvirt/Makefile| 1 -
 target/linux/at91/Makefile   | 2 --
 target/linux/ath25/Makefile  | 1 -
 target/linux/bcm27xx/Makefile| 1 -
 target/linux/bcm47xx/Makefile| 1 -
 target/linux/bcm53xx/Makefile| 1 -
 target/linux/bcm63xx/Makefile| 1 -
 target/linux/cns3xxx/Makefile| 2 --
 target/linux/gemini/Makefile | 1 -
 target/linux/imx6/Makefile   | 1 -
 target/linux/ipq40xx/Makefile| 1 -
 target/linux/ipq806x/Makefile| 1 -
 target/linux/ipq807x/Makefile| 1 -
 target/linux/lantiq/Makefile | 1 -
 target/linux/layerscape/Makefile | 1 -
 target/linux/mediatek/Makefile   | 1 -
 target/linux/mpc85xx/Makefile| 1 -
 target/linux/mvebu/Makefile  | 1 -
 target/linux/mxs/Makefile| 1 -
 target/linux/octeon/Makefile | 1 -
 target/linux/octeontx/Makefile   | 2 --
 target/linux/omap/Makefile   | 2 --
 target/linux/oxnas/Makefile  | 2 --
 target/linux/pistachio/Makefile  | 1 -
 target/linux/ramips/Makefile | 1 -
 target/linux/rb532/Makefile  | 1 -
 target/linux/samsung/Makefile| 1 -
 target/linux/sunxi/Makefile  | 1 -
 target/linux/tegra/Makefile  | 1 -
 target/linux/x86/Makefile| 1 -
 target/linux/zynq/Makefile   | 1 -
 34 files changed, 40 deletions(-)

diff --git a/target/linux/apm821xx/Makefile b/target/linux/apm821xx/Makefile
index 9ba623535ee9..9697af77bb78 100644
--- a/target/linux/apm821xx/Makefile
+++ b/target/linux/apm821xx/Makefile
@@ -9,8 +9,6 @@ BOARD:=apm821xx
 BOARDNAME:=AppliedMicro APM821xx
 CPU_TYPE:=464fp
 FEATURES:=fpu dt gpio
-MAINTAINER:=Chris Blake , \
-   Christian Lamparter 
 SUBTARGETS:=nand sata
 
 KERNEL_PATCHVER:=4.19
diff --git a/target/linux/arc770/Makefile b/target/linux/arc770/Makefile
index b5e2d54065e4..8150f147c5aa 100644
--- a/target/linux/arc770/Makefile
+++ b/target/linux/arc770/Makefile
@@ -9,7 +9,6 @@ include $(TOPDIR)/rules.mk
 ARCH:=arc
 BOARD:=arc770
 BOARDNAME:=Synopsys DesignWare ARC 770D
-MAINTAINER:=Alexey Brodkin 
 SUBTARGETS:=generic
 
 KERNEL_PATCHVER:=4.14
diff --git a/target/linux/archs38/Makefile b/target/linux/archs38/Makefile
index be6be0472b5a..a6ac05b9dfb3 100644
--- a/target/linux/archs38/Makefile
+++ b/target/linux/archs38/Makefile
@@ -10,7 +10,6 @@ ARCH:=arc
 CPU_TYPE:=archs
 BOARD:=archs38
 BOARDNAME:=Synopsys DesignWare ARC HS38
-MAINTAINER:=Alexey Brodkin 
 SUBTARGETS:=generic
 
 KERNEL_PATCHVER:=4.14
diff --git a/target/linux/armvirt/Makefile b/target/linux/armvirt/Makefile
index 03adf4436cfc..4a8c6b092c91 100644
--- a/target/linux/armvirt/Makefile
+++ b/target/linux/armvirt/Makefile
@@ -10,7 +10,6 @@ BOARD:=armvirt
 BOARDNAME:=QEMU ARM Virtual Machine
 FEATURES:=fpu pci rtc usb
 FEATURES+=cpiogz ext4 ramdisk squashfs targz
-MAINTAINER:=Yousong Zhou 
 
 KERNEL_PATCHVER:=5.4
 
diff --git a/target/linux/at91/Makefile b/target/linux/at91/Makefile
index 6c1ba11c5510..4780210f36f8 100644
--- a/target/linux/at91/Makefile
+++ b/target/linux/at91/Makefile
@@ -8,8 +8,6 @@ include $(TOPDIR)/rules.mk
 
 ARCH:=arm
 BOARD:=at91
-MAINTAINER:=Claudio Mignanti  \
-   Sandeep Sheriker 
 BOARDNAME:=Microchip (Atmel AT91)
 FEATURES:=ext4 squashfs targz usb usbgadget ubifs
 SUBTARGETS:=sama5 sam9x
diff --git a/target/linux/ath25/Makefile b/target/linux/ath25/Makefile
index cb8b7ec1be3e..4fb082edfd67 100644
--- a/target/linux/ath25/Makefile
+++ b/target/linux/ath25/Makefile
@@ -10,7 +10,6 @@ ARCH:=mips
 BOARD:=ath25
 BOARDNAME:=Atheros AR231x/AR5312
 FEATURES:=squashfs low_mem small_flash
-MAINTAINER:=Sergey Ryazanov 
 
 KERNEL_PATCHVER:=4.14
 
diff --git a/target/linux/bcm27xx/Makefile b/target/linux/bcm27xx/Makefile
index 507690357af4..7cc2aab7009b 100644
--- a/target/linux/bcm27xx/Makefile
+++ b/target/linux/bcm27xx/Makefile
@@ -11,7 +11,6 @@ ARCH:=arm
 BOARD:=bcm27xx
 BOARDNAME:=Broadcom BCM27xx
 FEATURES:=ext4 audio usb usbgadget display gpio fpu squashfs rootfs-part 
boot-part
-MAINTAINER:=Álvaro Fernández Rojas 
 SUBTARGETS:=bcm2708 bcm2709 bcm2710 bcm2711
 
 KERNEL_PATCHVER:=4.19
diff --git a/target/linux/bcm47xx/Makefile b/target/linux/bcm47xx/Makefile
index 32c1e7d211b0..c5b5e69edad3 100644
--- a/target/linux/bcm47xx/Makefile
+++ b/target/linux/bcm47xx/Makefile
@@ -11,7 +11,6 @@ BOARD:=bcm47xx
 BOARDNAME:=Broadcom BCM47xx/53xx (MIPS)
 FEATURES:=squashfs usb
 SUBTARGETS:=generic mips74k legacy
-MAINTAINER:=Hauke Mehrtens 
 
 KERNEL_PATCHVER:=4.19
 KERNEL_TESTING_PATCHVER:=5.4
diff --git a/target/linux/bcm53xx/Makefile b/target/linux/bcm53xx/Makefile
index b63aeaa0f91e..628d422b533d 100644
---

[OpenWrt-Devel] [PATCH] netifd: Improve handling of device rename

2020-03-11 Thread Kristian Evensen 
After an interface has been renamed on a "fast" device (for example
x86_64), the interface is sometimes not handled correctly by netifd.
Looking in the logs, I see the following messages when renaming fails:

Wed Mar 11 08:52:44 2020 kern.info kernel: [68383.522038] igb :03:00.0 
nlw_1: renamed from eth2
Wed Mar 11 08:52:44 2020 daemon.err netifd[2739]: __device_add_user(710): Add 
user for device 'nlw_1', refcount=2
Wed Mar 11 08:52:44 2020 daemon.err netifd[2739]: device_claim(413): Claim 
Network device nlw_1, new active count: 2
Wed Mar 11 08:52:44 2020 daemon.err netifd[2739]: device_claim(432): claim 
Network device nlw_1 failed: -1

Instrumenting netifd further reveals that there is a race between the hotplug
"@move" event and ioctl(SIOCGIFINDEX). When the above error happens, the
ioctl-call fails with ENODEV. Looking closer at the kernel code, it seems the
hotplug-event is triggered before the renaming is completed. The easiest way to
trigger the race, is if an interface name with the old name is not handled by
netifd and an interface with the new name is. If only the old name is handled,
or both names, I was not able to provoke the race.

When the renaming is complete, a NEWLINK-message is generated. This patch
modifies the logic surrounding renaming, so that we wait for the
NEWLINK-message before marking an interface as present. The changes made are:

* We only handle move-events for interfaces we know, and we return after
device has been set as not present.
* When we receive a NEWLINK message for an interface managed by netifd,
we call device_set_present. device_set_present is guarded by the same
checks as the add hotplug-event.

After these changes, renaming works properly on both "fast" and "slow"
devices. Removing a device is also handled correctly.

Signed-off-by: Kristian Evensen 
---
 system-linux.c | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/system-linux.c b/system-linux.c
index d533be8..aff67d6 100644
--- a/system-linux.c
+++ b/system-linux.c
@@ -590,6 +590,11 @@ static int cb_rtnl_event(struct nl_msg *msg, void *arg)
if (!system_get_dev_sysctl("/sys/class/net/%s/carrier", dev->ifname, 
buf, sizeof(buf)))
link_state = strtoul(buf, NULL, 0);
 
+   if (dev->type == _device_type &&
+   !system_if_force_external(dev->ifname) &&
+   !dev->present)
+   device_set_present(dev, true);
+
device_set_link(dev, link_state ? true : false);
 
 out:
@@ -652,13 +657,15 @@ handle_hotplug_msg(char *data, int size)
 move:
dev = device_find(interface_old);
if (!dev)
-   goto found;
+   return;
 
if (dev->type != _device_type)
goto found;
 
device_set_present(dev, false);
 
+   return;
+
 found:
dev = device_find(interface);
if (!dev)
-- 
2.20.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] imx6: switch to 5.4 kernel

2020-03-11 Thread Petr Štetiar 
Adrian Schmutzler  [2020-03-11 13:54:02]:

> > --- a/target/linux/imx6/Makefile
> > +++ b/target/linux/imx6/Makefile
> > @@ -14,7 +14,7 @@ CPU_TYPE:=cortex-a9
> >  CPU_SUBTYPE:=neon
> >  MAINTAINER:=Luka Perkov 
> > 
> > -KERNEL_PATCHVER:=4.19
> > +KERNEL_PATCHVER:=5.4
> >  KERNEL_TESTING_PATCHVER:=5.4
> 
> Did you keep TESTING_PATCHVER by intention (I do not think there is a rule 
> for it?)?

Yes, I don't see the reason for adding and removing of that line every few
months, but if that's prefered, fine with me and I can remove it :-)

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] imx6: switch to 5.4 kernel

2020-03-11 Thread Adrian Schmutzler 
Hi,

> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of Petr Štetiar
> Sent: Mittwoch, 11. März 2020 12:26
> To: openwrt-devel@lists.openwrt.org
> Cc: Petr Štetiar ; Tim Harvey ; Koen
> Vandeputte 
> Subject: [OpenWrt-Devel] [PATCH] imx6: switch to 5.4 kernel
> 
> Seems to be working fine, it's 99.9% upstream stuff anyway. Lets start
> wider userbase testing.
> 
> Cc: Tim Harvey 
> Cc: Koen Vandeputte 
> Signed-off-by: Petr Štetiar 
> ---
>  target/linux/imx6/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/imx6/Makefile b/target/linux/imx6/Makefile
> index 8c0770d04190..068d7ef5a4f7 100644
> --- a/target/linux/imx6/Makefile
> +++ b/target/linux/imx6/Makefile
> @@ -14,7 +14,7 @@ CPU_TYPE:=cortex-a9
>  CPU_SUBTYPE:=neon
>  MAINTAINER:=Luka Perkov 
> 
> -KERNEL_PATCHVER:=4.19
> +KERNEL_PATCHVER:=5.4
>  KERNEL_TESTING_PATCHVER:=5.4

Did you keep TESTING_PATCHVER by intention (I do not think there is a rule for 
it?)?

Best

Adrian

> 
>  include $(INCLUDE_DIR)/target.mk
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] imx6: switch to 5.4 kernel

2020-03-11 Thread Petr Štetiar 
Seems to be working fine, it's 99.9% upstream stuff anyway. Lets start
wider userbase testing.

Cc: Tim Harvey 
Cc: Koen Vandeputte 
Signed-off-by: Petr Štetiar 
---
 target/linux/imx6/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/imx6/Makefile b/target/linux/imx6/Makefile
index 8c0770d04190..068d7ef5a4f7 100644
--- a/target/linux/imx6/Makefile
+++ b/target/linux/imx6/Makefile
@@ -14,7 +14,7 @@ CPU_TYPE:=cortex-a9
 CPU_SUBTYPE:=neon
 MAINTAINER:=Luka Perkov 
 
-KERNEL_PATCHVER:=4.19
+KERNEL_PATCHVER:=5.4
 KERNEL_TESTING_PATCHVER:=5.4
 
 include $(INCLUDE_DIR)/target.mk

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ar71xx & ath79: ew-dorin, fix the trigger level for WPS button

2020-03-11 Thread Petr Štetiar 
Adrian Schmutzler  [2020-03-11 11:54:50]:

> please split this into separate commits for ar71xx and ath79.

FYI it was already pushed.

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v5] build: refactor JSON info files to `profiles.json`

2020-03-11 Thread Petr Štetiar 
Paul Spooren  [2020-03-10 18:11:21]:

> +  $$(_TARGET): $(BUILD_DIR)/json_info_files/$(call IMAGE_NAME,$(1),$(2)).json
> +  $(BUILD_DIR)/json_info_files/$(call IMAGE_NAME,$(1),$(2)).json: 
> $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2))$$(GZ_SUFFIX)

This JSON file target is relatively long, used twice already, perhaps using
common short variable would make sense here.

>   $(TOPDIR)/scripts/json_add_image_info.py \

You're missing here that output file argument.

> +  ROOTFS/$(1)/$(3) := \
> + $(KDIR)/root.$(1)$$(strip \
> + $$(if $$(FS_OPTIONS/$(1)),+fs=$$(call 
> param_mangle,$$(FS_OPTIONS/$(1 \
> + )$$(strip \
> + $(if $(TARGET_PER_DEVICE_ROOTFS),+pkg=$$(ROOTFS_ID/$(3))) \
> + )
> +  ifndef IB
> +$$(ROOTFS/$(1)/$(3)): $(if 
> $(TARGET_PER_DEVICE_ROOTFS),target-dir-$$(ROOTFS_ID/$(3)))
> +  endif
> +  $(KDIR)/tmp/$(call IMAGE_NAME,$(1),$(2)): $$(KDIR_KERNEL_IMAGE) 
> $$(ROOTFS/$(1)/$(3))
> + @rm -f $$@
> + [ -f $$(word 1,$$^) -a -f $$(word 2,$$^) ]
> + $$(call concat_cmd,$(if 
> $(IMAGE/$(2)/$(1)),$(IMAGE/$(2)/$(1)),$(IMAGE/$(2
> +
> +  .IGNORE: $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2))
> +
> +  $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)).gz: $(KDIR)/tmp/$(call 
> IMAGE_NAME,$(1),$(2))
> + gzip -c -9n $$^ > $$@
> +
> +  $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)): $(KDIR)/tmp/$(call 
> IMAGE_NAME,$(1),$(2))
> + cp $$^ $$@
> +

Is this reordering necessary? If so, I would probably do that in separate patch 
for
easier review.

> diff --git a/target/imagebuilder/files/Makefile 
> b/target/imagebuilder/files/Makefile
> index 15b3d5c35c..7d5eddaff6 100644
> --- a/target/imagebuilder/files/Makefile
> +++ b/target/imagebuilder/files/Makefile
> @@ -118,6 +118,7 @@ _call_image: staging_dir/host/.prereq-build
>   $(MAKE) package_install
>   $(MAKE) -s prepare_rootfs
>   $(MAKE) -s build_image
> + $(if $(CONFIG_JSON_OVERVIEW_IMAGE_INFO),$(_SINGLE)$(SUBMAKE) -r 
> json_overview_image_info)
>   $(MAKE) -s checksum

Seems like copy from the `world` target. I think, that:

  $(MAKE) -s json_overview_image_info

would make more sense here. I would as well move that if somewhere else.

> world: prepare $(target/stamp-compile) $(package/stamp-compile) 
> $(package/stamp-install) $(target/stamp-install) FORCE
>$(_SINGLE)$(SUBMAKE) -r package/index
> +   $(if $(CONFIG_JSON_OVERVIEW_IMAGE_INFO),$(_SINGLE)$(SUBMAKE) -r 
> json_overview_image_info)
> $(_SINGLE)$(SUBMAKE) -r checksum

Same here, move that if and the common place to not repeat that condition two 
times etc.

  $(_SINGLE)$(SUBMAKE) -r json_overview_image_info

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ar71xx & ath79: ew-dorin, fix the trigger level for WPS button

2020-03-11 Thread Adrian Schmutzler 
Hi,

please split this into separate commits for ar71xx and ath79.

Best

adrian

> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On
> Behalf Of c...@80211.de
> Sent: Mittwoch, 11. März 2020 10:10
> To: openwrt-devel@lists.openwrt.org
> Cc: Catrinel Catrinescu 
> Subject: [OpenWrt-Devel] [PATCH] ar71xx & ath79: ew-dorin, fix the trigger
level
> for WPS button
> 
> From: Catrinel Catrinescu 
> 
> Because the WPS button had the wrong trigger level,
> the failsafe mode was triggered quite often,
> after this commit:
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=27f3f493de
> 
> 
> Signed-off-by: Catrinel Catrinescu 
> ---
>  target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c | 2 +-
>  target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> index 575a976aec..5544596f91 100644
> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> @@ -47,7 +47,7 @@ static struct gpio_keys_button dorin_gpio_keys[] __initdata
> = {
>   .code   = KEY_WPS_BUTTON,
>   .debounce_interval = DORIN_KEYS_DEBOUNCE_INTERVAL,
>   .gpio   = DORIN_GPIO_BTN_JUMPSTART,
> - .active_low = 1,
> + .active_low = 0,
>   },
>   {
>   .desc   = "reset button",
> diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> index d0e0169f1b..88b48faf89 100644
> --- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> +++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> @@ -34,7 +34,7 @@
>   wps {
>   label = "wps";
>   linux,code = ;
> - gpios = < 11 GPIO_ACTIVE_LOW>;
> + gpios = < 11 GPIO_ACTIVE_HIGH>;
>   };
> 
>   reset {
> --
> 2.17.1
> 
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] ar71xx & ath79: ew-dorin, fix the trigger level for WPS button

2020-03-11 Thread cc 
From: Catrinel Catrinescu 

Because the WPS button had the wrong trigger level,
the failsafe mode was triggered quite often,
after this commit:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=27f3f493de


Signed-off-by: Catrinel Catrinescu 
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c | 2 +-
 target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c 
b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
index 575a976aec..5544596f91 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
@@ -47,7 +47,7 @@ static struct gpio_keys_button dorin_gpio_keys[] __initdata = 
{
.code   = KEY_WPS_BUTTON,
.debounce_interval = DORIN_KEYS_DEBOUNCE_INTERVAL,
.gpio   = DORIN_GPIO_BTN_JUMPSTART,
-   .active_low = 1,
+   .active_low = 0,
},
{
.desc   = "reset button",
diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts 
b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
index d0e0169f1b..88b48faf89 100644
--- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
+++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
@@ -34,7 +34,7 @@
wps {
label = "wps";
linux,code = ;
-   gpios = < 11 GPIO_ACTIVE_LOW>;
+   gpios = < 11 GPIO_ACTIVE_HIGH>;
};
 
reset {
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel