Re: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Sven Roederer
Am Donnerstag, 17. September 2020, 11:38:42 CEST schrieb e9hack:
>The kernel module lzo-rle is still missing. To solve this, it must be
> installed on the root-fs:
> 
> diff --git a/package/kernel/linux/modules/lib.mk
> b/package/kernel/linux/modules/lib.mk index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>HIDDEN:=1
>FILES:= \
> $(LINUX_DIR)/crypto/lzo.ko \
> +   $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
> $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
> $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
> 

Hartmut,

I had a short test wit zram-swap these days and also saw this. 
I fixed this by changing the default compression-algo to lzo via etc/config/
system. My intention was not to use an additional kernel-module which will 
consume additional RAM which I just won by using zram ... (Indeed I did not 
check the numbers and only assumed)


Sven




___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: ath79: move 8/32 boards to tiny subtarget

2020-09-17 Thread Sven Roederer
Adrian, David,

Am Mittwoch, 16. September 2020, 16:15:42 CEST schrieb David Bauer:
> Hi,
> 
> On 9/16/20 11:40 AM, Adrian Schmutzler wrote:
> >> -Original Message-
> >> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> >> On Behalf Of Sven Roederer
> >> Sent: Mittwoch, 16. September 2020 09:17
> >> To: openwrt-devel@lists.openwrt.org
> >> Subject: ath79: move 8/32 boards to tiny subtarget
> >> 
> >> Hi,
> >> 
> >> not sure if this has been discussed before.
> >> I recently worked with some 8/32 boards (Ubiquiti Nanostation M (XM),
> >> TPLink
> >> WR842 v2)  for our Freifunk-project and realized that the low RAM
> >> situation
> >> requires quite different handling than the full boards (8+/64+).
> >> 
> >> I wonder if there is a reason to not move the boards, which are affected
> >> by
> >> the 4/32MB warning also, to the ath79-tiny target?
> > 
> > I wonder whether the tiny subtarget will actually make much difference for
> > RAM issues?

My idea based on the fact, to have an easy way to disable certain kernel-
features to reduce teh kernel-size (in flash and RAM). Candidates I see here 
are: USB-Support, additional filesystems, block-devices, ...
Even some devices provide USB-connectors it might be better to have less OOM-
crashes and reboots than installing a usb-flashdrive. In our Freifunk-Firmware 
I've seen much less runtime-problems with a stripped down kernel.
With having the 8/32 in tiny it would just be a config-file for the low-RAM 
boards. Having them in generic subtarget would require to build 2 kernels for 
the same subtarget.

> In it's current state, it will most likely increase low-memory issues as the
> squashfs blocksize is 1024kB compared to the regular 256kB. Not that
> ath79-tiny has no target-flag for small memory set.
> 

Did you miss an "e" ? "Note that ath79-tiny has ..." gives more sense to me. 
Reading it this way, you expect the larger blocksize was choosen as tradeoff 
between using the flash most efficient vs. RAM for the 4/32 boards?
I've seen there is a low_mem flag for some 16MB boards defined. It seems that 
for some config-options SMALL_FLASH and LOW-MEM are conflicting.

Sven




___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


RE: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Adrian Schmutzler
Hi,

> -Original Message-
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org]
> On Behalf Of e9hack
> Sent: Donnerstag, 17. September 2020 11:39
> To: j...@mein.io; rsalvate...@gmail.com
> Cc: openwrt-devel@lists.openwrt.org
> Subject: zram-swap: default to lzo instead of lzo-rle compression
> 
> Hi,
> 
> I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the
> proper fix for the described issue.
> 
> The kernel module lzo-rle is still missing. To solve this, it must be 
> installed on
> the root-fs:
> 
> diff --git a/package/kernel/linux/modules/lib.mk
> b/package/kernel/linux/modules/lib.mk
> index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>HIDDEN:=1
>FILES:= \
> $(LINUX_DIR)/crypto/lzo.ko \
> +   $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
> $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
> $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
> 
>  define KernelPackage/lib-lzo/description
> 
> 
> Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.

Kernel 4.19 support is still present in master (for regression testing), so we 
should properly implement the switches until it is removed entirely.

Best

Adrian

> 
> Regards,
> Hartmut
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Rui Salvaterra
On Thu, 17 Sep 2020 at 10:38, e9hack  wrote:
>
> Hi,
>
> I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the proper fix 
> for the described issue.
>
> The kernel module lzo-rle is still missing. To solve this, it must be 
> installed on the root-fs:
>
> diff --git a/package/kernel/linux/modules/lib.mk 
> b/package/kernel/linux/modules/lib.mk
> index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>HIDDEN:=1
>FILES:= \
> $(LINUX_DIR)/crypto/lzo.ko \
> +   $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
> $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
> $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
>
>  define KernelPackage/lib-lzo/description
>
>
> Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.
>
> Regards,
> Hartmut

Good catch. You're absolutely right, the lzo-rle is a separate module.
Now, what I don't understand is why the crypto layer advertises
lzo-rle support without the module being present. Sounds like an
upstream bug to me…

Thanks,
Rui

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread e9hack
Hi,

I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the proper fix 
for the described issue.

The kernel module lzo-rle is still missing. To solve this, it must be installed 
on the root-fs:

diff --git a/package/kernel/linux/modules/lib.mk 
b/package/kernel/linux/modules/lib.mk
index 1289cc1f25..fade8a5cfd 100644
--- a/package/kernel/linux/modules/lib.mk
+++ b/package/kernel/linux/modules/lib.mk
@@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
   HIDDEN:=1
   FILES:= \
$(LINUX_DIR)/crypto/lzo.ko \
+   $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
$(LINUX_DIR)/lib/lzo/lzo_compress.ko \
$(LINUX_DIR)/lib/lzo/lzo_decompress.ko
-  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
+  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
 endef

 define KernelPackage/lib-lzo/description


Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.

Regards,
Hartmut 

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Merged: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Jo-Philipp Wich
Merged into my staging tree at
http://git.openwrt.org/?p=openwrt/staging/jow.git.

Thank you!


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel