Patches to enable DPDK and Pktgen for ipq40xx device
Hi Maintainers, We want to enable DPDK and Pktgen support for the ipq40xx device (WPJ419 platform) in the OpenWRT build system. We have tested DPDK/Pktgen for the ipq40xx platform using OpenWRT 19.07 stable release. We are ready with our changes to contribute to the OpenWRT community. Kindly let us know the process involved and the version which we shall contribute to, also kindly provide the dates planned for the next release. Regards, Supriya Mane -- Disclaimer:This message is intended only for the designated recipient(s). It may contain confidential or proprietary information and may be subject to other confidentiality protections. If you are not a designated recipient, you may not review, copy or distribute this message. Please notify the sender by e-mail and delete this message. GlobalEdge does not accept any liability for virus infected mails. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Paid support for MT7621 WAN port bugs in 21.02 HEAD/MASTER
The company I work for is interested in contracting/sponsoring a knowledgeable developer to resolve the following bug reports in OpenWrt 21.02: https://bugs.openwrt.org/index.php?do=details&task_id=3760 https://bugs.openwrt.org/index.php?do=details&task_id=3762 These problems will negatively effect the entire OpenWrt community of users with MT7621 based devices if they are not addressed before OpenWrt 21.02 is formally released, so we would like to see them addressed for everyone's benefit. If you are interested in helping us, please contact me directly and we can discuss the details. Steven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH v2] tplink-safeloader: fix product_name of TP-Link AD7200
The stock firmware does not accept firmware with "Talon" in the name.
Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200")
Signed-off-by: Alex Henrie
---
tools/firmware-utils/src/tplink-safeloader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware-utils/src/tplink-safeloader.c
b/tools/firmware-utils/src/tplink-safeloader.c
index b3d5c9151d..8a47e6a58f 100644
--- a/tools/firmware-utils/src/tplink-safeloader.c
+++ b/tools/firmware-utils/src/tplink-safeloader.c
@@ -676,7 +676,7 @@ static struct device_info boards[] = {
.vendor = "",
.support_list =
"SupportList:\r\n"
- "{product_name:Talon
AD7200,product_ver:1.0.0,special_id:}\r\n",
+
"{product_name:AD7200,product_ver:1.0.0,special_id:}\r\n",
.part_trail = 0x00,
.soft_ver = NULL,
--
2.31.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: Installing OpenWrt 21.02 on the TP-Link AD7200
Hi Alex, great to hear that you was able to fix the complete support for this unit. Am Sonntag, 2. Mai 2021, 09:56:04 CEST schrieb Alex Henrie: > > I tried renaming the file to > > AD7200v1-up-ver2-0-1-P1[20170103-rel71053]_2017-01-04_10.08.28.bin to > > match the latest stock firmware and the web interface still didn't > > accept it. > > This was just a rough guessing, based on the old vendor WefIf. But was a bling road ... > > I now have a header soldered to the four pins labeled JP4 but so far I > > have not been able to get serial communication. Do you happen to > > remember what the pinout is? > > I got it working with help from a friend The serial pinout on the > AD7200 is the same as on the C2600. I have attached the complete > serial output while attempting to upload OpenWrt over TFTP, but the Probably it's worth to put a not on the pinout to the Wiki, including a photo of the pcb? Best Sven ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
RE: [PATCH] ipq806x: fix product_name of TP-Link AD7200
Hi,
> -Original Message-
> From: Alex Henrie [mailto:alexhenri...@gmail.com]
> Sent: Sonntag, 2. Mai 2021 23:33
> To: openwrt-devel@lists.openwrt.org; f...@volatilesystems.org; devel-
> s...@geroedel.de; yn...@true.cz; m...@adrianschmutzler.de;
> g...@bitmessage.de; fercer...@gmail.com
> Cc: Alex Henrie
> Subject: [PATCH] ipq806x: fix product_name of TP-Link AD7200
Since we actually change tplink-safeloader here, a proper/better title would be
"tplink-safeloader: fix product_name of TP-Link AD7200"
>
> The stock firmware does not accept firmware with "Talon" in the name.
Please add the following line here:
Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200")
Best
Adrian
>
> Signed-off-by: Alex Henrie
> ---
> tools/firmware-utils/src/tplink-safeloader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-
> utils/src/tplink-safeloader.c
> index b3d5c9151d..8a47e6a58f 100644
> --- a/tools/firmware-utils/src/tplink-safeloader.c
> +++ b/tools/firmware-utils/src/tplink-safeloader.c
> @@ -676,7 +676,7 @@ static struct device_info boards[] = {
> .vendor = "",
> .support_list =
> "SupportList:\r\n"
> - "{product_name:Talon
> AD7200,product_ver:1.0.0,special_id:}\r\n",
> +
> "{product_name:AD7200,product_ver:1.0.0,special_id:}\r\n
> ",
> .part_trail = 0x00,
> .soft_ver = NULL,
>
> --
> 2.31.1
openpgp-digital-signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH opkg] libopkg: pkg_hash: print unresolved dependencies
On 5/3/21 2:38 PM, Baptiste Jonglez wrote:
Hi,
On 02-05-21, Hauke Mehrtens wrote:
When a package is not installed because it has unresolved dependencies
normally we get only an error message like this:
* pkg_hash_fetch_best_installation_candidate: Packages for ltq-vdsl-app
found, but incompatible with the architectures configured
* opkg_install_cmd: Cannot install package ltq-vdsl-app.
Log in addition the following error message:
* pkg_hash_check_unresolved: can not find dependency ltq-dsl-base for
ltq-vdsl-app
Since the error has probably nothing to do with "architectures", wouldn't
it make more sense to remove or improve the first error message? Or
understand why it fails for seemingly unrelated reasons.
This "incompatible with the architectures configured" error message is
shown for more error cases than the newly added one, see here:
https://lxr.openwrt.org/source/opkg-lede/libopkg/pkg_hash.c#L395
It would probably be good to improve the error messages, but I do not
understand the full code. If someone has some suggestions on how to
improve this it would be nice.
Signed-off-by: Hauke Mehrtens
---
I am not sure if this would happen in normal cases too and spam the
error log, I only saw this in an error case.
libopkg/pkg_hash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libopkg/pkg_hash.c b/libopkg/pkg_hash.c
index a07a25e..6c04ab2 100644
--- a/libopkg/pkg_hash.c
+++ b/libopkg/pkg_hash.c
@@ -263,8 +263,10 @@ pkg_hash_check_unresolved(pkg_t *maybe)
if (unresolved) {
res = 1;
tmp = unresolved;
- while (*tmp)
+ while (*tmp) {
+ opkg_msg(ERROR, "can not find dependency %s for %s\n",
*tmp, maybe->name);
free(*(tmp++));
+ }
free(unresolved);
}
pkg_vec_free(depends);
OpenPGP_0x93DD20630910B515.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] ipq40xx: fix hard_config partition size on MikroTik hAP-ac2
ACK
> On 3 May 2021, at 12:39, Baptiste Jonglez wrote:
>
> From: Baptiste Jonglez
>
> The routerbootparts driver dynamically discovers the location of MikroTik
> partitions, but it cannot determine their size (except by extending them
> up to the start of the next discovered partition).
>
> The hard_config partition has a default size of 0x1000 in the driver,
> while it actually takes 0x2000 on the hAP-ac2. Set the correct size in
> the hAP-ac2 DTS.
>
> On most devices, this isn't a problem as the actual data fits in 0x1000
> bytes. However, some devices have larger data that doesn't fit in 0x1000
> bytes. In any case, all devices seen so far have enough space for a
> 0x2000 hard_config partition before the start of the dtb_config partition.
> With the current 0x1000 size:
>
> 0xe000-0xf000 : "hard_config"
> 0x0001-0x00017bbc : "dtb_config"
>
> With this patch extending the size to 0x2000:
>
> 0xe000-0x0001 : "hard_config"
> 0x0001-0x00017bbc : "dtb_config"
>
> Other ipq40xx boards may need the same fix but it needs testing.
>
> References: https://forum.openwrt.org/t/support-for-mikrotik-hap-ac2/2/324
> Signed-off-by: Baptiste Jonglez
> ---
> .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
> b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
> index e1e6326ae9..d03409b556 100644
> --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
> +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
> @@ -191,6 +191,7 @@
>
> hard_config {
> read-only;
> + size = <0x2000>;
> };
>
> dtb_config {
> --
> 2.30.0
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH opkg] libopkg: pkg_hash: print unresolved dependencies
Hi,
On 02-05-21, Hauke Mehrtens wrote:
> When a package is not installed because it has unresolved dependencies
> normally we get only an error message like this:
> * pkg_hash_fetch_best_installation_candidate: Packages for ltq-vdsl-app
> found, but incompatible with the architectures configured
> * opkg_install_cmd: Cannot install package ltq-vdsl-app.
>
> Log in addition the following error message:
> * pkg_hash_check_unresolved: can not find dependency ltq-dsl-base for
> ltq-vdsl-app
Since the error has probably nothing to do with "architectures", wouldn't
it make more sense to remove or improve the first error message? Or
understand why it fails for seemingly unrelated reasons.
> Signed-off-by: Hauke Mehrtens
> ---
>
> I am not sure if this would happen in normal cases too and spam the
> error log, I only saw this in an error case.
>
> libopkg/pkg_hash.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libopkg/pkg_hash.c b/libopkg/pkg_hash.c
> index a07a25e..6c04ab2 100644
> --- a/libopkg/pkg_hash.c
> +++ b/libopkg/pkg_hash.c
> @@ -263,8 +263,10 @@ pkg_hash_check_unresolved(pkg_t *maybe)
> if (unresolved) {
> res = 1;
> tmp = unresolved;
> - while (*tmp)
> + while (*tmp) {
> + opkg_msg(ERROR, "can not find dependency %s for %s\n",
> *tmp, maybe->name);
> free(*(tmp++));
> + }
> free(unresolved);
> }
> pkg_vec_free(depends);
signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH] ipq40xx: fix hard_config partition size on MikroTik hAP-ac2
From: Baptiste Jonglez
The routerbootparts driver dynamically discovers the location of MikroTik
partitions, but it cannot determine their size (except by extending them
up to the start of the next discovered partition).
The hard_config partition has a default size of 0x1000 in the driver,
while it actually takes 0x2000 on the hAP-ac2. Set the correct size in
the hAP-ac2 DTS.
On most devices, this isn't a problem as the actual data fits in 0x1000
bytes. However, some devices have larger data that doesn't fit in 0x1000
bytes. In any case, all devices seen so far have enough space for a
0x2000 hard_config partition before the start of the dtb_config partition.
With the current 0x1000 size:
0xe000-0xf000 : "hard_config"
0x0001-0x00017bbc : "dtb_config"
With this patch extending the size to 0x2000:
0xe000-0x0001 : "hard_config"
0x0001-0x00017bbc : "dtb_config"
Other ipq40xx boards may need the same fix but it needs testing.
References: https://forum.openwrt.org/t/support-for-mikrotik-hap-ac2/2/324
Signed-off-by: Baptiste Jonglez
---
.../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git
a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
index e1e6326ae9..d03409b556 100644
--- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
+++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts
@@ -191,6 +191,7 @@
hard_config {
read-only;
+ size = <0x2000>;
};
dtb_config {
--
2.30.0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] Fix URL validation for more than one URLs.
Hi,
On 02-05-21, fabian.bauma...@mailbox.org wrote:
> That's my first contribution for OpenWRT, if something's not right, please
> let me know.
The patch is a good start (comments below), thanks a lot for your first
contribution!
There are a few formal issues with your patch. See
https://openwrt.org/submitting-patches#submission_guidelines for
guidelines, but in short:
- your email subject should start with "[PATCH uclient]" or even "[PATCH
uclient v2]" for a follow-up patch. You can just edit the email
manually before sending it with git-send-email.
- the commit message should start with "uclient-fetch: XXX"
- you're missing the Signed-off-by:
- don't forget to add "Fixes: FS#3559" when you have worked out the other
issue (a single patch for both reported issues is fine, it's the same
code that needs fixing)
> Until now, uclient-fetch only validates the first URL. If the second URL
> is invalid, it uses the first URL again.
> This patch catches the return value -1 of uclient_set_url and provides the
> user with an error message.
This should be part of the commit message description, and focus more on
the "why" than the "how".
> diff --git a/uclient-fetch.c b/uclient-fetch.c
> index 282092e..d046100 100644
> --- a/uclient-fetch.c
> +++ b/uclient-fetch.c
> @@ -384,14 +384,23 @@ static void request_done(struct uclient *cl)
> if (n_urls) {
> proxy_url = get_proxy_url(*urls);
> if (proxy_url) {
> - uclient_set_url(cl, proxy_url, NULL);
> + error_ret = uclient_set_url(cl, proxy_url, NULL);
> uclient_set_proxy_url(cl, *urls, auth_str);
> } else {
> - uclient_set_url(cl, *urls, auth_str);
> + error_ret = uclient_set_url(cl, *urls, auth_str);
> }
As far as I understand it, error_ret is meant as the global exit code of
the program, and it aims to be somewhat compatible with GNU wget (hence
the hard-coded values 4 and 8 throughout the code, see the end of "man
wget" for the codes used by GNU wget).
So, you should use a separate variable for error checking, and then set
error_ret to the appropriate value if the error needs to be communicated
through the exit code. I agree that the same function already abuses
error_ret but it seems wrong.
There's the question of what the exit code should be when one of the URL
is incorrect but the other ones are OK. I think we should again have the
same behaviour as wget for compatibility. Also, if one URL is invalid, we
should probably continue with the next one (if wget does that).
Thanks,
Baptiste
signature.asc
Description: PGP signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
